Commit Graph

5879 Commits

Author SHA1 Message Date
Mark Furneaux d28a318437 Clang format 2018-04-14 16:57:06 -04:00
Mark Furneaux 2793cfa7fb Add to loaderinserter 2018-04-14 16:31:48 -04:00
Jonas Kvinge 804168edc7 Bring back album cover fetching from discogs. (#6028)
* Bring back cover fetching from discogs.
2018-03-19 14:18:56 +00:00
Mark Furneaux 3626d84964 Add play next from library 2018-03-18 22:44:00 -04:00
Mark Furneaux a789ce82ca Allow playing of tracks already in queue 2018-03-18 22:03:04 -04:00
Mark Furneaux 6e387c2578 Initial playlist implementation 2018-03-18 14:43:44 -04:00
Andreas Sturmlechner 55a39a9609 Fix build with Qt 5.11 (#6029) 2018-03-17 02:16:49 -04:00
Valeriy Malov 2d7894915d Accept closeEvent() for mainwindow when closing to tray
There's no difference between close() and hide() if WA_DeleteOnClose is not set, so if we're going to hide the window we might as well accept the event.
Ignoring the event may interrupt shutdowns since it signals that the application doesn't want to close the window, at least this happens on Plasma 5.11 when Clementine is not minimized to tray.
2018-03-13 15:04:12 -04:00
Jonas Kvinge e52c7f6475 Fix formatting 2018-03-12 07:55:59 -04:00
Jonas Kvinge d33ac6ef81 Fix background not loading. 2018-03-12 07:55:59 -04:00
Jonas Kvinge c393926be6 Fix background not loading. 2018-03-12 07:55:59 -04:00
Jonas Kvinge de23c3181f Fix resume playback on start not working. 2018-03-12 07:55:59 -04:00
Jonas Kvinge c3a7920cb4 Don't use empty URL's from LastFM. 2018-03-12 07:55:59 -04:00
Pulfer ddfa5e63f1 Fix channels loading for DI.fm services after API domain changes (#6023) 2018-03-10 18:35:09 +00:00
Jonas Kvinge 335bc89c97 Workaround for broken CD playback in Qt5 (#6021)
* Workaround for cdda URL in qUrl()

* Workaround for cdda URL in qUrl()

* Fix code formatting

* Fix code style
2018-03-09 23:09:55 +00:00
Jonas Kvinge c9d954f8a3 Fix bug in covermanager not saving album cover to DB. (#6011)
* Fix bug in covermanager not saving album cover to DB.
2018-03-04 14:13:34 +00:00
Jonas Kvinge 5966ff51cc Fix bug in fetching album covers from Amazon (#6007)
* Fix bug where the http request is not sending anything else than the signature.

* Fix bug in fetching album covers from Amazon
2018-02-28 22:34:19 +00:00
Antonio Russo 1732e56fe6 Hide TrackSliderPopup on appropriate leaveEvent
The previous fix introduces a regression on some platforms
which did not generate a leaveEvent with the TrackSliderPopup
was displayed. Logic is introduced to identify bonafide mouse
motion out of the TrackSliderSlider.
2018-02-24 23:42:29 +00:00
John Maguire 9929450cc2 Revert "Hide TrackSliderPopup on exit from popup"
This reverts commit f629d37315.
2018-02-24 22:35:40 +00:00
Antonio Russo f629d37315 Hide TrackSliderPopup on exit from popup
The previous behavior exited on leaving TrackSliderSlider,
which causes the popup to flicker, as it is shown and
hidden rapidly.
2018-02-24 17:16:51 +00:00
John Maguire 4273c03132 Merge branch 'master' into qt5 2018-02-19 16:46:42 +00:00
Andreas Sturmlechner d5e5f8246f Remove "-qt5" suffix from ApplicationName and OrganizationName
Renaming the application does not really make sense, but keeping it in
qLog info to identify it in debug output.
2018-02-19 16:22:04 +00:00
Chocobozzz a1a892b35e Fix "Invalid key" error in lastfm auth 2018-02-19 09:10:26 +00:00
kleinfreund 2555595ce0 Determine operator enum instead of comparing with magic numbers 2018-02-12 19:13:36 +00:00
kleinfreund 4ab6f359d5 Smart Playlists: Add empty/not empty operators 2018-02-12 17:59:43 +01:00
John Maguire eafc1713ab
Merge pull request #5960 from vikramambrose/feature-playlist-page-search-filter
Add search filter to playlist list page
2018-02-03 17:19:10 +00:00
Benjamin Sproule 595eec7878 Removed filter for audio/folder OneDrive items as OneDrive doesn't count many audio file types as audio (e.g. flac) (#5977) 2018-02-01 11:38:25 +00:00
Chocobozzz 70f68b1926
Merge remote-tracking branch 'upstream/master' into qt5 2018-02-01 09:50:42 +01:00
Chocobozzz 38c1f8777c Fix compilation with crypto++ >= 6.0.0 (#5974) 2018-02-01 08:07:51 +00:00
Vikram Ambrose 5e065609b6 Ensure song items are shown on Favorited signal
There was an issue where the song items were only being shown
from a fresh start up but not when the playlist was created. This fixes
that issue and refactors the AddPlaylist code
2018-01-14 11:24:45 +02:00
Vikram Ambrose fefea9de61 Disable drag of track items until this is properly implemented
Stop bad things from happening until proper DnD support of track
items has been implemented
2018-01-11 13:49:18 +02:00
Vikram Ambrose ae71d24f6e Ensure all nodes are shown when filter is cleared 2018-01-11 13:31:23 +02:00
Vikram Ambrose 3da938eac2 Add search filter to playlist list page
This allows power users who keep 100s of playlists to easily
find a playlist either by directory name, playlist name or by
searching for a song artist/title a playlist might contain
2018-01-11 13:11:13 +02:00
Vikram Ambrose 790fc2ff28 Replace Nokia based FancyTabWidget with standard QTabWidget (#5956)
* Replace Nokia sidebar widget with QTabWidget

The old sidebar widget was written by Nokia 10 years ago
and was a hand made hardcoded mess of widgets trying to
emulate a QTabWidget.

This commit completely replaces it with a widget of the
same name (FancyTabWidget) but is a much simpler subclass
of the standard QTabWidget allowing for a 50% code reduction.

There is still some manual draw code copied over to get the
exact same look of the previous widget but this is not strictly
necessary and can be later refactored with simpler drawControl
code based on styling preferences.

Benefits:
 - 50% code reduction
 - Easier to understand standard QTabWidget mechanics
 - Built-in support for re-arranging and closing tabs

* Save and restore sidebar tab order

Allow the user to rearrange the tab order by dragging
tabs to a new location. Tab order is saved on exit and restored
on start

* Fix some code formatting issues
2018-01-10 09:22:05 +00:00
vikramambrose 2e4a67b8da Add appearance option to hide playlist filter toolbar (#5942)
Gives the user the option of a cleaner looking interface if the
filter toolbar isn't used.
2018-01-03 15:24:56 +00:00
Stephen Dawkins d9b12a5599 Added additional check when enclosure type is missing (#5934) 2017-12-23 12:48:38 +00:00
Benoit Brummer 902c22ef1b fixed issue #5868: IPs were not recognized as private when Qt translates ipv4 to ipv6 (#5896) 2017-12-15 02:10:02 +00:00
Mattias Andersson b724291ef9 Ensure that the correct playlist is played (#5929)
When the playlist doubleclick behavior is set to add songs to the queue,
the playback of the queue also starts if no song is currently
playing. To play the queue from the current playlist, we must set the
active playlist to the current one before starting the playback.

Fixes #5714.
2017-12-14 21:48:03 +00:00
Mattias Andersson 650eb0534a Always include the hours in the the time string if the duration if (#5925)
longer than one day.
2017-12-13 18:37:34 +00:00
benpicco 27bef68cf6 Attempt to reload stream on "Server does not support seeking." error (#5923)
When the network connection changes while playing an HTTP stream, I always get the "Server does not support seeking." error from GStreamer.
It seems like GStreamer tries to seek on reconnect, which fails, an propagates the error to Clementine which in turn ceases playback with
the error message handed through from GStreamer, even though there is now a perfectly fine network connection again.

As a workaround, try to reload the stream when this error occurs.

fixes #5116
2017-12-11 00:13:30 +00:00
Clementine Buildbot 3134e09aec Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-12-04 10:00:52 +00:00
Clementine Buildbot 944e5fb326 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-11-27 10:00:50 +00:00
Victor Parmar eab875c46d Add support for deleting the currently playing track via the commandline (#5899) 2017-11-21 10:02:36 +00:00
Adrian Garcia 27fc915921 Add settings option to stop playback if song fails to play (#5905) 2017-11-21 10:00:36 +00:00
Clementine Buildbot 7b1b43ffed Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-11-20 10:00:46 +00:00
Clementine Buildbot 83e860eabd Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-11-13 10:00:44 +00:00
Clementine Buildbot ce22905a01 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-11-06 10:00:44 +00:00
Clementine Buildbot 9a5bcb7a35 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-10-30 10:00:43 +00:00
Clementine Buildbot 221f6d7261 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-10-23 10:01:01 +00:00
Clementine Buildbot f1b767faa4 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-10-19 23:05:16 +00:00
droserasprout 0a59257dc3 Prevent thumbnailing nocover icon for MPRIS (#5886) 2017-10-18 01:53:45 +01:00
droserasprout 08a80a5750 Fix oversized currenttrack icon in playlistview (#5885) 2017-10-18 00:32:25 +01:00
Adrian Garcia dfa7042ff3 Subsonic: download cover art (#5880) 2017-10-06 14:08:00 +01:00
adwait a7ec5662e1 Updated qt bug report page 2017-10-04 16:47:35 +01:00
Clementine Buildbot c024b1340d Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-10-02 10:00:46 +00:00
Clementine Buildbot b851741a0c Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-09-25 10:00:43 +00:00
Clementine Buildbot d2a69b2f91 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-09-18 10:00:45 +00:00
Clementine Buildbot 6faa749b1f Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-09-11 10:00:43 +00:00
Clementine Buildbot 06e8d1eb56 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-09-04 10:00:45 +00:00
Allan Nordhøy f511ee12e3 Spelling: "Wii Remote" → ←↑↓⊕⊖⌂ (#5844) 2017-08-29 14:01:48 +02:00
Allan Nordhøy b581f2454a Spelling: Hip Hop (#5843)
https://en.wikipedia.org/wiki/Hip_hop Though inconsistent, this never uses "HipHop". While that could be perceived as the name of the equalizer, "Hip Hop" is at least consistent with the other EQs.
2017-08-29 02:09:05 +02:00
Allan Nordhøy 36459d2e62 Spelling "%" → "percent" for consistency (#5842) 2017-08-29 02:08:52 +02:00
Allan Nordhøy 566708b778 ↑↓ for "Up" and "Down" (#5841) 2017-08-29 01:45:43 +02:00
Allan Nordhøy be79e8f92f Spelling: FLAC elsewhere (#5840) 2017-08-29 01:23:22 +02:00
Allan Nordhøy 38cc22ca85 Update song.cpp (#5839) 2017-08-29 01:23:05 +02:00
Allan Nordhøy b89ccb04f2 Spelling: D-Bus (#5838) 2017-08-28 23:37:47 +02:00
Allan Nordhøy 050813bf9c Spelling: D-Bus (#5837) 2017-08-28 23:37:25 +02:00
Allan Nordhøy c29886d8c9 Spelling: URL (#5836) 2017-08-28 23:03:49 +02:00
Allan Nordhøy 55ef908728 Spelling: Log in, Last.fm (#5835)
As per https://www.last.fm/
2017-08-28 23:03:22 +02:00
Clementine Buildbot f910b2ff09 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-08-28 10:00:45 +00:00
John Maguire a8cb9bbd2a Authenticate Last.fm with "oauth". 2017-08-24 19:32:14 +01:00
Clementine Buildbot a056a73165 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-08-21 10:00:52 +00:00
Krzysztof Sobiecki dad0c8f314 [win32] Fix build in src/ui/ (#5784)
It looks like there is a problem with build of src/ui/appearancesettingspage.cpp
It might fix it.
2017-08-16 15:09:55 +01:00
John Maguire 328e669e81 Fix mac build 2017-08-16 14:55:38 +01:00
Clementine Buildbot 86d7639a7f Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-08-14 10:00:44 +00:00
Jacob Henner 203ec76973 Add contextual searches to playlists, library and global search. (#5649)
* Closes #5567: Contextual album/artist search in library search, global search, and playlists.

* Change artist/album search to 'search for this' in globalsearch

* Change artist/album search to 'search for this' in library

* Applying patch from @Fat-Zer to allow search incl year

* Re-adding missing schema definition
2017-08-09 14:12:36 +01:00
John Maguire 4aee29982e Fix MPRIS track ids
Fixes #5795
2017-08-07 17:46:07 +01:00
John Maguire 04beaa96f9 Fix MPRIS2 playlist ids.
Fixes #5798
2017-08-07 16:57:03 +01:00
Clementine Buildbot 03ff002776 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-08-07 10:00:48 +00:00
Clementine Buildbot fcceab377c Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-07-31 10:00:48 +00:00
Thomas Nilefalk 63e90791a4 Make the initial SmartPlaylistQuerySearchPage vertically resizeable, somewhat (#5799)
The outmost QWidget had vsizetype="Fixed", changed that to "Preferred" made the
preview window take up a small amount of resize. This made it possible to resize
the window a little at least.
2017-07-25 14:35:06 +01:00
Clementine Buildbot 32f31d46ea Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-07-24 10:00:46 +00:00
David Roeca 49876536a5 Resolve #3693 (#5790)
* bring in playlist updates for potential fix

* define signal to handle organise playlist bugs

* work in progress

* fix wrong signal/slot

* next push forward on handling new song creation

* Reorganize signals/slots; still need to figure out why not all signals are being handled

* Get playlists to work when they're in memory

* more changes to playlist updates

* revert unnecessary changes and finalize fix
2017-07-22 18:57:33 +01:00
Clementine Buildbot 61d2aaa6bd Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-07-17 10:00:47 +00:00
Clementine Buildbot 8205e3d846 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-07-10 10:00:45 +00:00
Santiago Gil a781cc0be4 Add 'transient' hint to OSD_X11 (#5756) (#5779) 2017-07-06 18:39:07 +01:00
Clementine Buildbot f288dd2594 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-07-03 10:00:57 +00:00
Clementine Buildbot ec33b0e0e4 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-06-26 10:00:53 +00:00
Yan Pashkovsky 7bd0639455 fix up key in playlist (#5768) 2017-06-21 15:11:41 +01:00
Clementine Buildbot 3c0f005928 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-06-19 10:00:57 +00:00
Clementine Buildbot 63e97fe0ac Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-06-12 10:00:58 +00:00
Chocobozzz fc517ce7a5 Merge remote-tracking branch 'upstream/master' into qt5 2017-06-05 21:28:05 +02:00
Clementine Buildbot 6035ce023b Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-06-05 10:00:59 +00:00
Alex Bikadorov 8953227c65 New shortcut: remove current playing song from playlist (#5723) 2017-05-31 17:59:36 +01:00
Yan Pashkovsky 583eb25cfc Gtkicons (#5742)
* sys icons tick in settings

* system icons loading support

* system icons loading, style fixes
2017-05-30 21:25:24 +01:00
Grace Dolphy bdda50b28f Continuation of "Seek instead of navigation with arrow keys" #5550, now allows up arrow key. (#5721)
* Continuation of "Seek instead of navigation with arrow keys" #5550, now allows up arrow key to not restart the song over when the library is in focus. Works as usuhal when playlist is in focus (song gets started over).

* Update playlistview.cpp

Added in the part that is responsible for seeking properly.
2017-05-30 18:19:08 +01:00
Rix 8ff7d5750c SoundCloud service simple search limit is set. (#5738)
SoundCloud search limit it set to 100. Pagination may be added soon. (see SoundCloud HTTP api: https://developers.soundcloud.com/docs/api/guide#pagination)
2017-05-30 18:17:40 +01:00
Clementine Buildbot 322e49d20c Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-05-29 10:00:58 +00:00
Clementine Buildbot f8f6feff34 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-05-15 10:01:16 +00:00
Elias Lattash f854bc5deb Simpler iconloader::Load() logic (#5706)
This fixes a bug when clementine uses an icon from the system, even though it exists in it the *data* folder.

For example: the icons at the top of *playlistlistview.ui*, and at the top of *fileview.ui*
2017-05-08 12:07:59 +01:00
Clementine Buildbot 61e6fc7815 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-05-08 10:01:07 +00:00
Clementine Buildbot e8dbea8c93 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-05-01 10:00:55 +00:00
Clementine Buildbot c1e7887857 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-04-24 10:00:59 +00:00
Grace Dolphy 52f1982353 Delete Undo Fix Attempt - Should Solve Issue #5701 Using Clementine to delete a song from disk should not be added to the undo stack (#5702)
* Fix delete functionality. Skips to next song if deleted song is also currently playing.

* Added in a bool to determine if the song being deleted is meant to be deleted from the disk or just from the playlist. Took advantage of the unused variable located in removeRows to distinguish between the two options. No longer adds delete from disk to the undo stack, and deleting from the playlist goes to undo stack as it should.

* Added in a bool to determine if the song being deleted is meant to be deleted from the disk or just from the playlist. Took advantage of the unused variable located in removeRows to distinguish between the two options. No longer adds delete from disk to the undo stack, and deleting from the playlist goes to undo stack as it should.

* Update mainwindow.cpp

* Formatting Changes

* Update playlist.cpp

Simplified condition statement.

* Added in a missed boolean for RemoveSelected

* Update playlistview.cpp
2017-04-18 14:29:25 +01:00
Clementine Buildbot 5acbcbb2ec Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-04-17 10:01:00 +00:00
Clementine Buildbot edccd95916 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-04-10 10:00:55 +00:00
Clementine Buildbot 2c60481f74 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-04-03 10:00:57 +00:00
Grace Dolphy 9f00e021f6 This fixes "First track always the same in shuffle #793". Adding this call in the if statement allows a reshuffle to happen after the playlist ends so that when the playlist will restart, it will already have a new set location to go to. (#5689) 2017-03-31 11:49:41 +01:00
Mark Furneaux fba9e8dd69 Fix psychedelic mode on analysers (#5688)
* Fix psychedelic mode

* Remove unnecessary checks

When the code isn't broken, these are just a waste
2017-03-31 11:48:28 +01:00
Grace Dolphy 672d00be05 Fixes the issue "Seek instead of navigation with arrow keys #5550". Now allows the leaf to be closed by arrow left at any point of the leaf, not only the parent, and if the library is focused and arrow keys are pressed and there is nothing to open or close, the request is ignored (no seek) (#5684) 2017-03-30 18:02:49 +01:00
MelissaManley97 a5d12d0d10 Request to merge a fix for a crash during searching under Internet Tab (#5682)
* Changing ClearSearchResults order.

If search_ is null, there is no point in clearing it.

* Update to fix 12 (Crash when searching under Internet tab with Spotify)

* Formatting Fixes
2017-03-28 17:38:55 +01:00
Santiago Gil 0b34586e52 Fix some warnings shown on start-up (#5679)
* Fix 'RGB parameters out of range' with psychedelic colors

* Fix 'edit-find' icon name

* BlockAnalyzer::drawBackground(): do not attempt to paint on a null background

* Use qBound()
2017-03-27 12:57:24 +01:00
santigl 18d2e35bc6 Register QAbstractSocket::SocketState meta type 2017-03-27 12:56:39 +01:00
Clementine Buildbot 0f4db74e0c Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-03-27 10:00:55 +00:00
santigl e3ece3d4c4 SaveToTemporaryFile(): use QTemporaryFile directly 2017-03-21 10:50:12 +00:00
santigl 35e274c497 Refactor SongLoader::LoadRemotePlaylist() 2017-03-21 10:50:12 +00:00
santigl f44414db81 Add Utilities::SaveToTemporaryFile() 2017-03-21 10:50:12 +00:00
santigl f609bc793f Fix remote-playlist load 2017-03-21 10:50:12 +00:00
Clementine Buildbot 33aa38bbdd Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-03-20 10:00:53 +00:00
santigl a034c2d4d0 Remove non-allowed characters in playlist filename when saving. (Fixes #5460) 2017-03-16 15:18:02 +00:00
Alexander Golubev 77b6d72a3e core/database: configure fts3 tokenizer support
Original patch by Arfrever
This fixes https://github.com/clementine-player/Clementine/issues/5297
2017-03-16 14:54:55 +03:00
John Maguire f7eea6c505 static_cast<:: apparently confuses older GCC. 2017-03-14 17:34:42 +00:00
Jacob Henner 2d1b425493 Fixes #5660 - compile error 2017-03-14 17:28:06 +00:00
santigl 6c9bc43bbb Refactor analyzers for new FHT modifications. Use QVectors where possible. Make readability changes in the code. 2017-03-13 18:56:37 +00:00
santigl 6a19afde15 Refactor FHT class: use QVector and const values, remove unnecesary memory handling. 2017-03-13 18:56:37 +00:00
Clementine Buildbot b7fb649b8f Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-03-13 10:00:55 +00:00
Jan Paul Erkelens 0215707810 Uses effective fields for album hashing and comparison (#5653) 2017-03-08 12:22:50 +00:00
Santiago Gil 62bc647cbc Roll back to the cache naming conventions for covers (#5651) 2017-03-07 11:46:54 +00:00
santigl 99ad5dcd2d Refactor EffectiveAlbumArtistName() 2017-03-06 18:47:34 +00:00
santigl a8cbb3b18a Unlock DB mutexes implicitly using scopes. Add error handling for query. 2017-03-06 18:21:27 +00:00
santigl f5bd7ef5c0 ItemHasCover(): Replace pointer with reference 2017-03-06 18:21:27 +00:00
santigl 82f0d261fa Use the 'effective_album' title when searching for a track's cover 2017-03-06 18:21:27 +00:00
santigl e30e6da065 Add 'effective_album' property to Song 2017-03-06 18:21:27 +00:00
santigl 2c643513e2 Refactor icon handling. Make empty-cover filtering work again. 2017-03-06 18:21:27 +00:00
santigl deb7c33c64 Add support for 'album artist' field in the LibraryBackendInterface 2017-03-06 18:21:27 +00:00
santigl 58b7c62f25 Make Cover Manager aware of 'album artist' field 2017-03-06 18:21:27 +00:00
santigl 62cec8cf28 Prioritize album artist in cover search and manager 2017-03-06 18:21:27 +00:00
John Maguire 5d0cf343d5 Use new clementine images API. 2017-03-06 18:15:59 +00:00
Clementine Buildbot 3d80f7e1e2 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-03-06 10:00:57 +00:00
Domenico Iezzi 3b51f80fa3 Small improvements to Cover Manager (#5645)
* nocover icon was previously loaded and used with the default size
(24x24), causing the list item without a cover in the QListWidget to be
shorter in height with respect to the others. Now the icon is
initialized to 120x120, which is the default size of the list elements.
* Added some padding between "Fetch Missing Cover" and "Export
Covers" buttons.
2017-03-03 11:49:47 +00:00
Santiago Gil 30e3fdb9cc Fix overflow in MoodbarProxyStyle (fixes #5638) (#5643) 2017-03-02 13:10:21 +00:00
John Maguire 27bf50d702 Do not log sensitive data in OAuthenticator. 2017-02-27 12:41:34 +00:00
Clementine Buildbot 973f32c061 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-02-27 10:00:52 +00:00
Andreas Muttscheller 652f38ac84 Fix C:\data cache directory for portable builds
Lastfm needs a NetworkAccessManager which is created during the
initialization of lastfm in main.cpp, it also sets a cache directory.

For the portable version, GetConfigPath uses
QCoreApplication::applicationDirPath() to get the current directory of
Clementine. If no QApplication (or QtSingleApplication in Clementines
case) was instantiated, it returns /data on Linux or C:\data on Windows
for the cache config path.

This commit changes the order so lastfm will be initialized after
QtSingleApplication was created and the correct cache config path will be
returned.

Fixes #5354
2017-02-26 11:20:10 +01:00
John Maguire 1aed6193e7 Fix intergalactic FM URLs. 2017-02-21 14:24:50 +00:00
Clementine Buildbot 3dd4375c77 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-02-20 10:00:57 +00:00
Morris Hafner 8a6cc8b506 Add missing <functional> includes (#5630) 2017-02-13 16:46:46 +00:00
Clementine Buildbot 4325be6944 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-02-13 10:00:46 +00:00
Clementine Buildbot 9967bd4194 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-02-06 10:00:57 +00:00
Clementine Buildbot 6483510bca Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-01-30 10:00:44 +00:00
Clementine Buildbot df0e7ab203 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-01-23 10:00:46 +00:00
Florian Bigard 69b2a832db Merge branch 'master' into qt5 2017-01-18 15:57:07 +01:00
Ted Stein 69cddf70ef macOS: Clear stale native notifications on 10.9+. (#5601) 2017-01-18 13:51:00 +00:00
Clementine Buildbot b463e63dde Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-01-16 10:00:51 +00:00
Ilya Selyuminov 1a477201ed Use CaseInsensitive file type checking #5499 (#5592)
* Fix Seafile setting page loading

Check access_token instead of QSetting parameters to make
sure that we're logged in.

* Use CaseInsensitive file type checking  (#5499)

CloudFileService and TagReader classes use
QString::endWith() method for checking file type.
This method is CaseSensitive by default.
2017-01-12 15:58:44 +00:00
Clementine Buildbot 7ce7fe185e Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-01-12 13:22:21 +00:00
John Maguire becb0b3d7f Remove some stray vkontakte code 2017-01-11 18:51:12 +00:00
John Maguire c7b8aacad8 Remove support for VK
Fixes #5591
2017-01-11 18:08:43 +00:00
Pavel Vatagin b52c99755d Fix windows7thumbbar.cpp and osdpretty.cpp (#5588)
* fix problem with toWinHICON() in Qt5

* fix Windows (Qt5) build (conversion to HWND)
2017-01-09 20:11:27 +00:00
Marko Hauptvogel 57d00394ee Bugfix for resume playback on start
This fixes issue #5365.

Because of the asynchronous loading of playlists introduced by
09e83935, the resume playback on startup logic finds the active
playlist as empty, because it is not restored yet. By attaching
the playback resume to the RestoreFinish signal, the playback
will be triggered as soon as the playlist is restored. It may be
possible (but unlikely) that the playlist will already be restored
before we wait for the signal, and playback won't be resumed.

Signed-off-by: Marko Hauptvogel <marko.hauptvogel@googlemail.com>
2017-01-05 17:09:57 +00:00
Santiago Gil 00c96f7334 Consider depth levels in path sorting (#5445) (#5573) 2016-12-31 13:22:10 +00:00
Santiago Gil d3898d2f47 Add dialog to display streams' audio details (#5547)
* Add Stream Details window

* Fix capitalization in StreamDiscoverer::Discover()

* StreamDiscoverer::Discover(): get URL by const reference

* Refactor StreamDiscoverer::Discover

* Rename StreamDiscoverer callbacks

* StreamDiscoverer::OnDiscovered: fix nullptr comparison

* StreamDiscoverer: rename DiscoverFinished signal

* StreamDiscoverer::DataReady: receive const reference

* StreamDiscoverer: Remove unsigned types

* StreamDetailsDialog: rename Close slot

* StreamDetailsDialog: rename ui pointer to ui_

* MainWindow::ShowStreamDetails: receive a const reference

* StreamDetailsDialog: use unique_ptr, remove unsigned types
2016-12-21 16:57:04 +00:00
Mark Furneaux 589d641955 Fix playlist save on dialogs which do not enforce extensions (#5496)
like GTK+
2016-12-21 14:41:48 +00:00
Santiago Gil 1c0891202d Let the audio sink autonegotiate the bit depth. (Possible fix for #5533) (#5541) 2016-12-21 14:40:40 +00:00
John Maguire bd2de93e3c Add more override specifiers. 2016-12-20 14:16:42 +00:00
John Maguire df5c53af84 Add "override" to SpotifyService. 2016-12-20 13:02:06 +00:00
Chocobozzz 2ede85bdcd Merge branch 'master' into qt5 2016-12-18 17:04:08 +01:00
Bigard Florian 6901c9b1b6 Fix podcast episodes forgotten (#5560) 2016-12-18 15:48:08 +00:00
John Maguire da90d1ccf2 Fix cross compiling for mac 2016-12-15 18:45:51 +00:00
John Maguire 6f356592a5 Fixes for cross compiling for mac. 2016-12-15 11:36:05 +00:00
Chocobozzz 2096b1f268 Merge branch 'master' into qt5 2016-12-13 20:26:19 +01:00
Chocobozzz ded3126857 Add compatibility with chromaprint >= 1.4 2016-12-08 23:12:17 +01:00
John Maguire 5e7dd00024 Use a flickr group instead of a tag for kittens.
Fixes #5531
2016-11-14 12:55:24 +00:00
John Maguire d19ee71443 Try disabling SPMediaKeyTap on Sierra+.
Update issue #5497
2016-11-09 13:58:39 +00:00
John Maguire 420601f10a Add support for classicalradio.com 2016-11-07 18:22:06 +00:00
Nicolas Martinelli 650f06f7ad Fix Subsonic endpoint
According to the documentation, the endpoint is `getAlbumList`, not
`GetAlbumList`. This typo makes the complete feature not working at
all.

Source: http://www.subsonic.org/pages/api.jsp#getAlbumList
2016-10-20 22:08:26 +02:00
Clementine Buildbot 1a2f6e2fe8 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-10-13 15:18:59 +00:00
Chocobozzz 18a89f78a9 Merge remote-tracking branch 'upstream/master' into qt5 2016-10-07 14:30:09 +02:00
Clementine Buildbot ac90f0b091 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-09-26 10:00:52 +00:00
Clementine Buildbot 20ed72fe11 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-09-19 10:00:51 +00:00
Jan Suchomel 622a3e478a Add support for displaying lyrics from a Vorbis comment (#5495)
* Added support for displaying lyrics from Vorbis Comments.

* Fixed style issues
2016-09-18 13:23:39 +01:00
Andreas Muttscheller e5ab3e786f Network Remote: Check bytesAvailable >= 4 before reading length integer
This caused Clementine Remote to stop working on Android N. writeInt()
splits the 4 bytes across multiple tcp frames. Clementine would read
a wrong length and thus fail to read any protocol buffer data.
2016-09-12 12:07:28 +02:00
Clementine Buildbot 363e88a6c4 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-09-12 10:00:50 +00:00
Matt d96a04431a added popular libraryfiltergroup filter: Album artist/Album (#5476) 2016-09-06 07:28:55 -05:00
Santiago Gil 8da53abcfa Add option to show/hide sidebar (#5459) 2016-09-06 07:28:25 -05:00
John Maguire afb7e1db36 Add attribution to wikipedia artist biographies 2016-09-05 15:17:14 +01:00
Clementine Buildbot 8ad56819b2 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-09-05 10:00:52 +00:00
Clementine Buildbot d70778b99b Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-08-29 10:00:48 +00:00
Ilya Selyuminov d9b3a9302a Update playlist virtual order after sorting (#5436) (#5466) 2016-08-26 08:59:26 -05:00
Ilya Selyuminov 09b0fab87c Add new command line option for creating a new one playlist #5373 (#5468) 2016-08-26 08:59:11 -05:00
Mark Furneaux 0ce9e1696c Don't cache missing covers (#5471)
They might change later
2016-08-23 09:26:15 -05:00
Clementine Buildbot 700361a9b7 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-08-22 10:00:43 +00:00
Clementine Buildbot a99dc10cd6 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-08-08 10:00:44 +00:00
Clementine Buildbot 0b5fb0ccff Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-08-01 10:00:48 +00:00
ArnaudBienner af8ba8946e Merge pull request #5452 from santigl/path-sort-lowercase
Ignore case in path comparison (#5445)
2016-07-26 16:17:16 +02:00
Santiago Gil 3d399cec8c Restructure edittagdialog layout (corrects #5437) (#5450) 2016-07-25 11:45:57 +01:00
Clementine Buildbot b702edb3ab Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-07-25 10:00:57 +00:00
santigl 9ddd630b3b Ignore case in path comparison (#5445) 2016-07-24 16:15:59 -03:00
Clementine Buildbot 17beaa7a88 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-07-18 10:32:08 +00:00
Mattias Andersson 516391a599 Urlencode file names in smart playlists (#5441) 2016-07-13 17:56:01 +01:00
Josef Vitu 32ed8ebba4 Back/Forward mouse buttons support (closes #4809) (#5440) 2016-07-12 21:47:42 +01:00
John Maguire 8eae8d4538 Merge pull request #5435 from paperbagcorner/emptyimageresponse
Cope with empty spotify image responses
2016-07-12 11:00:49 +01:00
Clementine Buildbot 4b0b8576d9 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-07-11 10:00:48 +00:00
Mattias Andersson deb1c638cc Cope with empty spotify image responses 2016-07-07 19:04:24 +02:00
John Maguire 1f95a23fd4 Remove non-static data member initializers 2016-07-06 14:26:45 +01:00
John Maguire 59415d5a5f Use old annotation names for backwards compatibility. 2016-07-06 12:03:39 +01:00
John Maguire de046cdf40 Fetch whole wikipedia article (as extract).
Fixes #1112
2016-07-05 15:09:12 +01:00
Clementine Buildbot f30db4b070 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-07-04 10:00:46 +00:00
Mattias Andersson 0b6d531bd3 Focus the library tab when using the 'Show in library' feature 2016-07-01 11:37:04 +02:00
John Maguire 678ea4c6d1 Fix fetching wikipedia images for unicode artists.
#5416
2016-06-29 14:58:03 +01:00
John Maguire f0406ba86b Fix parsing of URLs from wikipedia.
#5416
2016-06-29 13:34:59 +01:00
John Maguire 13aa0adc84 Migrate to dropbox api v2 2016-06-29 12:16:08 +01:00
John Maguire 7750d5015e Cope with empty biography responses. 2016-06-28 18:22:15 +01:00
John Maguire a9ba0f3bf2 Filter out bad wikipedia images better and support other locales better.
#5416
2016-06-28 16:28:20 +01:00
John Maguire 55af2b1d3b Add image fetching from wikipedia
#5416
2016-06-28 15:34:14 +01:00
John Maguire 7c0ef13bb7 Add artist biography from Google KG.
#5416
2016-06-28 14:16:23 +01:00
John Maguire a8a0f2e4fd Remove echonest and update songkick concert fetcher.
#5416
2016-06-27 14:47:42 +01:00
Clementine Buildbot f13288876f Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-06-27 10:00:53 +00:00
John Maguire aeb493c016 Replace echonest artist images with spotify #5416 2016-06-22 14:54:57 +01:00
Clementine Buildbot 0a4eafafcd Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-06-20 10:00:41 +00:00
Clementine Buildbot c96e33c6c7 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-06-13 10:00:47 +00:00
John Maguire fde64e31b8 Remember filename & extension for saving playlists
Fixes #2951
2016-06-07 18:04:53 +01:00
John Maguire ed26a7fb64 Merge pull request #5397 from TheUbuntuGuy/master
Fix pipeline with direct output to ALSA
2016-06-06 12:09:25 +01:00
Clementine Buildbot b81e6e7596 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-06-06 10:00:52 +00:00
Mark Furneaux 41d323332a Fix pipeline wit direct output to ALSA
In the new version of gstreamer, alsasink supports floating samples, so it seems to be bypassing audioconvert.
Integer samples make downmixing work correctly.
2016-06-03 11:49:22 -04:00
John Maguire 3fc6208248 Merge pull request #5391 from Yanpas/tray_scrolling
Scrolling over tray icon support
2016-06-02 15:15:35 +01:00
Yan Pashkovsky a879b8c7fd make format 2016-06-01 21:58:35 +03:00
John Maguire 6b90f69894 Fix typo 2016-06-01 11:46:52 +01:00
John Maguire b90fb73480 Merge pull request #5394 from Chemrat/udisks2
Udisks2 support
2016-06-01 00:10:26 +01:00
Valeriy ecaa9de788 fix variable names 2016-05-31 20:31:39 +03:00
Valeriy 1812f089b0 feed udisks2lister.* through format.py
add copyright headers
2016-05-31 18:31:00 +03:00
Valeriy 0172f7265b fix code style 2016-05-31 18:19:46 +03:00
Valeriy cc6a99ef92 handle our unmount responses because those unmount jobs expire too fast
for jobs use dbus interface when possible
clean up the code a bit
2016-05-30 18:24:02 +03:00
Clementine Buildbot aabce8c7ee Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-05-30 10:01:02 +00:00
Yan Pashkovsky a9a616863d Scrolling over tray icon support 2016-05-30 02:12:03 +03:00
John Maguire 75f9439843 Merge pull request #5375 from Chemrat/master
disconnect GVolumeMonitor signals from GioLister before destroying it
2016-05-24 14:40:24 +01:00
Clementine Buildbot 1eb8e32ca4 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-05-23 10:05:26 +00:00
Valeriy ed986d3863 UDisks2.Job interface support 2016-05-22 23:44:22 +03:00
Valeriy 68001ff7e8 udisks2: handle unmount jobs too, more verbose logging 2016-05-21 23:29:18 +03:00
Clementine Buildbot 4c3eb6135d Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-05-18 15:00:50 +00:00
Valeriy d4e932db9a udisks2 support for devicemanager (refs #3264) 2016-05-17 22:56:16 +03:00
Valeriy cbc7092ed9 fix code style 2016-05-17 14:47:02 +03:00
John Maguire 0beb6d3c59 Remove support for Amazon Cloud Drive. 2016-05-16 18:00:10 +01:00
Mark Furneaux bcf29dc670 Fix caps on audio pipeline
Fixes #1747

The pipeline has the caps for the analyzer applied in the wrong place. This results in the audio output being limited to 16 bit regardless of the input file.
This change also cleans up the mono/sample rate caps as well.
2016-05-15 13:31:00 -04:00
Valeriy 806e689d1d replace foreach with range-based for 2016-05-11 19:00:30 +03:00
Valeriy 948140fab5 disconnect GVolumeMonitor signals from GioLister before destroying it
fixes #5369
2016-05-11 17:58:12 +03:00
Chocobozzz 0aa3405274 Merge remote-tracking branch 'upstream/master' into qt5 2016-05-09 12:46:08 +02:00
Bigard Florian f2fce34ad8 Fix spotify blob config path (#5370) 2016-05-09 10:55:16 +01:00
Clementine Buildbot 931b6aa2a8 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-04-25 10:00:43 +00:00
Vavooon d019cb7f80 Initialize user_favorites_ and remove an excessive line
* Add Favorites support to SoundCloud

* Initialize variable and remove an excessive line
2016-04-21 21:03:58 +01:00
Vavooon 7ef095d0cb Add Favorites support to SoundCloud (#5345) 2016-04-20 13:03:48 +01:00
David G. F f1825629db Qt5
* Fixing a couple of issues with subsonic in the qt5 port

* Forgot to add this fixes as well, otherwise won't play music!
2016-04-19 23:22:23 +01:00
David G. F 182e5c3034 Fixing a couple of issues with subsonic in the qt5 port (#5346) 2016-04-19 21:50:21 +01:00
Santiago Gil 0451240df8 Display a stream's URL if it lacks a title (#5333) 2016-04-18 15:20:07 +01:00
Clementine Buildbot 1ade25e9f3 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-04-18 10:00:58 +00:00
Marko Hauptvogel c0e08d42ed Fix rating preservation
This is a bugfix for commit bb5a952e to prevent deletion of database-only ratings.
2016-04-17 19:23:36 -07:00
Mildred Ki'Lya 3afa80bef0 Don't scan directories with .nomedia or .nomusic files (#5327) 2016-04-15 10:44:44 +01:00
Alex 11670e1760 Fix playlist behaviour (#5330)
* Do not restore playback state on application start if overwritten by command line options

This also fixes unwanted pausing if a new instance is started with commandline URL combined with playback restore.
Note that the actual buggy code (MainWindow::ResumePlayback()) is not fixed here.

* Fix for commandline URLs for new instances are always appended to playlist.
2016-04-12 15:53:43 +01:00
Clementine Buildbot 75d7179dd7 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-04-11 10:00:58 +00:00
John Maguire 6693a870ad Reformat intergalacticfm service 2016-04-06 15:45:25 +01:00
John Maguire 9291f09b1b Merge branch 'master' into PanderMusubi-master 2016-04-06 15:43:32 +01:00
John Maguire b2c506656c Avoid redirects from IntergalacticFM 2016-04-06 15:42:25 +01:00
John Maguire be958495fe Merge branch 'master' of https://github.com/PanderMusubi/Clementine into PanderMusubi-master 2016-04-06 15:30:28 +01:00
Clementine Buildbot 003b258aab Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-04-04 10:00:54 +00:00
John Maguire 1489191794 Revert "Require Qt4.8.1 and CMake deprecate warnings ..."
This reverts commit e1124403fd.

qdbusxml2cpp did not support new annotation names until 4.8.2
2016-03-31 15:06:14 +01:00
Chocobozzz 0605dd83a5 Fix compilation (wrong echonest include) 2016-03-30 19:29:30 +02:00
John Maguire ed13d02231 Remove support for mpris1 2016-03-30 17:14:58 +01:00
John Maguire 807e4552e1 Merge pull request #5314 from ivan-leontiev/fix-globalsearch-sources
Move global search settings loading later in "MainWindow" initialisation
2016-03-30 16:44:34 +01:00
John Maguire 1d07be584e Fix annotations on mpris1 args. 2016-03-30 15:50:08 +01:00
John Maguire 9c33369fcc Merge pull request #5292 from printesoi/fix-mpris-signals
Fix mpris dbus notifications
2016-03-30 15:36:04 +01:00
Victor Dodon 3dd55e1c86 mpris2: fix format
Minor code refactoring:
- Use ternary operator in Mpri2::CanSeek
- Run make format
2016-03-29 21:29:47 -07:00
Ivan Leontiev 75d4731534 Move global search settings loading later in "MainWindow" initialisation
Fixes #5312.
2016-03-30 04:58:47 +03:00
David Sansome 2257dcd278 Merge pull request #5318 from goggle/master
Fixed compile error for the subsonic module.
2016-03-30 10:01:07 +11:00
John Maguire b20d0d87fd Revert "Adding support for subsonic cover art download" 2016-03-29 21:12:54 +01:00
Alex Seiler 6cc60d0cf8 Fixed compile error for the subsonic module. 2016-03-29 21:23:53 +02:00
John Maguire ca487a5166 Merge pull request #5270 from davidgfnet/master
Adding support for subsonic cover art download
2016-03-29 16:44:21 +01:00
John Maguire c22911815a Merge pull request #5285 from santigl/dummyBands
Add dummy bands to avoid #695
2016-03-29 15:35:43 +01:00
Clementine Buildbot 2e66eeb61f Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-03-28 10:00:51 +00:00
Chocobozzz cbd2a08432 Register metatype QAbstractSocket::SocketState 2016-03-28 11:50:52 +02:00
Chocobozzz 4898d20ce2 Merge remote-tracking branch 'upstream/master' into qt5 2016-03-28 11:38:22 +02:00
Ivan Leontiev 9afd71c651 Fix pressing "Backspace" key on a playlist results in appending "^H" character to the filter 2016-03-25 03:45:33 +03:00
Clementine Buildbot 23c0fe9f12 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-03-23 16:52:38 +00:00
René Tronsgaard Rasmussen 8e70046e4b Add -q,--stop-after-current commandline flag 2016-03-18 20:21:34 +01:00
David Guillen Fandos 10bac1cd2d Fixing issues in the pull request. 2016-03-12 19:44:32 +00:00
Pavel Vatagin b2db55e772 fix "undefined reference to" for clementine when build in MXE 2016-03-12 18:14:40 +03:00
Victor Dodon 91c144478b mpris2: emit CanSeek notification in EngineStateChanged
When the engine status is Playing must emit the notification CanSeek
2016-03-10 21:29:09 +00:00
Victor Dodon 5b066991ab playlist: call InformOfCurrentSongChange only after updating the virtual index
Calling InformOfCurrentSongChange before updating the virtual index results in
sending the CanGoNext and CanGoPrevious notifications with the wrong values.
2016-03-10 21:20:53 +00:00
Victor Dodon 5f14e887a7 mpris2: more notifications in RepeatModeChanged
Emit CanGoNext, CanGoPrevious notifications in RepeatModeChanged
2016-03-10 21:20:17 +00:00
Victor Dodon 3cf6cdb925 mpris2: more notifications in CurrentSongChanged
Emit CanGoNext, CanGoPrevious, CanSeek notifications in CurrentSongChanged
2016-03-10 21:14:31 +00:00
Victor Dodon c973c446e3 mpris2: add support for CanGoNext, CanGoPrevious, CanSeek 2016-03-10 21:11:05 +00:00
JulianVolodia e1124403fd Require Qt4.8.1 and CMake deprecate warnings ...
... "com.trolltech.*" changed to "org.qtproject"
2016-03-09 18:26:43 +01:00
Santi ed7375d7da Add dummy bands to equalizer (Fixes #695) 2016-03-08 15:26:45 -03:00
Clementine Buildbot e2fbb8e966 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-03-07 10:00:42 +00:00
Chocobozzz 8cf6fc839c Use QWidget::grab instead of deprecated QPixmap::grabWidget 2016-02-29 18:16:09 +01:00
Chocobozzz e6e189967d Merge remote-tracking branch 'upstream/master' into qt5 2016-02-29 18:03:02 +01:00
Clementine Buildbot 357af2263b Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-02-29 10:00:41 +00:00
David Guillen Fandos e4efde900a Adding support for subsonic cover art download 2016-02-26 23:29:13 +00:00
Pander 1496d581cd Changed HTTPS to HTTP for Intergalactic FM 2016-02-25 17:37:45 +01:00
Clementine Buildbot 9252925a56 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-02-22 10:00:42 +00:00
John Maguire 51c1c36934 Merge pull request #5263 from simark/fix-moodbar-crash
moodbar: check QSlider max/min before using them in division
2016-02-18 14:17:58 +00:00
Simon Marchi 725e1d8f0d moodbar: check QSlider max/min before using them in division
When switching playback from an item for which the moodbar is not
displayed (e.g. an internet stream), to an item for which it is
displayed (e.g. a local mp3 file), Clementine sometimes crashes.

This happens because the slider_opt->maximum and slider_opt->minimum
have the value 0 (their default value), and the difference is used as a
divisor.  This gives a division by 0, and a SIGFPE.

This problem has been fixed in commit af42cce.  However, when a9f9b0e
reverted 3f79fa5, a little to much was reverted and we lost what af42cce
did.  This patch re-introduces the fix.

Fixes #5261

moodbar: Add comment
2016-02-18 09:15:44 -05:00
John Maguire 4cd20ffdaa Cope with receiving no images from spotify 2016-02-17 18:06:30 +00:00
John Maguire abc6370b00 Don't force native windows on OS X with qt5 2016-02-17 17:14:14 +00:00
John Maguire 52c72f95ba Too clever for old GCC versions. 2016-02-17 16:42:03 +00:00
John Maguire 1304f8898e Fetch artist images from spotify. 2016-02-17 15:55:37 +00:00
John Maguire 5b4c0c920c Blacklist artist images from echonest using dead last.fm server. 2016-02-17 15:55:37 +00:00
John Maguire a80e241bbe Make image requests follow redirects 2016-02-17 15:55:32 +00:00
John Maguire b0322e7e7d Cleanup ApplicationImpl 2016-02-15 17:41:39 +00:00
John Maguire 20bfade965 Hide Application classes behind pimpl.
This should also fix the build on windows where gcc gets confused as
libmygpo declares DELETE as part of an enum and mingw #defines DELETE in
winnt.h
2016-02-15 17:39:50 +00:00
Clementine Buildbot b3d5cabdc1 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-02-15 10:00:41 +00:00
John Maguire affb215a52 Move cover providers initialisation later in startup. 2016-02-12 16:25:01 +00:00
John Maguire dcdd81d69f Moar Lazy migrations 2016-02-12 16:10:56 +00:00
John Maguire b99b090adc Refactor simple dialogs to use Lazy 2016-02-12 16:01:35 +00:00
John Maguire 74e6a1744f Convert edit tag & settings dialog to Lazy. 2016-02-12 15:56:08 +00:00
John Maguire 589f2ff62e Lazy initialise organise dialog 2016-02-12 12:25:35 +00:00
John Maguire 0cf83b19ee Eagerly initialise TagReaderClient 2016-02-12 12:07:26 +00:00
John Maguire 86a6345995 Merge pull request #5251 from santigl/gainLabel
EqualizerSlider: move include from .h to .cpp
2016-02-11 18:03:18 +00:00
Santi 1fa4201926 EqualizerSlider move include from .h to .cpp 2016-02-11 14:59:39 -03:00
John Maguire 7d1abbda55 Don't connect action signals multiple times.
Fixes #5249
2016-02-11 17:07:00 +00:00
John Maguire ce3ba02749 Fix songkick concert fetching 2016-02-11 16:59:40 +00:00
John Maguire d06f337ade Remove special deletion of objects in threads.
Fixes #5250
2016-02-11 16:31:08 +00:00
John Maguire 729dc8e281 Merge pull request #5182 from abika/fix-fetch_edit_dialog
Fix bug in edit tag dialog when fetching (2)
2016-02-11 15:30:51 +00:00
John Maguire f2daa772c1 Lazy initialise everything in Application. 2016-02-11 15:15:38 +00:00
Alexander Bikadorov 56e95839f0 Revert to iterator usage in edit tag dialog 2016-02-11 16:09:38 +01:00
John Maguire 6844dcc140 Remove unused variable 2016-02-11 14:19:01 +00:00
John Maguire 4c8b1d8143 Add lazy initialisation helper. 2016-02-11 13:46:23 +00:00
John Maguire ea12cfacac Merge pull request #5209 from narunlifescience/patch-1
move duplicated code to annonymous namespace static function
2016-02-11 11:58:06 +00:00
Arun Narayanankutty b4fe7ac7e2 move duplicated code to annonymous namespace static function
update
2016-02-11 05:45:08 -06:00
John Maguire 0ea84e129e Merge pull request #5210 from narunlifescience/patch-2
Use icon loader for remaining icons
2016-02-11 11:24:09 +00:00
narunlifescience b6bf54be6c remove magic numbers 2016-02-11 04:41:37 -06:00
John Maguire 100222477c Merge pull request #5218 from santigl/gainLabel
Add gain label to EqualizerSlider
2016-02-10 15:46:47 +00:00
Santi ec89bd3ea2 Add gain label to equalizerSlider 2016-02-10 12:44:33 -03:00
Alexander Bikadorov 9d413ad01d Edit tag dialog: merged duplicate code 2016-02-09 21:56:22 +01:00
John Maguire 1cc889fbfc Only set lastfm to https for liblastfm1 2016-02-09 15:17:20 +00:00
John Maguire be471e1792 Merge pull request #5181 from Korvox/master
OPML imports should prefer title to text attributes for podcast names
2016-02-09 14:05:10 +00:00
John Maguire 80bf644f8a Merge pull request #5214 from narunlifescience/patch-4
Remove unwanted lines from playlistcontainer
2016-02-09 13:59:15 +00:00
John Maguire 05c0d647f8 Merge pull request #5219 from narunlifescience/patch-5
use normal text color for volume
2016-02-09 13:56:15 +00:00
John Maguire 8dd933b265 Merge pull request #5233 from naokiiwakami/5151
Fix issue in checking existence of media files pointed by CUE files
2016-02-09 13:55:40 +00:00
John Maguire be651acbca Merge branch 'master' of https://github.com/PanderMusubi/Clementine into PanderMusubi-master 2016-02-09 13:40:54 +00:00
John Maguire 3ef46f016f Revert "Don't use https since it's not supported on windows and ubuntu 12.04"
This reverts commit ab5e86fec9.
2016-02-09 11:52:04 +00:00
Clementine Buildbot 9ba41411d3 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-02-08 10:00:52 +00:00
Pander e361af3eed Support also highest quality playlist 2016-02-07 20:06:03 +01:00
Pander 646983d6a9 Added space in name 2016-02-07 18:47:04 +01:00
ArnaudBienner 50c1fcb112 Merge pull request #5213 from ivan-leontiev/fix-tree-view
Resolve some issues related to "AutoExpandingTreeView"
2016-02-07 00:32:24 +01:00
Pander 2d3af58873 Added header files for Intergalactic FM 2016-02-06 14:21:51 +01:00
Pander dc534bbcef Added support for Intergalactic FM 2016-02-05 19:29:43 +01:00
John Maguire 20de7a1a81 Don't leak AudioScrobbler. 2016-02-04 17:13:42 +00:00
John Maguire ccedb0fdc6 At least try to authenticate with last.fm over https 2016-02-04 17:12:42 +00:00
Andreas ab5e86fec9 Don't use https since it's not supported on windows and ubuntu 12.04 2016-02-03 16:33:43 +01:00
Andreas 6c726e3e38 Use desktopauth instead of mobileauth for last.fm
It now uses an oauth like authentication process so the user isn't required to enter the last.fm password in Clementine but rather authenticate through the last.fm website.

Updates #5028
2016-02-03 15:33:46 +01:00
Clementine Buildbot ac0aff5e81 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-02-01 10:00:50 +00:00
Naoki Iwakami 4cb57c0543 Fix issue in checking existence of media files pointed by CUE files 2016-01-30 16:31:10 -08:00
John Maguire 8ef1d4cae2 Bump spotify lib & blob version. 2016-01-28 14:33:04 +00:00
Clementine Buildbot e269cdc8ee Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-01-25 10:00:52 +00:00
John Maguire 9467babee4 Download spotify blob over ssl 2016-01-21 14:54:42 +00:00
Arun Narayanankutty dd1dcb0b6b use normal text color for volume 2016-01-20 19:51:34 -06:00
Matt Scheirer 8193f6c2ec OPML imports should prefer title attributes to text attributes for podcast names 2016-01-20 18:05:22 -05:00
Clementine Buildbot 8eec78671f Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-01-18 10:00:51 +00:00
Arun Narayanankutty 9a7732577d Remove unwanted lines from playlistcontainer 2016-01-16 07:06:27 -06:00
Ivan Leontiev e5be225a39 Collapse current "AutoExpandingTreeView" branch if you press "Left" key under its root 2016-01-15 07:55:56 +03:00
Ivan Leontiev 780a34c0bc Make "AutoExpandingTreeView" animated by default
This adds dropdown animation to views which are derived
from "AutoExpandingTreeView" (internet, library, global search etc.)
2016-01-15 07:55:46 +03:00
Ivan Leontiev b85d09cd9c Fix misbehavior when you double click after a single click on a tree item
This issue appeared as a side effect since the commit
bcaa9e4a37, which adds dropdown
animation to the library/internet view.

Reproduce:
Single/double click on a song item in library/internet view
then all double clicks on this item will be ignored, until you
single click on it once again.

The reason of this behavior in that the "setExpanded" method call from the
"ItemClicked" slot makes the invocation of the "mouseDoubleClickEvent"
method in the context where the view is in the "QAbstractTreeView::AnimatingState"
which makes impossible to emit "doubleClicked" signal, because it just
returns immediatelly (see http://code.qt.io/cgit/qt/qt.git/tree/src/gui/itemviews/qtreeview.cpp#n1849).

To get rid of this behavior we emit "doubleClicked" signal ourselves.
2016-01-15 07:55:19 +03:00
Ivan Leontiev 93aa5031c7 Fix autoscroll fail to follow the selection in "InternetView"
The cause of this issue was the missing call of the parent class
method in "InternetView::currentChanged".

Removed "InternetView::CurrentIndexChanged" signal along with
the "InternetView::currentChanged" method since it looks redundant,
the "InternetView::selectionModel" and its "currentChanged" signal
can be used instead, also it isn't used anywhere in the code.

Resolves: #4485
2016-01-15 07:51:15 +03:00
Arun Narayanankutty 29b8d308b3 Use icon loader for remaining icons 2016-01-14 06:10:54 -06:00
Arnaud Bienner 8579cce85c SoundCloud: add configure action to context menu 2016-01-14 00:04:36 +01:00
David Sansome 48ff15d29c Merge pull request #5200 from Chocobozzz/difm2
show settings dialog for difm when populate streams without a premium account
2016-01-14 07:10:13 +11:00
Chocobozzz ef58ce27e5 show settings dialog for difm when populate streams without a premium account 2016-01-13 19:29:36 +01:00
Clementine Buildbot 3463b720c9 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-01-13 12:28:57 +00:00
Mattias Andersson d9c4e0844d Use mp4mux instead of ffmux_mp4 when transcoding to aac 2016-01-12 15:59:23 +01:00
John Maguire c4c094aa71 Merge pull request #5193 from Chocobozzz/difm
Disable digitally imported for free user (premium account required)
2016-01-11 15:10:48 +00:00
Chocobozzz 3ab20defce Disable digitally imported for free user (premium account required) 2016-01-09 16:45:10 +01:00
Andreas bca2607850 Execute global search always in main thread
Otherwise the timer doesn't work and the invoke of the closure fails (BlockingSearchProvider::SearchAsync).
This is because Q_ARG doesn't work well with templates and "QMetaMethod::invoke: Unable to handle unregistered datatype 'Arg'" is logged.
See closure.h "void Unpack(QList<QGenericArgument>* list, const Arg& arg)" and "Closure::Call".

This change was made because global search with the network remote didn't work anymore (network remote runs in a separete thread).
2016-01-09 15:45:11 +01:00
John Maguire c9b0bb2044 Revert "Add an option to inhibit suspend while playing" 2016-01-08 15:09:07 +00:00
John Maguire 70070ee0bf Geolocate over ssl. 2016-01-08 12:09:13 +00:00
John Maguire 5d868573bc Merge pull request #5153 from nicklan/savedmanager
Add dialog for managing saved files
2016-01-08 11:56:01 +00:00
John Maguire d7df6263cc Merge pull request #5171 from TheUbuntuGuy/master
Fix incorrect highlight colour in playlist when the window is inactive
2016-01-08 11:55:07 +00:00
John Maguire 2f7626e9d3 Merge pull request #5175 from ivan-leontiev/fix-vk-dupitems
Fix duplicate items under vk.com after login.
2016-01-08 11:54:38 +00:00
John Maguire 36c0e6645e Merge pull request #5180 from santigl/master
Enable Enter key shortcut in file view
2016-01-08 11:54:07 +00:00
John Maguire a9b5947fb0 Merge pull request #5150 from narunlifescience/master
Add an option to inhibit suspend while playing
2016-01-07 18:32:29 +00:00
Andreas ab000b1ba5 Fix transcoder settings not applied for network remote
The format was supplied, but the settings for the format was not applied when transcoding files for the network remote.
2016-01-06 13:17:55 +01:00
Santiago Gil 3ed298a73d Enable Enter key shortcut in file view 2016-01-04 18:17:58 -03:00
Alexander Bikadorov ff86ecddc5 Update modified fields boldness when fetching tags 2016-01-04 18:56:28 +01:00
Alexander Bikadorov bad9e4af5e Fix for erasing old tag values when using tag fetcher, replacement for #51311 2016-01-04 17:13:37 +01:00
Clementine Buildbot 3271c06d10 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-01-04 10:00:40 +00:00
David Sansome a168b618d3 Rename "Import" to "Add directory" in the transcode dialog 2015-12-31 11:02:45 +11:00
Mark Furneaux f90ca49340 Merge branch 'master' of https://github.com/clementine-player/Clementine 2015-12-29 12:00:30 -05:00
Clementine Buildbot ef8787e461 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-12-28 10:00:38 +00:00
Ivan Leontiev 71247781eb Fix duplicate items under vk.com after login. 2015-12-26 01:06:17 +03:00
Mark Furneaux 041be5b4ce Fix incorrect highlight colour in playlist when the window is inactive 2015-12-24 13:42:47 -05:00
Santi 98b042d29c Disable translation of shortcuts 2015-12-22 18:33:07 -03:00
narunlifescience 16707f0934 move member variables only used by dbusidlehandler.cpp to anonymous namespace 2015-12-22 10:03:57 -06:00
John Maguire 0c97803f11 Merge pull request #5163 from Ede123/star_icon
Improve the star icon of `favoritewidget`
2015-12-22 14:28:23 +00:00
Eduard Braun f68e4c8c87 Improve the star icon of `favoritewidget`
* Use the star icon in its native size (16 px × 16 px) instead of unnecessarily scaling it down by 1 px
* Center the star icon vertically
2015-12-21 22:25:32 +01:00
John Maguire b3e2525170 Merge pull request #5160 from v-fox/moodbar-regression-fix
Avoiding usage of pixelMetric because it breaks on non-Oxygen styling
2015-12-21 18:59:41 +00:00
John Maguire 7555913b0c Merge pull request #5161 from Chocobozzz/master
Reload playcount from tagreader only if it is set
2015-12-21 18:48:32 +00:00
John Maguire c15a6c8ee9 Merge pull request #5166 from Chocobozzz/edit_tag_main_window
Add error message if editing tag from playlist fails
2015-12-21 18:47:57 +00:00
Clementine Buildbot 0f46967c00 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-12-21 10:00:48 +00:00
Chocobozzz 5675091816 Add error message if editing tag from playlist fails 2015-12-20 19:07:15 +01:00
Chocobozzz dfdb21cd61 Reload playcount from tagreader only if it is set 2015-12-19 19:42:52 +01:00
Clementine Buildbot 6205166823 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-12-14 10:00:40 +00:00
v-fox a9f9b0ef72 Avoiding usage of pixelMetric because it breaks on non-Oxygen styling
Partial revertion for commit "3f79fa5c651f23e48faf1af6ca56dbff9e5660ab" because of
https://github.com/clementine-player/Clementine/issues/4770
2015-12-14 07:16:30 +05:00
Chocobozzz ff7026c9fe Merge remote-tracking branch 'upstream/master' into qt5 2015-12-13 20:05:12 +01:00
David Sansome 5a49fa4ad0 Fix an old bug in the dmg rule 2015-12-13 16:23:35 +11:00
Nick Lanham 2ab1c2fe36 Add a Manager dialog for saved groupings
- Right now only allows removal
- Could also add support for adding/reordering, but it's not clear
  that's necessary
- Triggered from the Display options menu, could also be added to Tools
  toolbar menu
2015-12-11 19:49:51 -08:00
Nick Lanham 862b9a8635 Add saved grouping to the Group by menu 2015-12-11 15:58:06 -08:00
Nick Lanham 5c256f349a Add option to save current library grouping
- Adds saved groupings to the Group by menu
- Currently missing a way to manage saved groupings
- Saved groupings are in a new section of the config file as
   "GroupingName"->ByteArray serialization
2015-12-11 12:02:52 -08:00
narunlifescience 9f121f4a9d move dbus names to unique namespace -> dbusidlehandler.cc & other minor updates
fix InhibitwhilePlaying signals
2015-12-11 08:49:12 -06:00
David Sansome d50cfd5293 Install frameworks into the app bundle properly so Mavericks considers them signed 2015-12-10 23:31:01 -06:00
narunlifescience b13f0690c8 Add an option to inhibit suspend while playing
minor modifications
2015-12-10 03:20:29 -06:00
Nick Lanham ee7c9527a0 Add ampache=1 to getAlbum for playcounts
- Ampache recently added support for returning playcounts, if the client
  reports that it knows it's talking to an ampache server:
  1aaf01ae98

- This checks the type attribute on the ping request to see if
  Clementine is talking to an Ampache server, and if so, it adds
  ampache=1 to getAlbum requests, and uses the returned playcounts.
2015-12-08 14:15:56 -08:00
John Maguire d47ee24962 Merge pull request #5138 from nicklan/master
Add "Smart Playlists" for subsonic
2015-12-08 12:26:18 +00:00
Nick Lanham 8dc6563718 Always pass size and count parameters, init to defaults 2015-12-07 11:00:03 -08:00
John Maguire d256763dcb Update link to point to github
Fixes #5147
2015-12-07 14:37:44 +00:00
Nick Lanham da537d9a4b use WaitForSignal 2015-12-03 17:25:00 -08:00
Nick Lanham 310cf001af Updates from hatstand's comments 2015-12-01 14:59:40 -08:00
narunlifescience 2603cf2088 use iconloader & cleanup previous remnants
update
2015-12-01 00:32:20 -06:00
Nick Lanham d022f974a1 Add "Smart Playlists" for subsonic
Notes:
- These playlists allow access to the subsonic feature of pulling new, frequently played, and so on albums.
- See: http://www.subsonic.org/pages/api.jsp#getAlbumList for the subsonic description
- The subsonic api is inherently album oriented.  Therefore at the moment the "count" argument for GenerateMore is used as the number of albums to pull, which hopefully isn't a problem.
- Could be made more efficient by multi-threading the fetch of the songs for each album
2015-11-30 22:13:37 -08:00
John Maguire f300946c81 Remove most usages of QFutureWatcher 2015-11-27 14:28:12 +00:00
John Maguire 2d61fe6c87 Changed my mind about automatically passing QFutures. 2015-11-27 12:04:14 +00:00
Arnaud Bienner ec98a68c3d Update SLOT signatures.
There weren't update as part of commit 33494dcddcb64f9fccae215f1100cfa885c72039: this prevented the slider to be updated, among other things.
2015-11-27 11:44:59 +01:00
John Maguire 3cc9c1e446 Remove ModelFutureWatcher 2015-11-26 19:02:08 +00:00
John Maguire 33494dcddc Remove BoundFutureWatcher 2015-11-26 18:53:42 +00:00
John Maguire 2cd15ff430 Add NewClosure overload for QFuture 2015-11-26 18:35:17 +00:00
John Maguire bcaa9e4a37 Merge pull request #5130 from narunlifescience/master
add dropdown animation to library & internet tree view
2015-11-25 12:03:40 +00:00
narunlifescience 8020749375 add dropdown annimation to library & internet tree view 2015-11-24 19:35:07 -06:00
John Maguire 398d619a15 Merge pull request #5128 from narunlifescience/master
Make a slight modification to library view line & preferences header line
2015-11-24 18:02:24 +00:00
narunlifescience f03d5356c3 Make a slight modification to library view line & preferences header line 2015-11-24 11:48:16 -06:00
Mattias Andersson bbe7a48c27 Add missing calls to base class constructor. 2015-11-24 13:46:17 +01:00
John Maguire e4966d1594 Merge pull request #5126 from narunlifescience/master
Fix boom analyzer, terbine & bar analyzer behaviour when paused
2015-11-24 11:30:36 +00:00
narunlifescience e586829452 use emplace_back 2015-11-24 03:44:33 -06:00
narunlifescience 154da7b5c0 Fix boom analyzer, terbine & bar analyzer behaviour when paused
remove hidden file added
2015-11-23 12:54:08 -06:00
John Maguire 136c980b1a Merge pull request #5123 from narunlifescience/master
combine nyancatanalyzer & rainbowdashanalyzer(eliminate duplicated code)
2015-11-23 17:50:34 +00:00
narunlifescience b77cb613e2 combine nyancatanalyzer & rainbowdashanalyzer(eliminate duplicated code)
update

minor modifications

format

add seperate classes for nyancat & dash

format

minor correction

restore previous name Nyanalyzer cat
2015-11-23 11:39:42 -06:00
John Maguire fcd4f5095d Merge pull request #5125 from TheUbuntuGuy/fixnext
Set next track as current when removing tracks
2015-11-23 14:03:35 +00:00
Clementine Buildbot 0be554240f Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-11-23 10:00:34 +00:00
Mark Furneaux 9b42ee50ef Set next track as current when removing tracks
Fixes #5031
Attempt to set the song after the deleted tracks as the current so that they will play next rather than the beginning of the playlist.
2015-11-23 01:48:48 -05:00
Mark Furneaux fa0a9d315c Respawn mainwindow on correct monitor
PR #5081 created a regression where the mainwindow will always start on the primary monitor regardless of which one it was closed on when maximized. This restores previous functionality.
2015-11-22 00:35:27 -05:00
John Maguire 1cf5e28030 Merge pull request #5120 from narunlifescience/master
Remove arrow indicators from mainwindow repeat & shuffle QToolButtons
2015-11-18 12:20:28 +01:00
narunlifescience 9314dcead8 Remove arrow indicators from mainwindow repeat & shuffle QToolButtons 2015-11-18 03:31:46 -06:00
Clementine Buildbot 3d035f3539 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-11-16 14:49:10 +00:00
narunlifescience 5f580f1dd9 add volume icon label to background stream settings page 2015-11-12 03:16:00 -06:00
narunlifescience e2c4b1567c seek time step label
height
2015-11-09 19:51:58 -06:00
narunlifescience e1657ab2e8 Mouse wheel track slider Seeking
event accept

make format
2015-11-09 08:14:38 -06:00
Arnaud Bienner d9150ec165 Fix Clementine getting stuck when transitioning from a local track to a Spotify track with crossfade disabled.
Two problems here:
- the first was that "StartPlaybackLater" wasn't called from the thread which created SpotifyServer, so the timer never started.
- then the playback sometimes failed or started with an offset: just hack to ignore sourcedrained signal in this case.
2015-11-03 23:20:44 +01:00
John Maguire a7ae275153 Merge pull request #5094 from terrorfisch/issue-3355
Fix 3355: Tag fetcher now ignores songs without any results
2015-11-02 13:02:46 +00:00
Clementine Buildbot e0ce339383 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-11-02 10:00:35 +00:00
John Maguire f92e88e321 Add support for inhibiting the screensaver on windows. 2015-10-30 16:45:51 +00:00
terrorfisch f49ae2f792 Add new line at the end. 2015-10-30 15:17:23 +01:00
terrorfisch a51baefde6 Resolve formatting issues. 2015-10-30 15:13:26 +01:00
terrorfisch c75f046c10 FIX: Tag fetcher applies incorrect tags for songs without any results
Before this fix the fetched data of the first title was applied to all selected titles. If the other titles hat correctly fetched tags, this information was overridden by the correct data. So the error only occured in case of failure during fetching.
2015-10-30 12:44:12 +01:00
John Maguire 84cc26f8b3 Support trackNum elements in XSPF.
Fixes #5093
2015-10-28 16:17:52 +00:00
John Maguire 240605a011 Merge pull request #5089 from narunlifescience/master
fix rating half star issue
2015-10-26 13:06:31 +00:00
narunlifescience 2b5ad90ea8 fix rating half star issue 2015-10-26 06:21:04 -06:00
John Maguire 3da8701e63 Merge pull request #5087 from narunlifescience/master
Lock/Unlock Ratings edit status
2015-10-26 11:57:26 +00:00
Clementine Buildbot 6917c4f690 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-10-26 10:00:33 +00:00
narunlifescience b9eca5e323 Lock/Unlock Ratings edit status 2015-10-24 23:05:23 -05:00
John Maguire de85d4a989 Merge pull request #5081 from narunlifescience/master
remember normal window state when user closes clementine in maximized state
2015-10-21 15:12:50 +01:00
John Maguire fad1767f6c Revert "Lock/Unlock Ratings edit status" 2015-10-20 18:39:42 +01:00
narunlifescience 6a11ac6162 remember normal window state when user closes clementine in maximized state 2015-10-20 04:44:42 -05:00
John Maguire 8208de9b53 Merge pull request #5077 from narunlifescience/master
Lock/Unlock Ratings edit status
2015-10-19 13:39:16 +01:00
Clementine Buildbot 8446c819cd Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-10-19 10:00:38 +00:00
narunlifescience bcceae175d Lock/Unlock Ratings edit status
add comment

organize

unclutter

patch to work with other languages

Update playlistheader.cpp
2015-10-18 23:06:35 -05:00
zluca 78aea2c8f6 Makes Clementine read "REM DISCNUMBER" from CUE. 2015-10-16 15:17:18 +03:00
John Maguire 5984c881c6 C++11 initialization list doesn't compile on mac 2015-10-14 14:09:41 +01:00
narunlifescience dd953fd86c check custom icon location, then system theme & then fallback theme
icons added & replaced
2015-10-13 22:35:49 -05:00
Chocobozzz f5cd85c6de Fix the command line options when another instance is running 2015-10-12 14:07:10 +02:00
John Maguire fd7843bdae Merge pull request #5073 from electric-indigo/revert-4984-master
Revert "Workaround for malfunctioning "Show in file browser" feature …
2015-10-12 12:34:45 +01:00
John Maguire 5e2a9983d3 Merge pull request #5070 from paperbagcorner/tracklengths
Show track durations in the CD ripper dialog.
2015-10-12 12:34:34 +01:00
Clementine Buildbot 5dea2a9148 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-10-12 10:00:30 +00:00
electric-indigo 2d2b037460 Revert "Workaround for malfunctioning "Show in file browser" feature in Linux" 2015-10-11 22:56:42 +02:00
Mattias Andersson 41d7d792ae Show track durations in the CD ripper dialog.
The duration in seconds is computed using integer division which should be close enough.
2015-10-11 12:18:15 +02:00
Eduard Braun 2e35e09c96 Songinfo/lyrics: Fix index error in "UltimateLyricsProvider::Extract"
(second argument to "QString,mid()" is number of characters, not end index)
2015-10-10 22:35:11 +02:00
Eduard Braun b25101c1be Songinfo/lyrics: Improve generation of paragraphs
(generate new paragraph for two or more newlines, generate line break for single newlines)
2015-10-10 22:04:37 +02:00
John Maguire 3aac164f1e Reverse volume slider direction with horizontal scroll.
Fixes #5064
2015-10-08 13:31:29 +01:00
John Maguire 8f84a53273 Update soma.fm to use https 2015-10-06 17:44:54 +01:00
John Maguire 86ce06e779 Merge pull request #5060 from eduardosm/esm-branch1
Initialize blur_radius_ and opacity_level_ on PlaylistView constructor.
2015-10-05 18:31:48 +01:00
John Maguire 816ff54cb0 Merge pull request #5057 from Chocobozzz/master
Fix byte range requests with seafile (server >= 4.4.1)
2015-10-05 18:31:35 +01:00
Clementine Buildbot d5d5267435 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-10-05 10:00:30 +00:00
Eduardo Sánchez Muñoz 95dad17f3e Initialize blur_radius_ and opacity_level_ on PlaylistView constructor. 2015-10-04 13:26:35 +02:00
Chocobozzz 847e3eefad Fix byte range requests with seafile (server >= 4.4.1) 2015-10-01 21:04:45 +02:00
Clementine Buildbot daddbdea96 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-09-28 10:17:25 +00:00
Ethan Warth 262ea27ec0 consolidated the options for double clicking a playlist
see https://github.com/clementine-player/Clementine/pull/4991#issuecomment-140082879
2015-09-25 22:39:21 -05:00
John Maguire 6ba65276fd Nevermind, OneDrive does not support more than one redirect uri
Revert "Use new oauth endpoint"

This reverts commit a2bef07fd0.
2015-09-25 17:09:43 +01:00
John Maguire a2bef07fd0 Use new oauth endpoint 2015-09-25 17:06:35 +01:00
John Maguire 06e5b6750c Make Dropbox logout work. 2015-09-25 16:25:42 +01:00
John Maguire 415e6dc5e8 Port dropbox authentication to oauth2 2015-09-25 16:21:01 +01:00
John Maguire a2f471d75d Remove task state from icecast service 2015-09-25 15:46:00 +01:00
Arun Narayanankutty ec60406f14 make library view sort line themable
set line color alpha to 100
2015-09-21 20:17:50 -05:00
John Maguire c6e56813ef Merge pull request #5042 from narunlifescience/master
volume slider handle glow effect using system theme
2015-09-21 20:25:54 +01:00
narunlifescience eaf79c3397 rename similar functions 2015-09-21 14:07:43 -05:00
narunlifescience c2e11bed30 move functions to private section & rename a function 2015-09-21 13:25:31 -05:00
Clementine Buildbot d7f10788c7 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-09-21 10:00:44 +00:00
Arnaud Bienner 774aeaaf11 Revert "clean up library view"
This reverts commit 97cbf556a0.
2015-09-21 00:23:30 +02:00
narunlifescience 90c09d1d0a code optimized & added paintevent entry for theme change
Update sliderwidget.cpp
2015-09-19 00:28:59 -05:00
narunlifescience 85d4340bfe Merge remote-tracking branch 'upstream/master' 2015-09-18 14:57:32 -05:00
narunlifescience 4d75fc086b volume slider handle glow effect using system theme
clean up
2015-09-17 16:19:57 -05:00
Chocobozzz 631a6cdabd Merge branch 'master' into qt5 2015-09-16 17:40:54 +02:00
John Maguire cdde9c99db Merge pull request #5038 from narunlifescience/master
change help_text QPalette to WindowText
2015-09-16 15:34:03 +01:00
Arun Narayanankutty f1cae49ad9 change help_text QPalette to WindowText 2015-09-16 09:08:47 -05:00
David Sansome 1e7242afa5 Remove Radio GFM since it's no longer running 2015-09-16 22:37:01 +10:00