Funkwhale
/
Clementine-audio-player-Mac-Linux-Windows
mirror of https://github.com/clementine-player/Clementine
1
0
Fork 0
Code Issues Releases Wiki Activity

Improve the star icon of `favoritewidget` 

* Use the star icon in its native size (16 px × 16 px) instead of unnecessarily scaling it down by 1 px
* Center the star icon vertically
This commit is contained in:
Eduard Braun 2015-12-20 04:10:15 +01:00
parent 4db358aabb
commit f68e4c8c87
2 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/widgets/favoritewidget.cpp
View File

@ -22,18 +22,18 @@
#include <QSize>
#include <QStyle>
#include <QStylePainter>
#include <QFontMetrics>
#include "core/logging.h"
const int FavoriteWidget::kStarSize = 15;
const int FavoriteWidget::kStarSize = 16;
FavoriteWidget::FavoriteWidget(int tab_index, bool favorite, QWidget* parent)
: QWidget(parent),
tab_index_(tab_index),
favorite_(favorite),
on_(":/star-on.png"),
off_(":/star-off.png"),
rect_(0, 0, kStarSize, kStarSize) {}
off_(":/star-off.png") {}
void FavoriteWidget::SetFavorite(bool favorite) {
if (favorite_ != favorite) {
@ -53,12 +53,19 @@ void FavoriteWidget::paintEvent(QPaintEvent* e) {
QStylePainter p(this);
if (favorite_) {
p.drawPixmap(rect_, on_);
p.drawItemPixmap(rect_, Qt::AlignVCenter, on_);
} else {
p.drawPixmap(rect_, off_);
p.drawItemPixmap(rect_, Qt::AlignVCenter, off_);
}
}
void FavoriteWidget::resizeEvent(QResizeEvent* e) {
// ignore text descent when vertically centering
QFontMetrics fontMetrics = QFontMetrics(this->font());
rect_ = this->rect();
rect_.setBottom(rect_.bottom() - fontMetrics.descent());
}
void FavoriteWidget::mouseReleaseEvent(QMouseEvent* e) {
favorite_ = !favorite_;
update();

1
src/widgets/favoritewidget.h
View File

@ -37,6 +37,7 @@ signals:
protected:
void paintEvent(QPaintEvent* e);
void resizeEvent(QResizeEvent * e);
void mouseReleaseEvent(QMouseEvent* e);
private: