1b3b621957
add tooltips to IconOnly tabs
2021-10-25 16:21:14 +02:00
2dc8df7e23
Automatic merge of translations from Transifex
2021-10-23 02:47:38 +00:00
4eebf5747d
Automatic merge of translations from Transifex
2021-10-20 02:46:38 +00:00
c24927a03b
Automatic merge of translations from Transifex
2021-10-19 02:47:25 +00:00
424dbd44e8
Automatic merge of translations from Transifex
2021-10-18 02:47:57 +00:00
68bc9d9ebb
Automatic merge of translations from Transifex
2021-10-17 02:45:03 +00:00
294620fe66
Automatic merge of translations from Transifex
2021-10-15 02:45:17 +00:00
21f038c156
Automatic merge of translations from Transifex
2021-10-14 02:45:24 +00:00
5705d4fd85
Fix: Detaching bus callback in ~GstEnginePipeline
2021-10-09 12:07:56 +01:00
86b958015b
Automatic merge of translations from Transifex
2021-10-09 02:44:42 +00:00
f8f849e49c
Automatic merge of translations from Transifex
2021-10-06 02:44:29 +00:00
69fd49b977
Automatic merge of translations from Transifex
2021-09-29 02:42:17 +00:00
62922147e6
Automatic merge of translations from Transifex
2021-09-28 02:44:15 +00:00
2e133f7ce4
Automatic merge of translations from Transifex
2021-09-27 02:44:15 +00:00
0820035b84
Automatic merge of translations from Transifex
2021-09-25 02:45:40 +00:00
679a0ee544
Automatic merge of translations from Transifex
2021-09-24 02:44:30 +00:00
8715815452
Automatic merge of translations from Transifex
2021-09-23 02:45:20 +00:00
b762aeb1ba
Automatic merge of translations from Transifex
2021-09-22 02:45:17 +00:00
fd585e8aa4
RipCDDialog: no longer forces Cdda* to emit signals
...
- CddaDevice: Removed LoadSongs() method (then renamed ForceLoadSongs to LoadSongs)
- CddaDevice: added songs() method to get currently song list
- CddaSongLoader: cached_tracks is now thread-safe
2021-09-21 10:53:43 +01:00
2936578fa4
CddaDevice: Preventing double read on disc change.
2021-09-21 10:53:43 +01:00
62b5a0e77b
CddaDevice now does not re-read song list if disc is not changed
2021-09-21 10:53:43 +01:00
50404a967b
RipCDDialog now only depends on CddaDevice, no longer on CddaSongLoader
2021-09-21 10:53:43 +01:00
6b03b8f5d1
CddaSongLoader now emits a Finished signal if no further updates will follow for the same disc read.
2021-09-21 10:53:43 +01:00
90ec6f6a24
CddaSongLoader now reads CD-Text for metadata
...
currently this gets overwritten by musicbrainz response almost immediately, though
2021-09-21 10:53:43 +01:00
b020171da7
Automatic merge of translations from Transifex
2021-09-21 02:44:04 +00:00
c969bf9783
Automatic merge of translations from Transifex
2021-09-20 02:44:43 +00:00
cd72cf3390
Use XSPF image elements as manually set artwork
2021-09-18 23:52:37 +01:00
ab6a480131
Apply reformatting from lint.
2021-09-07 18:04:38 +01:00
f548884f57
Correct time computation for seekbar tooltip.
2021-09-07 18:04:38 +01:00
1535e78aa0
Automatic merge of translations from Transifex
2021-09-06 02:44:55 +00:00
2cca75d930
Automatic merge of translations from Transifex
2021-09-05 02:43:23 +00:00
e556a59aea
RipCDDialog: Changing metadata edits now updates filename preview
2021-09-04 15:24:44 +01:00
e187a68e9f
MusicBrainzClient fix: Don't try to read reply on connection timeout
...
that previously resulted in an IO error
2021-09-04 15:24:44 +01:00
c58335c6c9
Automatic merge of translations from Transifex
2021-09-04 02:44:48 +00:00
769d8bbe6d
Automatic merge of translations from Transifex
2021-09-03 02:43:09 +00:00
3b7d5880f9
Automatic merge of translations from Transifex
2021-09-02 02:42:38 +00:00
7eb62b6266
Automatic merge of translations from Transifex
2021-09-01 02:44:42 +00:00
c8c110efaf
Fix: RipCDDialog now correctly loads and stores chosen transcoder preset
2021-08-31 10:19:32 +01:00
a72e252ec6
RipCDDialog: Added file name preview
2021-08-31 10:19:32 +01:00
b0704331d7
Integrate file name format options into RipCDDialog
...
for consistency with OrganiseDialog and reducing code duplication
2021-08-31 10:19:32 +01:00
5c8ca3754f
Added overwrite_existing argument to Transcoder::AddJob
2021-08-31 10:19:32 +01:00
83d961f808
Transcoder: create output paths if they do not already exist
2021-08-31 10:19:32 +01:00
a6fef97cac
Separating out filename formatting options into separate widget.
...
First step towards unifying filename formatting over different dialogs.
2021-08-31 10:19:32 +01:00
922afe506f
Automatic merge of translations from Transifex
2021-08-27 02:44:07 +00:00
8682d4de48
Fix sentinels in variadic function calls
...
Replace sentinel NULL with nullptr, guaranteed to be correctly expanded.
NULL may be defined as plain 0 in C++; which may lead to undefined upper
bits passed in variadic function arguments, causing crashes.
See: https://ewontfix.com/11/
2021-08-23 21:33:46 +01:00
03e13c69e7
Automatic merge of translations from Transifex
2021-08-17 02:42:46 +00:00
327d5fdac3
Automatic merge of translations from Transifex
2021-08-13 02:42:58 +00:00
b55e54388f
Automatic merge of translations from Transifex
2021-08-11 02:43:14 +00:00
cddc08e148
Automatic merge of translations from Transifex
2021-08-09 02:42:51 +00:00
bf424ce986
Automatic merge of translations from Transifex
2021-08-01 02:46:18 +00:00
e2d6759d55
Automatic merge of translations from Transifex
2021-07-27 02:45:37 +00:00
102317e5c8
internet/podcasts: Fix crash when updating podcasts.
...
When a podcast is updated and the number of visible items is set in the
podcast settings, child items that disappear from the view, and are
deleted, are still referenced by the database id map.
Move the removal code from SubscriptionRemoved to a common method and
use that for this case.
2021-07-26 12:36:24 +01:00
ac3a0d33f7
Automatic merge of translations from Transifex
2021-07-26 02:45:57 +00:00
224c475b50
Rename multiple files to match the application ID
...
The desktop entry file, appdata file and installed icons are renamed to
match the application ID for the benefit of Flatpak packaging.
2021-07-20 11:21:05 +01:00
dbe15e5e9f
Automatic merge of translations from Transifex
2021-07-20 02:45:18 +00:00
c0c9037677
Automatic merge of translations from Transifex
2021-07-19 02:44:08 +00:00
6982b47819
Search song from Spotify via web api
2021-07-18 10:45:10 +01:00
98dd3e48a6
Automatic merge of translations from Transifex
2021-07-17 02:45:02 +00:00
1e39ce29a4
Automatic merge of translations from Transifex
2021-07-15 02:43:57 +00:00
daa2f25e3c
Replace Q_ENUMS with Q_ENUM
...
Q_ENUMS is obsolete. See: https://doc.qt.io/qt-5/qobject-obsolete.html
The replacement is Q_ENUM which was introduced in Qt 5.5, and Clementine
requires Qt 5.6.
2021-07-14 10:19:28 +01:00
f379ad84d4
Fix use of emit
...
Adds missing emits.
QTreeView::collapse and QTreeView::expand are slots, not signals. So
remove emit.
2021-07-14 10:18:47 +01:00
320a1b81c9
Fix incorrect use of QFutureWatcher
...
To avoid a race condition, it is important to call setFuture() after doing the connections.
See: https://doc.qt.io/qt-6/qfuturewatcher.html
2021-07-14 10:18:15 +01:00
0c1b6a2a44
Fix setting task blocking library scans
...
TaskManager::SetTaskBlocksLibraryScans() takes the ID of the task.
2021-07-14 10:18:01 +01:00
598e660aeb
Unref bus in SongLoader::LoadRemote()
...
See: https://developer.gnome.org/gstreamer/stable/GstPipeline.html#gst-pipeline-get-bus
2021-07-14 10:17:50 +01:00
4d34748401
Fix memory leak in global search context menu
2021-07-14 10:17:35 +01:00
b3b769f0e7
Automatic merge of translations from Transifex
2021-07-14 02:43:05 +00:00
2902a8786e
Automatic merge of translations from Transifex
2021-07-12 02:43:07 +00:00
4acfdae740
Automatic merge of translations from Transifex
2021-07-09 02:43:48 +00:00
a5e84bbe98
internet: Add common InternetService::ConfigRequired() method.
...
This will allow some common handling of unconfigured services.
2021-07-07 10:47:01 +01:00
7cb5f5c804
Automatic merge of translations from Transifex
2021-07-06 02:43:44 +00:00
db8de64abb
Automatic merge of translations from Transifex
2021-07-03 02:40:42 +00:00
a5fd484a61
internet: Consolidate ShowConfig methods.
...
InternetService::ShowConfig() and ShowSettingsPage() were used to show
the settings page for a service.
2021-07-02 11:54:21 +01:00
25b537cf26
De-duplicate my translator credit
2021-07-02 10:29:17 +01:00
8c660e278c
Automatic merge of translations from Transifex
2021-07-01 02:44:35 +00:00
f35a640ce3
clang-format
2021-06-30 22:05:18 +01:00
cbe384d142
Add override
2021-06-30 22:05:18 +01:00
4a83f8c817
Automatic merge of translations from Transifex
2021-06-30 02:47:46 +00:00
67a947f116
Automatic merge of translations from Transifex
2021-06-29 02:46:23 +00:00
1db1e3231f
Automatic merge of translations from Transifex
2021-06-28 02:47:35 +00:00
f9854e564d
transcoder: Add options avenc_aac element.
...
Initially adding encoder and bitrate settings, but the gstreamer
element exposes a lot of ffmpeg options that can be added as needed.
Reference: https://gstreamer.freedesktop.org/documentation/libav/avenc_aac.html
2021-06-27 15:56:50 +01:00
5ab81fd8bc
Automatic merge of translations from Transifex
2021-06-25 02:47:39 +00:00
62cb889a3f
Automatic merge of translations from Transifex
2021-06-24 02:42:11 +00:00
e46503d0c3
Automatic merge of translations from Transifex
2021-06-23 02:46:40 +00:00
54be35f528
Automatic merge of translations from Transifex
2021-06-22 02:51:35 +00:00
6240fd3d0a
player: Fix crash on UrlHandler error.
...
In a case where a playlist is composed entirely of unresolvable
internet service URLs and the playlist is set to repeat, playing an
item will result in an infinite (until crash) recursive condition.
HandleLoadResult is called with a NoMoreTracks result. It then calls
NextItem, which calls PlayAt for the next item, which, again, calls
HandleLoadResult.
This can be reproduced by logging into a subsonic server, adding items
to an empty playlist, then signing out.
To solve this, separate the error condition from the NoMoreTracks
result. Handle URL resolution errors the same way that media playback
errors are handled, where an error count is incremented and the player
stops if a limit is reached. The common code also notifies the playlist
of the error and provides user feedback by graying out the item.
2021-06-21 12:52:25 +01:00
57b5911f13
Fixes from code review for PR #7037
2021-06-21 12:51:44 +01:00
6fa9cbcc65
Removing watch_for_disc_changes in CddaDevice constructor
2021-06-21 12:51:44 +01:00
83b6bf28f3
No exceptions for error handling! ConnectedDevice::Init now returns bool, indicating success or failure.
...
As decreed by @hatstand.
2021-06-21 12:51:44 +01:00
a4ad507704
Removed some unused includes.
2021-06-21 12:51:44 +01:00
d2240ec0ae
Device change watchdog timer no longer freezes main thread while CddaSongLoader is active.
2021-06-21 12:51:44 +01:00
2dd566653f
Dealing with cdio_open failures in CddaDevice constructor
2021-06-21 12:51:44 +01:00
e35e4195c2
Not using std::make_unique
2021-06-21 12:51:44 +01:00
6ea20336c2
CddaSongLoader: Only run one song loading thread at once.
...
- CddaSongLoader destructor waits for thread to end.
- Added flag to interrupt LoadSongsFromCdda
- Only start song loading if not already running
- Removed (now obsolete) mutex
2021-06-21 12:51:44 +01:00
ae9824e26a
RipCDDialog no longer needs to LoadSongs on show.
2021-06-21 12:51:44 +01:00
63953e1045
RipCDDialog now allows selecting the CD drive
2021-06-21 12:51:44 +01:00
b68734c761
Fix: Missing include guard for cddadevice in mainwindow.cpp
2021-06-21 12:51:44 +01:00
95799a911d
Removing ConnectedDevice::Refresh altogether
2021-06-21 12:51:44 +01:00
639b918557
Removing CddaDevice::Refresh
2021-06-21 12:51:44 +01:00
3c06b92b24
Ripper now works with a cdio instance passed into constructor
...
which comes from a CddaDevice corresponding to the device
2021-06-21 12:51:44 +01:00
ae3037984c
RipCDDialog now uses CddaSongLoader from passed in CddaDevice
2021-06-21 12:51:44 +01:00
14d5c25d37
Integrated cddevice back into cddadevice
2021-06-21 12:51:44 +01:00
9ca75ae357
RipCDDialog now relies on CddaDevice to be notified about disc changes
2021-06-21 12:51:44 +01:00
d2c636ab46
Introducing CdDevice, simple wrapper for cdio that watches disc changes.
...
CddaDevice now relies on this to update song list. CddaDevice::Refresh is now a no-op.
2021-06-21 12:51:44 +01:00
11bd0db03b
Automatic merge of translations from Transifex
2021-06-21 02:54:22 +00:00
c3c77aef19
Automatic merge of translations from Transifex
2021-06-16 02:55:57 +00:00
ffdaeba09f
cueparser: Be more lenient when parsing indexes.
...
Most specs have mm:ss:ff as the index time format, but cue files have
been found with single digit minutes. e.g. 0:00:00 instead of 00:00:00
Reference: https://www.gnu.org/software/ccd2cue/manual/html_node/CUE-sheet-format.html
2021-06-15 14:14:00 +01:00
2bf8f1388b
Automatic merge of translations from Transifex
2021-06-15 02:57:02 +00:00
418a366931
Automatic merge of translations from Transifex
2021-06-14 02:55:24 +00:00
4aa4f4fce3
Automatic merge of translations from Transifex
2021-06-13 02:54:58 +00:00
7fb387b967
Automatic merge of translations from Transifex
2021-06-12 02:54:18 +00:00
4e4fccc07a
playlistparser: Add error mechanism for parsers.
...
Add a new Error signal to parser implementations. Display an error when
user tries to use the unimplemented CueParser::Save.
2021-06-11 10:17:20 +01:00
f4108b5a0c
playlistparser: Display errors on failures.
...
Add an Error signal to PlayListParser and connect that to the
PlayListManager::Error signal. This is eventually connected to the
Application::AddError. Add error messages in some cases where
PlayListParser can fail silently.
2021-06-11 10:17:20 +01:00
612767c878
Automatic merge of translations from Transifex
2021-06-09 03:12:09 +00:00
b09ab3ff37
Automatic merge of translations from Transifex
2021-06-04 04:25:11 +00:00
0dbefa3064
Add a shortcut to go to next album
2021-06-03 17:06:48 +01:00
058fe6f4be
fall back to url if url_resolved is empty
2021-06-02 22:40:13 +01:00
38ac0d3ccb
Radiobrowser.info: use the url_resolved field for radio stations
2021-06-02 22:40:13 +01:00
f674753758
Automatic merge of translations from Transifex
2021-05-31 05:04:40 +00:00
f7369d2c42
Automatic merge of translations from Transifex
2021-05-28 04:26:27 +00:00
2132e99fbe
Automatic merge of translations from Transifex
2021-05-27 03:59:34 +00:00
684c9d232f
Automatic merge of translations from Transifex
2021-05-26 03:51:04 +00:00
d71eba97fb
Automatic merge of translations from Transifex
2021-05-25 03:20:50 +00:00
776bd3b022
settings: Add option to guess song metadata
...
Add "Try to guess missing metadata" option to the Song Metadata page
that controls the setting in SongPathParser.
2021-05-24 15:23:05 +01:00
cf88e47206
settings: Create a new Song Metadata settings page
...
Move tagreader process settings to the new page.
2021-05-24 15:23:05 +01:00
01be9f196a
settings: Organize page enums by category.
2021-05-24 15:23:05 +01:00
89831f8dca
MusicBrainzClient: Log message for malformed XML in reply
2021-05-18 12:13:10 +01:00
e756f2d686
CddaSongLoader: explicitly reading discid as UTF8
2021-05-18 12:12:01 +01:00
8d69da28f3
Fixing freeing of memory in cddasongloader
2021-05-18 12:12:01 +01:00
8668699977
CddaSongLoader: handle potential multiple tag messages correctly
2021-05-18 12:12:01 +01:00
e9945bcbc6
do NOT free toc entries in CddaSongLoader (reverting previous change)
2021-05-18 12:12:01 +01:00
86bbd2ace6
Formatting/linting fixes.
2021-05-18 12:12:01 +01:00
81c0661e8c
MusicBrainzClient stop result parsing after reading first medium with correct discid.
...
Tentative fix for #7020 .
2021-05-18 12:12:01 +01:00
54a497b302
RipCDDialog rejects metadata lists if number of tracks does not match disc.
...
First step for addressing #7020 .
2021-05-18 12:12:01 +01:00
436c53870a
Correctly freeing memory in CddaSongLoader::LoadSongsFromCdda
2021-05-18 12:12:01 +01:00
97800e613a
Fix for #7019 : CddaSongLoader obtaining metadata on first try.
2021-05-18 12:12:01 +01:00
1309c76bec
tagreader: Relocate artist/album/title guessing code
...
Move the code that attempts to fill missing song metadata out of the
tagreader worker. In the main process, it will be controllable using
settings and calling context.
The methods were moved into a new SongPathParser class that checks new
settings to determine if action should be taken.
2021-05-17 13:20:34 +01:00
75de59703c
Fix: Transcoding for CD rips not starting.
...
due to making Transcoder::Start a non-slot in 8d11e9ff
2021-05-15 10:14:18 +01:00
89155ace70
Automatic merge of translations from Transifex
2021-05-14 03:06:05 +00:00
a7468dcd41
Automatic merge of translations from Transifex
2021-05-13 03:03:53 +00:00
3f614464ee
Automatic merge of translations from Transifex
2021-05-12 03:01:45 +00:00
9bfd458b15
playlistparsers: Handle m3u UTF-16 playlists.
...
Rather than assume UTF-8, use QTextStream to read data. This checks the
byte order mark of the file to determine encoding.
As an optimization, since the playlist already needs to be searched for \r
characters, just create a string list and work from that.
2021-05-11 10:22:18 +01:00
d16d9ba282
Automatic merge of translations from Transifex
2021-05-11 02:59:45 +00:00
83157100c4
Automatic merge of translations from Transifex
2021-05-09 02:56:37 +00:00
33aa8c8579
build: Add libgpod link directory.
2021-05-08 15:53:20 +01:00
f5d3079db8
Automatic merge of translations from Transifex
2021-05-08 02:56:24 +00:00
783213f9c1
Automatic merge of translations from Transifex
2021-05-07 02:58:09 +00:00
d798c76e06
devices: Remove obsolete DeviceKit.
...
DeviceKit-disks, renamed udisks, was superseded by udisks2 in 2012.
2021-05-06 20:52:33 +01:00
079384c154
build: Add libmtp link directory.
...
If MTP is enabled, add library directory. This will allow it to be found
in brew installations.
2021-05-03 23:27:28 +01:00
f48888a430
networkremote: Fix some log noise.
...
In avahi, don't log empty errors.
2021-05-03 14:45:00 +01:00
708385c71f
devices: Fix guessed icons in DeviceIcons
...
In the initial implementation, DeviceLister::DeviceIcons returned a
string list and some listers would concatenate other lists to form that
list. When DeviceIcons was changed to return a variant list, that
logic wasn't changed in many places, so instead of appending, string
list variants are being added icon list.
2021-05-01 20:37:01 +01:00
Alfred
Clementine Buildbot
Lukas Prediger
Tom Kranz
Daniel Perelman
Ismael Luceno
Jim Broadus
Robin Lee
kentsangkm
Jonas Kvinge
Adolfo Jayme Barrientos
Robin Ekman
Fabio Bas