Funkwhale
/
Clementine-audio-player-Mac-Linux-Windows
mirror of https://github.com/clementine-player/Clementine
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix: RipCDDialog now correctly loads and stores chosen transcoder preset

This commit is contained in:
Lukas Prediger 2021-08-23 18:22:55 +03:00 committed by John Maguire
parent a72e252ec6
commit c8c110efaf
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/ripper/ripcddialog.cpp
View File

@ -129,10 +129,12 @@ RipCDDialog::RipCDDialog(DeviceManager* device_manager, QWidget* parent)
s.beginGroup(kSettingsGroup);
last_add_dir_ = s.value("last_add_dir", QDir::homePath()).toString();
QString last_output_format = s.value("last_output_format", "ogg").toString();
QString last_output_format =
s.value("last_output_format", "audio/x-vorbis").toString();
qLog(Debug) << "last_output_format loaded: " << last_output_format;
for (int i = 0; i < ui_->format->count(); ++i) {
if (last_output_format ==
ui_->format->itemData(i).value<TranscoderPreset>().extension_) {
ui_->format->itemData(i).value<TranscoderPreset>().codec_mimetype_) {
ui_->format->setCurrentIndex(i);
break;
}
@ -194,8 +196,6 @@ void RipCDDialog::ClickedRipButton() {
OrganiseFormat format = ui_->naming_group->format();
Q_ASSERT(format.IsValid());
ui_->naming_group->StoreSettings();
QFileInfo path(
ui_->destination->itemData(ui_->destination->currentIndex()).toString());
@ -233,6 +233,14 @@ void RipCDDialog::ClickedRipButton() {
SetWorking(true);
ripper->Start();
// store settings
QSettings s;
s.beginGroup(kSettingsGroup);
s.setValue("last_output_format", preset.codec_mimetype_);
qLog(Debug) << "last_output_format stored: " << preset.codec_mimetype_;
ui_->naming_group->StoreSettings();
}
void RipCDDialog::Options() {