David Sansome
76ef868c0a
Don't pass non-const references
2010-04-14 16:12:33 +00:00
David Sansome
65440dd374
Codereview comments from r685
2010-04-14 16:00:45 +00:00
John Maguire
4862c41477
Tidy up http gstreamer source element.
2010-04-14 15:42:49 +00:00
David Sansome
921eb94a21
Abstract the QSettings usage out of Playlist and PlaylistSequence, create a mock for it, and add a basic playlist test
2010-04-14 14:48:10 +00:00
David Sansome
9cec39ffac
Don't seek outside the bounds of the song. See issue #95
2010-04-14 13:22:50 +00:00
David Sansome
24463136b9
Don't inhibit autoscrolling when we scrolled as a result of autoscrolling. See issue #124
2010-04-14 13:11:39 +00:00
David Sansome
ce43638586
Autoscroll when the current song is changed, rather than any data. See issue #124
2010-04-14 13:07:21 +00:00
David Sansome
b97151e9b3
Lower the time we wait for background threads to terminate.
2010-04-14 12:43:13 +00:00
David Sansome
dfa8dabc7e
Add some more stop points in the library watcher to make it shut down faster
2010-04-14 12:41:03 +00:00
John Maguire
6bac7f6cec
Stop the pretty OSD from bringing clementine to front on OS X.
2010-04-14 12:26:29 +00:00
David Sansome
3b1188838b
Show the OSD when --show-osd is used even if the osd is disabled in the settings dialog. See issue #95
2010-04-13 20:45:40 +00:00
David Sansome
aaa1ef8a7f
Add a "seek by n seconds" commandline option, and make sure stopping and starting again from the commandline restarts the same track. See issue #95
2010-04-13 20:22:29 +00:00
John Maguire
f429b53212
Use static version of qsqlite plugin on mac as well & disable qxt for mac.
...
The plugin shipped with Qt has the sqlite symbols set to hidden. It seems dlsym() actually cares about that on Snow Leopard whereas it doesn't in Leopard.
If it can't find the sqlite functions in the given library, then it will go fishing and find /usr/lib/libsqlite3.dylib and that's bad :-(
2010-04-13 19:43:08 +00:00
David Sansome
ac3dba930a
Updated russian translation
2010-04-13 19:36:50 +00:00
John Maguire
a4405e7877
Add support for global media keys on mac (Cocoa only).
...
Updates issue #6
2010-04-13 13:55:54 +00:00
David Sansome
c59c7ee0ec
More commandline options. Fixes issue #95
2010-04-12 23:35:47 +00:00
David Sansome
2ec6ca45c8
Commandline options support. Fixes issue #189
2010-04-12 22:44:29 +00:00
David Sansome
57bd1b0227
Use different frequency values for the equalizer. Fixes issue #192
2010-04-12 20:57:21 +00:00
David Sansome
c08179aa94
Fix a race condition caused by global state in the equalizer.
2010-04-12 20:33:59 +00:00
David Sansome
1070a5fd07
Reverted r664, see issue #191
2010-04-12 20:08:23 +00:00
David Sansome
ecda1787c8
Remove the CanDecode check - it's slow, and overidden by the taglib check anyway.
2010-04-12 19:46:08 +00:00
David Sansome
d54c8cf2f9
Enforce a minimum row size in the playlist, and stop the current track highlight bar from becoming really pale when on an "alternate" row.
2010-04-12 18:07:07 +00:00
David Sansome
00b19ae83e
Fix somafm playback on linux. Might merge this with the mac ifdef if possible?
2010-04-12 17:40:08 +00:00
David Sansome
95bfcd86a9
Only change the equalizer values when the user lets go of the slider - might make it a bit smoother. Updates issue #191
2010-04-12 17:30:56 +00:00
David Sansome
07a851c951
Oops, we'd better unref these buffers to stop memory leaks
2010-04-12 16:41:44 +00:00
David Sansome
e4c3c600b9
Fix a problem where the scope would apperar to freeze for a few seconds when changing tracks.
2010-04-12 16:39:48 +00:00
John Maguire
821baa2211
Mac deployment fixes for gstreamer.
2010-04-12 12:36:30 +00:00
David Sansome
d51c7444ab
Fix some confusion with auto/manual track changes
2010-04-12 01:59:21 +00:00
David Sansome
caa63d3095
Save the last played item when it starts playing, not when it finishes, to fix strange behaviour when you quit during a track.
2010-04-12 01:06:47 +00:00
David Sansome
e755868b74
Remember which track was being played last. Fixes issue #56
2010-04-12 00:40:03 +00:00
David Sansome
a25fd395f1
Fixed the easier codereview comments from r645
2010-04-12 00:26:16 +00:00
David Sansome
aaee1ded22
Fix a crash at the end of the last song on a playlist
2010-04-12 00:21:41 +00:00
David Sansome
1b0b8979df
Codereview comments from r637
2010-04-12 00:20:52 +00:00
David Sansome
031752823c
Add support for crossfading when changing tracks automatically
2010-04-11 23:52:16 +00:00
David Sansome
152470e5b3
Codereview comments from r644
2010-04-11 23:26:06 +00:00
David Sansome
c4aa779728
Clean style of Engine::Base
2010-04-11 23:24:03 +00:00
David Sansome
23880b3cb5
Crossfading in gstreamer backend
2010-04-11 23:03:39 +00:00
David Sansome
c576ca92e8
Add an option to group the library by albumartist. Fixes issue #198
2010-04-11 22:21:21 +00:00
John Maguire
d0ddeb2956
Also show tooltip for playlist column names.
...
Updates issue #181
2010-04-11 21:45:19 +00:00
John Maguire
9cce2bddd9
Show full text on tooltip for playlist & library rows.
...
Fixes issue #181
2010-04-11 21:43:37 +00:00
David Sansome
b19fdbf272
Fadeout in gstreamer engine
2010-04-11 21:40:26 +00:00
David Sansome
656fbba37f
Remove the "identity" element
2010-04-11 20:01:44 +00:00
David Sansome
14d0b00f46
Factor out the gstreamer pipeline bits into another class.
2010-04-11 19:47:21 +00:00
David Sansome
1293865fea
Fix the behaviour of selecting "edit tag ..." when multiple tracks are selected. Fixes issue #139
2010-04-11 17:58:58 +00:00
David Sansome
8027449b8e
Fix a bug where the OSD would move back to the top-left of the first display
2010-04-11 17:19:25 +00:00
David Sansome
8b678cba9a
If the currently playing song was removed from the playlist, start from the beginning when playing the next track. Fixes issue #160
2010-04-11 15:13:39 +00:00
David Sansome
1eb9447097
Use F2 as a shortcut for editing the current track. Fixes issue #194
2010-04-11 15:05:30 +00:00
David Sansome
85032240d9
Set a plugin path on Windows, and don't do a pointless registry check any more
2010-04-11 14:26:30 +00:00
David Sansome
e6da826227
Make the equalizer sliders stick in the middle around '0' when being dragged. Updates issue #166
2010-04-11 13:29:27 +00:00
David Sansome
8c1bdd1bf6
msgmerge's juggling of this translation...
2010-04-11 13:28:57 +00:00
David Sansome
d8bc4c1172
Use the extra gst audio conversion on all platforms
2010-04-11 13:28:26 +00:00
David Sansome
72c67b48e1
Greek translation
2010-04-11 13:03:00 +00:00
John Maguire
95abb71dc0
Equalizer and sound working on mac with a hack.
2010-04-09 14:29:12 +00:00
John Maguire
b11c3b28f7
Fix scope on mac
2010-04-09 13:01:20 +00:00
John Maguire
19fe2cff54
Disable equalizer on Mac to at least get playback working.
2010-04-09 12:29:21 +00:00
David Sansome
2a00935759
Oops, forgot to pass this to the base class.
2010-04-09 00:34:48 +00:00
David Sansome
fba0af14ae
Replace the "new preset" button with a "save preset" button. Stops the user accidentally overwriting default equalizer presets. Fixes issue #190
2010-04-09 00:23:17 +00:00
David Sansome
0cd8f42ea5
Automatically scroll to the currently playing song whenever (it changes || the window is shown) && (the user hasn't done anything for 1 minute). Fixes issue #124
2010-04-08 22:59:02 +00:00
David Sansome
f10873e9b8
Don't get duplicate songs when dragging categories from the library to the playlist. Fixes issue #167
2010-04-08 22:14:43 +00:00
David Sansome
647ac1af8b
Don't block the window manager's logout sequence. Fixes issue #143
2010-04-08 22:08:18 +00:00
David Sansome
b6fd4dd3ac
Fix style in gstequalizer, and fix unused warnings from the elusively named irr_cf.h
2010-04-08 21:32:43 +00:00
David Sansome
c92d6f1852
Left clicking on the track slider will now jump to the absolute position in the track. Fixes issue #172
2010-04-08 21:15:33 +00:00
David Sansome
025bafab76
Put the "show..." and "group by..." library options in a submenu. Fixes issue #187 .
2010-04-08 20:48:22 +00:00
David Sansome
6d0c0d9f80
Show a little album icon next to Year - Album items. Updates issue #188 .
2010-04-08 20:35:21 +00:00
David Sansome
55946ac2ba
Show "Unknown" instead of "0" when sorting by year for albums that don't have a year set. Updates issue #188
2010-04-08 20:30:50 +00:00
David Sansome
539f0a517b
Rename this function so as to not confuse john.
2010-04-08 20:17:57 +00:00
David Sansome
1dbcfb9aa7
Add an option to change the output device on supported gst sinks. Fixes issue #184
2010-04-08 20:14:11 +00:00
David Sansome
baacfcf772
Make sure equalizer settings get saved and loaded properly. Fixes issue #185
2010-04-08 15:13:34 +00:00
David Sansome
a4e14afdbb
Load translations from an empty context too.
2010-04-08 14:29:08 +00:00
David Sansome
64bf9220cb
Make the indentation of the settings dialog pages more consistent
2010-04-07 20:13:11 +00:00
David Sansome
6122051b7d
Set a sync handler on the gstreamer bus to catch some other EOS events. Fixes issue #178
2010-04-07 20:01:44 +00:00
David Sansome
931273b9ea
Add a "sign out" button to the last.fm config dialog, and add an option to hide the "love" and "ban" buttons. Updates issue #156 .
2010-04-07 19:26:49 +00:00
David Sansome
59a113b532
Oops
2010-04-07 19:03:19 +00:00
David Sansome
ef24cd8c5b
Add some more people to the about box
2010-04-07 19:01:41 +00:00
David Sansome
333ac7d90d
Equaliser presets
2010-04-07 17:39:07 +00:00
David Sansome
c6fe113e79
GStreamer equalizer. Mostly working, just missing presets. Updates issue #166
2010-04-07 16:26:04 +00:00
David Sansome
256648f5e3
Add a UI for choosing which gstreamer audio sink to use
2010-04-07 13:51:14 +00:00
David Sansome
f8240e8b7c
Make GstEngine::canDecode much faster by creating the pipeline only once
2010-04-07 12:56:05 +00:00
David Sansome
96aef75c91
Don't add line numbers to the translations - cleans up diffs
2010-04-07 12:27:16 +00:00
David Sansome
f7f05576e8
Icons for the shuffle and repeat menu items. Fixes issue #182 . Also 600 GET.
2010-04-07 12:18:00 +00:00
David Sansome
add852a132
Maybe fix the silly line
2010-04-07 12:14:10 +00:00
David Sansome
b3d62edbef
Fix automatic track change ... again
2010-04-07 00:20:30 +00:00
David Sansome
74ec2fe921
Remove debug output
2010-04-07 00:19:09 +00:00
David Sansome
5188e4f3d2
Enforce the right audio datatype in the gst pipeline... which makes the scope work \o/
2010-04-07 00:18:55 +00:00
David Sansome
f80d459135
Add an option to always hide/show the mainwindow on startup. Also moved "hide tray icon" to the settings dialog. Fixes issue #170 .
2010-04-06 23:46:34 +00:00
David Sansome
98352b707c
Stop the user from dragging covers around in the cover manager. Fixes issue #171
2010-04-06 23:18:19 +00:00
David Sansome
d79b92e27b
Add a little line between the analyzer and the volume slider. Fixes issue #173
2010-04-06 23:16:23 +00:00
David Sansome
46818c851b
Fix canDecode on tracks with funny characters. Thanks Sylvain
2010-04-06 23:00:20 +00:00
David Sansome
6b472b1e4a
Clean up the gstengine formatting a bit
2010-04-06 22:58:41 +00:00
David Sansome
b154f2bd4e
Go on to the next track properly
2010-04-06 22:01:51 +00:00
David Sansome
ac887cf468
Add a damn header to the .pot file
2010-04-06 21:52:29 +00:00
David Sansome
6de9b8e9d7
Moved to gnu gettext translations
2010-04-06 19:18:14 +00:00
David Sansome
c7f4a091ed
Let's give gstreamer another try...
2010-04-06 16:57:02 +00:00
David Sansome
57189ea911
Comments and warning fixes
2010-04-05 19:16:48 +00:00
David Sansome
1c5b6c6b05
Use the vlc engine on Windows
2010-04-05 15:50:53 +00:00
David Sansome
f1f4584da0
Updated greek translation
2010-04-05 15:19:28 +00:00
David Sansome
2966763471
Hopefully fix audio stuttering
2010-04-05 13:38:12 +00:00
David Sansome
f0a2176c78
Emit trackEnded() properly with the VLC backend
2010-04-05 13:26:11 +00:00
David Sansome
34e2fbeb9a
Updated slovak translation. Fixes issue #162
2010-04-05 13:15:18 +00:00
David Sansome
2fdd07fd1c
Updated spanish translation
2010-04-05 02:31:27 +00:00
David Sansome
c7f58b9618
Scope support for the VLC engine
2010-04-05 02:21:53 +00:00
David Sansome
b77a64a2f1
Ooops, forgot this file
2010-04-04 20:45:59 +00:00
David Sansome
993a4f0e43
Experimental VLC audio engine
2010-04-04 20:45:03 +00:00
David Sansome
d5eb2297d2
Move the audio engines to their own directory
2010-04-04 17:50:11 +00:00
David Sansome
38400012e2
Update spanish translation
2010-04-04 17:10:07 +00:00
David Sansome
82f7df1cce
Update translation sources
2010-04-04 17:09:11 +00:00
David Sansome
9f3fc3d8ab
Add the library test back in
2010-04-04 16:28:34 +00:00
David Sansome
dacdf4cc5a
Clean up deleted subdirectories from the database properly. Fixes an issue where subdirectories in the library wouldn't be rescanned if they were removed and recreated. Updates issue #45 .
2010-04-04 14:59:55 +00:00
David Sansome
9151ba05d4
Always watch new directories that were created while Clementine is running. Updates issue #45
2010-04-04 14:09:07 +00:00
David Sansome
90b125499e
Filter the "Choose manual cover" dialog to just image files. Fixes issue #150
2010-04-04 13:42:56 +00:00
David Sansome
83194ecf74
"Add to playlist" context menu item for the library view. Fixes issue #153
2010-04-04 13:31:21 +00:00
David Sansome
fa8f825f48
Update polish translation. Fixes issue #154
2010-04-04 13:18:51 +00:00
David Sansome
45f5219cde
Updated slovak translation. Fixes issue #149
2010-04-04 13:07:22 +00:00
David Sansome
2803a071b6
Update translation sources
2010-04-01 17:21:18 +00:00
David Sansome
ae3923f93b
Set the "group_by" properties of the actions in code instead of in the .ui file, so the enum keys don't get translated.
2010-04-01 17:20:31 +00:00
David Sansome
2443ce6585
Reworked the library watcher to be much more efficient - the backend now holds a list of subdirectories within each library directory, and only the mtimes of these are checked on startup.
2010-04-01 16:59:32 +00:00
David Sansome
1f2220ac63
Add an option to disable the library view's behaviour of automatically opening nodes without many children.
2010-04-01 00:12:25 +00:00
David Sansome
7415b7f4bd
Made mouse wheel events on both the tray icon and the volume widget change the volume by a smaller amount. Fixes issue #145
2010-03-31 23:45:52 +00:00
David Sansome
5c4118dff5
Stop every divider from being '0'.
2010-03-31 23:41:27 +00:00
David Sansome
134743bd29
Add an advanced grouping dialog for the library. boost::multi_index ftw. Fixes issue #94 .
2010-03-31 23:11:45 +00:00
David Sansome
738fdb662d
Better comments
2010-03-31 19:55:32 +00:00
David Sansome
ce43f8dbf9
Make the "Edit tag..." menu item edit all selected tracks, and only show "Renumber selected tracks in this order" if the user right clicked on the track column. Thanks christoph.gysin. Fixes issue #139
2010-03-31 19:09:35 +00:00
David Sansome
2d12b59951
Move the GroupBy enum into library so we can get a QMetaEnum from it. Tidy up the logic for the "group by" options by moving it into properties in the .ui file.
2010-03-31 15:18:39 +00:00
John Maguire
3c60423e18
Add polish translation.
2010-03-31 10:46:47 +00:00
David Sansome
a5412cc274
Make sure to hide the mainwindow on startup if it was hidden last time. Also fix the logic to ensure either the tray icon or the window is visible.
2010-03-31 03:07:11 +00:00
David Sansome
4c42813d9f
Add "group by" support to the library, and improve the whole library model to make it more robust.
...
Still todo: the "Group by advanced..." dialog, unit tests.
Updates issue #94 .
2010-03-31 00:30:57 +00:00
John Maguire
df38ebf9d9
A few little mac fixes.
2010-03-30 15:53:45 +00:00
David Sansome
c0da64c6a2
Make sure the playlist gets reshuffled when the user manually changes track. Fixes issue #137
2010-03-30 00:51:00 +00:00
David Sansome
ef9780b44e
Add a cmake option to use phonon even on unix. Also fix a strange bug with the phonon backend that stopped the track slider from working.
2010-03-30 00:38:32 +00:00
David Sansome
96802bdf6e
Remove debug lines from the cmake script
2010-03-30 00:08:48 +00:00
David Sansome
4e5218a189
On linux, don't reuse the notification if it's already probably closed. Fixes nastyness on KDE4. Fixes issue #118 .
...
Also merge the two ShowMessageNative functions to cut down on copypasta.
2010-03-30 00:08:16 +00:00
David Sansome
3a33d220f6
Update line numbers in other translations
2010-03-29 23:52:01 +00:00
David Sansome
f7dee52e03
Updated spanish translation
2010-03-29 23:49:34 +00:00
David Sansome
d68c61ff25
Reuse the same native notification popup on Linux. Fixes issue #118
2010-03-29 20:08:32 +00:00
David Sansome
48632b5fc0
Updated slovak translation from danovskyjan. Fixes issue #135
2010-03-29 19:39:27 +00:00
David Sansome
ea1df6dbff
Fix the translation resource file generation - thanks Henry Sylvain. Also add a test to make sure they're always found.
2010-03-29 19:12:06 +00:00
David Sansome
afe2aadcf6
Use autocompletion in the edit tag dialog too. Thanks christoph.gysin. Fixes issue #130
2010-03-29 16:59:01 +00:00
David Sansome
227c64177c
Automatically generate .po and .pot files from the translation sources, for launchpad
2010-03-29 16:05:23 +00:00
David Sansome
c1308c1b6c
Czech translation from Vít Pelčák
2010-03-29 14:14:57 +00:00
David Sansome
5367a01bb7
Using the stack works too...
2010-03-29 14:03:05 +00:00
David Sansome
0aec407984
Only prune the scope buffer list from a single thread. Maybe fixes issue #120
2010-03-29 14:00:44 +00:00
David Sansome
ac33a53c5d
Updated greek translation
2010-03-29 13:36:30 +00:00
David Sansome
8af5138758
Outputs go last :(
2010-03-29 13:28:29 +00:00
David Sansome
1433a53960
Fix behaviour when clicking on the system tray when clementine is minimized. Thanks christoph.gysin. Fixes issue #133
2010-03-29 13:24:40 +00:00
David Sansome
f2d3644ca1
Support writing the special ID3/Xiph tags. Fixes issue #115
2010-03-29 13:15:47 +00:00
John Maguire
3980bfbd8f
Update translation strings & french translation.
...
Thanks to Henry Sylvain.
2010-03-29 10:24:36 +00:00
John Maguire
ee9e676df1
Add autocompletion to artist & album tags in playlist.
...
Thanks to christoph.gysin
Updates issue #130
2010-03-27 23:45:46 +00:00
David Sansome
0e4fb1b789
Fix loading songs with a # (or other URL special characters) in the name. Fixes issue #117
2010-03-27 15:53:02 +00:00
David Sansome
c0a323b5ff
Make sure the pretty osd is really the default on windows
2010-03-27 15:15:20 +00:00
David Sansome
6bad424058
Don't show these two columns by default
2010-03-27 15:10:52 +00:00
David Sansome
66df980238
French translation
2010-03-27 12:56:36 +00:00
John Maguire
2afd94ce47
Switch cover manager filter from OR to AND.
2010-03-26 15:04:38 +00:00
John Maguire
2b812a76fd
Split search query in cover manager.
...
Add unit tests.
Fixes issue #119
2010-03-26 12:22:19 +00:00
David Sansome
5b468823d6
Simplify Prev/NextEditableIndex a bit. Thanks christoph.gysin
2010-03-26 00:32:44 +00:00
David Sansome
766429c860
Allow inline editing of tags in the playlist. Thanks christoph.gysin
2010-03-25 23:48:58 +00:00
John Maguire
11bd9966d1
Mac build fixes
2010-03-25 23:03:28 +00:00
David Sansome
40e7737ba3
Maybe global shortcuts on windows...
2010-03-25 22:37:00 +00:00
David Sansome
82cdab9047
Make the pretty OSD the default on platforms without a native notification (Windows).
2010-03-25 21:29:17 +00:00
David Sansome
9c3ea3599f
Fade the OSD in and out on Windows
2010-03-25 21:24:19 +00:00
David Sansome
07ace1db70
Fix the size of the text label in the pretty osd
2010-03-25 20:57:34 +00:00
David Sansome
cffa51a881
Make sure the pretty OSD stays in the same place between calls to show(). Fixes issue #121
2010-03-25 20:54:47 +00:00
David Sansome
3a726f71cd
Fallback for the OSD on systems without transparant top level widgets
2010-03-25 19:57:52 +00:00
David Sansome
b492a63dfa
Fix errors in Qt < 4.6
2010-03-25 19:36:56 +00:00
David Sansome
7d5673930d
Pretty OSD.
2010-03-25 19:30:10 +00:00
John Maguire
fc2877dc30
Show radio icon rather than nothing in notification.
2010-03-25 18:38:20 +00:00
John Maguire
7250587c03
Remove dependency on libnotify and use dbus directly.
2010-03-25 17:52:28 +00:00
John Maguire
2e71390acd
Switch from OR to AND in split queries.
...
Fixes issue #116
2010-03-25 15:59:58 +00:00
John Maguire
645b819b68
Actually use unicode aware LIKE() on win32.
2010-03-25 15:39:13 +00:00
John Maguire
502e346218
Forgot to update win32 sqlite functions.
2010-03-25 15:37:15 +00:00
David Sansome
38b114e4ad
Show the basefilename in the title column if there's no title tag. Fixes issue #99
2010-03-25 15:00:56 +00:00
David Sansome
d5762bbbd7
Fix codereview comments for r496
2010-03-25 14:47:41 +00:00
David Sansome
088d298c7d
Stop scanning the library straight away if we're asked to quit. Fixes issue #114
2010-03-25 14:33:09 +00:00
John Maguire
95252ccc71
Support query splitting in library search.
...
Improve performance of LIKE().
Fixes issue #104
2010-03-25 13:58:24 +00:00
David Sansome
9adf70d77e
Fix the alternate background colour
2010-03-25 13:38:57 +00:00
David Sansome
06555da965
Add another check to see if library files still exist between the two loops in the librarywatcher. Also make sure songs are valid before trying to insert them into the database (triggering not-null constraint violations). Fixes issue #113
2010-03-25 13:15:55 +00:00
David Sansome
c1e2cbe800
This Qt bug was fixed in 4.7
2010-03-25 12:57:11 +00:00
John Maguire
a1baa06dbf
Remove debug
2010-03-25 11:41:07 +00:00
John Maguire
5dc9f2358f
Forgot stylesheet changes :-)
2010-03-25 11:39:44 +00:00
John Maguire
6b6ce0e582
Enable alternating row colours for playlist... hackity hack.
...
Fixes issue #112
2010-03-25 11:38:28 +00:00
John Maguire
a64e5fb17e
I <3 Qt.
2010-03-24 22:31:34 +00:00
John Maguire
ca774badc4
More bounds checking on dbus interface.
2010-03-24 22:29:17 +00:00
John Maguire
c00493223d
Fix segfault when GetMetadata() is called when no song is playing.
2010-03-24 22:17:56 +00:00
John Maguire
b6e3c52f44
Fix comments from r482.
2010-03-24 21:46:00 +00:00
John Maguire
2e35831b0b
Mac build fixes
2010-03-24 21:34:32 +00:00
John Maguire
f9972183c5
ifdef dbus stuff for X11 only.
2010-03-24 21:07:16 +00:00
John Maguire
a8a37264f7
Add MPRIS support (thanks Amarok ;-)
...
Fixes issue #29
Example command lines:
dbus-send --print-reply --dest=org.mpris.clementine /Player org.freedesktop.MediaPlayer.Play
dbus-send --print-reply --dest=org.mpris.clementine / org.freedesktop.MediaPlayer.Identity
dbus-send --print-reply --dest=org.mpris.clementine /TrackList org.freedesktop.MediaPlayer.GetCurrentTrack
dbus-send --print-reply --dest=org.mpris.clementine /TrackList org.freedesktop.MediaPlayer.GetMetadata int32:0
2010-03-24 20:58:17 +00:00
David Sansome
1103ef77da
More library tests
2010-03-24 19:05:49 +00:00
David Sansome
da21f265c6
Fix the "verticalSpacer" warning
2010-03-24 16:51:12 +00:00
David Sansome
91b08cb4a3
Don't set the g++ warning flags on c files. Thanks christoph.gysin. Fixes issue #108
2010-03-24 16:45:44 +00:00
David Sansome
7d6a7101c9
Add a menu item to remove tracks from the playlist. Fixes issue #110
2010-03-24 16:36:44 +00:00
David Sansome
ad30bad33c
Check the playlist context menu index is valid before getting data from it. Fixes issue #109
2010-03-24 16:13:05 +00:00
David Sansome
70b6ba8c39
Fall back on sqlite's default non-unicode aware LIKE when we couldn't load the sqlite symbols. Fixes problems for slackware users (one of their problems anyway...).
2010-03-24 16:02:06 +00:00
David Sansome
4b4603e138
Make sure current_virtual_index_ is kept consistent when clearing or deleting items from the playlist. Fixes issue #107
2010-03-24 14:37:10 +00:00
David Sansome
92c7eff0fb
Don't scrobble a track if we've been skipping through it. Fixes issue #105
2010-03-24 14:21:26 +00:00
David Sansome
16a953af11
Limit length of the "Set x to y..." menu item. Fixes issue #106
2010-03-24 14:14:17 +00:00
David Sansome
4271122976
Add an empty translation to make it easier for new translators to get started.
2010-03-24 13:45:39 +00:00
John Maguire
f312b04df7
Enable more compiler warnings and fix them.
...
Fixes issue #108
2010-03-24 12:07:37 +00:00
David Sansome
821e524b5f
Menu option to set all fields from selected tracks to the same value. Thanks christoph.gysin. Fixes issue #102
2010-03-24 00:12:52 +00:00
David Sansome
bea2709186
Update the debian copyright file
2010-03-23 23:30:52 +00:00
David Sansome
fa00ee971d
Add license headers to all our source files
2010-03-23 23:11:46 +00:00
David Sansome
ea83789f17
Some more library model tests
2010-03-23 21:52:42 +00:00
David Sansome
4ab755c831
Don't try to load translations from a directory that contains another directory called "clementine". Fixes issue #88
2010-03-23 18:00:55 +00:00
David Sansome
f8dd079cfd
Fix codereview comments from r454
2010-03-23 17:56:24 +00:00
David Sansome
16e1deaade
Make it possible for the LibraryBackend to be mocked, and add a simple test for Library.
2010-03-23 17:26:54 +00:00
David Sansome
051263c05d
Enable playlist sorting on columns other than title, artist, album, track and length.
...
Fixes issue #97
2010-03-23 14:24:48 +00:00
David Sansome
ceb6382e9f
Fix compilation in release mode
2010-03-23 14:07:05 +00:00
David Sansome
7fee944b06
Updated spanish translation
2010-03-23 13:37:21 +00:00
David Sansome
ed80c2e6c0
Update translations
2010-03-22 23:03:49 +00:00
John Maguire
3bc93339d9
Reduce watchers on mac (hitting 256 file descriptor limit).
2010-03-22 23:01:03 +00:00
David Sansome
a82e4c5b9a
Added track auto-numbering, thanks christoph.gysin.
...
Fixes issue #25
2010-03-22 22:46:53 +00:00
John Maguire
3e0e3f6889
Actually check for errors in AlbumCoverFetcher.
2010-03-22 21:36:02 +00:00
David Sansome
39a97d9878
Minor UI fix to the settings dialog
2010-03-22 19:46:42 +00:00
John Maguire
2aeff9b5e2
Fix compile on mac for old sqlite3 header.
2010-03-22 18:46:41 +00:00
David Sansome
b1e1de709c
Bring the QSQLITE plugin into the source tree and statically link it on Windows.
...
Also remove the unused xine windows patches, and move all the windows resources into dist/windows
2010-03-22 18:35:31 +00:00
John Maguire
6947fe2923
Set version to 0.2 for mac.
2010-03-22 16:18:03 +00:00
John Maguire
2f350c1ae6
Add unit tests for custom LIKE() function.
2010-03-22 16:03:24 +00:00
David Sansome
ad3c77cb5a
Fix compilation errors on ubuntu
2010-03-22 13:49:08 +00:00
David Sansome
41ab127d1a
Set version to 0.2
2010-03-22 13:20:30 +00:00
David Sansome
91b2162d25
Enforce a minimum size for playlist columns when they're shown. This prevents 0-width columns appearing for whatever reason. Fixes issue #85
2010-03-22 12:13:04 +00:00
David Sansome
1879b6f858
Make this compile when DBUS isn't available
2010-03-21 23:19:56 +00:00
David Sansome
7191f968a6
Fix the memory leak!
...
The scope's buffer, used by the analyzers, wasn't being cleared when the mainwindow (or the analyzer) was hidden. There was a timer that was supposed to clear it, but it wasn't being run because the xine engine is in a thread without an event loop.
Fixes issue #5
2010-03-21 23:11:34 +00:00
David Sansome
43a8b89732
Delete the divider entries properly from the library when deleting songs, and move songs to "Various artists" correctly.
2010-03-21 22:14:07 +00:00
David Sansome
b5b61a2e0e
Add a couple of indexes to the database to speed up searches on large libraries.
2010-03-21 21:17:01 +00:00
David Sansome
eea777e74e
Global shortcuts on gnome, with GSD over DBUS
2010-03-21 19:02:56 +00:00
David Sansome
a2c5bebd25
Remove unused includes. Fixes issue #84
2010-03-21 18:13:22 +00:00
David Sansome
24541609d7
Fixed some RGB parameters out of range warnings
2010-03-21 17:28:54 +00:00
David Sansome
d09eaac67a
Fix up the other 2D analyzers
2010-03-21 17:22:05 +00:00
John Maguire
87b552d16d
set background thread priority on mac
2010-03-21 16:45:34 +00:00
David Sansome
1314ef2e37
Remove the global shortcuts dialog from trunk
2010-03-21 16:37:38 +00:00
David Sansome
0b2bb418f3
Updated spanish translation from Mariano Copetti
2010-03-21 16:22:22 +00:00
David Sansome
0e42e0b9f7
Updated slovak translation
...
Fixes issue #83
2010-03-21 16:21:42 +00:00
David Sansome
2e1023457c
Show the analyzer popup menu on a left click as well as a right click
2010-03-21 16:20:27 +00:00
John Maguire
a7596959eb
Compile fixes for mac for old sqlite3 header.
2010-03-21 16:11:26 +00:00
David Sansome
416670671f
Run the background library scanner at IDLE io priority on linux
2010-03-21 15:55:58 +00:00
David Sansome
530d58b4cf
Add some more strings for translation
2010-03-21 15:00:36 +00:00
David Sansome
56fb0663ee
Fix segfault when a song's tag has changed inbetween runs
2010-03-21 14:47:59 +00:00
David Sansome
cbb41cab46
Store these booleans as ints so sqlite doesn't get confused.
...
Fixes issue #82
2010-03-21 13:50:00 +00:00
John Maguire
b468306d2f
Stop linking against sqlite and use the loaded plugin.
2010-03-21 13:29:06 +00:00
David Sansome
645d7e48cc
Translate this missing string - thanks Mariano Copetti
2010-03-21 13:07:02 +00:00
David Sansome
da7e88d754
Update translations
2010-03-21 00:32:22 +00:00
David Sansome
8cebf0092f
Updated greek translation
2010-03-21 00:31:19 +00:00
David Sansome
26098db9c8
Update the length of the first track on a last.fm stream
2010-03-21 00:30:05 +00:00
David Sansome
2bde36a1c2
Fix timestamps on scrobbled songs
2010-03-21 00:22:15 +00:00
David Sansome
1a930bf2b5
Add a menu item to the library for forcing albums to appear under Various Artists.
...
Fixes issue #43
2010-03-20 23:59:39 +00:00
John Maguire
758f99be49
Support unicode-aware comparisons in Sqlite3.
...
Fixes issue #71
2010-03-20 23:41:59 +00:00
David Sansome
e1c44cdc77
Add options for choosing or disabling the analyzer.
...
Fixes issue #75 .
2010-03-20 22:45:54 +00:00
David Sansome
595877445b
Multiple selections in the album cover manager
2010-03-20 22:03:58 +00:00
John Maguire
417b6af911
Update slovak translation.
...
Fixes issue #79
2010-03-19 13:20:54 +00:00
David Sansome
257170b212
Add support for showing the filename without the path - thanks ralf.neupert
...
Fixes issue #80
2010-03-19 10:39:22 +00:00
John Maguire
7e7aa6a0c4
Fix crash in last.fm radio when the user's subscription expires.
2010-03-18 17:18:54 +00:00
John Maguire
fd2daf6fa2
Fixes issue #3 \o/
...
A reminder for next time: enable various "Universal Access" options.
2010-03-17 17:16:05 +00:00
John Maguire
84bede61d3
Fix compiler warning from Clang.
2010-03-17 15:07:49 +00:00
John Maguire
4a26d10e7e
Build fixes for mac.
2010-03-16 15:09:08 +00:00
David Sansome
6a4d1734b6
Add the shuffle and repeat menus to the menubar as well
2010-03-12 01:03:43 +00:00
David Sansome
e1952e7ff2
Fix the cover manager behaviour when there are unknown albums or albums by various artists.
2010-03-12 00:54:18 +00:00
John Maguire
e809019bef
Fix code review comment for r353
...
Add more tests for XSPF parser.
2010-03-11 15:25:25 +00:00
Andrew Udvare
116204d58e
Start of event handling to capture keys with virtual function event()
2010-03-11 09:56:02 +00:00
Andrew Udvare
f9711d414f
More implementation of ShortcutsDialog and settings
2010-03-11 06:00:47 +00:00
John Maguire
eb5d4cc309
XSPF support in the GUI
2010-03-10 21:39:25 +00:00
David Sansome
65d88ac831
Fix strangeness when rearranging the playlist with shuffle disabled
2010-03-10 14:09:35 +00:00
David Sansome
4988d45f23
Fix a crash bug when clearing the playlist, and then advancing to the next track
2010-03-10 14:06:34 +00:00
David Sansome
b8d7773776
Updated spanish translation
2010-03-10 00:43:36 +00:00
David Sansome
e7c3174109
Fix a segfault. This got lost in the merge
2010-03-10 00:09:49 +00:00
David Sansome
aee1cbb4fd
Revert the multiple playlist commits until they can be cleaned up a bit. These are: r324, r326, r327, r328, r335, r336, r337, r338, and r339.
2010-03-10 00:04:04 +00:00
David Sansome
5294ea1276
Update translation sources
2010-03-09 22:49:14 +00:00
David Sansome
cecc6def3c
Get the translated version of this string - thanks Mariano Copetti
2010-03-09 22:47:36 +00:00
John Maguire
11330d0177
XSPF parser with test.
2010-03-09 17:17:32 +00:00
John Maguire
4eb51bf6d9
Remove pointless cpp file.
2010-03-09 15:46:26 +00:00
John Maguire
95c1f702c5
Oops. s/OS/WS/
...
Updates issue #6 .
2010-03-09 14:31:30 +00:00
John Maguire
b66370ed87
Enable global shortcuts for all X11 platforms instead of just Linux.
...
Updates issue #6
2010-03-09 14:28:58 +00:00
David Sansome
9f0e399fba
Fix a failing test
2010-03-08 18:07:18 +00:00
David Sansome
67214bf4dc
Rename ShuffleRepeatWidget to PlaylistSequence
2010-03-08 18:05:41 +00:00
David Sansome
85d5e398da
Shuffle and repeat buttons now work.
...
Fixes issue #20
2010-03-08 17:55:40 +00:00
David Sansome
d15fffc802
Do something more sensible with negative times.
2010-03-08 14:13:22 +00:00
David Sansome
c9ddf09869
Add shuffle and repeat options. These don't do anything yet.
...
Updates issue #20
2010-03-08 14:08:54 +00:00
David Sansome
427e24dece
Show the time remaining as negative, like amarok
2010-03-08 12:30:55 +00:00
David Sansome
ee5facbd01
Fix the size of the time elapsed and time remaining labels on the track slider, so they don't move the slider around while it's being dragged.
2010-03-08 12:13:11 +00:00
David Sansome
7d0bc4830f
Set the source properly for tracks from last.fm radio
...
Fixes issue #62
2010-03-07 23:39:28 +00:00
David Sansome
6f2119bce0
Fix a bug that meant the track progress slider was greyed out on the first song in a last.fm radio stream
2010-03-07 23:28:40 +00:00
David Sansome
3d34aa240c
Add albumartist, composer, file type and date columns to the playlist. Also add columns to the database for rating, playcount, and lastplayed (not used yet).
...
Fixes issue #66
2010-03-07 22:46:41 +00:00
Bartek Taczała
030e454d1e
Enabling removal of playlist. Slightly changing how informatiion about playlists are stored in QSettings
2010-03-07 20:55:02 +00:00
Bartek Taczała
6f2754bcba
Changing tabWidget to tab_widget
2010-03-07 20:21:20 +00:00
Bartek Taczała
b303d59b4c
Saving qtab current index ( current playlist ).
2010-03-07 20:19:35 +00:00
Bartek Taczała
0a1e7916d8
Ensure one playlist at startup if no restoring. Minor code modifications to compatibility with code guidelines.
2010-03-07 20:14:05 +00:00
Bartek Taczała
8ae713802d
Playlist manager for handling multiple playlists. Storing/restoring is enabled.
2010-03-07 20:06:00 +00:00
John Maguire
1aebf19077
Ensure Song is valid from m3u parser.
...
Fix tests.
2010-03-07 15:26:54 +00:00
John Maguire
768bf85cd7
M3U support in the UI from "Add Media" \o/
2010-03-07 14:42:51 +00:00
John Maguire
08416e2c51
Make M3U parser grab tags from file.
2010-03-07 14:04:17 +00:00
John Maguire
4219dfa718
Add test for taglib usage in Song, will be more helpful testing M3U/XSPF parsing.
...
Dave: I'm sorry.
2010-03-06 20:08:01 +00:00
John Maguire
a4b1452a22
Fix annoying disconnect() messages.
2010-03-06 15:35:02 +00:00
John Maguire
3fe0213106
Make tabbed playlists store & restore.
...
Fix style issues.
2010-03-06 15:33:57 +00:00
John Maguire
28f4b4de0b
add at least one playlist tab at startup
2010-03-06 14:35:06 +00:00
John Maguire
1ad24804cc
Finish m3u parser
2010-03-05 11:57:06 +00:00
Bartek Taczała
4773d7cadc
Adding support for multiple playlists ( as in foobar )
2010-03-05 10:55:37 +00:00
John Maguire
64abef1cd4
Make tracks with no album show up.
...
Fixes issue #57
2010-03-05 10:51:16 +00:00
David Sansome
35a306b9a7
Install .desktop file and icon. Also add an "uninstall" target.
...
Fixes issue #52
2010-03-04 16:41:14 +00:00
John Maguire
7b520ab361
Fix code review comments for r313.
2010-03-03 20:35:19 +00:00
John Maguire
7763d7da89
Add test for AlbumCoverFetcher.
...
Comes with infrastructure for testing network requests.
2010-03-03 19:14:14 +00:00
David Sansome
15797e07c6
Test updating and deleting songs
2010-03-03 18:38:20 +00:00
David Sansome
7a1f7438d7
Updated spanish translation
2010-03-03 18:06:44 +00:00
David Sansome
101b30c4b5
Add some more options to the album cover manager: show fullsize, fetch automatically, choose manually, unset cover
2010-03-03 14:29:53 +00:00
David Sansome
3f861654ec
Some more backend tests
2010-03-03 00:33:31 +00:00
David Sansome
3296bf7b7d
LibraryBackend tests should test at a higher level
2010-03-02 23:37:12 +00:00
David Sansome
4d3bd03f16
More windows fixes
2010-03-02 22:02:43 +00:00
David Sansome
72aa271b23
Fixes for mingw32 cross-compiling
2010-03-02 20:46:46 +00:00
John Maguire
08778f3f2c
Fixes issue 47
2010-03-02 18:44:46 +00:00
David Sansome
5e503cbe64
Try the application's directory as well
2010-03-02 17:48:56 +00:00
David Sansome
111c019edd
Load translations from the current directory so translators don't have to recompile to test their translations
2010-03-02 17:29:43 +00:00
John Maguire
54a5bd2c8e
Everyone loves scoped_ptr.
2010-03-02 12:30:14 +00:00
John Maguire
864215cb23
Adds a test for LibraryBackend (not as trivial as it sounds :-)
...
Adds Googlemock.
Adds mock Qt database drivers.
2010-03-01 22:00:15 +00:00
David Sansome
dae28e10ab
Remember to actually load the translation resources
2010-03-01 17:36:50 +00:00
David Sansome
a0c551f7a7
Remove the qmake project files
2010-03-01 17:33:31 +00:00
David Sansome
0dc1a87781
Automatically generate the qm files, and the translations qrc file
2010-03-01 17:31:54 +00:00
John Maguire
84786c7bc8
Add more tests to m3uparser including one windows-only test.
...
Fix code review comments from r291.
2010-03-01 16:31:19 +00:00
John Maguire
c043eaba0c
Add mostly done M3UParser with basic unit tests.
...
Add lots of test infrastructure.
2010-03-01 15:40:12 +00:00
John Maguire
7e500a2fa8
fix build and move gtest to 3rdparty
2010-03-01 12:55:51 +00:00
John Maguire
e7c064809c
Link resources into library & init in main().
2010-03-01 12:15:15 +00:00
John Maguire
461157bbc9
Mac build & deploy updates.
2010-03-01 12:13:11 +00:00
John Maguire
42fd8c6f1e
Seems resources need to be linked directly in the binary.
2010-03-01 02:49:47 +00:00
John Maguire
269957e7ca
Add infrastructure for unit tests.
2010-03-01 01:47:50 +00:00
David Sansome
91958d0fd2
Change the data returned from sqlite a bit so the library view can use cover art too. Still a couple of TODOs in here.
2010-02-28 22:07:59 +00:00
Andrew Udvare
235a015a6f
Updated Shortcuts dialog to use native widget for OK/Cancel
2010-02-28 21:46:25 +00:00
David Sansome
b6330db85c
More file renames
2010-02-28 21:40:21 +00:00
David Sansome
787a3d2625
Forgot to rename this file in the qmake project
2010-02-28 21:38:52 +00:00
John Maguire
30fa135521
cmake fix
2010-02-28 20:56:27 +00:00
John Maguire
ad52c825ae
Mac deploy script - generates most of the commands necessary for an app bundle.
2010-02-28 20:55:10 +00:00
David Sansome
16d991b76a
Scroll the album cover manager view more sensibly
2010-02-28 19:56:18 +00:00
David Sansome
605e3a87cc
Fetch missing album covers from last.fm :)
2010-02-28 19:25:52 +00:00
John Maguire
eb3b286f0d
Fix broken include.
2010-02-28 18:09:58 +00:00
David Sansome
12273256e5
Album cover art manager. So far this only displays cover art that was loaded from disk.
2010-02-28 18:04:50 +00:00
John Maguire
f9ad923f3a
CMake support \o/
...
Also fixes xine deprecation messages.
2010-02-28 17:28:56 +00:00
David Sansome
2c04b4a23a
Start Slovak translation
2010-02-28 14:10:32 +00:00
David Sansome
e2e2e153c0
Oops, we always want to set these
2010-02-28 01:25:00 +00:00
David Sansome
4d8636874e
Add an option to turn off album art in the OSD
2010-02-28 01:08:18 +00:00
David Sansome
6436c53705
Smooth scale cover art for notifications, and display an empty album cover for tracks that have no artwork
2010-02-28 01:03:13 +00:00
David Sansome
c811505d45
Save and restore album art in the playlist
2010-02-28 00:57:51 +00:00
David Sansome
1a26380e3f
Load album cover art from files on disk
2010-02-28 00:35:20 +00:00
David Sansome
a338707388
Maybe fix crash
2010-02-27 21:01:04 +00:00
David Sansome
669a0263ff
Improved various artists detection - inspired by Amarok.
...
Also support updates to the database schema.
Fixes issue #18
2010-02-27 20:12:22 +00:00
Andrew Udvare
bbe0f81c2b
Implementation of global shortcuts dialog, no settings saved yet; Start of fix for issue #6
2010-02-27 18:20:20 +00:00
David Sansome
e365baf7d1
Oops, now with lrelease-qt4
2010-02-27 17:08:15 +00:00
David Sansome
17bf68798b
Updated translations
2010-02-27 17:07:46 +00:00
David Sansome
1297e8d6ce
Update translations
2010-02-27 17:01:57 +00:00
David Sansome
5edc2c84bc
Fix a typo in last.fm config dialog
2010-02-27 17:01:15 +00:00
David Sansome
b47d53d569
Another attempt to avoid duplicate notifications
2010-02-27 16:57:43 +00:00
Andrew Udvare
cd8243b58f
Fix variable name style, settings->settings_
2010-02-27 16:52:18 +00:00
David Sansome
c5b1e2a0e3
Set the volume on the audio engine after it's finished loading.
...
Fixes issue #40
2010-02-27 16:47:31 +00:00
David Sansome
cf2a8e73e2
Make the colours in the stylesheet obey the Qt colour scheme.
...
Fixes issue #37
2010-02-27 16:36:25 +00:00
Andrew Udvare
bdae62d502
Move settings to be private member of class MainWindow
2010-02-27 08:57:43 +00:00
David Sansome
f7d99ad720
Make it an option whether to show the OSD when the volume changes, and disable it by default.
...
Fixes issue #31
2010-02-27 00:48:27 +00:00