Funkwhale
/
Clementine-audio-player-Mac-Linux-Windows
mirror of https://github.com/clementine-player/Clementine
1
0
Fork 0
Code Issues Releases Wiki Activity

Rename this function so as to not confuse john.

This commit is contained in:
David Sansome 2010-04-08 20:17:57 +00:00
parent 1dbcfb9aa7
commit 539f0a517b
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/engines/gstengine.cpp
View File

@ -777,7 +777,7 @@ bool GstEngine::CreatePipeline() {
return false;
}
if (SinkSupportsDevice(sink_) && !device_.isEmpty()) {
if (DoesThisSinkSupportChangingTheOutputDeviceToAUserEditableString(sink_) && !device_.isEmpty()) {
g_object_set(G_OBJECT(gst_audiosink_), "device", device_.toUtf8().constData(), NULL);
}
@ -907,6 +907,6 @@ void GstEngine::ClearScopeQ() {
}
}
bool GstEngine::SinkSupportsDevice(const QString &name) {
bool GstEngine::DoesThisSinkSupportChangingTheOutputDeviceToAUserEditableString(const QString &name) {
return (name == "alsasink" || name == "osssink" || name == "pulsesink");
}

2
src/engines/gstengine.h
View File

@ -76,7 +76,7 @@ class GstEngine : public Engine::Base {
void gstMetaData(Engine::SimpleMetaBundle &bundle) { emit metaData( bundle ); }
PluginDetailsList GetOutputsList() const { return GetPluginList( "Sink/Audio" ); }
static bool SinkSupportsDevice(const QString& name);
static bool DoesThisSinkSupportChangingTheOutputDeviceToAUserEditableString(const QString& name);
public slots:
bool load(const QUrl&, bool stream);

2
src/settingsdialog.cpp
View File

@ -320,7 +320,7 @@ void SettingsDialog::SetGstEngine(const GstEngine *engine) {
void SettingsDialog::GstPluginChanged(int index) {
QString name = ui_.gst_plugin->itemData(index).toString();
bool enabled = GstEngine::SinkSupportsDevice(name);
bool enabled = GstEngine::DoesThisSinkSupportChangingTheOutputDeviceToAUserEditableString(name);
ui_.gst_device->setEnabled(enabled);
ui_.gst_device_label->setEnabled(enabled);