Funkwhale/Clementine-audio-player-Mac-Linux-Windows
1
0
Fork 0
mirror of https://github.com/clementine-player/Clementine synced 2024-12-15 10:48:33 +01:00
Code Issues Releases Wiki Activity

Check the playlist context menu index is valid before getting data from it. Fixes issue #109

Browse Source
This commit is contained in:
David Sansome 2010-03-24 16:13:05 +00:00
parent 70b6ba8c39
commit ad30bad33c
1 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/mainwindow.cpp
View File

@ -585,18 +585,22 @@ void MainWindow::PlaylistRightClick(const QPoint& global_pos, const QModelIndex&
ui_.action_renumber_tracks->setEnabled(editable);
ui_.action_selection_set_value->setEnabled(editable >= 2);
Playlist::Column column = (Playlist::Column)playlist_menu_index_.column();
ui_.action_selection_set_value->setVisible(
column <= Playlist::Column_Genre &&
column != Playlist::Column_Length);
if (!index.isValid()) {
ui_.action_selection_set_value->setVisible(false);
} else {
Playlist::Column column = (Playlist::Column)index.column();
ui_.action_selection_set_value->setVisible(
column <= Playlist::Column_Genre &&
column != Playlist::Column_Length);
QString column_name = Playlist::column_name(column);
QString column_value = playlist_->data(playlist_menu_index_).toString();
if (column_value.length() > 25)
column_value = column_value.left(25) + "...";
QString column_name = Playlist::column_name(column);
QString column_value = playlist_->data(index).toString();
if (column_value.length() > 25)
column_value = column_value.left(25) + "...";
ui_.action_selection_set_value->setText(tr("Set %1 to \"%2\"...")
.arg(column_name.toLower()).arg(column_value));
ui_.action_selection_set_value->setText(tr("Set %1 to \"%2\"...")
.arg(column_name.toLower()).arg(column_value));
}
playlist_menu_->popup(global_pos);
}