Commit Graph

2402 Commits

Author SHA1 Message Date
David Sansome babad3b32a Fix DeviceKit devices on Linux. Thanks vsevolod.minkov. Fixes issue 1217 2011-04-11 22:06:44 +00:00
Andrea Decorte 2d27f10cfb Add tooltips to playlist tabs. Fixes issue 1725 2011-04-11 16:29:36 +00:00
Andrea Decorte 502b17cfb3 Revamped last.fm config dialog. Fixes issue 1053 2011-04-09 09:00:10 +00:00
John Maguire 685710a7f7 Fix SIP file for Playlist. 2011-04-08 22:34:19 +00:00
Andrea Decorte d10d1913cb removed useless slot, made the disabled scrobbling icon a little lighter 2011-04-08 15:35:08 +00:00
David Sansome b799543272 Stamp last.fm tracks before checking if they're valid scrobbles 2011-04-07 19:18:24 +00:00
Andrea Decorte 5d8f1fe872 Added scrobbling button in main window and a global shortcut for
toggling it. Fixes issue 1090
Improved last.fm error handling
2011-04-07 16:25:52 +00:00
John Maguire 55021ef67d Fix compilation without pjsip. 2011-04-07 14:12:37 +00:00
John Maguire 18bfa12042 Add the beginnings of an ICE socket implementation.
Currently, it can be demoed using --stun-test and the icedemo from pjsip as the other client.
TODOs:
Add ability to do a full demo using only 2 clementine instances.
Complete session initiation over XMPP.
Add local & port forwarded sockets as options.
2011-04-07 13:38:27 +00:00
John Maguire cb763213bf Add missing Q_OBJECT macro. 2011-04-07 13:29:42 +00:00
Paweł Bara 2b22dfaaee download only large covers from google
add cover size tooltip (see issue #1704)
cover search window is now a grid and not a long list with vertical scrollbar
2011-04-06 15:24:56 +00:00
John Maguire 41ef30151a Remove debug output. 2011-04-04 13:16:13 +00:00
John Maguire ab363a54ea Fix free space & capacity counts for MTP devices on Mac. 2011-04-04 13:15:56 +00:00
Andrea Decorte e57d988f5d oops, it seems that MidButton is a better choice... 2011-04-02 18:15:20 +00:00
Andrea Decorte d29aa81a3b disable double middle click in playlist tabbar and activate elide mode
in sidebar
2011-04-02 17:28:43 +00:00
Paweł Bara 3c61fbdade terminate the search for covers immediately if there are no providers
if there's a search timeout, send back the results gathered so far (if any)
fixing the previous commit
2011-04-02 15:31:28 +00:00
Andrea Decorte 886f3d4d6f Double click on a tab to rename it and visual improvements to tab bar.
Fixes issue 1651
2011-04-02 14:46:56 +00:00
Paweł Bara f86b671272 fixing the minimal build 2011-04-02 14:43:50 +00:00
Paweł Bara 032b5f7e48 initial commit of "multiple covers providers" feature:
- simple API for cover providers (both C++ and SIP)
- a new "package" for cover related code
2011-04-02 13:34:06 +00:00
David Sansome a10d396f22 Fix the InsertUrls dbus method so it inserts tracks at the end of the playlist and plays them again. 2011-03-31 18:47:25 +00:00
Andrea Decorte 55b2d30959 added a button to remove items and keyboard shortcuts in the Queue
Manager. Fixes issue 1646
2011-03-30 18:41:34 +00:00
David Sansome c6bd3cbb30 Fix an uninitialised variable error with gcc 4.6.0. Fixes issue 1659 2011-03-30 15:00:00 +00:00
Andrea Decorte 9c2f0e7d8f Ask before creating Jamendo database. Fixes issue 1440 2011-03-30 13:47:06 +00:00
David Sansome e5bc2be85f Add some more debugging output for deciding when to scrobble a song 2011-03-29 21:12:49 +00:00
David Sansome e8101273f0 Set a minimum size on the visualisation window. Fixes issue 1643 2011-03-29 19:12:58 +00:00
David Sansome 96b9321d3b Fix --seek-to and --seek-by. Fixes issue 1654 2011-03-29 19:05:09 +00:00
David Sansome f416c27483 Fix a compiler warning in mpris1.cpp 2011-03-29 19:05:04 +00:00
David Sansome e69970709e Add an option to turn off -Werror. Thanks ssuominen@unk.fi 2011-03-29 18:51:16 +00:00
David Sansome 7d6eee590a Don't force the track to stop at the end of a section unless it's part of a cue sheet. Fixes issue 1610. Fixes issue 1636. 2011-03-28 22:11:07 +00:00
David Sansome 9f04aa7bb2 Remove an unused variable. 2011-03-28 12:52:20 +00:00
David Sansome 31a2b8779d Oops 2011-03-27 13:00:50 +00:00
David Sansome e4a5820488 Update Portugese translations, thanks smarquesPT. Fixes issue 1625 2011-03-27 12:04:06 +00:00
Arnaud Bienner 900cbcf001 Using trUf8 instead of classic tr. Now displays the already translated strings (utf8) correctly. Fixes issue 1620 2011-03-26 19:03:59 +00:00
David Sansome 7c0569f2ae Merge translations from Launchpad 2011-03-26 17:37:09 +00:00
David Sansome f2ddc92a0d Maybe fix the mac build without breakpad 2011-03-26 17:36:13 +00:00
David Sansome 0968e6680b Oops, Fix a compile error 2011-03-25 21:52:56 +00:00
David Sansome a707b4c502 Add a little bit of debugging output for system proxy URLs on linux 2011-03-25 20:13:04 +00:00
Andrea Decorte ecda0ada4a Playlists get an automatic name, no more prompts. Fixes issue #423 2011-03-25 19:16:12 +00:00
John Maguire d86dce4b96 Add support for Google breakpad on mac. (Uploading crash reports doesn't work yet due to redirect). 2011-03-25 11:38:03 +00:00
David Sansome d50cfaed46 Add google breakpad to 3rdparty, and gather crash reports 2011-03-23 21:53:24 +00:00
David Sansome d91aaa880c Make the library watcher pick up hidden files too. 2011-03-23 16:50:19 +00:00
Jonathan Anderson ddfb90a0a1 clementine Issue 858 2011-03-23 11:23:55 +00:00
Arnaud Bienner 4f83d59f59 Oups... :S 2011-03-23 00:51:19 +00:00
Arnaud Bienner 163e65d765 Translate equalizer settings' names at runtime. Fixes issue 1376 2011-03-23 00:42:35 +00:00
Paweł Bara df35f2cd9c mark icecast songs as streams so they won't get greyed out (as non existent songs) when starting Clementine 2011-03-22 22:04:10 +00:00
David Sansome 92520a911e Change Clementine to request the icecast directory from data.clementine-player.org, and to follow redirects 2011-03-22 20:41:31 +00:00
Paweł Bara d775ef5c4c a little tiny final language fix 2011-03-22 19:44:31 +00:00
Arnaud Bienner 5a7771aeea Restoring tranlasted strings lost during r3037 2011-03-22 19:40:34 +00:00
Paweł Bara 7d54ee6644 mi scusi 2011-03-22 17:31:13 +00:00
Paweł Bara f6c8c74302 mi scusi, missing translation 2011-03-22 14:53:48 +00:00
Paweł Bara 11cf7acded avoid "loading tracks 0%" label showing forever on the status bar when loading an empty folder 2011-03-21 17:44:36 +00:00
John Maguire b767c1ccf2 Fix display of stopped stream when stopped via play/pause shortcut. 2011-03-21 17:07:15 +00:00
John Maguire eceb4164c1 Add more trayicon mouse wheel actions.
Update issue 1597
Status: Fixed
Thanks for the patch!
2011-03-21 15:15:17 +00:00
John Maguire fa20af4516 Tidy up magnatune config code, fix comments from r2999. 2011-03-21 15:07:41 +00:00
Paweł Bara 02c51be094 fixing SIPs 2011-03-20 23:04:58 +00:00
David Sansome 31ead96e91 Fix last.fm scrobbling. Fixes issue 1503 2011-03-20 22:19:38 +00:00
David Sansome 4f11cb94e1 Make visualisations work again (how did nobody notice this for 3 months??) 2011-03-20 21:41:09 +00:00
David Sansome 008d396077 Use a monotonically increasing ID to identify pipelines, instead of their pointer value. 2011-03-20 21:40:53 +00:00
David Sansome b3db5d699e Remove CanDecode from GstEngine - it was only used by a test, and the test was disabled on buildbot because it was unreliable. 2011-03-20 19:36:50 +00:00
David Sansome 116bfc4594 Remove a comment and a TODO 2011-03-20 19:36:44 +00:00
David Sansome e761f2bdc8 Fix a bug where the engine would skip a song that didn't exist, but then not play the next song. 2011-03-20 19:18:54 +00:00
Paweł Bara bbd5b04244 visual revamp of "add to new playlist" option 2011-03-20 18:31:15 +00:00
Andrea Decorte a88e02c452 Added right-click menu option to copy track to specific playlist. Fixes issue 1289 2011-03-20 17:38:15 +00:00
Paweł Bara e619d7a280 fixing a bug where streams were removed from playlist during Clementine's startup 2011-03-20 16:07:24 +00:00
Paweł Bara bfb068a6d1 conditionally hide some context menu actions in library view and playlist view
Song.is_stream()
2011-03-20 12:43:10 +00:00
David Sansome 246723a5a2 Don't crash when dragging a file in the playlist by grabbing its rating. Fixes issue 1458 2011-03-20 12:39:49 +00:00
Paweł Bara 41f659ff4b fixing tests 2011-03-19 10:43:50 +00:00
Paweł Bara 3db00fc339 plugin that lets you grey out deleted songs on demand ("main menu / playlist") - available by default
also: this action will "ungrey" songs that were deleted but got restored

SIPs
2011-03-19 10:22:55 +00:00
Paweł Bara 823f798451 new option for greying out deleted songs on startup 2011-03-19 09:41:00 +00:00
Paweł Bara a4bf317f33 minor deleted items handling fixes 2011-03-18 21:54:22 +00:00
John Maguire 7705487f96 Default to large sidebar on all OS.
< r3000 >
 -------
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||
2011-03-18 15:09:30 +00:00
John Maguire 32193dbb9f Add validation for Magnatune accounts. 2011-03-18 14:39:29 +00:00
David Sansome 744bf922f3 Merge translations from launchpad 2011-03-17 19:54:57 +00:00
David Sansome 9086ab8ed4 Add a "Show in file browser..." to the library context menu as well. Fixes issue #1563 2011-03-17 19:52:21 +00:00
David Sansome 0594fc53af Enable the "Edit track information..." item in the library context menu when right-clicking an un-expanded node 2011-03-17 19:52:15 +00:00
David Sansome a2d62883c2 Ignore subsequent errors by setting a flag instead of setting the pipeline state, which may deadlock if the pipeline is also being destroyed at the same time. Fixes issue #1584 2011-03-17 19:52:05 +00:00
John Maguire 0a54c5135b Ignore empty lines in m3u files.
Fixes issue #1403
2011-03-17 16:05:08 +00:00
Andrea Decorte 4b6e2a8a62 Add global shortcuts for repeat and shuffle modes. Fixes issue #955 2011-03-17 08:21:05 +00:00
David Sansome f4f482a440 Updated Turkish translation from H. İbrahim Güngör 2011-03-15 20:04:07 +00:00
David Sansome 85502e5516 Don't crash at the end of the last song on a playlist 2011-03-14 20:04:33 +00:00
David Sansome cf826aeee0 Support dragging and dropping image files onto the now playing widget and edit tag dialog to set an album's cover art 2011-03-14 20:01:27 +00:00
Paweł Bara c8a0ab9625 don't hide the truth 2011-03-14 07:29:43 +00:00
Paweł Bara 8ed6eca57e fixing skipping songs for library songs
another "silent" GST error type
David's POT
2011-03-13 22:57:49 +00:00
David Sansome f700df2f54 ALL GLORY TO THE HYPNOTOAD. Fixes issue 1374 2011-03-13 22:46:25 +00:00
David Sansome f37467ac69 Don't try to create a pixmap from an invalid HICON on Windows. Fixes issue 1417 2011-03-13 22:14:23 +00:00
David Sansome a37bb47e53 Merge translations from launchpad 2011-03-13 21:27:47 +00:00
David Sansome cb275f318f Add an option to disable automatic crossfading between tracks on the same album or from the same cuesheet. Fixes issue 1479 2011-03-13 18:37:46 +00:00
David Sansome f22f361f66 Revert "Do not cross-fade if two songs of the same CUE file are consecutively being played"
This reverts r2921.
2011-03-13 18:37:39 +00:00
John Maguire e172765331 Some support for MediaStorageInterface. 2011-03-13 18:20:37 +00:00
David Sansome 002ae13817 Use the canonical file path (resolve symlinks and '..') when adding directories to the library, and when adding files to the playlist. Fixes issue #1494 2011-03-13 14:43:03 +00:00
David Sansome 3d593e696c Make escape and backspace work in the library and radio views. Fixes issue 1510 2011-03-13 14:14:16 +00:00
David Sansome d7dbd21438 Fixed some of the "metadata changed" when doing a library rescan 2011-03-13 13:40:24 +00:00
David Sansome db8359838a Set a timeout of 5 seconds on musicbrainz network requests. Fixes issue #1390 2011-03-13 13:17:35 +00:00
Paweł Bara ad7223f8b3 code review 2011-03-13 13:02:48 +00:00
David Sansome 8690438ad4 Cancel network requests and outstanding fingerprint operations when cancelling musicbrainz lookups 2011-03-13 12:52:08 +00:00
Paweł Bara ce17d5f1c9 API for coloring rows in playlist view
graying out of broken songs on playback

David's POT?
2011-03-13 11:43:44 +00:00
David Sansome 1fb7dae446 Show a helpful error if the gstofa plugin isn't available 2011-03-12 22:29:13 +00:00
David Sansome b74576cbd5 Fix build error on mac 2011-03-12 22:29:08 +00:00
David Sansome 3d696ad4f4 Add some docs for the musicbrainz stuff 2011-03-12 22:29:03 +00:00
David Sansome b51566cdd9 Remove the dependencies on libtunepimp, libofa, libmusicbrainz. Use the gstreamer ofa plugin instead to fingerprint songs. 2011-03-12 21:19:41 +00:00
David Sansome 2c4102b060 Fix an error if you try to disable dbus, but enable wiimotedev. Fixes issue #1516 2011-03-12 21:19:32 +00:00
Paweł Bara c8c394d200 don't push new URL into engine in the CurrentMetadataChanged slot - send it the beginning and end markers only
this means that Clementine still skips broken songs while at the same time fixes issue #1565
2011-03-12 20:20:13 +00:00
Paweł Bara e25e9efffc Clementine now skips broken streams (radios for example). At least I hope it always does. ;) Fixes issue #1562. 2011-03-12 13:24:30 +00:00
Paweł Bara 7c86b0c7a5 updating SIPs 2011-03-10 18:12:56 +00:00
Paweł Bara 8722e00103 Clementine now skips songs that don't exist anymore (updates issue #250) 2011-03-10 18:01:35 +00:00
Andrea Decorte f62f1a6df8 Middle click to append to playlist now works in the other views. Fixes issue #1546 2011-03-10 12:42:35 +00:00
Andrea Decorte a356c5c425 Ctrl + Space to select/deselect in playlist. Fixes issue #1190 2011-03-09 13:03:52 +00:00
David Sansome 8e9c913605 Recreate the windows 7 thumbbar buttons if the window is hidden and then shown again. Fixes issue #1547 2011-03-09 00:13:50 +00:00
John Maguire 48b7dc3501 Massively hacky basic integration to tomahawk. 2011-03-08 21:16:09 +00:00
John Maguire 7ca69e009e Add libportfwd and an async wrapper. 2011-03-08 16:34:20 +00:00
Arnaud Bienner 7fbd09954b Using new actions (that doesn't display unusuable shorcuts) for the tray icon menu. Fixes issue 679 2011-03-07 21:33:01 +00:00
David Sansome 7a60b52704 Fix the size of the now-playing widget to make it line up exactly with the top of the player controls 2011-03-07 20:21:34 +00:00
David Sansome 6a64b8f8f3 Fix a bug that made it sometimes impossible to seek a track 2011-03-07 20:00:03 +00:00
David Sansome 961a97659e Fix keyboard shortcuts on actions in the playlist menu that aren't added anywhere else. 2011-03-06 18:26:06 +00:00
David Sansome 5672fa90e7 Wait for the gstreamer pipeline to be connected and in either the PAUSED or PLAYING state before trying to do the initial seek. This should stop the occasional "seek failed" messages when playing tracks. Fixes issue #1292 2011-03-06 18:11:53 +00:00
John Maguire 19af887465 Disable automated tag encoding correction and instead just mark tags as "suspicious". 2011-03-06 16:39:36 +00:00
David Sansome 2cb8b8dba7 Stop cue sections at exactly the right place, and move seamlessly between consecutive sections of the same file. Fixes issue #1233. Fixes issue #1419. 2011-03-06 16:35:47 +00:00
Andrea Decorte b8a008aaeb Added middleclick to enqueue to playlist. Fixes issue #865 2011-03-06 15:53:08 +00:00
David Sansome c4c7d8f82f Fix compilation without libtunepimp 2011-03-06 15:11:52 +00:00
David Sansome 0acfbda94d Don't crash when closing a playlist that has a pending SongLoaderInserter. Fixes issue #1471 2011-03-06 14:46:01 +00:00
David Sansome 8e70124830 When loading part of a cuesheet that wasn't in the library on startup, keep the metadata that was loaded last time instead of replacing it with what is in the file's tags 2011-03-06 14:45:56 +00:00
David Sansome cce41f1372 Fix the scope when playing cue files. Fixes issue #1291 2011-03-06 14:18:53 +00:00
David Sansome c2445edad5 Add a "complete tags automatically" shortcut to the playlist context menu. Fixes issue #1532 2011-03-06 14:07:41 +00:00
David Sansome 99101c8442 Add a "Show in file browser..." menu item to the playlist. Thanks dein.negativ. Fixes issue #465 2011-03-06 13:10:14 +00:00
Andrew Udvare 4fe36ad7b3 Do not test if both songs don't have CUE files 2011-03-06 03:31:04 +00:00
Andrew Udvare dabeab9360 Do not cross-fade if two songs of the same CUE file are consecutively being played 2011-03-06 03:15:28 +00:00
David Sansome 4a020c0c04 Add support for fetching tags for multiple songs at once. Fixes issue #1399 2011-03-05 19:24:44 +00:00
Arnaud Bienner 34f8c124f5 Modif analyzers' framerate to make code cleaner. Adding 'very high' framerate 2011-03-05 18:53:48 +00:00
Andrea Decorte cfe6b9e652 Added option to hide dividers in library view. Fixes issue #1125 2011-03-05 15:20:27 +00:00
David Sansome 2ca38cbe99 Don't turn off dynamic mode when adding an empty smart playlist. Fixes issue #1526 2011-03-05 13:01:08 +00:00
David Sansome 90c35b3e3c Don't show the Script Manager entry in the Tools menu if scripting support is disabled. Fixes issue #1536 2011-03-05 13:01:03 +00:00
David Sansome dacc7c1a2d Remove " characters from the library filter text before doing an FTS query. Fixes issue #1504 2011-03-04 21:10:10 +00:00
David Sansome 9a1dad3490 Fix the selected track length display. Fixes issue #1488 2011-03-04 21:10:06 +00:00
Arnaud Bienner 6cc12ed964 Forgot to commit translations 2011-03-04 00:49:24 +00:00
Arnaud Bienner ea391c2b7d Adding a menu to allow user to change analyzers' framerate 2011-03-04 00:38:15 +00:00
John Maguire 4acd6883cc Update comment about X-GOOGLE-TOKEN auth. 2011-03-01 16:18:55 +00:00
John Maguire 86919cc0ff Hack X-GOOGLE-TOKEN support into gloox and use it in clementine. 2011-03-01 16:03:04 +00:00
David Sansome 285f2c9ff9 Add cross-links to the PyQt4 docs, document Song, NetworkAccessManager, PlaylistSequence 2011-02-27 17:16:22 +00:00
David Sansome 4471e27ef6 Python docs for PlaylistParser, and clean up the interface a bit 2011-02-27 12:14:32 +00:00
David Sansome dc509db512 Python docs for PlaylistItem 2011-02-27 12:14:21 +00:00
David Sansome 2b08d27a88 Show loading indicators in the library model and the status bar when asynchronously loading songs during initialisation. 2011-02-26 14:27:57 +00:00
David Sansome 62b6d052de Fix the library model test 2011-02-26 13:34:31 +00:00
John Maguire 6a14e0d94f Link correct directory for gloox. 2011-02-26 09:51:36 +00:00
Paweł Bara aa6c3ab35b a way to mark DB schema versions as requiring a full library rescan
message dialog for a user when he's reached a full library rescan requiring schema version (like the final one of CUE sheet support)
2011-02-25 20:10:41 +00:00
Arnaud Bienner 609f882e27 Making library init async. Prevent from freezing GUI with large collection (especially Jamendo) when loading from DB for the first time since startup 2011-02-24 23:29:45 +00:00
Arnaud Bienner 80c1b9417e Pressing ESC (from playlist view) also focus on filter, and clear it. Fixes issue 606 (definitely) 2011-02-24 18:05:38 +00:00
Arnaud Bienner 7f783d088e Minor change 2011-02-24 00:00:10 +00:00
Arnaud Bienner 57ac8c441a Play/Pause when pressing space (on playlistview). Fixes issue 244 2011-02-23 23:59:12 +00:00
Arnaud Bienner 9c0094b9a6 Improve playlist view: focus on playlistview or search filter, depending on keyboard event. Fixes issue 606 2011-02-23 22:21:17 +00:00
David Sansome b04fbf226c Fix MPRIS2's CanPause() PlayPause() behaviour 2011-02-23 19:31:12 +00:00
David Sansome 7fc03dc326 Increase the font size of the track slider popup 2011-02-23 19:31:07 +00:00
Paweł Bara 17af8b935c fixing a regression where clicking on empty playlist space would crash Clementine 2011-02-23 18:34:42 +00:00
John Maguire 2e286e4271 Fix broken signal in MPRIS1.
Fixes issue #1497
2011-02-23 11:11:17 +00:00
David Sansome bab78c2b4f Fix mpris2's PlayPause method 2011-02-22 20:13:02 +00:00
David Sansome a39cccd059 Update the track slider popup delta time when the track position changes. 2011-02-21 22:25:04 +00:00
David Sansome 107b7b54f9 Add an extra line to the track slider popup to show the difference between the current time and the destination time. 2011-02-21 20:59:30 +00:00
David Sansome 24fbe6aa74 Merge translations from Launchpad. Fixes issue #1491 2011-02-21 20:24:46 +00:00
Paweł Bara 5c8c5c5413 making availability of library view's context menu items saner (?). also makes the CUEs readonly from library view 2011-02-21 20:06:44 +00:00
Paweł Bara e1d5abd83e first step of making CUEs read only (playlist view) 2011-02-21 18:18:16 +00:00
David Sansome bc1372a735 Fix the build failure when the remote is disabled 2011-02-20 16:26:26 +00:00
Paweł Bara 05cbe241e9 just changed a duplicated translation string 2011-02-20 16:23:30 +00:00
Paweł Bara 677a93b359 minor changes 2011-02-20 15:05:05 +00:00
David Sansome 72096bf1c8 Move ArtLoader from mpris_common.h to its own file, add libxrme to 3rdparty, add a working XMPP remote. 2011-02-19 18:24:11 +00:00
David Sansome 304ce97b16 Fix a crash bug in MPRIS2 if MPRIS1 couldn't register on the bus. 2011-02-19 18:24:05 +00:00
David Sansome acc2c537de Require gloox 0.9 instead of 1.0 (for Lucid), do some better logging, and login after connecting 2011-02-18 20:14:17 +00:00
David Sansome c4f14527c8 Fix getting the user's XMPP password for the first time 2011-02-18 20:14:08 +00:00
David Sansome ff66bc0ade Docs for the signals in PlaylistManager 2011-02-18 15:18:27 +00:00
Paweł Bara 832b258b55 me no speaky english 2011-02-17 20:04:58 +00:00
Paweł Bara 20658989c3 full library rescan feature - should already work as expected 2011-02-17 19:57:14 +00:00
John Maguire 438e332ea5 Fix crash in settings dialog. 2011-02-17 19:42:36 +00:00
John Maguire 68de9c99d3 Fixing comments from code review for r2833 2011-02-17 14:34:45 +00:00
David Sansome d0aa3c6dea Fix a parsing error >.> 2011-02-17 14:23:58 +00:00
John Maguire 65264b517c Change XMPP connection to use stored credentials. 2011-02-17 14:10:10 +00:00
David Sansome 7717005415 Docs for PlaylistManager 2011-02-17 13:56:25 +00:00
John Maguire 45cabc1b6b Add settings dialog for Google account with verification and stores password in secure keychain. 2011-02-17 13:47:54 +00:00
Arnaud Bienner 6d8c87418a Corrected an other regression introduced in r2826: exit when playing and fadeout is disable 2011-02-16 23:44:03 +00:00
Arnaud Bienner 0f1a1cc332 Corrected regression introduced in r2826: exit application when nothing is playing 2011-02-16 23:03:00 +00:00
Arnaud Bienner 375abfd04e Don't exit application to fast, to allow fadeout 2011-02-16 22:43:05 +00:00
John Maguire e36a333212 Basic XMPP support using gloox. 2011-02-16 20:49:12 +00:00
Paweł Bara 7de912d3a1 moving the responsibility for naming playlists into mimeData() methods (into models)
this means that pretty names for new playlists now also work when double clicking (in certain mode) or dragging and dropping
fixes issue #1477
2011-02-16 18:29:35 +00:00
Paweł Bara 383138737c the easy way is worse - reverting my last GstEngine's changes 2011-02-16 17:07:06 +00:00
John Maguire 7688cc35c6 Prevent libimobiledevice from using ~/.config on OS X. 2011-02-16 13:58:45 +00:00
John Maguire b106979fb7 Use correct preferences file on OS X and migrate old config files. 2011-02-16 13:43:01 +00:00
Arnaud Bienner b8bf93fc23 Being consistent: use already defined name_for_new_playlist_ field and GetNameForNewPlaylist function, to have the same behavior through the 'Open in a new playlist' action than with drag and drop 2011-02-16 01:04:48 +00:00
David Sansome ec49e7a955 Docs for TaskManager, Queue and PythonEngine 2011-02-16 00:58:06 +00:00
Paweł Bara 2b0dcebaec let's try simpler EndOfStreamReached version now that we have nanoseconds 2011-02-15 22:37:33 +00:00
David Sansome f5d5451c16 Document the IconLoader 2011-02-15 22:36:28 +00:00
Paweł Bara 7f3f4f4107 more accurate parsing of indices in CUEs (we now respect the FRAMES part)
+ incorporating arnaud's code comment in fileviewlist
2011-02-15 22:26:56 +00:00
David Sansome 0ce8f99494 Add a utility to generate python API docs using epydoc 2011-02-15 19:18:53 +00:00
Paweł Bara fb33ba4cce lookout for smart playlists in 'open in new playlists' functionality (Fixes issue #1465) 2011-02-15 19:16:45 +00:00
Paweł Bara 29056d944c allow to delete now-playing playlists from their context menus (we already allow to do such a thing with middle click so we should be ok...) - Fixes issue #1444 2011-02-15 17:53:21 +00:00
Paweł Bara 88e0beeea9 better names for 'new playlists' generated from the files' tab (Fixes issue #1463) 2011-02-15 17:38:45 +00:00
Arnaud Bienner b3839cf1d6 Adding accelerator key for just one simple string, while keeping old translations. Gonna check how Launchpad is able to handle this and how it will updated strings 2011-02-15 01:10:09 +00:00
Arnaud Bienner f893b34ae0 Adding myself to the about dialog. Feel proud to have my name here :) 2011-02-15 00:00:07 +00:00
Arnaud Bienner 4d58e75e0a Using library item's name instead of generic text 'Playlist' when creating new playlist by DnD from the library, or when using 'Open in new playlist' 2011-02-14 23:06:36 +00:00
Arnaud Bienner 7221d93888 Minor syntactic changes on tagfetcher 2011-02-14 22:26:58 +00:00
David Sansome dadbb3e6e5 Oops again :( 2011-02-14 21:23:01 +00:00
David Sansome 2740ad4370 Oops 2011-02-14 20:15:35 +00:00
David Sansome 8c691d2b3e Use constants instead of "1eN" literals for converting between time units. 2011-02-14 19:34:37 +00:00
Paweł Bara faa0970c00 fixing SIP binding 2011-02-14 18:12:43 +00:00
Paweł Bara 85b876d112 fixed broken RemoveDuplicates script
maybe fix the issue #1444
2011-02-14 17:44:15 +00:00
Paweł Bara d109b70898 David's comments 2011-02-14 17:29:56 +00:00
Paweł Bara 0182829223 user-friendly name for 'Open in new playlist' playlists (fixes issue #1445) 2011-02-14 17:00:13 +00:00
David Sansome e67f39cedb Fix the windows build 2011-02-13 20:25:55 +00:00
David Sansome f801252e3d Refactor Player and PlaylistManagers to have interfaces and add more MPRIS1 tests 2011-02-13 18:37:45 +00:00
David Sansome 12da941885 Add a really basic unit test for MPRIS1 2011-02-13 18:37:21 +00:00
David Sansome e18409ebf4 Factor out a PlayerInterface from Player, and use it in MPRIS1 and MPRIS2 2011-02-13 18:36:29 +00:00
David Sansome b38ce42ff8 Move the "Reset play counts" button in the edit tag dialog 2011-02-13 18:35:52 +00:00
David Sansome 3a1853a681 Use nanoseconds in playlist parsers, and fix the tests 2011-02-13 18:35:26 +00:00
David Sansome 507c5e2632 Change the fields in Song from seconds to nanoseconds 2011-02-13 18:34:30 +00:00
David Sansome 37618dae96 Use nanoseconds instead of seconds or milliseconds throughout the Player and Engine. 2011-02-13 18:29:27 +00:00
David Sansome 9aefae4e39 Remove a little space in the edit tag dialog 2011-02-13 18:29:13 +00:00
Arnaud Bienner e6b59de56b Corrected center on last played track 2011-02-11 20:16:42 +00:00
Paweł Bara c8aed5fd30 further refactoring of duplicated playlist-insertion related code in RadioServices 2011-02-10 22:24:17 +00:00
Arnaud Bienner 79159700fc Center on last played song when restoring playlist. Fixes issue 410. 2011-02-10 20:55:19 +00:00
Arnaud Bienner 0544cfa90a Sort playlist by ui_order, to keep playlist ordered even if the user re-order them. Most of the code was written, I can't figure out why this code was missing... Anyway, fixes issue 1068 2011-02-10 20:50:57 +00:00
Paweł Bara a6b6147c9d drag and drop to empty playlist-tab-bar's space in order to create a new playlist with the dragged items (fixes issue #1431) 2011-02-09 18:48:31 +00:00
Paweł Bara 38172c39b4 simplifying AddItems API of RadioService 2011-02-09 18:23:14 +00:00
Paweł Bara 60ac6768b8 Fresh new 'open in new playlist' action (Updates issue #1431). 2011-02-09 17:51:59 +00:00
Arnaud Bienner fb36940d5e Add tooltip for cover manager's items, which displays artist and album name info. Fixes issue 451 2011-02-08 22:54:37 +00:00
Paweł Bara 4cd01a43b7 fixing names of all the 'add to playlist' items in context menus (Fixes issue #1421) 2011-02-08 22:42:09 +00:00
Arnaud Bienner de2193f5af Display tooltip info in library only if text displayed is elided (as it was done for playlistdelegates, r2745). Partially fixes issue 451 2011-02-08 21:55:32 +00:00
Paweł Bara 33276132ec when saving cover, start in the album's folder (just like with the similar 'load cover from disk' feature) 2011-02-07 23:53:32 +00:00
Paweł Bara b7cd42fe53 minor C++ stuff 2011-02-06 14:34:47 +00:00
Paweł Bara 82e92bb3ac library view has now three modes: 'all songs', 'duplicates only' and new 'untagged songs only' (check out the http://code.google.com/p/clementine-player/wiki/LibraryViewModes) - fixes issue #305
+ hiding the 'complexity' of QueryOptions filter and query_mode mutual exclusion behind it's API
2011-02-06 13:18:18 +00:00
Paweł Bara e08c6cc6a5 just a prettier expression 2011-02-05 13:45:40 +00:00
Paweł Bara 9a9d8ad177 don't let invalid CUE related media files into library (invalid == those which were not recognized by TagLib)
better logging of erroneous DB queries (error + query + bound values instead of just error)
2011-02-05 13:43:04 +00:00
Paweł Bara a0dfaf89fb be consistent - if we're letting playlist to decide what songs are valid then let's also restore everything it's loaded when Clementine restarts (this actually fixes some problems with a CUE I have) 2011-02-04 17:41:45 +00:00
John Maguire 4fb6f92ad4 Fix compile warning on mac. 2011-02-04 15:25:05 +00:00
John Maguire 8a5455dc7e Fix UI file warnings. 2011-02-04 15:17:29 +00:00
John Maguire 1fc9dd183d Put our CFLAGS after the default ones so they don't get overridden. 2011-02-04 14:35:25 +00:00
John Maguire 084b9a2fe3 Remove taglib prefix from includes as the taglib include path contains it already. 2011-02-04 12:36:56 +00:00
John Maguire ab2f3360e2 Add Linux variable and set -Werror for Linux builds. 2011-02-04 12:07:00 +00:00
John Maguire c680c55379 Fix a couple of warnings found by Clang. 2011-02-04 11:17:31 +00:00
Paweł Bara ed4b7abde0 changed my mind - reverting my playlist changes to previous status quo (just making the PlaylistParser's contract more explicit)
this doesn't mean the previous revision was pointless - it still fixed one CUE related bug which I forgot to mention...
2011-02-03 22:21:15 +00:00
David Sansome e586ca12e5 Link clementine_lib instead of clementine against qtsparkle, fixing the tests on Windows 2011-02-03 21:06:05 +00:00
David Sansome 3ef0bf65a8 Fix the last.fm icon while a last.fm station is loading 2011-02-03 20:59:53 +00:00
David Sansome 2a68ecc726 Remove some unused bits 2011-02-03 20:59:14 +00:00
Paweł Bara 7bdac8fba6 when loading playlist, take only it's valid songs (+ force validity of CUE and PLS related songs) 2011-02-03 17:47:32 +00:00
Arnaud Bienner 74a878be41 Minor modication thanks to David comment 2011-02-02 23:27:55 +00:00
Arnaud Bienner e8720f5bda Display item info in playlist view only if text displayed is elided 2011-02-02 22:58:19 +00:00
Paweł Bara 2623a170a4 forgot this 2011-02-02 21:05:07 +00:00
Paweł Bara 77151d7ebd Hiding some of Song's cover art logic complexity in Song's API (namely: embedded and manually unset covers). 2011-02-02 21:01:08 +00:00
John Maguire f0ac22e31b Fix crash in mac on show duplicates only.
Fixes issue #1396
2011-02-02 19:16:27 +00:00
Paweł Bara 12099d48f6 maybe fix the mac build 2011-02-02 17:22:30 +00:00
Paweł Bara ce104b9cf4 working on making disable for library filter widget work on MacOS (Updates issue #1396) 2011-02-02 16:46:57 +00:00
Paweł Bara 8aedda1795 moving the 'Save cover to file' action into AlbumCoverChoiceController; implementing the action in all related places (now playing widget, album cover manager, edit tag dialog)
now playing widget: disable all cover related context menu options (except for the 'save cover' one) when in 'Kittens' mode
2011-02-02 16:22:04 +00:00
Arnaud Bienner b52f3b6082 Improve track selection dialog: allow expanding, use linedit for filename and minor other modifications. Fixes issue 1392 2011-02-01 20:59:33 +00:00
David Sansome e4d9d54414 Link Clementine against SIP and PyQt on Windows, and add the modules to python's inittab 2011-01-31 23:44:44 +00:00
John Maguire 9786570f35 Add support for saving album covers/kittens.
Fixes issue #1395
2011-01-31 20:53:38 +00:00
Paweł Bara 5b5d3f0c2e watch out for optional last.fm dependencies in AlbumCoverChoiceController -> fixes issue #1393
from the creators of "david is always right" movie -> maybe fix issue #1396
2011-01-31 15:21:32 +00:00
Paweł Bara 2959dbff85 'show duplicates only' view for library where you can see which songs in your library are duplicated and delete unnecessary duplicates (fixes issue #1328) 2011-01-30 21:00:49 +00:00
Paweł Bara 35441d829e fixed a bug where 'Show cover in full size' and 'Unset cover' actions were incorrectly being disabled in the 'Now playing' widget 2011-01-30 20:17:09 +00:00
John Maguire 06c62f169f Set default mac sidebar to Large and allow building on mac without tunepimp & scripting. 2011-01-29 21:28:11 +00:00
Arnaud Bienner 9159e3c47e Oups... miss to also correct this 2011-01-29 16:11:20 +00:00
Arnaud Bienner 8b681a5dd2 Allow autotagging for non-library music files. Fixes issue 1389 2011-01-29 16:02:23 +00:00
Arnaud Bienner 6c42240b02 Minor correction in tagfetcher. Thanks David 2011-01-29 15:32:55 +00:00
Arnaud Bienner e9f19f2cdb Correct regression introduced in r2705. Partially fixes issue 1390 2011-01-29 15:18:14 +00:00
David Sansome 618aec2c74 Clean module dicts properly when unloading a script - works around a bug in Python 2.7.0 only 2011-01-29 00:57:58 +00:00
David Sansome bcc35ec29c Add a test for stuff in the module's global dict 2011-01-28 21:43:10 +00:00
David Sansome 9ca237bfa2 Add a unit test for some basic python scripting functionality 2011-01-28 20:52:38 +00:00
John Maguire ba0c7bab65 Change "kittens" feature to fetch the kittens tag instead of cat tag for fluffier kittens. 2011-01-27 16:54:03 +00:00
John Maguire 703a3b43d6 Mac build fixes for musicbrainz integration. 2011-01-27 14:48:58 +00:00
Arnaud Bienner 05a4cae370 Add track seeking from playlistview 2011-01-26 23:20:56 +00:00
Paweł Bara 2fec795b89 fixed an error where entering the Cover Searcher dialog without query would make it show the busy indicator forever
further refactoring of album cover changes (QMenu in controller)
2011-01-25 23:33:27 +00:00
Andrea Decorte 4e9aef16cb forgot to add these files, sorry 2011-01-25 20:13:28 +00:00
Andrea Decorte f98b89a2d8 Fixed issue #764 2011-01-25 19:15:51 +00:00
David Sansome f929a88473 Fix mpris 2011-01-24 21:25:09 +00:00
David Sansome 0beb12fc14 Add some options to control what happens when you double click or use the menu to add tracks to the playlist 2011-01-24 21:16:26 +00:00
John Maguire 2ad5acdd29 Move version information in to separate file to decrease churn on svn up.
Fix inverted error message for Avahi.
2011-01-24 20:45:15 +00:00
David Sansome 5e9edd52fe Hold the taglib mutex while loading embedded cover art from files. Fixes issue #1350 2011-01-24 20:06:59 +00:00
Paweł Bara 4a9d38bbdd final refactoring stage of cover changing code (common QAction*s)
reset URL in 'Cover from URL' dialog on reentrance
2011-01-24 18:32:09 +00:00
Paweł Bara ebfbdba8a9 further refactoring of cover changing code (saving covers in controller) 2011-01-24 17:53:31 +00:00
John Maguire c39a514f2b Add close shortcut to script dialog. 2011-01-24 17:06:21 +00:00
Arnaud Bienner 03df8195b0 Minors modification on TagFetcher. Fixes issue #1346 2011-01-24 17:03:36 +00:00
John Maguire ed3719a950 Fix release build.
Fixes issue #1355
2011-01-24 12:44:19 +00:00
Paweł Bara 8bce92e69b refactoring the code that handles common UI album cover related actions into a common controller
fixes a bug where cancelling the 'cover from URL' dialog would set the cover to a previously chosen URL
2011-01-24 00:09:57 +00:00
Paweł Bara 3e2ffd3647 ability to load cover from URL in all the usual places: cover manager, now playing widget and edit tag dialog (fixes issue #517) 2011-01-23 20:24:17 +00:00
David Sansome 30019a9624 Update Turkish translation. Thanks H. İbrahim Güngör 2011-01-23 15:56:19 +00:00
David Sansome 4291d21eab Load embedded cover art from ogg files. Thanks markwatkinson. Fixes issue #1232 2011-01-23 15:50:59 +00:00
David Sansome fe818e5597 Don't drop the embedded art indicator from songs when updating the library. Thanks markwatkinson 2011-01-23 15:36:09 +00:00
Paweł Bara fae96f00de thanks to translators in 'about' dialog 2011-01-23 11:58:35 +00:00
David Sansome 795a4df422 Fix compilation on mac and windows 2011-01-22 14:13:56 +00:00
David Sansome 2ecf61a57e Move everything DBus related back to the main thread and use synchronous method calls everywhere 2011-01-22 12:47:19 +00:00
David Sansome 7880026767 Add some better error handling to the WMDM device lister if parts of WMP aren't installed 2011-01-22 11:29:47 +00:00
Arnaud Bienner c929db4637 Oops... 2011-01-20 23:55:22 +00:00
Arnaud Bienner 729e8e729d Adding track selection dialog for tag fetcher results. Also corrected tagfetcher to prevent from infinite loop when no result is found 2011-01-20 23:42:28 +00:00
David Sansome d32ec67b8a Add Keiran to the about dialog 2011-01-20 21:55:01 +00:00
David Sansome ee06d779f2 Fix a bug that would occasionally cause an extra track to be skipped when a track ended. Fixes issue #1233 2011-01-20 21:29:48 +00:00
Paweł Bara be5eb7a9fb smart playlists: 'on date' (equals for dates) operator was too precise (fixes issue #1174) 2011-01-20 18:55:28 +00:00
Paweł Bara 3b7ae72f82 smart playlists are incorrectly filtering ratings (fixes issue #1113) 2011-01-20 18:35:38 +00:00
Paweł Bara cc05ce55ca visual tweaks of edit tag dialog's summary tab 2011-01-20 17:29:04 +00:00
Paweł Bara 1c1d9551bb fixes issue #553 ('seek forward' and 'seek backward' hotkeys worked wrong) 2011-01-19 16:05:16 +00:00
Paweł Bara a575dac451 restoring CUE related files in playlist after Clementine's restart (fixes issue #68) 2011-01-19 15:36:40 +00:00
David Sansome 3f9dec3808 Add an "Install script from file..." button 2011-01-18 23:10:22 +00:00
John Maguire 4db998c0b6 Script for shutting down clementine at the end of the current playlist.
Fixes issue #271
2011-01-18 22:56:47 +00:00
David Sansome 046c75380c Merge translations from Launchpad 2011-01-18 19:07:54 +00:00
Paweł Bara 70952d94d8 I wonder how those Cisco routers are so good if people responsible for them are SLACKERS! 2011-01-18 17:20:42 +00:00
Paweł Bara e24e786a5d incorporating David's suggestions 2011-01-18 17:12:05 +00:00
Paweł Bara 07739d6c68 Python bindings for LibraryView + new UI hook for plugins: the view's context menu
support for IN operator in LibraryQuery.AddWhere
2011-01-18 16:34:43 +00:00