870969ef42
Automatic merge of translations from Transifex
2020-12-23 02:57:28 +00:00
c999fc70e2
Fix hang during internet model reset
...
An old hack was notifying MergedProxyModel users that max int rows had been
removed when a submodel was reset. This caused the code that invalidates
selected items to spin for a very long time. A modelAboutToBeReset signal,
introduced in Qt 4.6, allows notification before the submodel information is
lost.
Note: there is one other case, in RemoveSubModel, where this hack is used.
This is only called when a device is removed and doesn't trigger this
condition, but it should probably be addressed in the future.
2020-12-22 20:40:05 +00:00
9f8093a22b
Automatic merge of translations from Transifex
2020-12-22 02:56:44 +00:00
863a668240
Automatic merge of translations from Transifex
2020-12-21 02:54:48 +00:00
af4810a581
Automatic merge of translations from Transifex
2020-12-20 02:51:13 +00:00
51c600a537
Automatic merge of translations from Transifex
2020-12-19 02:51:12 +00:00
6a6ef729ef
Automatic merge of translations from Transifex
2020-12-18 02:52:23 +00:00
41513527cd
hatstand code review update 1
2020-12-17 12:23:30 +00:00
114802a0ca
Adding links to new remote in network remote settings
2020-12-17 12:23:30 +00:00
7d038c7354
Missing filechooserwidget files...
2020-12-17 12:23:30 +00:00
9714b0632d
All changes for ClemRemote v1.0 (in one go)
2020-12-17 12:23:30 +00:00
cfcd0a956e
Drop -std=c++0x and -U__STRICT_ANSI__
...
This was causing compilation failures, static assertion failed, with GCC 11.
Fix #6865
Signed-off-by: Robert-André Mauchin <zebob.m@gmail.com>
2020-12-17 11:28:09 +00:00
ccba649f62
Clear cached indexes in InternetModel when rows are removed
...
When opening a context menu on an internet item, the selected items are stored
in the InternetModel instance. In cases when the items are removed, certain menu
options can cause a crash. A specific case is downloading a podcast when the
user has chosen to limit the number of visible episodes. The subtree for the
podcast is rebuilt after the download completes, so if a context menu was opened
during the download time, selecting the append to playlist option will attempt
to operate on bad indexes.
This fix uses the rowsAboutToBeRemoved signal to remove these stored indexes.
There are likely another rare cases where the indexes can become invalid. For
example, sibling items within a subtree may be removed, causing the stored
indexes to become incorrect or out of range.
2020-12-15 22:36:30 +00:00
c1c43e9a67
Automatic merge of translations from Transifex
2020-12-13 02:43:47 +00:00
91bad31f68
Automatic merge of translations from Transifex
2020-12-09 02:41:23 +00:00
ba8fc09a65
Automatic merge of translations from Transifex
2020-12-07 02:38:38 +00:00
01f0727649
giolister: Don't include invalid mountpoint url
...
If the gvfs mountpoint property for a volume is empty, we add an empty URL to
the devices URL list. This causes errors in duplicate entry detection.
2020-12-06 12:59:50 +00:00
df262c5c7e
Automatic merge of translations from Transifex
2020-12-06 02:37:13 +00:00
cca48b1ebf
giolister: Ignore mountpoints
...
Read the G_FILE_ATTRIBUTE_UNIX_IS_MOUNTPOINT attribute (unix::is-mountpoint) to
determine if a volume is a mount that udisks2 has detected. Ignoring these
prevents network mounts from showing up as devices.
2020-12-05 13:24:54 +00:00
f5c904b267
Automatic merge of translations from Transifex
2020-12-05 02:35:11 +00:00
1a0b288a8f
giolister: Remove extra g_object_unref
...
GioLister::UnmountDevice calls g_object_unref on the GVolume object held by a
DeviceInfo. This appears to be left over from a time before DeviceInfo held
onto the volume.
2020-12-04 22:07:01 +00:00
abc70554f3
giolister: Append _ to some DeviceInfo class members
...
Rename drive, mount, and volume to drive_, mount_, and volume_ to
avoid confusion with method arguments.
2020-12-04 22:07:01 +00:00
20f49c4454
Automatic merge of translations from Transifex
2020-12-03 02:34:21 +00:00
41b1ba8ffc
Automatic merge of translations from Transifex
2020-12-02 02:33:31 +00:00
c4d22d4414
Automatic merge of translations from Transifex
2020-12-01 02:33:42 +00:00
f60c422242
Automatic merge of translations from Transifex
2020-11-30 02:33:52 +00:00
7b3e2dfd8c
PlayPlaylist: set current and not active playlist to selection
2020-11-30 01:50:58 +00:00
f17e29f41d
Automatic merge of translations from Transifex
2020-11-29 02:32:32 +00:00
b2044a5be5
apply PR recomendations
2020-11-28 20:24:56 +00:00
ee72b974bf
add CLI play-playlist option, to play given playlist name.
2020-11-28 20:24:56 +00:00
c536dc88e9
Automatic merge of translations from Transifex
2020-11-28 02:31:39 +00:00
eec7641ef7
Automatic merge of translations from Transifex
2020-11-27 02:31:50 +00:00
d417aed29f
Automatic merge of translations from Transifex
2020-11-26 02:31:54 +00:00
c856a66176
Automatic merge of translations from Transifex
2020-11-25 02:31:22 +00:00
d970b74003
Automatic merge of translations from Transifex
2020-11-24 02:31:19 +00:00
ae4948ce32
Automatic merge of translations from Transifex
2020-11-23 02:30:52 +00:00
1daf43f914
Automatic merge of translations from Transifex
2020-11-07 02:29:09 +00:00
eefb96bdce
Automatic merge of translations from Transifex
2020-11-03 02:27:29 +00:00
16d09ace07
Fix visibility incongruences
2020-11-02 11:07:42 +00:00
cac606186a
Automatic merge of translations from Transifex
2020-10-31 02:27:33 +00:00
fc4cb6fc7a
Fix opml import crash
...
The opml parsing code handles cases where there are extra levels in the xml file
by copying the child to the main container. This corrupts the source instance
during the copy, which leads to corruption in the destination, and ultimately a
crash when it is later used.
To fix, do the copy in two steps, copying the child container to a temporary
location before copying to the destination.
2020-10-17 09:12:22 +01:00
4e3e9c8d14
Automatic merge of translations from Transifex
2020-10-12 02:34:09 +00:00
9e8d4434a0
Automatic merge of translations from Transifex
2020-10-04 02:31:34 +00:00
b49afcc5b7
Automatic merge of translations from Transifex
2020-09-24 02:30:41 +00:00
2bac3626c5
Fix logout cancelling ( #6796 )
2020-09-23 10:39:59 +01:00
54f7637ad2
Automatic merge of translations from Transifex
2020-09-23 02:29:48 +00:00
2172732b1e
Include windows.h first as it's special
2020-09-22 14:56:06 +01:00
341dc7326f
Reformat all C++
2020-09-22 14:56:06 +01:00
8ae194c4a7
Automatic merge of translations from Transifex
2020-09-20 02:29:18 +00:00
f7bece3b83
Automatic merge of translations from Transifex
2020-09-13 02:28:52 +00:00
e9b62fa343
Automatic merge of translations from Transifex
2020-09-11 02:28:40 +00:00
7b3a0f397b
Automatic merge of translations from Transifex
2020-09-09 02:29:06 +00:00
d0bf92f064
Automatic merge of translations from Transifex
2020-09-06 02:28:36 +00:00
598f840078
Automatic merge of translations from Transifex
2020-09-03 02:28:37 +00:00
06855ea6c8
Automatic merge of translations from Transifex
2020-09-02 02:28:14 +00:00
29aad2ae3d
Automatic merge of translations from Transifex
2020-08-29 02:27:36 +00:00
6821f6d7bd
udisks2lister: enable ipod recognition
...
The extends two functions:
- Recognize iPods as iPods, check for them in MakeDeviceUrls
- Give them a nice Icon in DeviceIcons (code taken from devicekitlister)
2020-08-28 16:48:13 +01:00
2d280734aa
Automatic merge of translations from Transifex
2020-08-27 02:27:20 +00:00
3a4d7f3a3d
Only enable main window rate button when LastFM is disabled ( #6778 )
2020-08-26 16:06:13 +01:00
d3e3270227
Automatic merge of translations from Transifex
2020-08-26 02:27:24 +00:00
44af6f9d5d
Replaced the heart icon with a star for local files
2020-08-25 21:51:03 +01:00
c60c523185
Replaced the heart icon with a star for local files
2020-08-25 21:51:03 +01:00
6a078f93a3
Automatic merge of translations from Transifex
2020-08-21 02:27:21 +00:00
fe33912886
Automatic merge of translations from Transifex
2020-08-19 02:27:16 +00:00
2a85d2c600
Automatic merge of translations from Transifex
2020-08-18 02:27:43 +00:00
70c79bd462
Automatic merge of translations from Transifex
2020-08-15 02:27:47 +00:00
8aa49902bd
Automatic merge of translations from Transifex
2020-08-10 02:27:42 +00:00
e932d421f7
Automatic merge of translations from Transifex
2020-08-04 02:27:34 +00:00
0e7cb988a7
Automatic merge of translations from Transifex
2020-08-03 02:27:25 +00:00
b10222145e
Automatic merge of translations from Transifex
2020-08-02 02:28:29 +00:00
222e142ad7
Automatic merge of translations from Transifex
2020-08-01 02:29:33 +00:00
2d3e2254f8
Automatic merge of translations from Transifex
2020-07-31 02:28:34 +00:00
d9fa56c179
Share the love: Minor corrections
2020-07-30 18:24:58 +01:00
acb75a5099
Share the love
2020-07-30 18:24:58 +01:00
75264f314d
Share the love
2020-07-30 18:24:58 +01:00
68d375c43c
Use effective album artist for Repeat Album logic
...
When there is album artist information available for a track, the user would
probably expect that "Repeat Album" should cycle through all songs with the same
album artist and album title, not only all songs with the same artist and album
title.
2020-07-20 10:45:49 +01:00
ee72793b5f
Automatic merge of translations from Transifex
2020-07-17 02:29:12 +00:00
987fe047c6
Fix access past end of vector in getPsychedelicColor
2020-07-13 15:07:02 +01:00
1f7607b1db
Get backend from application in PlaylistContainer::SetApplication
...
The manager's library backend may not be set when this is called.
2020-07-12 09:44:47 +01:00
dd9ed23345
Automatic merge of translations from Transifex
2020-07-11 02:27:49 +00:00
c75fa0077e
Fix playlist memory leak
...
When the current playlist is changed, PlaylistContainer::SetViewModel is called
to set the new list. This calls PlaylistView::SetItemDelegates, which allocates
several objects that are never freed. Instead, move the call to SetItemDelegates
to PlaylistContainer::SetApplication, which is only called once.
2020-07-10 10:28:19 +01:00
3bfaf3ff38
Automatic merge of translations from Transifex
2020-07-09 02:28:42 +00:00
ebf9ebf080
Show only a basic tooltip in the system tray
...
For environments that implements the D-Bus
http://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/StatusNotifierItem
specification HTML is not supported in the tool tip title. (It is
supported in the tool tip subtitle but this field is not set by
QSystemTrayIcon.)
See the discussion in #6733 for more info.
2020-07-08 17:24:42 +01:00
7d28e8700b
Call SettingsPage::showEvent from child class implementations
2020-07-07 10:35:02 +01:00
0fcb1df200
Automatic merge of translations from Transifex
2020-06-28 02:29:27 +00:00
ad882cc999
Add static IsTypeSupported methods to playlist item classes
2020-06-23 11:06:06 +01:00
9455a3ef79
Use IsLocalLibraryItem instead of comparing type string
2020-06-23 11:06:06 +01:00
cf279e6f48
Automatic merge of translations from Transifex
2020-06-21 02:27:27 +00:00
76a24a0a28
Use DbPlaylistItem base class for Jamendo and Magnatune
...
Moving these from LibraryPlaylistItem removes local file specific
implementations of IsLocalLibraryItem and Reload. Returning true for
IsLocalLibraryItem caused ratings to be set on unrelated library songs.
2020-06-19 11:18:32 +01:00
f563b7da40
Add DbPlaylistItem base class to LibraryPlaylistItem
...
This will be used to move items from non-library databases away from the
LibraryPlaylistItem class.
2020-06-19 11:18:32 +01:00
247cc8f715
Add missing playlistitem.h to CMakeLists.txt
2020-06-19 11:18:32 +01:00
8c25c443cd
Automatic merge of translations from Transifex
2020-06-19 02:28:31 +00:00
0d25a1b39c
Properly delete ignored DeviceInfo object
...
Since the SimpleTreeItem constructor variant used from LoadAllDevices adds the
object to the parent's children list, use the parent's Delete method to destroy
it.
2020-06-19 00:10:54 +01:00
1ef5ec2590
Automatic merge of translations from Transifex
2020-06-18 02:27:25 +00:00
06544054a6
Automatic merge of translations from Transifex
2020-06-15 02:27:43 +00:00
56ed6d4f7e
Automatic merge of translations from Transifex
2020-06-12 02:27:47 +00:00
6900197a8c
Automatic merge of translations from Transifex
2020-06-10 02:28:25 +00:00
cf8d2004bd
Use deleteLater to destroy device backends
2020-06-07 14:46:13 +01:00
c299c198de
organise: Update the song preview when the selected destination's data changes
...
This will cause the file exensions to change when transcode options are changed.
2020-06-07 14:45:50 +01:00
4dd3233976
organise: Set extension override in OrganiseDialog
...
If the destination device has a transcode option set, then compute filenames
with updated extensions. This does not cover the case where Organise needs to
transcode due to format support.
2020-06-07 14:45:50 +01:00
Clementine Buildbot
Jim Broadus
Matthieu Bruel
Robert-André Mauchin
NicolasToussaint
zan
Zanny
John Maguire
Gerion Entrup
dmdmdm
dmdmdm
Keshav Kini
Mattias Andersson