Funkwhale
/
Clementine-audio-player-Mac-Linux-Windows
mirror of https://github.com/clementine-player/Clementine
1
0
Fork 0
Code Issues Releases Wiki Activity
6,205 Commits 23 Branches 533 Tags 239 MiB
Commit Graph

4947 Commits

Author SHA1 Message Date
Andreas 8799222d64 Fix mono playback. This was broken with commit eaad4c32ee. 2015-05-02 16:14:44 +02:00
John Maguire e1ea116bfb Remove Grooveshark support. 
Well that was nice while it lasted.
 2015-05-01 11:57:59 +01:00
John Maguire c0cf5e1220 Check for both names of libcrypto++ 
Fixes #4835
 2015-05-01 11:52:40 +01:00
Andreas a32f725c5f Register QList<int> as a media type. Under windows, the connect doesn't work without it. 2015-04-29 17:14:37 +02:00
John Maguire 319b8a5824 Use SHA512 signatures for the spotify blob. 
SHA512 is unsupported by reasonable QCA versions so we must use
libcrypto++ instead.
 2015-04-28 12:27:07 +01:00
John Maguire 4cbe098b83 Fix memory leak in Amazon Cloud Drive. 2015-04-27 14:02:07 +01:00
John Maguire 8d2e3373a8 Use a GTlsDatabase for gstreamer SSL on mac. 2015-04-27 11:21:22 +01:00
Clementine Buildbot 2da11e0d90 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-04-27 10:01:21 +02:00
Adam Porter bb5a952e25 Re-read FMPS_Rating from file when changed 
When the FMPS_Rating changes in a file, Clementine will now re-read it
and change the rating in the library database.  This lets you modify
song ratings outside of Clementine and then load the new ratings into
Clementine.  Previously Clementine would ignore changed ratings in a
file's metadata after a song had been scanned into the library.
 2015-04-25 18:32:34 +02:00
Arnaud Bienner 20583b8b0a Correct typo 2015-04-25 18:01:32 +02:00
ArnaudBienner c7416cbfb5 Merge pull request #4599 from cincodenada/spotify-improvements 
Improve handling of Spotify Top Tracks and compilations
 2015-04-25 17:59:27 +02:00
Arnaud Bienner 99521ac15f Add missing certificate for api.soundcloud.com 
Fixes #4794.
 2015-04-25 17:51:08 +02:00
Andreas a0f24dff86 Network remote: Only start transcoder when we actually have something to transcode. 2015-04-24 17:43:18 +02:00
Andreas c152bc26d9 Network remote: Don't send downloader the first data since it's not needed. 2015-04-24 17:30:21 +02:00
Andreas 136fca6dc2 Network remote: Send filesize on songoffer. 2015-04-24 17:24:14 +02:00
Andreas d93917ce9b Network remote: Send song url as well. 2015-04-24 15:35:18 +02:00
Andreas c9b39e7c83 Fix crash when trying to download a track, but there is no current one playing. 2015-04-24 15:31:09 +02:00
John Maguire 30346e7810 Fix missing gst_buffer_unref. 
Fixes #4823
 2015-04-23 11:25:34 +01:00
Clementine Buildbot d55628a1e8 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-04-20 10:01:18 +02:00
Joel Bradshaw 0cc7801d33 Add comments and declare `artist` in tighter scope 2015-04-19 21:05:55 -07:00
Joel Bradshaw ddd641b1ae Improve handling of Spotify Top Tracks and compilations 
Two improvements to handling of Spotify albums:
 - Remove single-track results if they also show up in the album
results.  This eliminates duplicates showing up in albums.
 - For each album, choose the majority artist attribution to
specify as the Album Artist.  For users who group by Album Artist,
this prevents splitting albums into multiple entries when there
are contributing artists.

Squashes following commits:

    commit d8bf17e13f50c7642ba491228f31608f4861d3b6
    Author: Joel Bradshaw <cincodenada@gmail.com>
    Date:   Tue Oct 28 19:56:36 2014 -0700

        Improve handling of Spotify Top Tracks and compilations

        Two improvements to handling of Spotify albums:
         - Combine individual tracks into a "Top Tracks" album by just
        setting the album name to "Top Tracks"
         - For each album, choose the majority artist attribution to
        specify as the Album Artist.  For users who group by Album Artist,
        this prevents splitting albums into multiple entries when there
        is a contributing artist.

    commit 228650a1d7122e5d1947133ba793afaffaa69cb4
    Author: Joel Bradshaw <cincodenada@gmail.com>
    Date:   Wed Oct 29 10:00:21 2014 -0700

        Style cleanup, including run of make format

        Also wrapped Top Tracks with tr()

    commit a4f6c1ecd9bcc8338a956b1a45c2f184ee9d660d
    Author: Joel Bradshaw <cincodenada@gmail.com>
    Date:   Sun Feb 15 13:38:52 2015 -0800

        Simply remove duplicate entries from the "Top Tracks" section

        Don't create the fake "Top Tracks" album, but remove entries
        from it if they show up in the album results.  This will
        eliminate the main problem - duplicates showing up in albums -
        and avoid issues with actual single-track results showing up
        erroneously as "Top Tracks"

    commit 859abc93b3491cc526d89df19a85dc4cf9bce1c8
    Author: Joel Bradshaw <cincodenada@gmail.com>
    Date:   Sat Apr 18 09:17:50 2015 -0700

        Clean up stray f and make format

    commit 333de1c4aa947c7cbe785429565bf4f08f98d476
    Author: Joel Bradshjaw <cincodenada@gmail.com>
    Date:   Sat Apr 18 09:19:10 2015 -0700

        Update majority_count so it works

        Fixes issue with it just picking the last artist on the album
        as the album artist
 2015-04-18 09:23:45 -07:00
John Maguire e142bcaa21 Remove extraneous logging. 2015-04-17 12:13:27 +01:00
John Maguire aa22a43f44 Add exponential back-off to Amazon requests. 2015-04-17 12:10:40 +01:00
John Maguire e59ab5fa27 Comply with Amazon Cloud Drive branding guidelines. 2015-04-16 15:57:54 +01:00
Clementine Buildbot 6ecd47011a Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-04-13 10:01:20 +02:00
Andreas ec35688c86 Fix crash when stopping a track while a fadeout to pause is occuring. Fixes #4800. 2015-04-11 11:30:28 +02:00
Andreas 11d2702841 Try fixing buildbot. 2015-04-10 22:59:35 +02:00
Andreas 25e73d5714 Merge pull request #4679 from TheUbuntuGuy/master 
Do not remove currently playing track when repopulating a dynamic playlist
 2015-04-10 22:41:44 +02:00
Martin Babutzka 258ae281d8 IDv3 tag lyrics support. 
Squashed the following commits:

5c723ad commit: Fix: Includes alpha sort
15ac350 commit: Fix: Updated Database::kSchemaVersion to 49.
767a26a commit: Fixed small code style issue. Added schema-49 to data.qrc instead schema-48
bf6aa64 commit: fixup! Modified async handling of CollapsibleInfoPane as recommended by Andreas. Display of IDv2 tag lyrics works now.
c1f97e9 commit: fixup! Added support to read/display the ID tag lyrics in MP3 files:
c946b1d commit: Added support to read/display the ID tag lyrics in MP3 files:

-Added schema to the database to store it
-Added readers/writers for ID tags
-Added readers/writers for the database to the song class
-Added the taglyricsinfoprovider to show the lyrics in songinfo
 2015-04-10 21:05:07 +02:00
Clementine Buildbot f533b2998c Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-04-06 10:01:21 +02:00
Arnaud Bienner ccf5bffd99 Oops, this should just be a comment (remove warning) 2015-03-30 18:34:45 +02:00
Clementine Buildbot 82df087a83 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-03-30 10:01:17 +02:00
Arnaud Bienner 9877ac49fa Use Alt+Tab to switch between playlist tabs on OS X, as Cmd+Tab is already used by default for switching applications 2015-03-28 17:18:22 +01:00
John Maguire 8d3fd00956 Amazon Cloud Drive support. 
Squashed commit of the following:

commit 451a327fabb5f9aba077d93a33d75d8a6a288f5f
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:55:36 2015 +0100

    Revert debug console changes.

commit 52f643c3dc524a837f56268b6da4881187204165
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:49:28 2015 +0100

    Revert extra logging

commit 23645f9fea
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:47:55 2015 +0100

    How did you get there

commit 8153388f19
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:45:12 2015 +0100

    Update copyright headers.

commit fa9e279259
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:43:27 2015 +0100

    Remove logging

commit 47a405543c
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:42:05 2015 +0100

    Show login state correctly for Amazon.

commit 748d88d993
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:28:55 2015 +0100

    Ensure Amazon is connected before serving URLs.

commit 25ec9c65f4
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:22:28 2015 +0100

    Refresh Amazon authorisation & follow changes.

commit 27c1a37173
Author: John Maguire <john.maguire@gmail.com>
Date:   Thu Mar 26 18:27:27 2015 +0100

    Revert unneeded OAuthenticator change.

commit 3594af5be1
Author: John Maguire <john.maguire@gmail.com>
Date:   Thu Mar 26 16:52:19 2015 +0100

    Initial support for Amazon Cloud Drive.
 2015-03-27 14:56:08 +01:00
Arnaud Bienner f3426c05c7 Don't call gst_deinit when exiting Clementine. 
It sometimes cause a deadlock since we migrated to GStreamer 1.0.
And it seems we shouldn't need to call it as we are "a normal application":
http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/gstreamer-Gst.html#gst-deinit
 2015-03-25 22:23:13 +01:00
Arnaud Bienner 7ae9e0dd9b Set starting_up_ to false in playlist container when manager is done adding playlists. 
Otherwise, it was never set to false at startup if no "current_playlist" was saved in the settings, then there was no new value saved for "current_playlist".
Fixes #4011.
 2015-03-25 22:13:39 +01:00
Ivan Leontiev aba0517b4c Fix memory leak in networkremote. 2015-03-24 09:22:02 +00:00
Clementine Buildbot 791aa482c2 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-03-23 10:01:17 +01:00
Clementine Buildbot b50c51200c Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-03-16 10:01:20 +01:00
Arnaud Bienner 5b2e4419ae Don't check AXAPIEnabled when initializing the shortcuts, fixes media keys not working on OS X. 
Fixes issue #3958.
 2015-03-15 13:40:27 +01:00
Arnaud Bienner 5e45f59e2c Fix crash in Grooveshark. 
Not sure how I end up with this null pointer, but better to always to this sanity check.
 2015-03-11 23:07:20 +01:00
Clementine Buildbot 3bad88d01e Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-03-09 10:01:15 +01:00
John Maguire 705cdf11fc Move ScopedNSAutoreleasePool to ext 2015-03-02 17:51:17 +01:00
John Maguire 7823d95a07 Merge pull request #4756 from paperbagcorner/fix-paths 
Construct filenames with correct paths on all platforms
 2015-03-02 12:18:20 +01:00
John Maguire 66333d2940 Merge pull request #4758 from Chocobozzz/seafile_info 
Try to make Seafile implementation more robust
 2015-03-02 12:17:48 +01:00
Clementine Buildbot b6fd781ace Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-03-02 10:01:13 +01:00
Arnaud Bienner 946c0381d1 Don't set thread priority in LibraryWatcher constructor, as this is executed in the main thread. 
Do it when thread actually starts (create a new Thread class for this purpose).
Fixes #4523.
 2015-02-28 16:44:32 +01:00
Krzysztof Sobiecki 24b6fbf36c Add ability to parse more of "innovative" datetime formats. close #4760 2015-02-27 02:11:53 +01:00
Chocobozzz 2804ab32ec Change the name of the task when updating the libraries in the Seafile 
service and clean the code
 2015-02-23 15:27:20 +01:00
Clementine Buildbot 0f2d7b9879 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-02-23 10:01:28 +01:00
Chocobozzz 4b1a6651b1 Stop adding new songs if we cancelled the seafile indexing 2015-02-21 16:28:13 +01:00
Arnaud Bienner 2986ca23e6 Fix Spotify drag n drop. 
Was partially broken since commit ee7e2ec26c.
 2015-02-21 13:42:01 +01:00
Mattias Andersson 8ad0e93381 Construct file paths correctly on all platforms 2015-02-20 19:19:45 +01:00
Chocobozzz ec60d1174c Fix disconnecting a closure, forgot it was single shot 2015-02-20 16:09:15 +01:00
Chocobozzz 716064a006 Try to make seafile implementation more robusts and more verbose 2015-02-20 15:15:55 +01:00
Mattias Andersson 7f4d467c27 Make the code clearer. 2015-02-19 16:49:42 +01:00
Mattias Andersson 666faa5b37 Simplify some things. Use iterators instead of non-const references in 
two loops.
 2015-02-19 13:31:53 +01:00
Mattias Andersson f7185101ce Update the target file name after transcoding 
After a transcoding job is complete, we need to update the corresponding
filename since the transcoder, rather than overwriting an existing file,
changes the filename of the output file. This ensures that the right
file is tagged later on.
 2015-02-19 11:07:06 +01:00
Mattias Andersson 7d0d7be568 Some ui changes to the ripcd dialog. 
- Move the Rip audio CD menu item to the Tools menu.

- Hide the progress bar if the CD ripper isn't working when the CD ripping
dialog is shown.
 2015-02-18 20:08:02 +01:00
Mattias Andersson eed0c0d45f Assorted edits to the ripper class. 
- The constructor of the AlbumInformation struct now takes no arguments.

- Only add tracks to the rip list if their track numbers are valid.

- Only call cdio_get_media_changed if we have a valid cdio_ object.

- Add a description of the ripper class.
 2015-02-18 20:08:02 +01:00
Mattias Andersson fc2e4db229 Split the CD ripper into two classes 
Separate the cd ripper dialog from the ripper itself.
 2015-02-18 20:08:02 +01:00
Mattias Andersson eb8a618197 Move the CD ripper into its own directory. 2015-02-18 20:08:02 +01:00
John Maguire fb2b91c874 Remove some more obsolete os x version checks. 2015-02-18 18:03:46 +01:00
John Maguire 484db9d92b Remove obsolete snow leopard check. 2015-02-18 17:29:07 +01:00
John Maguire e5508ed53c Remove check for NSUserNotification support. 2015-02-18 17:22:01 +01:00
Clementine Buildbot 5709f3c5b8 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-02-16 10:01:27 +01:00
David Sansome b268771c3a Merge pull request #4750 from DevynCJohnson/patch-1 
Update equalizer.cpp
 2015-02-16 07:35:50 +11:00
Arnaud Bienner ce50cbe09f Fix compile issue on Yosemite 2015-02-15 16:43:36 +01:00
Devyn Collier Johnson b63d1fb661 Update equalizer.cpp 
I added more presets for additional generas
 2015-02-15 09:32:30 -05:00
John Maguire f73d2f4d24 Merge pull request #4740 from sobkas/small_fixes 
Small fixes for podcasts
 2015-02-11 16:11:04 +01:00
Clementine Buildbot 1f15df9936 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-02-09 10:01:26 +01:00
Arnaud Bienner ee7e2ec26c Ability to add tracks to Spotify starred playlist by drag and drop 2015-02-07 14:40:34 +01:00
Krzysztof Sobiecki 9934efc76b Small fixes for podcasts 2015-02-06 23:38:36 +01:00
John Maguire fbf22ccf3b Merge pull request #4739 from Chocobozzz/subsonic_fix 
Emit scanfinished when the library is empty
 2015-02-06 11:33:34 +01:00
Chocobozzz 5df8471ad6 Emit scanfinished when the library is empty 2015-02-06 11:23:57 +01:00
John Maguire af8f4100cd Fix crash when trying to fingerprint but missing a plugin. 2015-02-03 18:13:23 +01:00
John Maguire f2e6d665f3 Remove references to libindicate-qt 2015-02-03 13:48:32 +01:00
John Maguire 33117a1b44 Fix name of pulse audio gstreamer sink. 2015-02-03 13:32:41 +01:00
John Maguire 1a01b825da Remove Discogs support. 
Fixes #4735
Downloading album covers now requires per-user access tokens.
 2015-02-03 13:10:13 +01:00
Clementine Buildbot 5b46923034 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-02-02 10:01:25 +01:00
Fletcher Dostie 5fc4be803b Add Now Playing widget option: No Song Details 2015-01-26 13:11:19 -05:00
Clementine Buildbot 9dbd58276b Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-01-26 10:01:29 +01:00
Arnaud Bienner 43768d4af8 Small modifications to previous pull request: 
- remove reference to iPod, as this is not iPod specific IMO
- make comment clearer
 2015-01-19 15:01:33 +01:00
ArnaudBienner 29bcd2e15c Merge pull request #4692 from asiviero/previous_restart 
Added iPod-like behavior to previous button (closes #4638)
 2015-01-19 14:56:40 +01:00
John Maguire 87fed5d0f4 Merge pull request #4715 from Chocobozzz/albumartist_flac 
Fix album artist for FLAC/OGG files (with vorbis comments)
 2015-01-19 10:57:31 +01:00
Clementine Buildbot 0712978866 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-01-19 10:01:26 +01:00
Chocobozzz b96c1f060f Add tests to check the tag edition of FLAC/OGG files and make format 2015-01-17 12:11:33 +01:00
Chocobozzz 2a7d4e6d5e Improve edit tag when set values 2015-01-17 11:31:02 +01:00
John Maguire c96502ef4b Merge pull request #4712 from Chocobozzz/skyfm 
Change sky.fm to radiotunes.com
 2015-01-15 22:29:13 +01:00
Chocobozzz 5e5738f642 Make format 2015-01-15 19:58:20 +01:00
Chocobozzz 7e9f8d75c6 Change sky.fm to radiotunes.com 2015-01-15 18:48:27 +01:00
Arnaud Bienner e1139e731f run make format 2015-01-14 22:55:20 +01:00
Arnaud Bienner 7039c2a2bf Spotify: add the ability to add/remove tracks to/from Starred playlist 2015-01-14 22:49:36 +01:00
Clementine Buildbot 53279ebc66 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-01-12 10:01:26 +01:00
John Maguire 66ac5fa1d7 Show simplified & traditional chinese properly. 2015-01-08 17:22:00 +01:00
John Maguire 08449c76c3 Show sr@latin correctly in the language selector 2015-01-08 17:10:00 +01:00
Andre Siviero e4df00050d Includes in alphabetical order, moved Player ReloadSettings() to Player init 2015-01-08 01:10:35 -02:00
Andre Siviero 1120f97844 Added iPod-like behavior to previous button 2015-01-06 02:36:08 -02:00
Clementine Buildbot a61eac109c Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-01-05 10:01:23 +01:00
Krzysztof Sobiecki 8cf127a19c [internet/podcasts]Fix modification date&time support 
After setting QDateTime to invalid state, it's saved into database as uint,
with then is read from database as a valid date. To make behaviour consistent, this change is needed.
If date is 4294967295, then it's an invalid one.
 2015-01-02 15:29:58 +01:00
Krzysztof Sobiecki 2613341761 Formating fixes in src/dbus 2015-01-02 14:44:30 +01:00
Clementine Buildbot 66f74adc99 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-12-29 10:01:23 +01:00
Mark Furneaux c4daa227a7 Do not remove currently playing track when repopulating a dynamic playlist 2014-12-27 20:34:29 -05:00
Arnaud Bienner 7278e7c4d0 Add ability to get a link to share Spotify playlists 2014-12-27 18:05:04 +01:00
Arnaud Bienner cbddecb6c8 Add ability to get a link to share Spotify songs 2014-12-27 16:40:13 +01:00
ArnaudBienner 2d90789cbd Merge pull request #4677 from sobkas/formating_src_covers 
Formating src covers
 2014-12-27 14:52:11 +01:00
Arnaud Bienner 9bbb534fa1 Sanity check 
Not sure this can really happen in real life (happens because I was playing with
    the code and end up having "=true" line in Clementine.conf) but FWIW, better
to check those values they come from possibly corrupted files/preferences.
 2014-12-27 01:23:26 +01:00
Arnaud Bienner c5b6f7b531 I guess our users are more interested in classic Facebook page than JSON. 
Not sure why Echonest returns graph URL.
 2014-12-27 00:47:24 +01:00
Arnaud Bienner 9cb2a17f37 Sort children is recursive and will mess up services' children (e.g. search 
result item not the first item anymore) so we should call it only once at
the beginning.
And instead of sorting all items everytime, we just insert them at the correct
position.
 2014-12-27 00:33:23 +01:00
Krzysztof Sobiecki 6c8826c3f8 Fix headers order in src/covers 2014-12-26 14:57:02 +01:00
Krzysztof Sobiecki 0ff2e33d55 Fix formating in src/covers 2014-12-26 13:44:40 +01:00
David Sansome 3557576a87 Install Info.plist files into ${framework}/Resources as well, to fix code signing on 10.9 (http://stackoverflow.com/questions/19637131/sign-a-framework-for-osx-10-9) 2014-12-26 10:18:23 +11:00
Krzysztof Sobiecki acb02932bd Fix crash when marking podcast as listened 
Fixes #4674
 2014-12-25 23:02:12 +01:00
Krzysztof Sobiecki f2b4a5a520 M4B on cloud storage 2014-12-25 01:33:56 +01:00
Krzysztof Sobiecki c4d150d3e0 Add m4b support, only for non-drm files 2014-12-25 01:12:15 +01:00
David Sansome 75cea2f2b9 Merge pull request #4669 from TheUbuntuGuy/master 
Don't load the moodbar if the song was stopped
 2014-12-23 09:26:39 +11:00
Mark Furneaux a4be57414a Don't load the moodbar if the song was stopped 
When an async moodbar load completes, it checks to see if the song is still playing and should update the UI.
It however failed to check if the song was stopped, so it would load a moodbar when no song is playing.
It now checks the player state before emitting a change.
 2014-12-22 16:53:58 -05:00
ArnaudBienner 3288c7d289 Merge pull request #4668 from TheUbuntuGuy/master 
Fix socket leak in moodbarpipeline
 2014-12-22 22:39:42 +01:00
Mark Furneaux 3886f3d1e4 Fix socket leak in moodbarpipeline 
Fixes #4663
When tearing down the pipeline, there was a leak of a GstBus which holds a socketpair open.
Eventually the OS runs out of file descriptors and terminates Clementine.
 2014-12-22 16:13:44 -05:00
Clementine Buildbot 0a74c4cbff Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-12-22 10:01:26 +01:00
Krzysztof Sobiecki a6322da196 Fix header copyright tags in internet/ 2014-12-19 00:47:55 +01:00
Krzysztof Sobiecki 17c35e32e5 Fix header order in internet/ 2014-12-19 00:40:30 +01:00
Krzysztof Sobiecki 23ee9170b6 Fix header guards in internet/ 2014-12-18 23:54:21 +01:00
Krzysztof Sobiecki fa9ea6ec5f Fix compilation with moved files in internet/ 2014-12-18 23:35:21 +01:00
Krzysztof Sobiecki 93a286a272 Move files around and make subdirectories inside src/internet, move src/podcasts to src/internet 2014-12-18 00:39:20 +01:00
Krzysztof Sobiecki ff62032568 Various formating changes in src/internet 2014-12-17 22:36:27 +01:00
Krzysztof Sobiecki ad4bc3b88b Cherry pick more make format changes src/podcasts 2014-12-16 14:59:17 +01:00
Krzysztof Sobiecki 4fec417a93 Produce a proper url for date parse error 2014-12-16 13:14:56 +01:00
David Sansome 6851a15dc0 Merge pull request #4651 from sobkas/fix 
Fix the parsing of some strange date formats in podcasts, and add a way to limit the number of podcast episodes shown, and hide listened podcasts.  Fixes #3696, fixes #3475
 2014-12-16 12:33:50 +11:00
Krzysztof Sobiecki 81537754e8 A better error url 2014-12-16 01:45:54 +01:00
Clementine Buildbot 943e79ebea Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-12-15 10:01:29 +01:00
Krzysztof Sobiecki ba1d73d1aa Fix problems with code 2014-12-14 14:35:21 +01:00
Krzysztof Sobiecki bf55bc08fb Cherry pick make format changes 2014-12-14 12:23:04 +01:00
Krzysztof Sobiecki 6cc72e2f5d Fix a date parser for one podcasts 2014-12-14 12:13:05 +01:00
Krzysztof Sobiecki 958cb42e98 Allow to hide listened podcast episodes and show only n number of episodes. 
Fixes #3696
Fixes #3475
 2014-12-14 12:12:57 +01:00
John Maguire 946dc0ce3e Merge pull request #4648 from sobkas/master 
PodcastDownloader changes
 2014-12-14 00:37:37 +01:00
Krzysztof Sobiecki a7e8c927f4 Now without sender 2014-12-13 20:06:39 +01:00
Krzysztof Sobiecki 1922d51780 Fix header files order 2014-12-13 02:24:20 +01:00
Krzysztof Sobiecki 418d65a1a7 Fix header files order 2014-12-13 02:05:08 +01:00
Krzysztof Sobiecki 741bceab02 Ability to cancel downloads in progress 
Fixes #3661
 2014-12-12 19:38:29 +01:00
Arnaud Bienner 4b48be4a5b Sort Grooveshark favorite songs according to "TSFavorited", as such songs have no "Sort" field. 
BTW the compare was buggy (didn't compare against song2). This was OK though, as
we stable sort songs, and they are always ordered as far as I know (I remember
adding this sort just in case they will not be sent ordered on day).
 2014-12-10 22:48:49 +01:00
Krzysztof Sobiecki a43a39b669 Fix errors, newline was here 2014-12-10 22:17:10 +01:00
Krzysztof Sobiecki 3bdf765e3d Fix errors, cherry picked make format fixes 2014-12-10 22:13:01 +01:00
Krzysztof Sobiecki 8cbe742d9f Fix errors, needed for a pull 2014-12-10 21:57:09 +01:00
Krzysztof Sobiecki 2d2783ab04 Fix copyright notices 2014-12-10 01:25:52 +01:00
Krzysztof Sobiecki 793ece163a Fix copyright notices 2014-12-10 01:24:51 +01:00
Krzysztof Sobiecki a07f115088 Fix copyright notices 2014-12-10 01:23:43 +01:00
Krzysztof Sobiecki 970e86aac5 Allows to download multiple podcasts at the same time 
A new PodcastDeleter, it deletes podcast episodes
 2014-12-10 00:47:52 +01:00
Krzysztof Sobiecki d1cad6cbc1 Remove podcast episode automatic deleter out of PodcastDownloader 2014-12-10 00:31:40 +01:00
John Maguire fdd669360f Merge pull request #4644 from sbird/fasterstartup 
Patches to start clementine faster
 2014-12-09 20:02:51 +01:00
Simeon Bird 3f9b5f4663 Do Podcast updates on song change off main thread 
Each time the song is changed, the podcast backend checks whether the
new song is a podcast and, if so, mark it as listened to. This requires
1-2 db queries, so do it off the main thread.

Time to change song before: 300 ms
                    after: 50 ms usually, 80 ms sometimes
 2014-12-09 12:49:24 -05:00
Simeon Bird 401f07c7cb Avoid db commits during startup 
When starting clementine, each playlist is loaded in turn.
When loading a playlist, the new tab order is committed to the db,
but we don't need to do that here because we know that once all the
playlists are loaded the tab order will be the same as it was initially.

This speeds startup substantially.
kstartperf:
Before: 3.5s
After: 1.5s
 2014-12-09 12:48:53 -05:00
Simeon Bird 09e839353e Speed up playlist restoring by moving sqlite query off main thread 
The playlist fetching uses QtConcurrent to make the playlist on a
different thread (possibly concurrently for each item).
However, profiling reveals that the slow operation is fetching
the rows from the SQLite database, making this redundant.

Instead move the whole playlist loading, including the database access,
into a single function, and call that function in a different thread via
QtConcurrent::run.

This has the side effect of moving all the concurrent stuff from
PlaylistBackend into the callers.

kstartperf measures:

Before: 7.5s cold
        3.6 s warm

After: ~4.0 s cold
       3.5 s warm
 2014-12-09 12:47:37 -05:00
Clementine Buildbot 8e0952e0b1 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-12-08 10:01:25 +01:00
Andreas 0f1b29a523 Make sure SongSender is deleted when client disconnects. 2014-12-07 13:54:18 +01:00
Arnaud Bienner 16b2ac547c Sort music brainz releases according to status 2014-12-06 17:54:13 +01:00
Arnaud Bienner f34f868c0f Add Spotify tracks to Spotify playlists by drag and drop 2014-12-03 23:58:09 +01:00
Arnaud Bienner f7924905d2 Also add internet_service method for other search providers which have a internet services. 
Shouldn't change anything in practice, but better to have items correctly inserted as Internet items FWIW. And will avoid other "custom context menu not working" issues if one day we implement one for
these services.
 2014-12-03 22:33:29 +01:00
Arnaud Bienner 05d43e27a9 Add internet_service to SpotifySearchProvider so custom context menu is correctly shown on playlist items created from the global search 2014-12-03 22:27:43 +01:00
John Maguire 20e626a9ab Merge pull request #4626 from ntrrgc/master 
Fix #4420: Previous track in dynamic random mix
 2014-12-02 13:56:55 +00:00
John Maguire f79b0c867c Merge pull request #4628 from sobkas/master 
Fixes for copyright notices, cpplint.py errors and misc.
 2014-12-01 10:55:41 +00:00
Clementine Buildbot dbe9f38dc8 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-12-01 10:01:25 +01:00
John Maguire 39e6d071f2 Merge pull request #4630 from Chocobozzz/xspfparser_fix 
Fix accents issue in when save playlist in xspf format
 2014-11-30 14:59:46 +00:00
Krzysztof Sobiecki 4e32b36f59 Set ctime and mtime in Song returned by PodcastEpisode::ToSong 
Fixes #4627,#4368
 2014-11-30 15:49:13 +01:00
Chocobozzz 824526618c Fix accents issue in when save playlist in xspf format 2014-11-30 10:36:36 +01:00
Krzysztof Sobiecki 1cbe135a8d Fix some errors in src/analyzers introduced while fixing cpplint.py errors 2014-11-29 21:05:59 +01:00
Krzysztof Sobiecki dc669eb603 Fix cpplint.py errors, fix copyright notices in src/analyzers, move src/core/fht* to src/analyzers 2014-11-29 20:07:01 +01:00
Juan Luis Boya García 292fff7e3a Fix #4420: Previous track in dynamic random mix 2014-11-29 19:34:31 +01:00
John Maguire 64c34f58ae Merge pull request #4608 from sobkas/src_core_fix 
Fix the copyright info and formatting in src/podcast and src/core
 2014-11-27 15:17:16 +01:00
Clementine Buildbot 154a1d3ebe Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-11-24 10:01:26 +01:00
John Maguire ff91759b71 Fix Ubuntu PPA 
Adds a missing check for libcdio.
Adds libcdio as a dependency for debian.
Fixes issue #4618
 2014-11-19 15:45:05 +09:00
Andreas 5e77aed01e Cancel transcode when downloader disconnects. 2014-11-18 11:55:27 +01:00
Clementine Buildbot 8ac5d8e595 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-11-17 10:01:31 +01:00
Andreas 880308c205 Remove async bus callback from transcoder. This caused the UI to get unresponsive after a song was converted. 
A bit more information:
Normal transcoding worked fine, the transcoder object was in the main thread. In the network remote, a new transcoder object is created which runs in the network remote thread. When a song was transcoded there, the UI became unresponsive.
Removing the async bus callback solved the problem, exactly the g_source_remove() method caused it. Since the bus callback returned FALSE (GST_BUS_DROP), the watch was already removed. (See http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/GstBus.html#gst-bus-add-watch)
 2014-11-14 23:50:59 +01:00
Andreas 86a375f952 Send correct total file size if files were transcoded. 2014-11-14 17:53:25 +01:00
Andreas ff172f6ed4 Network remote can now transcode lossless files before sending them to the remote. 
- It is configurable in the settings.
- Any format can be chosen that is supported by the transcoder.
- The status of the transcoder is send to the remote.

- Transcoder format settings have now a postfix so we can define mutliple transcoder formats and use them separatly. Here one for the normal transcoder and one for the network remote transcode. You can pass the postfix in the constructor.
- Fixed Transcoder crash (was introduced with the gstreamer1.0 merge, decodebin doesn't have a "new-decoded-pad").
- Transcoder emits the output filename as well on "JobComplete" signal
- Transcoder can now convert a file to a temporary file ("AddTemporaryJob")
 2014-11-13 22:31:49 +01:00
Andreas 8aa78af8f8 Save last used transcoder format with the mimetype instead of the extension. 
ogg vorbis and ogg flac have the same extensions (*.ogg) and therefore the wrong item in the format combobox might be loaded.
 2014-11-11 14:40:52 +01:00
Clementine Buildbot 9cdb31c2d8 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-11-10 10:01:29 +01:00
John Maguire f150ad8971 Merge pull request #4600 from sobkas/master 
Ability to automatically set podcast as listened
 2014-11-06 12:21:07 +00:00
Krzysztof Sobiecki 6efb5d05b7 Fix some problems 2014-11-05 17:48:04 +01:00
Krzysztof Sobiecki cabaaf3333 More copyright info fixes 2014-11-05 17:48:04 +01:00
Krzysztof Sobiecki 130d3c72f0 More copyright info fixes 2014-11-05 17:48:04 +01:00
Krzysztof Sobiecki d775d72345 More copyright info fixes 2014-11-05 17:48:04 +01:00
Krzysztof Sobiecki 39a3b46ead More copyright info fixes 2014-11-05 17:48:04 +01:00
Krzysztof Sobiecki a85728dfb3 Fix some problems 2014-11-05 17:48:03 +01:00
Krzysztof Sobiecki 011155a751 Fix copyright notices inside src/podcasts 2014-11-05 17:48:03 +01:00
Krzysztof Sobiecki c0614dbe09 Fix copyright notices inside src/core 2014-11-05 17:48:03 +01:00
Krzysztof Sobiecki 0af1470cce Clean up src/core 2014-11-05 17:48:03 +01:00
Krzysztof Sobiecki 978a91442c Connect signal to signal 2014-11-05 17:35:14 +01:00
Chocobozzz 8fba1c30f4 Make format 2014-11-05 13:05:58 +01:00
Chocobozzz da99c55eed Use constructor for QString 2014-11-05 12:25:55 +01:00
Chocobozzz 2e64b24290 Revert "Use constructor for QString and make format" 
This reverts commit 5a2348fae6.
 2014-11-05 12:25:09 +01:00
Chocobozzz 5a2348fae6 Use constructor for QString and make format 2014-11-05 11:51:38 +01:00
Krzysztof Sobiecki 5045f9b870 Don't use caller in OrganiseDialog 2014-11-05 02:37:44 +01:00
Krzysztof Sobiecki e4141dd862 Fix formating 2014-11-05 00:42:56 +01:00
Krzysztof Sobiecki b89c05048a Move connect out of emitter 2014-11-05 00:42:56 +01:00
Krzysztof Sobiecki 578c9ad598 Ability to automatically set podcast as listened after sucesfully sending it to a device 2014-11-05 00:42:55 +01:00
Chocobozzz 942fda88bf Check if there is a current icon item in the device manager. Fixes #4604 #4555 2014-11-04 21:46:10 +01:00
Clementine Buildbot 797236fc60 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-11-03 10:01:27 +01:00
John Maguire 4f4c8f6894 Merge pull request #4580 from Chocobozzz/hide_internet_services 
Hide internet services
 2014-10-31 12:02:29 +01:00
John Maguire a6514617cf Merge pull request #4596 from Homulvas/master 
Sorting by disc in advanced grouping
 2014-10-29 18:00:51 +01:00
Ivan Leontiev 7c7e855e1a correct formatting and some code cleanup 2014-10-29 16:45:52 +03:00
Ignas Kaziukenas 0a2a358d8b "Green Day Problem" solved. Year-Album grouping also obeys grouping tag that allows to order albums released in the same year non-alphabetically 2014-10-29 15:29:45 +02:00
Ivan Leontiev 8406a47628 Merge branch 'master' of https://github.com/ivan-leontiev/Clementine 2014-10-29 01:40:01 +03:00
Ivan Leontiev 45a3f32c86 VkService: added albums support, added ability to fetch music from wall. Fixed 
update bug.
 2014-10-29 01:22:07 +03:00
Ivan Leontiev 3d124a2dea encode "+" character in url in VkConnection::makeRequest 2014-10-28 20:12:01 +03:00
Ignas Kaziukenas a2df43c830 Reverted changes amde to groupby_performer 2014-10-27 15:49:11 +02:00
Ignas Kaziukenas 7516438c8b Added disc to the groupby interface. Replced groupby_performer to groupby_disc 2014-10-27 14:47:04 +02:00
David Sansome 5ec9dcdcb7 Merge pull request #4559 from TheUbuntuGuy/master 
Fix missing buffers sent to analyzer
 2014-10-27 22:17:14 +11:00
Clementine Buildbot e222e1ad0d Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-10-27 10:01:31 +01:00
Arnaud Bienner 2208fa7d13 Add a source icon for CD tracks 2014-10-26 18:45:48 +01:00
Arnaud Bienner baa0654b03 Try to fix minimal build 
Maybe one day I will stop breaking it everytime I change something
 2014-10-26 17:12:00 +01:00
Arnaud Bienner 7ac9e4c6d1 Fix a bug in InsertItems functions that makes Cdda tracks to not be saved/restored correctly when restarting Clementine 2014-10-26 17:08:12 +01:00
Arnaud Bienner 1779050fff Add error message when MB disc id request fails 2014-10-26 17:07:29 +01:00
Arnaud Bienner 5a7c462fc3 Remove useless includes 2014-10-26 03:37:17 +01:00
Arnaud Bienner dc0d3436c8 Finish CD integration update to Gstreamer 1.0 
Move everything related to CDDA to a seperate class, so we can more easily reuse it in SongLoader
 2014-10-26 03:32:37 +01:00
Arnaud Bienner a8266173c5 Start to reactivate audio CD support 2014-10-26 00:28:03 +02:00
Chocobozzz 0b8e566544 Use utf8 for password instead of ascii 2014-10-24 13:12:50 +02:00
Chocobozzz 15a8af9bbb Use hex in password auth for subsonic. Fixes #4589 2014-10-24 09:47:03 +02:00
Chocobozzz 33d38b94da Use auto for iterator 2014-10-24 09:22:35 +02:00
Andreas 1ad5884b39 Fix some minor C++ things in OutgoingDataCreator. 2014-10-23 18:07:39 +02:00
Arnaud Bienner 21551ca83c Try to fix issue #4582 2014-10-21 21:54:46 +02:00
Andreas c43eb02efd Android Remote: Add global search. 2014-10-21 18:07:02 +02:00
Clementine Buildbot 611d746855 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-10-20 10:02:20 +02:00
Chocobozzz 50b7b7d889 Make format after update to avoid conflicts 2014-10-15 21:57:57 +02:00
Chocobozzz 9770154b57 Merge remote-tracking branch 'upstream/master' into hide_internet_services 2014-10-15 21:55:09 +02:00
Chocobozzz 8279f21251 Revert "Make format" 
This reverts commit 17b1e9fbe6.
 2014-10-15 21:55:03 +02:00
Chocobozzz 17b1e9fbe6 Make format 2014-10-15 20:55:24 +02:00
Chocobozzz 34a43635bd Delete useless warning icon from internet show setting page 2014-10-15 20:51:09 +02:00
Chocobozzz c54d1baf15 Allow user to hide internet services. Closes #2784 2014-10-15 20:44:09 +02:00
David Sansome 88a6300509 Completely revert the Spotify seeking stuff - it's hacky and I don't like 
waiting 4 seconds to have my songs start.  I'll reimplement it properly later.

Reverts commits 96387803cd and 160b151652.
 2014-10-14 19:33:03 +11:00
David Sansome c428e536ab When replacing a decodebin, offset the timestamps on the new element's buffers 
so they match up with the buffers produced by the old element.  Fixes #4542.
 2014-10-14 19:22:43 +11:00
Clementine Buildbot bb439f61b9 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-10-13 10:01:36 +02:00
John Maguire aa3671b54a Merge pull request #4521 from Korvox/master 
Add an option to pull all music files recursively into transcoding
 2014-10-08 12:37:16 +02:00
Arnaud Bienner 78804b12c6 Use a save dialog option instead of quick change menu. 
This is less confusing IMO. The dialog will shown up only if users decided to in the preferences, so that will not bother users who don't need this.
This reuses lot of things from Alan contribution from #4484
 2014-10-07 00:29:46 +02:00
Arnaud Bienner 54d76506a7 Fix member not initialized in constructor. 
Was init soon after anyway, but FWIW...
 2014-10-07 00:29:46 +02:00
Alan Briolat c69f2e5561 Reuse some work from Alan from pull request #4484 2014-10-07 00:29:46 +02:00
Arnaud Bienner c35e573637 Missing things from previous commit 2014-10-07 00:29:46 +02:00
Arnaud Bienner f6e6d3b937 Revert "Finished the changes to the quick change menu. Everything should work." 
This reverts commit a468085c3a.

Conflicts:
	src/playlist/playlistcontainer.cpp
	src/playlist/playlistcontainer.h
	src/ui/behavioursettingspage.cpp
 2014-10-07 00:29:46 +02:00
Arnaud Bienner f7d2dd94f9 Revert "Add a quick change menu to the playlist container." 
This reverts commit 1cddc696ae.

Conflicts:
	src/ui/behavioursettingspage.ui
 2014-10-07 00:29:46 +02:00
Pasi Saarinen 1ecee037c7 Fix moodbar segfault when playing broken mp3 
When playing a broken mp3 (eg empty file) clementine crashed if moodbar
was enabled.
 2014-10-06 15:40:10 +02:00
Clementine Buildbot c0f4ab8591 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-10-06 10:01:33 +02:00
Andreas dba79a7e99 Revert "Add option to show year next to album name in library and global search." 
This reverts commit e17fc06be1.

Doesn't work as I thought.
 2014-10-05 15:06:56 +02:00
Andreas e17fc06be1 Add option to show year next to album name in library and global search. 2014-10-05 14:14:24 +02:00
Andreas d32c3236ef Fix little dropout when transition to next track. Updates #4542. 
SourceDrainedCallback() has a valid next url and calls TransitionToNext(). This sets a new decode bin for the pipeline. The pipeline then buffers the new track and sends GST_MESSAGE_BUFFERING. BufferingMessageReceived() then pauses the pipeline because it's buffering. But we are buffering the next track and not the current one, so the pipeline has still data and doesn't need to be paused.
 2014-10-05 11:57:57 +02:00
Arnaud Bienner 37a6c125c0 Consider some more things as text (like numbers) when deciding if we should focus on the search bar 2014-10-04 18:08:53 +02:00
Mark Furneaux 3be48f8f44 unref buffers going to analyser at the right time 
This unrefs the buffer after the last chunk is pulled from it.
 2014-10-04 10:39:33 -04:00
David Sansome 0b97a29aa1 Set log levels after commandline options are parsed. Fixes --verbose, --quiet and --log-levels 2014-10-04 21:22:29 +10:00
David Sansome eec246718a Fix track transitions with gstreamer-1.0. The segment-start event is now a stream-start bus message. Fixes #4542 2014-10-04 21:21:21 +10:00
Mark Furneaux e8c2b4b267 Fix missing buffers sent to analyzer 
This is a regression in the upgrade to gstreamer1.0.
The gst_buffer_unref() is incorrect as it removes the buffer when it is still needed by the chunker.
Forcing the pointer to be null prevents it from segfaulting but causes it to skip all chunks in the buffer, dropping the framerate and causing a worse case of #4321.
Removing these 2 lines restores original functionality.
 2014-10-03 20:53:07 -04:00