Commit Graph

2183 Commits

Author SHA1 Message Date
Arnaud Bienner fb36940d5e Add tooltip for cover manager's items, which displays artist and album name info. Fixes issue 451 2011-02-08 22:54:37 +00:00
Paweł Bara 4cd01a43b7 fixing names of all the 'add to playlist' items in context menus (Fixes issue #1421) 2011-02-08 22:42:09 +00:00
Arnaud Bienner de2193f5af Display tooltip info in library only if text displayed is elided (as it was done for playlistdelegates, r2745). Partially fixes issue 451 2011-02-08 21:55:32 +00:00
Paweł Bara 33276132ec when saving cover, start in the album's folder (just like with the similar 'load cover from disk' feature) 2011-02-07 23:53:32 +00:00
Paweł Bara b7cd42fe53 minor C++ stuff 2011-02-06 14:34:47 +00:00
Paweł Bara 82e92bb3ac library view has now three modes: 'all songs', 'duplicates only' and new 'untagged songs only' (check out the http://code.google.com/p/clementine-player/wiki/LibraryViewModes) - fixes issue #305
+ hiding the 'complexity' of QueryOptions filter and query_mode mutual exclusion behind it's API
2011-02-06 13:18:18 +00:00
Paweł Bara e08c6cc6a5 just a prettier expression 2011-02-05 13:45:40 +00:00
Paweł Bara 9a9d8ad177 don't let invalid CUE related media files into library (invalid == those which were not recognized by TagLib)
better logging of erroneous DB queries (error + query + bound values instead of just error)
2011-02-05 13:43:04 +00:00
Paweł Bara a0dfaf89fb be consistent - if we're letting playlist to decide what songs are valid then let's also restore everything it's loaded when Clementine restarts (this actually fixes some problems with a CUE I have) 2011-02-04 17:41:45 +00:00
John Maguire 4fb6f92ad4 Fix compile warning on mac. 2011-02-04 15:25:05 +00:00
John Maguire 8a5455dc7e Fix UI file warnings. 2011-02-04 15:17:29 +00:00
John Maguire 1fc9dd183d Put our CFLAGS after the default ones so they don't get overridden. 2011-02-04 14:35:25 +00:00
John Maguire 084b9a2fe3 Remove taglib prefix from includes as the taglib include path contains it already. 2011-02-04 12:36:56 +00:00
John Maguire ab2f3360e2 Add Linux variable and set -Werror for Linux builds. 2011-02-04 12:07:00 +00:00
John Maguire c680c55379 Fix a couple of warnings found by Clang. 2011-02-04 11:17:31 +00:00
Paweł Bara ed4b7abde0 changed my mind - reverting my playlist changes to previous status quo (just making the PlaylistParser's contract more explicit)
this doesn't mean the previous revision was pointless - it still fixed one CUE related bug which I forgot to mention...
2011-02-03 22:21:15 +00:00
David Sansome e586ca12e5 Link clementine_lib instead of clementine against qtsparkle, fixing the tests on Windows 2011-02-03 21:06:05 +00:00
David Sansome 3ef0bf65a8 Fix the last.fm icon while a last.fm station is loading 2011-02-03 20:59:53 +00:00
David Sansome 2a68ecc726 Remove some unused bits 2011-02-03 20:59:14 +00:00
Paweł Bara 7bdac8fba6 when loading playlist, take only it's valid songs (+ force validity of CUE and PLS related songs) 2011-02-03 17:47:32 +00:00
Arnaud Bienner 74a878be41 Minor modication thanks to David comment 2011-02-02 23:27:55 +00:00
Arnaud Bienner e8720f5bda Display item info in playlist view only if text displayed is elided 2011-02-02 22:58:19 +00:00
Paweł Bara 2623a170a4 forgot this 2011-02-02 21:05:07 +00:00
Paweł Bara 77151d7ebd Hiding some of Song's cover art logic complexity in Song's API (namely: embedded and manually unset covers). 2011-02-02 21:01:08 +00:00
John Maguire f0ac22e31b Fix crash in mac on show duplicates only.
Fixes issue #1396
2011-02-02 19:16:27 +00:00
Paweł Bara 12099d48f6 maybe fix the mac build 2011-02-02 17:22:30 +00:00
Paweł Bara ce104b9cf4 working on making disable for library filter widget work on MacOS (Updates issue #1396) 2011-02-02 16:46:57 +00:00
Paweł Bara 8aedda1795 moving the 'Save cover to file' action into AlbumCoverChoiceController; implementing the action in all related places (now playing widget, album cover manager, edit tag dialog)
now playing widget: disable all cover related context menu options (except for the 'save cover' one) when in 'Kittens' mode
2011-02-02 16:22:04 +00:00
Arnaud Bienner b52f3b6082 Improve track selection dialog: allow expanding, use linedit for filename and minor other modifications. Fixes issue 1392 2011-02-01 20:59:33 +00:00
David Sansome e4d9d54414 Link Clementine against SIP and PyQt on Windows, and add the modules to python's inittab 2011-01-31 23:44:44 +00:00
John Maguire 9786570f35 Add support for saving album covers/kittens.
Fixes issue #1395
2011-01-31 20:53:38 +00:00
Paweł Bara 5b5d3f0c2e watch out for optional last.fm dependencies in AlbumCoverChoiceController -> fixes issue #1393
from the creators of "david is always right" movie -> maybe fix issue #1396
2011-01-31 15:21:32 +00:00
Paweł Bara 2959dbff85 'show duplicates only' view for library where you can see which songs in your library are duplicated and delete unnecessary duplicates (fixes issue #1328) 2011-01-30 21:00:49 +00:00
Paweł Bara 35441d829e fixed a bug where 'Show cover in full size' and 'Unset cover' actions were incorrectly being disabled in the 'Now playing' widget 2011-01-30 20:17:09 +00:00
John Maguire 06c62f169f Set default mac sidebar to Large and allow building on mac without tunepimp & scripting. 2011-01-29 21:28:11 +00:00
Arnaud Bienner 9159e3c47e Oups... miss to also correct this 2011-01-29 16:11:20 +00:00
Arnaud Bienner 8b681a5dd2 Allow autotagging for non-library music files. Fixes issue 1389 2011-01-29 16:02:23 +00:00
Arnaud Bienner 6c42240b02 Minor correction in tagfetcher. Thanks David 2011-01-29 15:32:55 +00:00
Arnaud Bienner e9f19f2cdb Correct regression introduced in r2705. Partially fixes issue 1390 2011-01-29 15:18:14 +00:00
David Sansome 618aec2c74 Clean module dicts properly when unloading a script - works around a bug in Python 2.7.0 only 2011-01-29 00:57:58 +00:00
David Sansome bcc35ec29c Add a test for stuff in the module's global dict 2011-01-28 21:43:10 +00:00
David Sansome 9ca237bfa2 Add a unit test for some basic python scripting functionality 2011-01-28 20:52:38 +00:00
John Maguire ba0c7bab65 Change "kittens" feature to fetch the kittens tag instead of cat tag for fluffier kittens. 2011-01-27 16:54:03 +00:00
John Maguire 703a3b43d6 Mac build fixes for musicbrainz integration. 2011-01-27 14:48:58 +00:00
Arnaud Bienner 05a4cae370 Add track seeking from playlistview 2011-01-26 23:20:56 +00:00
Paweł Bara 2fec795b89 fixed an error where entering the Cover Searcher dialog without query would make it show the busy indicator forever
further refactoring of album cover changes (QMenu in controller)
2011-01-25 23:33:27 +00:00
Andrea Decorte 4e9aef16cb forgot to add these files, sorry 2011-01-25 20:13:28 +00:00
Andrea Decorte f98b89a2d8 Fixed issue #764 2011-01-25 19:15:51 +00:00
David Sansome f929a88473 Fix mpris 2011-01-24 21:25:09 +00:00
David Sansome 0beb12fc14 Add some options to control what happens when you double click or use the menu to add tracks to the playlist 2011-01-24 21:16:26 +00:00
John Maguire 2ad5acdd29 Move version information in to separate file to decrease churn on svn up.
Fix inverted error message for Avahi.
2011-01-24 20:45:15 +00:00
David Sansome 5e9edd52fe Hold the taglib mutex while loading embedded cover art from files. Fixes issue #1350 2011-01-24 20:06:59 +00:00
Paweł Bara 4a9d38bbdd final refactoring stage of cover changing code (common QAction*s)
reset URL in 'Cover from URL' dialog on reentrance
2011-01-24 18:32:09 +00:00
Paweł Bara ebfbdba8a9 further refactoring of cover changing code (saving covers in controller) 2011-01-24 17:53:31 +00:00
John Maguire c39a514f2b Add close shortcut to script dialog. 2011-01-24 17:06:21 +00:00
Arnaud Bienner 03df8195b0 Minors modification on TagFetcher. Fixes issue #1346 2011-01-24 17:03:36 +00:00
John Maguire ed3719a950 Fix release build.
Fixes issue #1355
2011-01-24 12:44:19 +00:00
Paweł Bara 8bce92e69b refactoring the code that handles common UI album cover related actions into a common controller
fixes a bug where cancelling the 'cover from URL' dialog would set the cover to a previously chosen URL
2011-01-24 00:09:57 +00:00
Paweł Bara 3e2ffd3647 ability to load cover from URL in all the usual places: cover manager, now playing widget and edit tag dialog (fixes issue #517) 2011-01-23 20:24:17 +00:00
David Sansome 30019a9624 Update Turkish translation. Thanks H. İbrahim Güngör 2011-01-23 15:56:19 +00:00
David Sansome 4291d21eab Load embedded cover art from ogg files. Thanks markwatkinson. Fixes issue #1232 2011-01-23 15:50:59 +00:00
David Sansome fe818e5597 Don't drop the embedded art indicator from songs when updating the library. Thanks markwatkinson 2011-01-23 15:36:09 +00:00
Paweł Bara fae96f00de thanks to translators in 'about' dialog 2011-01-23 11:58:35 +00:00
David Sansome 795a4df422 Fix compilation on mac and windows 2011-01-22 14:13:56 +00:00
David Sansome 2ecf61a57e Move everything DBus related back to the main thread and use synchronous method calls everywhere 2011-01-22 12:47:19 +00:00
David Sansome 7880026767 Add some better error handling to the WMDM device lister if parts of WMP aren't installed 2011-01-22 11:29:47 +00:00
Arnaud Bienner c929db4637 Oops... 2011-01-20 23:55:22 +00:00
Arnaud Bienner 729e8e729d Adding track selection dialog for tag fetcher results. Also corrected tagfetcher to prevent from infinite loop when no result is found 2011-01-20 23:42:28 +00:00
David Sansome d32ec67b8a Add Keiran to the about dialog 2011-01-20 21:55:01 +00:00
David Sansome ee06d779f2 Fix a bug that would occasionally cause an extra track to be skipped when a track ended. Fixes issue #1233 2011-01-20 21:29:48 +00:00
Paweł Bara be5eb7a9fb smart playlists: 'on date' (equals for dates) operator was too precise (fixes issue #1174) 2011-01-20 18:55:28 +00:00
Paweł Bara 3b7ae72f82 smart playlists are incorrectly filtering ratings (fixes issue #1113) 2011-01-20 18:35:38 +00:00
Paweł Bara cc05ce55ca visual tweaks of edit tag dialog's summary tab 2011-01-20 17:29:04 +00:00
Paweł Bara 1c1d9551bb fixes issue #553 ('seek forward' and 'seek backward' hotkeys worked wrong) 2011-01-19 16:05:16 +00:00
Paweł Bara a575dac451 restoring CUE related files in playlist after Clementine's restart (fixes issue #68) 2011-01-19 15:36:40 +00:00
David Sansome 3f9dec3808 Add an "Install script from file..." button 2011-01-18 23:10:22 +00:00
John Maguire 4db998c0b6 Script for shutting down clementine at the end of the current playlist.
Fixes issue #271
2011-01-18 22:56:47 +00:00
David Sansome 046c75380c Merge translations from Launchpad 2011-01-18 19:07:54 +00:00
Paweł Bara 70952d94d8 I wonder how those Cisco routers are so good if people responsible for them are SLACKERS! 2011-01-18 17:20:42 +00:00
Paweł Bara e24e786a5d incorporating David's suggestions 2011-01-18 17:12:05 +00:00
Paweł Bara 07739d6c68 Python bindings for LibraryView + new UI hook for plugins: the view's context menu
support for IN operator in LibraryQuery.AddWhere
2011-01-18 16:34:43 +00:00
John Maguire 2c9964ffa9 zomg scripting support on Mac. 2011-01-18 14:02:51 +00:00
John Maguire b10422c575 Build fix for Gentoo.
Fixes issue #1314
Thanks Nickollai.
2011-01-18 13:54:32 +00:00
David Sansome 472ab04e97 Make libarchive optional, disable loading scripts from archives if it's not present. 2011-01-18 13:44:12 +00:00
Arnaud Bienner abb93cd020 Minor modification to tag fetcher (including adding mutex to prevent crashes) and changing cursor during tag fetching 2011-01-17 22:58:16 +00:00
Paweł Bara 3cfca9e926 fixes segfault introduced in last commit 2011-01-17 20:57:00 +00:00
David Sansome 35a61de0a4 Refactor ScriptInfo into another class, add some (currently unused) code to read scripts from archives. 2011-01-17 20:01:16 +00:00
Paweł Bara a883630ab3 duplicate remover script (fixes #21)
fix a scripting crash when one native object was registered more than once
veto mechanism for inserting songs into playlist
2011-01-16 23:46:58 +00:00
David Sansome b9b504be30 Fix a crash on exit when you have the Magnatune list open 2011-01-16 17:58:46 +00:00
John Maguire d7df24816c Fix mac build. 2011-01-16 17:26:25 +00:00
David Sansome 7e9452f48d Fix the mac and windows builds 2011-01-16 16:43:19 +00:00
David Sansome 5eb916cdff Watch script directories for changes 2011-01-16 15:11:23 +00:00
David Sansome 2c8e038b44 Make the Windows 7 thumbbar actually work. Move it to a different class that deals with QActions. Fixes issue #851 2011-01-16 00:39:51 +00:00
David Sansome da2ab82712 Be sure to translate strings in the edittagdialog 2011-01-15 21:13:43 +00:00
David Sansome f79c10f41e Add some buttons to the Windows 7 taskbar list. They don't do anything yet, but they sure look pretty! 2011-01-15 20:51:48 +00:00
Arnaud Bienner 55f212a713 Oops.. 2011-01-15 20:35:12 +00:00
Arnaud Bienner d53e74a91f Start auto tagging support (using MusicBrainz) 2011-01-15 20:00:39 +00:00
Paweł Bara ddd3f119d3 CUE songs are now properly updated in library - you can delete a CUE sheet, add it, you can change section markers in it etc. and everything should work as expected
Song now knows it's cue path (if any)
2011-01-15 18:46:23 +00:00
David Sansome 5c29a62b19 Convert QObject subclasses to clementine wrapped python types properly when calling python functions 2011-01-15 17:59:33 +00:00
David Sansome 839e81b674 Fix a segfault when unloading a script that has registered actions, but they are deleted during unload 2011-01-15 16:55:21 +00:00
David Sansome dd5f5d16ae Move the script console into a developer mode extension 2011-01-15 16:20:16 +00:00
David Sansome c6d724f53a Add Python bindings for PlaylistParser 2011-01-15 13:59:34 +00:00
David Sansome 1344103515 Add a workaround for broken XML entities in ASX playlists 2011-01-15 13:58:35 +00:00
David Sansome 32b599f70c Add python bindings for the NetworkManager, SongLoader and IconLoader. Add a workaround for a SIP assertion bug (assign_helper != ((void *)0)) that was fixed in 4.10.3: http://www.riverbankcomputing.com/hg/sip/rev/3e647ed0f2a2 2011-01-15 00:55:45 +00:00
David Sansome f49457b416 Never cache the RadioService pointer in a playlist item - the service could get unloaded at any time 2011-01-15 00:53:39 +00:00
David Sansome 765d4bb172 Don't set the User-Agent again in the Soma.fm service, it's already set by the network manager 2011-01-15 00:53:10 +00:00
John Maguire 883826a113 Tidy up the mac build a bit. 2011-01-14 14:16:56 +00:00
David Sansome 3954186af8 Maybe fix the mac build 2011-01-13 12:34:14 +00:00
David Sansome 4e0cf13b26 Add python bindings for RadioService, RadioModel, MergedProxyModel, TaskManager and SettingsDialog. Make sure radio services are removed from the model when they are deleted (eg. when their python script gets unloaded) 2011-01-12 21:20:20 +00:00
David Sansome 03e6231483 Make the RadioModel's AddService method public, add a RemoveService method, and clean up the last.fm mess 2011-01-12 20:18:17 +00:00
David Sansome 0ba1962fc8 Lazy-load the RadioService in a RadioPlaylistItem that is loaded from the database on startup 2011-01-12 19:59:17 +00:00
John Maguire 9249952b03 Only guess tag encoding for id3v1/2 tags. 2011-01-12 18:46:23 +00:00
Paweł Bara 4f7e804638 library: watcher now updates CUE associated songs + ignores the not-CUE-associated songs in a CUE sheet
CueParser: properly update length for the last song from every FILE in multifile CUE sheet
new 'playlist_path' argument in the 'Load' part of PlaylistParser's API
2011-01-11 23:09:59 +00:00
John Maguire bc573d55f1 Forgotten DBus file. 2011-01-11 20:55:17 +00:00
John Maguire 48bf42b2a5 Linux support for Zeroconf using Avahi over DBus. 2011-01-11 20:36:16 +00:00
David Sansome 135b32642e Refactor all the code that handles adding items to the playlist - whether it be by a context menu item, double clicking in a view or dragging. Everything now uses the models' mimeData() instead of duplicating the same code everywhere. 2011-01-10 22:26:13 +00:00
David Sansome 7ce5cfb5a1 Always create the connection to the dbus session bus in the main thread 2011-01-09 23:42:56 +00:00
David Sansome d922a75327 Add some more tracing to MPRIS registration on startup 2011-01-09 23:14:44 +00:00
David Sansome 380fa71e86 Do gnome global shortcut registration in a background thread 2011-01-09 23:11:51 +00:00
David Sansome 2d53db13c3 Fix the scroll direction in the pretty image view. Fixes issue #1226 2011-01-09 19:10:15 +00:00
David Sansome 7e3c0911ee Pass the dotted version number to qtsparkle instead of the display version 2011-01-09 19:05:54 +00:00
David Sansome dc619eb437 Start refactoring the RadioModel to inherit from QStandardItemModel 2011-01-09 18:27:41 +00:00
David Sansome 9c273aa745 Updated Polish translation from Michał Ziąbkowski 2011-01-08 16:17:11 +00:00
David Sansome b15398e90d Connect to the notification daemon in a background thread 2011-01-08 16:06:28 +00:00
David Sansome b3c211e26a Move MPRIS setup to a background thread 2011-01-08 15:31:14 +00:00
David Sansome 7a089faa29 Fix a crash that ocurrs when something calls GetCaps over dbus before the playlist is initialised, and when a repeat mode is set. 2011-01-07 19:16:45 +00:00
Paweł Bara 9f95909848 exterminating a deceiving parameter name 2011-01-06 21:53:50 +00:00
Paweł Bara 55683887c0 implemented Seeked signal for MPRIS 2 2011-01-06 21:08:11 +00:00
Paweł Bara 3372340f6b fixes the DesktopEntry() property of MPRIS 2 2011-01-06 19:29:54 +00:00
John Maguire 6cbf825c41 Make remote control support optional. 2011-01-06 16:00:40 +00:00
John Maguire c9d5b8100b More remote work. Clementine now requires QJson. 2011-01-06 15:09:09 +00:00
Paweł Bara d4d7f19fab better .cue spec conformity (allow many files in one sheet, use the SONGWRITER field as song's composer, ignore data files) 2011-01-05 20:23:53 +00:00
Paweł Bara bb79a68be0 some minor .cue related changes 2011-01-04 17:12:29 +00:00
John Maguire dfa5b9f8ea Fix building without last.fm. 2011-01-04 15:11:38 +00:00
John Maguire 3f923d2cb1 Add default parameters to MPRIS constructors. 2011-01-04 11:53:37 +00:00
John Maguire bde7902686 Refactor some initial setup out of MainWindow::MainWindow(). 2011-01-04 11:33:22 +00:00
Paweł Bara 59378166b4 finalized the support for loading .cue based media using 'files' tab or drag and drop from the system's file browser
use FILE's PERFORMER as albumartist
2011-01-03 23:36:10 +00:00
Paweł Bara 34d496aadc cleaner forced end-of-track when media stream is past it's 'end' marker 2011-01-03 18:03:15 +00:00
David Sansome 3a3cba3a85 Add bindings for Queue and PlaylistSequence 2011-01-03 15:49:41 +00:00
David Sansome e1b899bc61 Add python bindings for the library 2011-01-03 15:15:51 +00:00
David Sansome 0fba393f6e Fix the version numbering mess 2011-01-03 14:21:10 +00:00
David Sansome 156f4a51c5 Remove the extra clear button from the icecast filter bar 2011-01-03 14:20:41 +00:00
David Sansome d5321475cd Make the scroll wheel on the pretty image view scroll through images. 2011-01-02 19:17:03 +00:00
David Sansome d78ad452f2 Make the "No cover" image the same size as the cover art when showing cover art in the library. Thanks markwatkinson. Fixes issue #785. 2011-01-02 18:58:52 +00:00
Paweł Bara bbe97b00a2 make engine 'multiple-section songs' aware -> you should now be able to play your .cue related music 2011-01-02 18:53:45 +00:00
David Sansome bbe07cef44 Add a couple more menus for scripts to use 2011-01-02 18:52:24 +00:00
David Sansome 9da56fd916 Always compile basic scripting support 2011-01-02 18:44:45 +00:00
David Sansome 45caf3b6f4 Fix the windows build 2011-01-02 18:33:31 +00:00
David Sansome 385753ad4f Oops 2011-01-02 18:22:22 +00:00
David Sansome a79ca8c556 Let scripts register actions at predefined locations in the UI 2011-01-02 18:10:26 +00:00
David Sansome cfffa59b9b Initialise the scripts only after everything else has loaded 2011-01-02 16:17:36 +00:00
David Sansome fdc2ec2e73 Better (read: some) error handling when the clementine module can't be imported 2011-01-02 16:09:14 +00:00
David Sansome b2f22cf3a3 Add the extra sip dependencies as actual dependencies 2011-01-02 15:30:15 +00:00
David Sansome 43940de195 Add an option to show cover art in the library view. Thanks markwatkinson. Fixes issue #785 2011-01-02 14:51:01 +00:00
David Sansome a466cff48a Reload all settings from one function 2011-01-02 14:50:17 +00:00
David Sansome c80a4301cc Don't statically initialise the RadioModel's services map 2011-01-02 14:49:55 +00:00
David Sansome cdac0c6c86 Add python bindings for Playlist and PlaylistManager 2011-01-02 03:25:15 +00:00
David Sansome cfbbd3665c Show the script console tab in red if an error has occurred 2011-01-02 02:46:16 +00:00
David Sansome 5cadf923fc Unload scripts properly 2011-01-02 02:23:10 +00:00
David Sansome 7a7597500b Set __path__ properly so scripts can import other modules, and put all scripts in a namespace 2011-01-02 01:33:54 +00:00
David Sansome c8d8ef208d Don't create a separate interpreter for each script (it's not very well supported), instead create a module for each one. Redirect sys.stdout and sys.stderr to the clementine console. 2011-01-02 01:07:19 +00:00
David Sansome 11f4157f6f Let scripts show a settings dialog 2011-01-01 19:03:33 +00:00
David Sansome 2bbbda7714 Add buttons to the script manager to enable and disable scripts, and remember which ones were enabled and start them on startup 2011-01-01 18:37:08 +00:00
David Sansome dac0d071ea Add bindings for Song, PlaylistItem, PlaylistItemPtr and EngineBase, add a "player" attribute to the clementine module 2010-12-31 20:29:52 +00:00
David Sansome 5b1000834f Add some basic script loading support and add python bindings for the Player class 2010-12-31 18:13:28 +00:00
David Sansome 6ea9ea3b4d Add a linebreak to a tooltip 2010-12-30 18:26:13 +00:00
David Sansome 92b6c3a3ec Work around QTBUG-11620 (fixed in 4.7) that causes a crash when skipping through tracks with the Artist Info tab open. Fixes issue #935 2010-12-30 17:35:10 +00:00
David Sansome b578c61b36 Fix loading songs with non-ascii characters in the filename on Windows. Fixes issue #1207. Fixes issue #531. Fixes issue #813. 2010-12-30 17:13:11 +00:00
David Sansome 398f5d7f66 Use qtsparkle instead of winsparkle 2010-12-30 16:20:33 +00:00
John Maguire bc2eb6ad65 Fix release build. 2010-12-30 13:35:36 +00:00
John Maguire a44fef5028 Remove extraneous code. 2010-12-30 13:06:22 +00:00
John Maguire ce65c95580 Beginnings of remote control support. 2010-12-30 13:03:36 +00:00
David Sansome 45a7780f95 Add winsparkle support (doesn't work yet) 2010-12-29 17:53:28 +00:00
Paweł Bara 234465874c remember the track number when parsing .cue 2010-12-29 15:46:01 +00:00
David Sansome ca032eb445 Add an "Enqueue to playlist" menu item. Thanks bendarb. Fixes issue #980 2010-12-29 15:08:43 +00:00
David Sansome 9c03677143 Make the track slider popup a normal widget instead of a top-level window. Removes a lot of the complexity and fixes some bugs 2010-12-29 14:49:39 +00:00
David Sansome 5b4b4a98c7 Don't show the slider popup when the slider is disabled, and remove some window flags 2010-12-29 14:32:16 +00:00
David Sansome a9a8b849ca Add some safeguards to the merged proxy model against dereferencing child models that have been deleted 2010-12-28 23:21:56 +00:00
David Sansome d1d0236385 Make the "show full size" menu item in the now playing widget and edit tag dialog work with embedded covers 2010-12-28 22:20:54 +00:00
David Sansome d2fda6875f Pass wheel events through the track slider popup too 2010-12-28 21:04:55 +00:00
Paweł Bara da5f941333 consider .cues when scanning the library
persist the new 'beginning' marker of songs
fixed a bug where %allsongstables script would not update the attached databases
2010-12-28 15:36:01 +00:00
David Sansome 1362809b5d Make the library scanner use filter words for selecting cover art. Thanks markwatkinson. Fixes issue #634 2010-12-28 12:52:58 +00:00
David Sansome 6456665066 Cache the background pixmap, and add support for X without transparency 2010-12-27 19:37:36 +00:00
David Sansome 62e21d64f3 Make the track slider popup more accurate, make the text bold, make the shadow bigger but fade out towards the bottom, and make it close when the mouse leaves the area of the slider. 2010-12-27 19:23:12 +00:00
John Maguire 72da76a71a Fix track slider popup on Mac. 2010-12-27 17:41:59 +00:00
David Sansome fbbd4d4b27 Add a picker to the seek slider. Fixes issue #1050 2010-12-27 16:34:00 +00:00
David Sansome 97d7fe764a Download higher resolution images from last.fm. Thanks markwatkinson. Fixes issue #1187 2010-12-26 20:19:12 +00:00
David Sansome d08782b720 Don't automatically expand items in tree views when clicking them if a modifier key is pressed as well. 2010-12-26 18:07:57 +00:00
David Sansome 35242f740e Fix dbus 2010-12-26 17:24:44 +00:00
David Sansome b49fd1903d Add menu items to set the cover art to the context menu of the now playing widget. Fixes issue #906 2010-12-26 17:16:40 +00:00
David Sansome dc31a0be7e Make it possible to disable all lyric providers. 2010-12-26 15:06:11 +00:00
David Sansome fd00924f26 Fix parsing non-ascii filenames passed on the commandline (or through a file browser). Fixes issue #773. Fixes issue #752. 2010-12-26 14:54:46 +00:00
David Sansome e3a9bd7b26 Make DBUS bits optional on Linux. Thanks Nickollai. Fixes issue #1177 2010-12-26 13:38:35 +00:00
David Sansome 6737b8a5c2 Always use the gstreamer engine, remove xine, vlc and phonon engines. 2010-12-26 13:01:35 +00:00
David Sansome 41c42fe3a2 Fix compilation of the edit tag dialog when lastfm is compiled out 2010-12-26 12:42:47 +00:00
David Sansome b5942aa7d6 Fix network access on linux without a proxy 2010-12-26 12:03:10 +00:00
David Sansome e6561a0122 Fix a race condition on startup that might lead to two instances of Clementine being started. 2010-12-25 17:49:04 +00:00
David Sansome ae9ada254c Maybe fix build error 2010-12-25 17:41:18 +00:00
David Sansome 9b22f2ce40 Proxy support. Fixes issue #38 2010-12-25 17:25:29 +00:00
David Sansome eca62e037b Don't re-read song tags from files while loading a playlist if they're already avaiable in the library. Fixes issue #1165 2010-12-25 14:41:31 +00:00
David Sansome ced9a8b6e2 Test we can connect to udisks before connecting signals and reset the pointer of the interface. Thanks mail@holger-mense.de. 2010-12-25 14:25:05 +00:00
David Sansome 843cd92615 Increment play counts even if the song is shorter than 30 seconds. Fixes issue #1172 2010-12-25 13:37:45 +00:00
David Sansome 9b1765d1b0 The DeviceKit service not being around is not necessarily an error - it might get started automatically. Thanks mail@holger-mense.de. Fixes issue #1060 2010-12-25 13:23:25 +00:00
David Sansome 9b82ecbb72 Add tag completers for albumartist, composer and genre, and load completion models in background threads 2010-12-25 13:11:09 +00:00
David Sansome 8cdce2767b Implement the reset play counts button 2010-12-25 11:54:21 +00:00
David Sansome e21307e087 Non-const references put me on santa's naughty list 2010-12-25 00:43:55 +00:00
David Sansome c2bd0bbb05 Make the rating widget work 2010-12-25 00:33:53 +00:00
David Sansome 31005e5943 Update the cover art on other cached songs that would be changed anyway when changing cover art. 2010-12-25 00:15:05 +00:00
David Sansome 33b5bebb95 Add keyboard shortcuts for the previous and next song buttons 2010-12-24 23:35:34 +00:00
David Sansome b3450e9853 It's "edit track information", not "edit tracks information" in english 2010-12-24 23:29:13 +00:00
David Sansome f09aa34bb1 Edit tag dialog changes: remove the statistics tab and put its fields into the Summary tab, make right clicks on the album art do the same as clicking "change cover art", grey the field labels a bit, make sure large filenames don't make the dialog bigger. 2010-12-24 23:22:09 +00:00
Paweł Bara d7fe4600b8 an initial version of .cue sheets parser
initial support for multipart media files in Song ('beginning' and 'end' fields)
2010-12-23 21:13:43 +00:00
John Maguire cd4ecc1f8e Fix compiling with Sparkle support. 2010-12-22 15:41:30 +00:00
David Sansome 95ef57cf1e Add column text alignment options to the playlist header menu. Thanks brunciter! 2010-12-22 10:45:14 +00:00
John Maguire 2c0cd683db Typo in comment. 2010-12-21 15:49:17 +00:00
John Maguire 718be22d0d Automatically bump the max file descriptors for clementine to the maximum on Mac. 2010-12-21 15:48:30 +00:00
John Maguire 596b5471b1 Nicer fix for mac crash. 2010-12-21 14:55:42 +00:00
John Maguire a139d46114 "Fix" for mac crash. Somehow adding an eventFilter prevents the stack overflow.
Fixes issue #1109
2010-12-21 14:41:02 +00:00
David Sansome 8453e9e768 Make the edit tag dialog save tags, also make it load them in a background thread. 2010-12-21 13:42:06 +00:00
Arnaud Bienner ccd26b4002 Removing trackSkipped when stopping: even if Amarok wasn't acting like this, in my opinion, a 'stopped' track should not be considered as 'skipped' 2010-12-21 00:38:07 +00:00
Arnaud Bienner 3218e08118 Displaying different text depending on the number of selected songs 2010-12-21 00:20:36 +00:00
David Sansome d531d01f60 Fix Windows \\ paths when preloading files as well as when playing them initially. 2010-12-20 19:00:48 +00:00
David Sansome 998f9e1af5 Add next and previous buttons to the edit tag dialog 2010-12-20 16:36:16 +00:00
David Sansome 2a63a746fe Allow changing the cover art from the edit tag dialog 2010-12-20 15:46:38 +00:00
John Maguire 4e2d82f3fb Fix mac build. 2010-12-20 14:49:47 +00:00
David Sansome b0d4d72b42 Add some information to the summary and statistics tabs in the edit tags dialog. 2010-12-20 14:12:40 +00:00
David Sansome c8520021d7 Start of a new edit tag dialog. Lots of things don't work and it doesn't actually save tags yet (so it's about as useful as before). 2010-12-19 23:40:36 +00:00
David Sansome a97c23d173 Fix liblastfm detection. Protip: variables can't be used before they're set. 2010-12-19 15:10:26 +00:00
David Sansome 2d8028d89a Use a smaller cover in the tray icon tooltip again. Fixes issue #1135 2010-12-19 15:04:22 +00:00
David Sansome 8bc23a4d66 Keep hold of the generator object while updating the smart playlist preview. Fixes issue #1139 2010-12-19 14:37:25 +00:00
David Sansome a21320e635 Make the sidebar larger by default 2010-12-19 14:29:25 +00:00
David Sansome afdf02e37b Hide the score and comment columns by default 2010-12-19 14:27:07 +00:00
David Sansome eb61b67dd1 Oops, remove debug output 2010-12-19 14:22:47 +00:00
David Sansome a348a4529d Make the pretty OSD snap to the center of the screen while dragging. Thanks brunciter. 2010-12-19 14:06:51 +00:00
David Sansome 7fd29f160d Add a configurable timeout to song and artist info network requests. Default to 2.5 seconds 2010-12-19 13:58:53 +00:00
David Sansome a6445f2fe7 Don't strip off file extensions in the OSD. Fixes issue #1066 2010-12-18 20:40:35 +00:00
David Sansome 05a1bf6e37 Make the clear button a part of the search textbox. Fixes issue #1071 2010-12-18 20:32:05 +00:00
David Sansome 75fad2ff60 Blur the sidepanel again if it was resized while blurred. Also make it opaque to mouse events while blurred. Fixes issue #1092 2010-12-18 19:56:05 +00:00
David Sansome c133a8db7c Don't scale album art when saving it to /tmp. Fixes issue #1096 2010-12-18 19:42:06 +00:00
David Sansome 85d1f16c5e Fix a crash when removing the active playlist when it is the first playlist. Fixes issue #1097 2010-12-18 19:37:29 +00:00
David Sansome f1f0a384a5 Sort songs loaded from directories by filename if there are no other tags present. Fixes issue #1104 2010-12-18 18:47:44 +00:00
David Sansome a8a035a13a Use the system libechonest if it's installed 2010-12-18 18:36:56 +00:00
Paweł Bara 5b2625f420 fixes a crash when trying to rate the current song if there's none (rate using global shortcut) 2010-12-18 17:41:03 +00:00
David Sansome 302333c36a Fix r2420 properly 2010-12-18 17:29:07 +00:00
David Sansome 28fdb147d8 Make last.fm optional. Thanks volkov0aa. Fixes issue #49 2010-12-18 17:28:02 +00:00
David Sansome 623ab527ee Maybe fix a crash when loading tags from MP3 files with encrypted frames 2010-12-18 17:01:25 +00:00
David Sansome 6ec77eadf6 Fix a display bug in the Last played column for songs that haven't been played in the last week. Thanks gmail@robbertkrebbers.nl. Fixes issue #1081 2010-12-18 16:50:00 +00:00
Paweł Bara 5893c27d2b missing include failing on windows 2010-12-17 17:05:55 +00:00
Paweł Bara 32f9825794 global shortcuts for rating songs (Fixes issue #1089)
renaming *index* methods in Playlist to *row*
2010-12-17 00:21:20 +00:00
Arnaud Bienner 6ecc69d18b Also filter on artist name on Cover manager (instead of only album name) 2010-12-16 23:38:27 +00:00
Paweł Bara 256d46624c in 'Files' tab, use Backspace or 'Back' key to go up one folder (Fixes issue #1105) 2010-12-15 20:41:31 +00:00
Paweł Bara 61d5641c35 try to start the 'load cover' dialog in album cover manager inside the chosen album's folder (Fixes issue #733) 2010-12-15 20:15:46 +00:00
Paweł Bara 80e8fc8d60 corrections to "make sure a playlist column will appear in the UI even if it's width was somehow set to 0" 2010-12-15 17:46:31 +00:00
Paweł Bara 0f3b8156f3 make sure a playlist column will appear in the UI even if it's width was somehow set to 0 2010-12-15 16:32:45 +00:00
Paweł Bara 4563c2dbd9 you can now use "file path" attribute when creating dynamic playlists (Fixes issue #1073)
some more MPRIS 2 corrections (Updates issue #1058)
2010-12-15 15:50:22 +00:00
John Maguire 7f6f1888cf Maybe fix crash in song info. 2010-12-14 19:00:05 +00:00
John Maguire 6cb9bd5619 Fix failed to build on ARM. 2010-12-14 18:54:25 +00:00
John Maguire d82262c0c9 Just one more close shortcut and settings dialog width fix on mac. 2010-12-14 18:28:14 +00:00
John Maguire cf160d6ebb Add one more close shortcut... 2010-12-14 18:23:14 +00:00
John Maguire f95d893945 Add support for building without Sparkle on mac. 2010-12-14 18:20:14 +00:00
John Maguire b9e642c864 Add more close shortcuts. 2010-12-14 17:55:08 +00:00
John Maguire 74b745366b Add keyboard shortcut to close queue manager. 2010-12-14 17:43:03 +00:00
John Maguire 6257b29629 Add keyboard shortcut for album cover manager close. 2010-12-14 17:31:39 +00:00
John Maguire 769a78c6a2 UI tweaks for mac album cover manager. 2010-12-14 17:09:41 +00:00
John Maguire 21415ff230 Fix some mac ui and metadata bugs. 2010-12-14 15:00:46 +00:00
Paweł Bara 5082d81ba4 some corrections to MPRIS 2 (Updates issue #1058) 2010-12-12 23:20:41 +00:00
David Sansome c6829feb82 Show just the artist and title in the system tray tooltip on Windows since it doesn't support HTML 2010-12-11 17:23:05 +00:00
David Sansome 8bd0319966 Merge translations from Launchpad 2010-12-11 15:31:44 +00:00
David Sansome 19ea38b0a1 Don't download the Magnatune catalogue every time. 2010-12-11 15:07:39 +00:00
David Sansome b8a78abe06 Don't wrap text in the loading indicator. Fixes issue #1028 2010-12-11 15:01:01 +00:00
David Sansome d98859eabb Support rating multiple songs at once. Fixes issue #1017 2010-12-11 14:53:43 +00:00
John Maguire f28d67966a Fix flickr url for kittens. 2010-12-11 14:31:03 +00:00
David Sansome 23f2530f59 Prevent the last playlist column from being hidden, and check that at least one is visible on startup. Fixes issue #991 2010-12-11 14:26:49 +00:00
David Sansome 5e17e93360 Smarter adding/removing from various artists. Fixes issue #717 2010-12-11 14:17:07 +00:00
David Sansome 01cccc0468 Cache the last emitted state from the engine to fix some invalid values being emitted over DBUS while a last.fm stream is buffering. Fixes issue #374 2010-12-11 13:38:51 +00:00
David Sansome 2b77c894db Err... fix the ASX parser 2010-12-11 12:12:36 +00:00
David Sansome bb186feda1 Show scroll buttons on the sidebar when it's bigger than the window. Fixes issue #1061 2010-12-11 12:01:19 +00:00
David Sansome 0aa3cb4308 Don't expand items on a double click now that we expand them on single clicks instead 2010-12-11 11:26:47 +00:00
David Sansome a739ff2714 Fix playlist parser tests 2010-12-11 11:07:00 +00:00
David Sansome 67452baa4d Fix a crash when requesting an invalid playlist index over MPRIS. Fixes issue #1041 2010-12-11 10:58:15 +00:00
David Sansome 9a7087d05f Add a "delete from disk" to the playlist menu. Fixes issue #218 2010-12-11 10:54:42 +00:00
David Sansome 2986d185e3 Make clicking items in tree views toggle expanded/collapsed, rather than always expanding 2010-12-11 10:40:54 +00:00
David Sansome 08b2bcc816 Always write URLs in XML based playlists, instead of URLs of relative paths. Also load playlist items from the library if possible. Fixes issue #1054 2010-12-11 10:35:07 +00:00
David Sansome d5f8d2f9af Translations 2010-12-11 10:33:35 +00:00
David Sansome 7650c1eddc Remove "-session" from the commandline to fix session management on KDE. Fixes issue #769 2010-12-11 10:04:17 +00:00
David Sansome 292fdd3e7f Fix writing of album art paths when saving XSPF files 2010-12-11 09:31:39 +00:00
John Maguire 5f6dcbe4b7 Early Caturday! 2010-12-10 14:26:29 +00:00
Arnaud Bienner 6b35eea469 Moving emitTrackSkipped from Next to PlayAt, to handle cases where user doesn't use Next button to skip a track. Also emit TrackSkipped in Stop if track was not ended 2010-12-10 00:11:38 +00:00
Paweł Bara 49f46bced8 playlists now emit PlaylistChanged also when their ordering changes (Updates issue #374) 2010-12-09 20:43:06 +00:00
David Sansome fca0ce1188 Use the current playlist, not the active playlist, when rating songs. Fixes issue #1047 2010-12-09 20:15:44 +00:00
David Sansome 47c13c4479 Listen for keyPressEvent instead of keyReleaseEvent in the library view. Thanks arnaud.bienner. Fixes issue #1042 2010-12-09 14:33:20 +00:00
John Maguire 81f43ac4f5 Unbreak the build. 2010-12-09 14:19:09 +00:00
John Maguire 4c66007e26 Code review comments from r2370. 2010-12-09 13:06:00 +00:00
John Maguire 3a19bb9d46 Fix config file location on Mac and automatically migrate. 2010-12-09 12:34:08 +00:00
Paweł Bara 04bbf73cff MPRIS' TracklistChanged event now contains the length of the playlist that has actually changed (Update issue #374)
the PlaylistChanged event now shows which playlist has changed
2010-12-08 00:09:17 +00:00
Paweł Bara 6bf3162449 some MPRIS 1 bugfixes (Updates issue #374)
also:
- PlaylistSequence: RepeatMode and ShuffleMode are changed before change event is emitted
- PlaylistManager: emits an event after it has been initialized (which, for example, indicates that it's PlaylistSequence is now in place)
2010-12-07 21:14:40 +00:00
David Sansome 579e24965a Make single clicking on an item in a library view expand it. Fixes issue #1027 2010-12-07 21:13:40 +00:00
David Sansome d761a5e91f Add a "plain sidebar" option. Fixes issue #1031 2010-12-07 21:04:52 +00:00
David Sansome 44dc05a87a Don't stop the track when it's about to end if crossfading is enabled but fadeout is disabled. Fixes issue #1040 2010-12-07 20:29:13 +00:00
David Sansome bbf0cd48c2 Insert songs as library playlist items if they're in the library. Fixes issue #1039 2010-12-07 19:33:19 +00:00