Commit Graph

8269 Commits

Author SHA1 Message Date
Lukas Prediger 6b03b8f5d1 CddaSongLoader now emits a Finished signal if no further updates will follow for the same disc read. 2021-09-21 10:53:43 +01:00
Lukas Prediger 90ec6f6a24 CddaSongLoader now reads CD-Text for metadata
currently this gets overwritten by musicbrainz response almost immediately, though
2021-09-21 10:53:43 +01:00
Clementine Buildbot b020171da7 Automatic merge of translations from Transifex 2021-09-21 02:44:04 +00:00
Clementine Buildbot c969bf9783 Automatic merge of translations from Transifex 2021-09-20 02:44:43 +00:00
Jim Broadus 082f941bb9 build: Fix translations
transifex-client indirectly requires Unidecode>=0.04.16. As of version
1.3.2, Unidecode no longer supports Python 2. Its setup shebang points
to /usr/bin/python, which it assumes is python3. To correct the issue,
install pip3 instead of pip, avoiding the installation of Python 2.
2021-09-19 15:28:40 +01:00
Tom Kranz cd72cf3390 Use XSPF image elements as manually set artwork 2021-09-18 23:52:37 +01:00
Jim Broadus ba29b0e3ba build: Add Debian Bullseye.
Reference: https://www.debian.org/releases/bullseye/
2021-09-12 00:31:48 +01:00
Daniel Perelman ab6a480131 Apply reformatting from lint. 2021-09-07 18:04:38 +01:00
Daniel Perelman f548884f57 Correct time computation for seekbar tooltip. 2021-09-07 18:04:38 +01:00
Clementine Buildbot 1535e78aa0 Automatic merge of translations from Transifex 2021-09-06 02:44:55 +00:00
Clementine Buildbot 2cca75d930 Automatic merge of translations from Transifex 2021-09-05 02:43:23 +00:00
Lukas Prediger e556a59aea RipCDDialog: Changing metadata edits now updates filename preview 2021-09-04 15:24:44 +01:00
Lukas Prediger e187a68e9f MusicBrainzClient fix: Don't try to read reply on connection timeout
that previously resulted in an IO error
2021-09-04 15:24:44 +01:00
Clementine Buildbot c58335c6c9 Automatic merge of translations from Transifex 2021-09-04 02:44:48 +00:00
Clementine Buildbot 769d8bbe6d Automatic merge of translations from Transifex 2021-09-03 02:43:09 +00:00
Clementine Buildbot 3b7d5880f9 Automatic merge of translations from Transifex 2021-09-02 02:42:38 +00:00
Clementine Buildbot 7eb62b6266 Automatic merge of translations from Transifex 2021-09-01 02:44:42 +00:00
Ismael Luceno 628ff65828 logging: Add proper backtrace support detection
The Q_OS_UNIX macro is inappropriate because many UNIX-like platforms may
lack backtrace support in the libc. E.g.: Darwin / Mac OS X, Musl libc,
OpenBSD, OpenIndiana.
2021-08-31 11:15:55 +01:00
Lukas Prediger c8c110efaf Fix: RipCDDialog now correctly loads and stores chosen transcoder preset 2021-08-31 10:19:32 +01:00
Lukas Prediger a72e252ec6 RipCDDialog: Added file name preview 2021-08-31 10:19:32 +01:00
Lukas Prediger b0704331d7 Integrate file name format options into RipCDDialog
for consistency with OrganiseDialog and reducing code duplication
2021-08-31 10:19:32 +01:00
Lukas Prediger 5c8ca3754f Added overwrite_existing argument to Transcoder::AddJob 2021-08-31 10:19:32 +01:00
Lukas Prediger 83d961f808 Transcoder: create output paths if they do not already exist 2021-08-31 10:19:32 +01:00
Lukas Prediger a6fef97cac Separating out filename formatting options into separate widget.
First step towards unifying filename formatting over different dialogs.
2021-08-31 10:19:32 +01:00
Clementine Buildbot 922afe506f Automatic merge of translations from Transifex 2021-08-27 02:44:07 +00:00
Ismael Luceno 8682d4de48 Fix sentinels in variadic function calls
Replace sentinel NULL with nullptr, guaranteed to be correctly expanded.

NULL may be defined as plain 0 in C++; which may lead to undefined upper
bits passed in variadic function arguments, causing crashes.

See: https://ewontfix.com/11/
2021-08-23 21:33:46 +01:00
Clementine Buildbot 03e13c69e7 Automatic merge of translations from Transifex 2021-08-17 02:42:46 +00:00
Clementine Buildbot 327d5fdac3 Automatic merge of translations from Transifex 2021-08-13 02:42:58 +00:00
Clementine Buildbot b55e54388f Automatic merge of translations from Transifex 2021-08-11 02:43:14 +00:00
Clementine Buildbot cddc08e148 Automatic merge of translations from Transifex 2021-08-09 02:42:51 +00:00
Clementine Buildbot bf424ce986 Automatic merge of translations from Transifex 2021-08-01 02:46:18 +00:00
Clementine Buildbot e2d6759d55 Automatic merge of translations from Transifex 2021-07-27 02:45:37 +00:00
Jim Broadus 102317e5c8 internet/podcasts: Fix crash when updating podcasts.
When a podcast is updated and the number of visible items is set in the
podcast settings, child items that disappear from the view, and are
deleted, are still referenced by the database id map.

Move the removal code from SubscriptionRemoved to a common method and
use that for this case.
2021-07-26 12:36:24 +01:00
Clementine Buildbot ac3a0d33f7 Automatic merge of translations from Transifex 2021-07-26 02:45:57 +00:00
Robin Lee 224c475b50 Rename multiple files to match the application ID
The desktop entry file, appdata file and installed icons are renamed to
match the application ID for the benefit of Flatpak packaging.
2021-07-20 11:21:05 +01:00
Clementine Buildbot dbe15e5e9f Automatic merge of translations from Transifex 2021-07-20 02:45:18 +00:00
Clementine Buildbot c0c9037677 Automatic merge of translations from Transifex 2021-07-19 02:44:08 +00:00
kentsangkm 6982b47819 Search song from Spotify via web api 2021-07-18 10:45:10 +01:00
Clementine Buildbot 98dd3e48a6 Automatic merge of translations from Transifex 2021-07-17 02:45:02 +00:00
Clementine Buildbot 1e39ce29a4 Automatic merge of translations from Transifex 2021-07-15 02:43:57 +00:00
Jonas Kvinge daa2f25e3c Replace Q_ENUMS with Q_ENUM
Q_ENUMS is obsolete. See: https://doc.qt.io/qt-5/qobject-obsolete.html
The replacement is Q_ENUM which was introduced in Qt 5.5, and Clementine
requires Qt 5.6.
2021-07-14 10:19:28 +01:00
Jonas Kvinge f379ad84d4 Fix use of emit
Adds missing emits.

QTreeView::collapse and QTreeView::expand are slots, not signals. So
remove emit.
2021-07-14 10:18:47 +01:00
Jonas Kvinge 1d1d3b157f Add *.kdev4 to .gitignore 2021-07-14 10:18:25 +01:00
Jonas Kvinge 320a1b81c9 Fix incorrect use of QFutureWatcher
To avoid a race condition, it is important to call setFuture() after doing the connections.

See: https://doc.qt.io/qt-6/qfuturewatcher.html
2021-07-14 10:18:15 +01:00
Jonas Kvinge 0c1b6a2a44 Fix setting task blocking library scans
TaskManager::SetTaskBlocksLibraryScans() takes the ID of the task.
2021-07-14 10:18:01 +01:00
Jonas Kvinge 598e660aeb Unref bus in SongLoader::LoadRemote()
See: https://developer.gnome.org/gstreamer/stable/GstPipeline.html#gst-pipeline-get-bus
2021-07-14 10:17:50 +01:00
Jonas Kvinge 4d34748401 Fix memory leak in global search context menu 2021-07-14 10:17:35 +01:00
Clementine Buildbot b3b769f0e7 Automatic merge of translations from Transifex 2021-07-14 02:43:05 +00:00
Clementine Buildbot 2902a8786e Automatic merge of translations from Transifex 2021-07-12 02:43:07 +00:00
Clementine Buildbot 4acfdae740 Automatic merge of translations from Transifex 2021-07-09 02:43:48 +00:00