Commit Graph

4061 Commits

Author SHA1 Message Date
Andreas 42d9a86ff0 Calculate chunkcount with the real file size, not the size saved in the database (might be wrong and results in corrupted download). 2013-11-29 13:59:48 +01:00
Clementine Buildbot d04b4a602e Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2013-11-27 12:11:07 +01:00
Arnaud Bienner 4a1d3e2de6 Disable inline editing with 'SelectedClicked'. Still available using F2. Fixes 3251 (once again). 2013-11-22 21:55:46 +01:00
Arnaud Bienner 3715e5f15e Revert revision 316b5d7db4 and revision e7a5c482fe (aka re-enable inline editing) 2013-11-22 20:59:31 +01:00
Arnaud Bienner 503b8445ad Remove debug message 2013-11-22 20:52:14 +01:00
John Maguire 4c23072bef Link dynamically against sqlite3 but still use a copy of QSqlLiteDriver 2013-11-22 16:31:41 +00:00
Aggelos Biboudis 2647fe4bbc Emit MPRIS notification when we add or remove a playlist.
Fixes issue 3962.
2013-11-19 00:13:45 +01:00
Clementine Buildbot 6e3a456046 Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2013-11-18 10:02:12 +01:00
Arnaud Bienner 316b5d7db4 (Add a comment to explain why I removed this) 2013-11-17 19:42:06 +01:00
Arnaud Bienner e7a5c482fe Don't allow tag inline editing anymore.
This was a pretty good idea, but now we have a dedicated tag dialog editor, I'm not sure it is very useful. It was probably faster to edit tags this way, but I'm afraid lot of people may inadvertently modify their tags because of this. Still allow inline editing of score and comment, because they sound less critical to me.
Fixes issue 3251.
2013-11-17 19:00:44 +01:00
Arnaud Bienner 51d9080a81 Update issue 3962: don't try to activate a playlist which doesn't exist/isn't opened anymore (otherwise we crash on Q_ASSERT) 2013-11-16 19:53:02 +01:00
Clementine Buildbot e929b4f466 Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2013-11-11 10:02:21 +01:00
John Maguire 95330a3d7c Deal more gracefully with a device's library not having any directories on second mount.
Fixes issue #3940
2013-11-04 18:44:07 +01:00
Clementine Buildbot a6f4affc10 Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2013-11-04 10:01:55 +01:00
John Maguire a872fa3828 Redirect box login via SSL appengine page.
Apparently that's more secure than just redirecting to localhost :-S
Fixes issue #3936
2013-11-01 12:15:21 +01:00
Andreas 7470f67acf - Fix remove songs from playlist in network remote.
- Update protocol buffer version.
2013-10-31 19:52:02 +01:00
Andreas 10369cdbbb revert last commit. 2013-10-30 22:36:44 +01:00
Andreas 9bc605dc58 Try to fix the config path in windows. 2013-10-30 22:27:08 +01:00
John Maguire 981bbdce72 D'oh 2013-10-28 17:39:18 +01:00
John Maguire b08898bf2d Add workaround for weird font issue in 10.9. 2013-10-28 17:12:23 +01:00
Clementine Buildbot 55be260750 Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2013-10-28 10:01:41 +01:00
Andreas afae01156d Merge branch 'portable' 2013-10-26 09:34:07 +02:00
Andreas f6ab3a9044 Fix library download in network remote. 2013-10-25 20:31:56 +02:00
David Sansome b34da7cb00 Merge branch 'release-1.2'
Conflicts:
	src/translations/ca.po
	src/translations/fi.po
	src/translations/fr.po
	src/translations/pl.po
	src/translations/pt.po
	src/translations/ru.po
	src/translations/tr.po
2013-10-25 19:02:06 +11:00
Clementine Buildbot 5306c290aa Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2013-10-21 10:01:54 +02:00
Clementine Buildbot e737e7467f Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2013-10-14 10:01:50 +02:00
Andreas 8b8d3e2849 Rearrange main.cpp, so no GetConfigPath() is called before instanciating QApplication and CheckPortable(). 2013-10-10 18:36:12 +02:00
Andreas 4584b50d18 Fix wrong networkcache dir. 2013-10-10 10:00:57 +02:00
Andreas 9d0b1611c7 Fix crash when fetching lyrics with the network remote.
(cherry picked from commit 90c8929f96)
2013-10-09 19:43:28 +02:00
Andreas 72c10d42f4 Fix crash when fetching lyrics with the network remote.
(cherry picked from commit 90c8929f96)
2013-10-09 19:36:22 +02:00
Andreas 90c8929f96 Fix crash when fetching lyrics with the network remote. 2013-10-09 19:33:59 +02:00
Clementine Buildbot 8e39e70c39 Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2013-10-07 10:01:28 +02:00
Andreas 77ac74c3f5 Merge branch 'release-1.2' into portable 2013-10-05 12:03:57 +02:00
Arnaud Bienner cdd5bf928c Check playlist exists in manager. Fixes issue 3878
(cherry picked from commit 2e18b7eb96)
2013-10-03 20:45:12 +02:00
Arnaud Bienner ce117da026 Don't ignore Folder (so we don't ignore playlists they contain and we don't end up with dangling pointers in playlists_by_id_)
(cherry picked from commit fb78321c16)
2013-10-03 20:45:01 +02:00
Arnaud Bienner 2e18b7eb96 Check playlist exists in manager. Fixes issue 3878 2013-10-03 20:36:46 +02:00
Andreas 98dd001a4f Further work on portable version. 2013-10-03 17:08:42 +02:00
Arnaud Bienner fb78321c16 Don't ignore Folder (so we don't ignore playlists they contain and we don't end up with dangling pointers in playlists_by_id_) 2013-10-02 22:58:47 +02:00
Andreas acb18cdcde First tries on a portable version. 2013-09-29 10:43:34 +02:00
Clementine Buildbot 88bb606082 Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2013-09-23 10:01:31 +02:00
Andreas fc78a78afc - Send songrating to client.
- Receive songrating as float (like saved in Song).
- On RemoteClient destructor check if socket is still connected before calling waitForDisconnect()
(cherry picked from commit 9237356e33)
2013-09-22 12:10:18 +02:00
Andreas 9237356e33 - Send songrating to client.
- Receive songrating as float (like saved in Song).
- On RemoteClient destructor check if socket is still connected before calling waitForDisconnect()
2013-09-22 12:06:19 +02:00
Arnaud Bienner d7d7df7646 Manually fix a bad pt translation. Fixes issue 3857 for 1.2 2013-09-18 21:28:00 +02:00
David Sansome 65b8e147ed Make the Spotify downloader optional again on Windows and Mac
(cherry picked from commit 4e8dba16d4)
2013-09-18 01:25:02 +02:00
David Sansome 96a8c5a9fe Make the GPL spotify code non-optional
(cherry picked from commit 2c55688601)
2013-09-18 01:24:49 +02:00
David Sansome 1efd88cc2a Create a Fatal logging level, and use it when sqlite symbols can't be resolved.
(cherry picked from commit f0b9120c43)
2013-09-18 01:24:36 +02:00
David Sansome 4e8dba16d4 Make the Spotify downloader optional again on Windows and Mac 2013-09-18 01:27:13 +10:00
David Sansome 2c55688601 Make the GPL spotify code non-optional 2013-09-18 00:49:29 +10:00
David Sansome f0b9120c43 Create a Fatal logging level, and use it when sqlite symbols can't be resolved. 2013-09-18 00:15:46 +10:00
Clementine Buildbot 8d8b1a70f2 Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer)
(cherry picked from commit 611731ed4a)
2013-09-16 11:43:55 +02:00
Clementine Buildbot 611731ed4a Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2013-09-16 11:41:24 +02:00
Arnaud Bienner 1780b8192d Update Flickr API Key for Kittens
(cherry picked from commit 02e51dad2f)
2013-09-12 00:00:03 +02:00
Arnaud Bienner 696f6a81b9 Hide the console for now as it's not useful for end users. Fixes issue 3853.
(cherry picked from commit daee19e076)
2013-09-11 23:59:56 +02:00
Arnaud Bienner 02e51dad2f Update Flickr API Key for Kittens 2013-09-11 23:54:41 +02:00
Arnaud Bienner daee19e076 Hide the console for now as it's not useful for end users. Fixes issue 3853. 2013-09-11 23:17:00 +02:00
Clementine Buildbot 3437cbf052 Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer)
(cherry picked from commit 954b897ebe)
2013-09-10 13:07:27 +02:00
Clementine Buildbot 954b897ebe Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2013-09-09 10:02:29 +02:00
Arnaud Bienner 1fc573a3eb Revert "Update issue 3682: deactivate moodbar generation for wma files on Windows until we find a proper way to fix this issue."
This is not needed anymore now issue 3682 is fixed.

This reverts commit c9be07f508.
(cherry picked from commit d3295f083b)
2013-09-07 19:58:17 +02:00
Glad Olus efc5f31d9b Use short locale format in playlist view.
Fixes issue #1451
(cherry picked from commit f8efbd81e4)
2013-09-07 19:58:10 +02:00
Arnaud Bienner d3295f083b Revert "Update issue 3682: deactivate moodbar generation for wma files on Windows until we find a proper way to fix this issue."
This is not needed anymore now issue 3682 is fixed.

This reverts commit c9be07f508.
2013-09-07 00:23:56 +02:00
Glad Olus f8efbd81e4 Use short locale format in playlist view.
Fixes issue #1451
2013-08-29 16:31:29 +02:00
Arnaud Bienner 0c401b6de9 Update issue 3682: deactivate moodbar generation for wma files on Windows until we find a proper way to fix this issue.
(cherry picked from commit c9be07f508)
2013-08-28 23:11:39 +02:00
Arnaud Bienner e0c63674f8 Increase GS album search limit from 5 to 10. Also, use a constant instead.
(cherry picked from commit d8e2fa5b1c)
2013-08-28 23:11:32 +02:00
Arnaud Bienner c9be07f508 Update issue 3682: deactivate moodbar generation for wma files on Windows until we find a proper way to fix this issue. 2013-08-28 22:55:59 +02:00
Arnaud Bienner d8e2fa5b1c Increase GS album search limit from 5 to 10. Also, use a constant instead. 2013-08-28 22:20:58 +02:00
Mateusz Kowalczyk 32ffc73d68 Don't ask about closing the playlist if it's empty
Fixes issue 3827.
2013-08-28 21:45:24 +02:00
Mateusz Kowalczyk aa347d0a57 Don't ask about closing the playlist if it's empty
Fixes issue 3827.
2013-08-28 21:38:17 +02:00
Clementine Buildbot a95c536cc8 Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer)
(cherry picked from commit dc25bdd282)
2013-08-26 11:56:05 +02:00
Clementine Buildbot dc25bdd282 Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2013-08-26 10:01:59 +02:00
Andreas 3210d016d6 Wait until socket is closed before destroying RemoteClient object. Otherwise the disconnect message is not sent.
(cherry picked from commit 6a61f8598d)
2013-08-24 21:29:04 +02:00
Andreas b6dd3f9a01 Fix divide by zero error in MoodbarRenderer. Fixes issue 3823.
(cherry picked from commit bd528a47cd)
2013-08-24 21:28:39 +02:00
Andreas 6a61f8598d Wait until socket is closed before destroying RemoteClient object. Otherwise the disconnect message is not sent. 2013-08-24 21:24:01 +02:00
Andreas bd528a47cd Fix divide by zero error in MoodbarRenderer. Fixes issue 3823. 2013-08-24 21:07:44 +02:00
Andreas 23aff7c890 Use qBound() instead of multiple ifs.
(cherry picked from commit 5fc6804326)
2013-08-20 11:09:19 +02:00
Andreas 5fc6804326 Use qBound() instead of multiple ifs. 2013-08-20 11:07:58 +02:00
Clementine Buildbot 2d921dbe47 Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer)
(cherry picked from commit e8b43eac1d)
2013-08-19 21:02:01 +10:00
Clementine Buildbot e8b43eac1d Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2013-08-19 10:02:08 +02:00
David Sansome 4b0a7ae70b Oops, make that actually compile 2013-08-18 13:07:32 +10:00
David Sansome 534f216de2 Ensure we don't read past the end of the color vector when rendering a moodbar.
Fixes issue 3811.
2013-08-18 13:05:12 +10:00
Andreas 2c0b505b7b Append playlist id to new playlists. 2013-08-17 15:54:39 +02:00
Andreas 1254d025ab Include rate song feature in network remote. 2013-08-15 20:52:12 +02:00
Clementine Buildbot 9987b3f9a9 Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2013-08-12 10:01:57 +02:00
Andreas 9e322adfd4 Track position timer was not started when a client connects and Clementine is playing a track. 2013-08-11 21:46:29 +02:00
Arnaud Bienner 379b8743f9 Force the position of the checkbox for the confirmation prompt (looked bad on Windows) + update an old, not up to date comment 2013-08-11 16:36:28 +02:00
Arnaud Bienner 9f38f14fbf Don't really need the QObject:: here 2013-08-10 21:46:17 +02:00
Arnaud Bienner e3c5f3398c Add a "don't prompt me again" checkbox to the "warn_close_playlist" message box 2013-08-10 20:18:29 +02:00
Clementine Buildbot 0ff0c30619 Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2013-08-05 10:02:10 +02:00
Andreas 53b8f59e6f Try to fix Windows build. 2013-08-01 19:13:43 +02:00
Andreas 3a309e9b25 Added message to retrive the library (table songs). 2013-08-01 18:13:14 +02:00
Andreas 662b635d96 - Do not send cover arts on file download chunks.
- Set the version in the send function, not in each function that creates a protocol buffer message.
2013-08-01 10:52:01 +02:00
Andreas 4fe293b6d0 The insert and remove signal for a playlist was not correct. 2013-07-31 19:06:29 +02:00
Andreas e8f9d856b6 Open the server socket without proxy. 2013-07-31 17:28:11 +02:00
Clementine Buildbot 7358a70170 Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2013-07-29 10:02:02 +02:00
Arnaud Bienner 00a0e990fd Correct typo 2013-07-28 15:37:02 +02:00
Arnaud Bienner f75c0a2b97 Add an option for not being asked before closing a playlist 2013-07-27 19:59:15 +02:00
Arnaud Bienner fc1880161c Add a 'language_without_region' as this is not specific to networkremotesettingpage 2013-07-27 19:23:55 +02:00
Arnaud Bienner 9bf5690671 Use mouseReleaseEvent instead of mousePressEvent
Now, tabbar's mouseReleaseEvent will not be executed if we did something. This prevents middle-click to unstar a playlist, then remove it, with the same click.
Should prevent users to accidentaly loose their playlists.
2013-07-27 19:17:09 +02:00
Andreas 0785214949 - Do not offer streams to download clients.
- Move Google Play logo and qr code to the middle of the settings screen.
2013-07-27 14:13:02 +02:00
Vasily Fomin b1c488ffea Make wheel events on the analyzer change the volume. Fixes issue 3761 2013-07-27 16:13:07 +10:00
David Sansome b31c646090 Make the Ubuntu One settings page a bit more sane 2013-07-27 16:09:36 +10:00
David Sansome 1a3f6af1bd Clean up the network remote settings page, add a "Get it on Google Play" button. 2013-07-27 15:27:08 +10:00
Andreas cf1dfe0d58 Clementine will offer a song before download first. The client can deceide if it want to download it or not. Only when the client accepted the file, Clementine sends it. 2013-07-23 16:59:50 +02:00
Clementine Buildbot 66df83fa84 Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2013-07-22 10:02:02 +02:00
Andreas 1e4819f2df Add stop after current track feature to network remote. 2013-07-20 19:38:37 +02:00
John Maguire f166954495 Add Google cpplint & lint one class 2013-07-19 15:38:22 +02:00
Andreas 7238916359 Some code style improvements. 2013-07-19 14:41:49 +02:00
Andreas b4cf8280c3 - DownloadItem has a constructor now.
- Use QQueue instead of QQueue* for download_queue_.
- Code cleanup.
2013-07-19 14:16:32 +02:00
Andreas d1da0159e2 - Check if Queue is empty before sending next song.
- Changed the way the queue is deleted after client disconnects.
2013-07-18 12:14:00 +02:00
Andreas 66eff922d8 Delete download queue entry only if it contains the client. 2013-07-18 11:39:52 +02:00
Andreas 3dff73965e Merge branch 'master' of https://code.google.com/p/clementine-player 2013-07-18 11:37:32 +02:00
Andreas f67083c92e Network remote: Each song will be send after client confirms that the previous track was received. Saves a lot of memory especially when sendings lossless files. 2013-07-18 11:28:53 +02:00
Arnaud Bienner b53e58d407 Ask user for confirmation before closing a non-favorite playlist, as it will be deleted. Don't ask if middle-clicked 2013-07-18 00:37:31 +02:00
Andreas 4406992554 Oops. 2013-07-16 22:17:25 +02:00
Andreas 01084de461 Fix memory leak when a client downloads tracks. 2013-07-16 22:16:05 +02:00
Andreas 8ac665f372 Merge branch 'master' of https://code.google.com/p/clementine-player 2013-07-16 17:48:41 +02:00
Andreas 6c19acdf48 Memory optimization in network remote. 2013-07-16 17:47:49 +02:00
Clementine Buildbot 7505f2321b Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2013-07-15 11:09:05 +02:00
Andreas 150345f2a6 Fix build error with QT < 4.7 2013-07-12 13:27:52 +02:00
Andreas 25b3dc8b09 Remove unnecessary parameter and comment. 2013-07-12 12:41:45 +02:00
Andreas c09d77f413 Network remote can now send songs to clients. 2013-07-12 12:31:27 +02:00
John Maguire cd85b67ebc Make code signing a separate target. 2013-07-10 20:19:28 +02:00
Andreas 6b92048c15 Code cleanup. 2013-07-10 20:00:52 +02:00
John Maguire f4f9b70f8d Another attempt at getting CMake to escape the Apple developer id correctly. 2013-07-10 18:59:39 +02:00
John Maguire da5c338b53 Escape apple developer id properly. 2013-07-10 17:25:23 +02:00
Andreas c413beda8f Only send lyrics from active providers. 2013-07-10 13:51:18 +02:00
Andreas 9e0b877e5a The network remote can now send lyrics to clients. 2013-07-10 13:24:23 +02:00
John Maguire a650ac91bd Don't probe stupid printers on OS X. 2013-07-09 12:03:01 +02:00
Clementine Buildbot a2e8e2931b Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2013-07-08 10:01:49 +02:00
Ross Wolfson 27c017626b Allow Subsonic to follow redirects when logging in, as described in issue 3747
Fixes issue #3747
2013-07-03 11:45:44 +02:00
Clementine Buildbot 106e9a5dbd Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2013-07-01 10:01:43 +02:00
Andreas 9ff9050d9c Select files to transcode directly from a playlist. 2013-06-30 16:54:13 +02:00
David Sansome eb20fb5945 Remove all the soruce for WMDM devices. Fixes issue 3748 2013-06-30 08:25:12 +00:00
Arnaud Bienner f245f7ed82 Add a playlistlist view with a helper text 2013-06-29 18:05:03 +02:00
Arnaud Bienner 77d80fc60b Add a playlistlist view with a helper text 2013-06-29 18:05:00 +02:00
Arnaud Bienner a5e6c3273c Delete a playlist when unstaring it from the left 'Playlists' panel and when it's not opened 2013-06-29 16:16:52 +02:00
Arnaud Bienner cee18eebb2 Add a tooltip to the favorite widget 2013-06-29 16:12:53 +02:00
Ross Wolfson c1d37896a4 Add disc number functionality to SubSonic
Fixes issue #3743
2013-06-18 12:09:54 +02:00
Clementine Buildbot c7bbf97558 Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2013-06-17 10:01:45 +02:00
Ross Wolfson a8117c31f0 Fix to prevent spinning status wheel if incomplete Subsonic credentials are supplied
Fixes issue #3733
2013-06-12 14:04:39 +02:00
Clementine Buildbot 2e614a3d60 Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2013-06-10 10:01:34 +02:00
Andreas ecd94cf472 Oops. 2013-06-09 16:41:02 +02:00
Andreas a6a8997a2e Use QDir::toNativeSeparators instead of QString::replace. Add QProcess include for windows build. 2013-06-09 16:29:40 +02:00
Andreas d16ac382ef Highlight the opened file in Windows Explorer. Fixes issue 3695. 2013-06-09 15:52:47 +02:00
David Sansome 246e0808d2 Emit EOS when the buffer timestamps go backwards, as well as when a DISCONT buffer arrives. Fixes issue 3721. 2013-06-08 14:31:29 +10:00
David Sansome e7dcac4f15 When transitioning to a preloaded song, emit the EOS event at the time the
audio actually changes to the next song instead of when the src changes songs.

Fixes issue 3716
2013-06-04 22:17:44 +10:00
John Maguire 07e7950f7e Remove obsolete ClearScopeBuffers() reference. 2013-06-03 18:14:20 +02:00
Clementine Buildbot c5c07b3085 Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2013-06-03 10:01:43 +02:00
Andreas 20e1f1b3d6 Rescale album art when heigt is greater than 1000px, too. 2013-06-01 13:52:39 +02:00
David Sansome 1a4e4ba86f Fix a compilation error on an old GCC 2013-06-01 18:50:25 +10:00
David Sansome 619261f5e1 Remove the precise analyzer timing code from Amarok and instead just use the
latest buffer from GStreamer.  This works just as well and fixes the occasional
freezing analyzer.  Fixes issue 2464
2013-06-01 18:03:59 +10:00