Commit Graph

4598 Commits

Author SHA1 Message Date
Mark Furneaux 663b7430d8 Add new analyzer "Rainbow Dash"
As requested in SuperUltraCriticalShowstopper request #2685
I have built an analyzer based on Rainbow Dash
...oh god, what have I done...

This will either make some people happy, or is absolute garbage.
2014-05-22 10:33:21 -04:00
Mattias Andersson 4569bd9f2f Check for error when getting the number of cd tracks. Build an empty
track list table if this is the case.
2014-05-22 07:51:08 +02:00
Mattias Andersson 0c76ca3c45 Don't start ripping unless the user has selected some tracks. 2014-05-21 18:07:48 +02:00
John Maguire 1f97406171 Revert "Send album artist to Last.fm"
This reverts commit d7ec8b9103.
AlbumArtist seems unsupported by newer liblastfm.
2014-05-21 17:47:01 +02:00
John Maguire 7702271fe6 Merge pull request #4344 from paperbagcorner/fix-tagging
Improve the tagging and the track information handling in the CD ripper
2014-05-21 15:46:00 +01:00
Mattias Andersson 8bb19f1887 Save tags using async calls. 2014-05-21 16:36:46 +02:00
David Sansome 48731d0420 Merge pull request #4364 from TheUbuntuGuy/master
Add icons to extras: hypnotoad, kittens, enterprise.  Fixes #1601
2014-05-21 22:12:53 +10:00
Mark Furneaux 805d8f85b0 Add icons to extras: hypnotoad, kittens, enterprise
Fixes totally critical bug #1601
2014-05-21 07:26:16 -04:00
Diogo Pereira d7ec8b9103 Send album artist to Last.fm 2014-05-20 21:20:55 +01:00
John Maguire 9f6899ac82 Use guaranteed random number generator.
Fixes #4352
2014-05-20 17:03:04 +02:00
John Maguire efcb5c4adc Merge pull request #4359 from TheUbuntuGuy/slider
Increase update rate of track slider
2014-05-20 12:50:58 +01:00
Mark Furneaux bd87230301 Change constant format 2014-05-20 07:44:30 -04:00
John Maguire 24a4cff807 Merge pull request #4288 from sundrythoughts/rating-optimization
Increase performance of mass rating changes.
2014-05-20 12:42:39 +01:00
Mark Furneaux 7fb30f2596 Add constants to track progress timers 2014-05-20 07:29:59 -04:00
Mark Furneaux b76af5f792 Increase update rate of track slider
Increases the refresh rate of the track progress bar to 25fps.
This looks much better with moodbars than the previous 1fps.
All the common code that use to run at 1fps still retains that
rate so the overhead due to this is negligible.
2014-05-19 11:51:40 -04:00
Clementine Buildbot b2abe5ff51 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-05-19 10:01:50 +02:00
John Maguire 8919b730da Update Jamendo db dump URL.
Fixes #4351
2014-05-18 18:10:56 +02:00
John Maguire 8fa96f68c8 Merge pull request #4353 from TheUbuntuGuy/master
Fix dbz possibility with small buffers at end of track
2014-05-18 18:06:36 +02:00
Mark Furneaux b0b94163f9 Merge branch 'master' of https://github.com/TheUbuntuGuy/Clementine 2014-05-18 12:02:41 -04:00
John Maguire 22a454e405 Merge pull request #4350 from TheUbuntuGuy/master
Add ability to fit now playing cover to width
2014-05-18 17:55:29 +02:00
Mattias Andersson 7d4343a826 Give functions a more verbose name. 2014-05-18 14:39:21 +02:00
Mattias Andersson 2137ac4709 Keep working until tagging is complete. 2014-05-18 14:24:46 +02:00
Mark Furneaux 7976ad2d3c Initialize fit_width_ 2014-05-17 16:35:52 -04:00
Mark Furneaux 84434fd84e Fix dbz possibility with small buffers at end of track
There was a possibility of a dbz when a buffer sent to the
analyzer was shorter than 1ms long, such as what may happen at the end
of a track when stopping. This patch guards against this.
2014-05-17 14:38:46 -04:00
Mark Furneaux 8269dc8613 Set text size on now playing widget
In removing the background colour I accidentally removed the text size style.
This edit re-adds it so the size is uniform against all modes.
2014-05-15 18:39:08 -04:00
Mark Furneaux 971b8ea137 Use UI background colour when in fit width mode
When in fit width mode with the details below the artwork,
drawing the black background is out of place. This uses the ui colour
making it less obtrusive.
2014-05-15 16:39:32 -04:00
Mark Furneaux 1f8fa45da0 Add ability to fit now playing cover to width
Some people seem to want to have a way of enlarging the now playing
widget cover when in large mode to get rid of the black bars on the sides.
This patch adds an option in the context menu which allows the cover to
fill the width of the panel when either large mode is enabled.
2014-05-15 16:02:46 -04:00
David Sansome 0332bed3fc Remove temporary cover-art from /tmp on exit. Fixes #4349 2014-05-15 16:21:19 +10:00
David Sansome ff5d23b288 Merge pull request #4347 from TheUbuntuGuy/master
Add new now playing widget mode.  Fixes #853
2014-05-15 16:17:46 +10:00
Mark Furneaux 20be94ee51 Change height on details change
When the details change, the height is updated so if the details
now span more or fewer lines we can accompany that
2014-05-14 22:10:39 -04:00
Mark Furneaux 9d118345c0 Add placeholder text for safety
Just to make sure that details_ has the correct height when initializing
2014-05-14 22:06:02 -04:00
Mark Furneaux eb0b53aa96 Add new now playing widget mode
In an attempt to satisfy many users, I have added another mode to the
now playing widget. This shows the large cover art however it draws the song details
below the artwork, without the gradient that everyone seems to have a problem with.
This is just an option and all the original functionality is unchanged.
2014-05-14 19:07:53 -04:00
John Maguire 42a2739daf Merge pull request #4343 from TheUbuntuGuy/master
Fix block analyzer framerate
2014-05-14 14:14:33 +02:00
Mark Furneaux 542dbe8d12 Make framerate notification less nasty
Now uses a virtual function in Analyser::Base to notify any
analyser which whishes to listen
2014-05-13 16:43:46 -04:00
Mattias Andersson 182c90ccf4 Run RipCD::TagFiles in a background thread. 2014-05-13 15:18:42 +02:00
John Maguire c2890de65f Remove "using" statement in header 2014-05-13 14:46:50 +02:00
Mark Furneaux 6a882370a6 Fix block analyzer framerate
Block analyzer uses an internal variable m_step to determine how
long to hold a bar up. This is dependant on framerate, however it is
only set on creation or resize of the analyzer. This patch changes
this value whenever the framerate is changed, preventing the analyzer
from appearing wildly fast or extremely slow until a restart.
2014-05-12 18:15:00 -04:00
Mattias Andersson 467a1443e4 Capture log messages from the transcoder. 2014-05-12 23:58:51 +02:00
Mattias Andersson 98fd82a371 Use the TagReaderClient to tag the files in the CD ripper instead of
using Taglib directly.
2014-05-12 23:57:11 +02:00
Mattias Andersson bbd83344b8 Initialise cancel_requested_ to false in the constructor's initialisation list. 2014-05-12 17:40:41 +02:00
Mattias Andersson 08f5af3320 Give the mutex lockers a tighter scope. 2014-05-12 17:24:35 +02:00
Mattias Andersson 919f7cbe94 Add a mutex to protect a variable shared between threads. 2014-05-12 16:14:33 +02:00
Mattias Andersson 6235e69ac4 Run 'make format' 2014-05-12 14:38:46 +02:00
Mattias Andersson be09f6e5c7 Merge branch 'master' into ripcd-cancel
Conflicts:
	src/ui/ripcd.cpp
2014-05-12 13:50:34 +02:00
John Maguire 5fe468456a Merge pull request #4171 from asiviero/master
Addressing #4165 and #4166
2014-05-12 13:20:26 +02:00
David Sansome f593eb0952 Use arraysize instead of sizeof 2014-05-12 19:00:26 +10:00
Clementine Buildbot 093d160cca Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-05-12 10:01:51 +02:00
David Sansome 98b6b6f906 Don't use italic text anywhere - Arabic text doesn't have italics. Fixes #4329 2014-05-11 20:42:49 +10:00
David Sansome 18f72f3ada Capture this lambda argument by value, since it's a local variable and won't be valid when the outer function exits. 2014-05-11 19:24:22 +10:00
David Sansome 41425b3c5c Remove . from the beginning of filenames when organising files. Fixes #4338 2014-05-11 19:24:21 +10:00
David Sansome cf6cdc6936 Add disambiguation strings to "Quality". Fixes #4316 2014-05-11 17:35:23 +10:00
David Sansome 4e9a7ca7f3 Load all the metadata for the first song, so the duration will appear properly when it starts playing. 2014-05-11 17:35:23 +10:00
Andreas f52e48c956 Send filesize and file count in advance when client wants to download songs. 2014-05-10 14:53:38 +02:00
asiviero d448ac1179 Replaced scoped_ptr by unique_ptr 2014-05-10 00:41:32 -03:00
Andreas 24481ae7bc Clementine Remote can now download all urls that are in the library. 2014-05-08 19:17:58 +02:00
Andreas c04eb3da19 Only search for covers automatically if artist & album is filled. 2014-05-07 21:17:33 +02:00
Clementine Buildbot 40a7ae24fc Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-05-07 14:56:34 +02:00
Mattias Andersson f91c162ba3 Use a single label for the text at the top of the soundcloud settings page. 2014-05-04 08:31:15 +02:00
David Sansome 0d71067333 Merge pull request #4327 from TheUbuntuGuy/coverchoicecontroller
Fix oversized album cover art.  Fixes #1260
2014-05-04 14:00:41 +10:00
Mark Furneaux 394d8e7b51 Add support for monitors in portrait mode
Album covers bound to width or height, whichever is smaller
2014-05-03 09:54:19 -04:00
Mark Furneaux 8f9229d7c9 Apparently I'm blind. (Refactoring) 2014-05-03 09:28:07 -04:00
Mark Furneaux 00a1fe1e32 Refactoring 2014-05-03 09:14:15 -04:00
Mark Furneaux 9156f8f389 Fix oversized album cover art
When viewing the "Full Size" album covers, if the cover was higher in
resolution than that of the monitor, it would get cut off. Also,
the window was resizable however the image was not. This patch makes
the dialog a fixed size and resizes the cover only if it is too large to
fit on the screen. It also now displays the dimentions of the original
artwork in the title bar.
2014-05-01 12:26:48 -04:00
Mark Furneaux 6c653e5ba2 Synchronize buffer chunks with audio stream
The chunks are now determined by the density of data in the buffer
to the length of audio in the buffer. The chunk length can change
size so that the audio that is analysed is exactly what is being played
at the instant the frame is requested.
2014-04-30 14:18:39 -04:00
Mark Furneaux ee7fed36bc Fix pointer arithmetic when seeking buffers
It's possible the sample type will change, so best to not use
a fixed value.
2014-04-30 10:00:58 -04:00
asiviero 4b7c3a2f8c Using scoped ptr to ripcd window, removing extra parenthesis again 2014-04-29 23:12:18 -03:00
Mark Furneaux 53f21584e4 Fix inconsistent buffer sizes sent to analyzer
The analyzers are sent new buffers of audio data to process each time
they pass through the gst pipeline. Different file formats and bit depths/
sample rates can change the size of these buffers, in some cases making them
large and therefore infrequent. This causes choppiness in the analyzer
as it is not getting new data with every frame. This patch chunks the buffers
coming off the pipeline to correspond with the framerate of the analyzer.
2014-04-29 21:38:21 -04:00
John Maguire 41e9c15248 Add arraysize macro from Chromium 2014-04-29 14:11:52 +02:00
Clementine Buildbot 0392420cd8 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-04-28 10:01:51 +02:00
David Sansome ec0565d07d Merge pull request #4313 from TheUbuntuGuy/master
Fix analyzer framerate when mouseover play scrubber.  Fixes ##2504
2014-04-27 16:51:36 +10:00
Mark Furneaux 16f12a3da8 Formatting 2014-04-27 02:49:26 -04:00
Mark Furneaux 7d3d0f04cf Fix analyzer framerate when mouseover play scrubber
This patch prevents the framerate of all analyzers from
increasing beyond the framerate set in the interface at all times.
It however will allow the analyser to redraw as often as required
to prevent artifacting when the play scrubber is drawn in front.
2014-04-27 01:54:42 -04:00
David Sansome 3e57a85711 Merge pull request #4308 from TheUbuntuGuy/master
Fix play bleeding into next track after auto stop
2014-04-26 18:46:26 +10:00
Mark Furneaux f793d09d8e Fix play bleeding into next track after auto stop
If "fade out on stop" is enabled, the "stop after this track" feature
would stop not stop the on current track, but instead start playing
the next track and fade out on that immediately. This patch disables
fadeout when the engine is stopped by HandleStopAfter().
2014-04-26 00:58:08 -04:00
David Sansome 231443f6d1 Merge pull request #4305 from TheUbuntuGuy/master
Fix stop after track.  Fixes #3572
2014-04-26 13:10:23 +10:00
Mark Furneaux d0ca2cef6c Comment remove 2014-04-25 23:02:42 -04:00
Mark Furneaux ce8b7303c0 Formatting 2014-04-25 22:50:52 -04:00
Mark Furneaux c890af6306 More elegant solution to last commit
set_current_row now takes optional parameter "is_stopping" for when auto stop
is enabled.
2014-04-25 22:45:25 -04:00
Joseph Freeman fe4a80b2d5 Removed commented-out code and ran make format. 2014-04-25 19:41:04 -04:00
Joseph Freeman 156728390d Increase performance of mass rating changes. 2014-04-25 19:37:46 -04:00
Mark Furneaux 416d06bb06 Fix stop after track
Stop after track would cause now playing widget, OSD, and last.fm
scrobbler to change to next track after stopping. This patch prevents
set_current_row() from firing an event which triggers the track change.
2014-04-25 14:30:31 -04:00
vkrishtal 42f62be5b6 Fix after review 2014-04-25 08:57:31 +04:00
vkrishtal 69b4f9113a BugFix: clementine cannot delete directories in file tab #858 2014-04-25 00:28:22 +04:00
John Maguire b3ef8b0fe0 Try out actually using lambdas for something useful. 2014-04-23 18:05:59 +02:00
David Sansome c7459b1b28 Load songs in a background thread while initialising the Organise dialog 2014-04-23 21:46:05 +10:00
David Sansome 98a328cf97 Switch from foreach to for 2014-04-23 21:13:58 +10:00
David Sansome 25ee987ec7 Recursively add songs in subdirectories to the organise dialog. Broken in revision 35060d6. 2014-04-23 21:06:23 +10:00
Arnaud Bienner d49d818b37 Very minor style change 2014-04-23 00:40:06 +02:00
Arnaud Bienner 3f79fa5c65 Try to make the slider more accurate when moodbar is activated.
Previously, the slide wasn't displayed at the exact position where the user clicked, and the moodbar's width was equal to the slider's width, while it should have been as long as long the groove.
2014-04-23 00:03:30 +02:00
John Maguire c94a94ece2 Merge pull request #4285 from paperbagcorner/sqlite-3.8
Fix slow library search on sqlite 3.8.
2014-04-22 18:47:45 +08:00
Mattias Andersson 5fffbbc689 Add explanatory comment to last commit. 2014-04-22 12:25:59 +02:00
Clementine Buildbot e09298b9a3 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-04-21 10:01:49 +02:00
Mattias Andersson 56dade2598 Fix slow library search on sqlite 3.8. 2014-04-19 14:23:50 +02:00
Arnaud Bienner 3dad47e7ca Reorder SoundCloud menu 2014-04-16 23:17:23 +02:00
Arnaud Bienner 67951f64a5 SoundCloud: retrieve user's playlists 2014-04-16 23:09:48 +02:00
Arnaud Bienner ef01353a0f SoundCloud: retrieve stream playlists 2014-04-16 22:37:40 +02:00
Andre Siviero af34bf6062 Removing extra parenthesis 2014-04-16 11:07:50 -03:00
Mattias Andersson 773c3475ba Remove unnecessary string conversion. 2014-04-15 14:47:26 +02:00
Clementine Buildbot 2c82826d26 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-04-14 10:01:28 +02:00
Adolfo Jayme Barrientos 15e4f7fe9c Remove space in provider’s name 2014-04-14 00:32:58 -05:00
Mattias Andersson ddf0c0cbc3 Merge remote-tracking branch 'origin/master' into asivieromaster 2014-04-13 14:59:58 +02:00
Mattias Andersson 44025dc588 Add a call to cdio_get_media_changed in RipCD::CheckCDIOIsValid
This prevents an erroneous message that the media has changed the first
time the ripCD dialog is used.
2014-04-13 14:41:04 +02:00
David Sansome b9279ca128 Merge pull request #4263 from abika/master
Load all songs that require disc-read non-blocking.
2014-04-12 16:03:55 +02:00
Mattias Andersson 31400f2740 Run 'make format' 2014-04-12 09:20:25 +02:00
Mattias Andersson d66a73bed5 Merge remote-tracking branch 'origin/master' into HEAD
Conflicts:
	src/ui/mainwindow.cpp
	src/ui/ripcd.cpp
2014-04-12 09:08:21 +02:00
SATOH Fumiyasu 9add1ad708 Update Transifex URL 2014-04-11 16:30:57 +09:00
John Maguire 8429e92b52 Remove obsolete configure #defines 2014-04-10 18:03:15 +02:00
Arnaud Bienner 2f5e03e921 Use a more appropriate log level 2014-04-10 00:49:31 +02:00
Arnaud Bienner 532720ea79 Merge branch 'master' of https://github.com/clementine-player/Clementine 2014-04-09 23:08:14 +02:00
Arnaud Bienner e557c56d96 We ask for 'non-expiring' tokens, so it seems normal that we don't have refresh_tokens actually 2014-04-09 23:07:58 +02:00
Arnaud Bienner beb5f9fa30 Handle error in SoundCloud replies 2014-04-09 23:03:09 +02:00
Alexander Bikadorov 66fcaefed9 Documentation update for async song load. 2014-04-07 15:38:26 +02:00
Alexander Bikadorov a056a87c8e Coding style fixes for async song load. 2014-04-07 15:27:47 +02:00
John Maguire 712d8ecd8a Remove Growl support. 2014-04-07 14:54:10 +02:00
Clementine Buildbot 57e4217ccc Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-04-07 10:01:42 +02:00
Clementine Buildbot db32b67f89 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-04-06 12:17:25 +02:00
David Sansome 5066dcf696 Merge pull request #4212 from paperbagcorner/searchtooltip
Don't translate field names in the library search filter tool tip
2014-04-06 18:18:07 +10:00
Gavin Howard b41b9232ce Use relative filenames when saving XSPF playlists 2014-04-06 17:40:50 +10:00
David Sansome 24404b4357 Make the "buffer low fill" string a bit more understandable 2014-04-05 22:03:36 +11:00
John Maguire 51385cc801 Add a different label for the mavericks shortcut settings.
Fixes issue #4002
2014-04-02 16:27:07 +02:00
John Maguire 4ed6f94211 Open the right part of the system preferences for global shortcuts on Mavericks. 2014-04-02 16:27:07 +02:00
John Maguire 30d1c2f8db Remove Ubuntu One support.
http://blog.canonical.com/2014/04/02/shutting-down-ubuntu-one-file-services/
2014-04-02 16:02:00 +02:00
Alexander Bikadorov 0d199be5a7 Load all songs that require disc-read non-blocking. 2014-04-02 15:57:01 +02:00
Marcus Fritzsch 22c0a79924 gstenginepipeline: Do not use QString::sprintf() 2014-04-02 12:39:19 +02:00
Marcus Fritzsch e3bea84bea gstenginepipeline: make buffer min fill configurable 2014-04-02 11:54:14 +02:00
Arnaud Bienner 4c70f17444 Fix a small issue in oauthenticator 2014-03-31 22:04:03 +02:00
David Sansome 2134e13b53 Make CloudFileServices show logged in state and settings dialog properly in
global search.
2014-03-30 17:11:31 +11:00
David Sansome 25544cb672 Sort the list of Internet Providers in the settings dialog and internet tab 2014-03-30 17:11:19 +11:00
David Sansome 93a0f160df Add Configure items to the context menus for cloud file services. 2014-03-30 16:46:16 +11:00
David Sansome adff4864d4 Recurse into folders when indexing music on OneDrive 2014-03-30 16:36:07 +11:00
David Sansome 6ecc534bf9 Construct oauth URLs properly when using REMOTE or REMOTE_WITH_STATE 2014-03-30 16:35:38 +11:00
David Sansome 9c66528c0f Add a settings page for OneDrive 2014-03-30 16:35:27 +11:00
David Sansome 345e58ce6b Only save the Drive cursor after all songs have been indexed. 2014-03-30 16:01:58 +11:00
David Sansome ca7937112d Show only one status bar entry while indexing files on Drive. 2014-03-30 15:47:25 +11:00
David Sansome d662d23e53 Maybe fix the make install step in the mac build 2014-03-30 01:21:12 +11:00
David Sansome 1719b1599c Get audio device names on Windows too. 2014-03-29 23:48:26 +11:00
David Sansome 2d7be1502f Get audio device names on OS X too. 2014-03-29 22:44:08 +11:00
David Sansome 6d1dc56a7c Get a list of available audio devices from pulseaudio, and let the user choose
from those in the settings dialog instead of just giving him a text box.
2014-03-29 19:31:38 +11:00
John Maguire 4ab4bbc23f Remove Last.fm radio support.
Fixes #4259
2014-03-28 14:55:04 +01:00
Arnaud Bienner 1b7f99127d Add login to SoundCloud + get user tracks and activties (stream)
Still need to handle playlists and to clean up things (e.g. to check why refresh_token doesn't work and if we can do something about this)
2014-03-26 21:33:27 +01:00
Arnaud Bienner 4520a1c115 Grooveshark: don't crash when receiving the reply for a canceled request.
Mark all tasks as finished when removing all items, to prevent never ending task in case we disconnect or refresh before all replies have been received.
2014-03-21 12:48:45 +01:00
Arnaud Bienner fddb87ba63 Add an option to sort Grooveshark playlist alphabetically. Fixes issue #3480.
Did it the lazy way for now, but it would have better to refactor Grooveshark code, to add a proper sort model, etc.
2014-03-21 00:52:12 +01:00
Alexander Bikadorov 27e1c16e8a Debug logging when saving a playlist. 2014-03-18 16:14:12 +01:00
Alexander Bikadorov d023b56cea Avoid saving the playlist multiple times. 2014-03-18 16:13:38 +01:00
John Maguire 0a67a00ec0 Initialise logging earlier. 2014-03-12 19:06:00 +01:00
Sebastian J. Mielke e73450cf43 Moodbar-Trackslider uses the full available height
When determining the next state (for rendering the change), the slider widgets vertical SizePolicy is changed from Fixed to MinimumExpanding (same thing works the other way around).
2014-03-11 16:08:24 +01:00
Maltsev Vlad 2659a8364c Fix group title string. 2014-03-10 16:05:45 +07:00
Maltsev Vlad dde8535470 Translation, typos and mac build fixes. 2014-03-08 19:11:48 +07:00
Maltsev Vlad a7b0accd93 Add Vk.com plugin. 2014-03-08 00:58:50 +07:00
John Maguire d2b62334e8 Merge pull request #4225 from sobkas/master
This time it fixes the crash, I swear.
2014-03-03 17:48:41 +01:00
Krzysztof A. Sobiecki 3339aabf19 Fix crash during adding a new podcast 2014-03-03 17:45:31 +01:00
Clementine Buildbot b3766a392b Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-03-03 10:01:41 +01:00
Clementine Buildbot ee131f07d5 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-02-24 10:01:39 +01:00
Andreas 95c4db25e0 Broken kittens repaired. Aww.... 2014-02-22 22:21:00 +01:00
Andreas d397f711fe Better placeing of the loading icon when automatic cover loading is activated. 2014-02-22 21:27:58 +01:00
Mattias Andersson cdf5363320 Prevent translation of the names of the available fields in the tool tip for the library search field. 2014-02-22 18:21:58 +01:00
John Maguire 5146bcdebc Some more NULL -> nullptr conversions. 2014-02-21 17:30:46 +01:00
Clementine Buildbot 734b7b9bd7 Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2014-02-17 10:01:43 +01:00
John Maguire b46e9ff55c Seems this should be the other way around. 2014-02-14 15:51:08 +01:00
John Maguire c162a9316d Fix clang warning. 2014-02-14 14:36:47 +01:00
John Maguire fc9c983e2c Put global functions used for startup in namespace 2014-02-13 18:59:59 +01:00
Mattias Andersson 3b01247df9 Iterate over a copy of the parents container since we are removing elements from the original. 2014-02-13 10:41:24 +01:00
Arnaud Bienner faaa75cb61 Few style fixes + avoid unneeded copies 2014-02-12 22:11:28 +01:00
Alexander Bikadorov 3adaf5d598 fixed indentation / coding style 2014-02-11 13:18:08 +01:00
Alexander Bikadorov c7ac2012b4 correct selection after removing rows in playlist 2014-02-10 16:51:43 +01:00
John Maguire 192b60d965 Use nullptr as parent parameter default everywhere 2014-02-10 16:03:54 +01:00
John Maguire fd183a80ff Merge branch 'coding_style_fixes_and_c++11' of https://github.com/sobkas/Clementine into sobkas-coding_style_fixes_and_c++11
Conflicts:
	src/podcasts/addpodcastbyurl.cpp
	src/podcasts/gpoddersync.cpp
	src/podcasts/podcastinfowidget.cpp
	src/podcasts/podcastupdater.cpp
2014-02-10 15:55:42 +01:00
John Maguire 3323c2d094 Convert all instances of foreach() to a C++11 for
find ext src -name '*.cpp' -exec \
    sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
Krzysztof A. Sobiecki f6941726f9 Use nullptr instead of 0 2014-02-10 14:20:20 +01:00
Krzysztof A. Sobiecki 1d1cc92263 Someone else 2014-02-10 13:51:03 +01:00
Clementine Buildbot 89433be9aa Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2014-02-10 10:01:46 +01:00
Krzysztof A. Sobiecki 6d2cdad286 So here list have hidden 2014-02-09 18:46:59 +01:00
Krzysztof A. Sobiecki d7ff44005e No more 'auto' :( 2014-02-09 17:53:20 +01:00
Krzysztof A. Sobiecki c71782c700 I don't know who put this damn spaces there 2014-02-09 17:07:35 +01:00
David Sansome 67f6560c04 Merge pull request #4194 from abika/master
Use double click settings as default behaviour for new files added as command line arguments.  Fixes #4183
2014-02-09 16:51:10 +11:00
David Sansome 7b93630b03 Resize the sort order combobox when its contents changes. Fixes #4173 2014-02-09 16:43:43 +11:00
David Sansome fc5b5f584e Merge pull request #4198 from paperbagcorner/searchtooltip
Add a tool tip to the library search field. Fixes #3344
2014-02-09 14:23:10 +11:00
Mladen Pejaković f09a0c00a8 More disabmiguations 2014-02-08 16:09:27 +01:00
Mladen Pejaković da535d6429 More disambiguations 2014-02-08 15:11:06 +01:00
Mattias Andersson 175827f73f Add a tool tip to the library search field. 2014-02-08 14:50:12 +01:00
Dave Sansome 89369029ab Merge branch 'skip_track' of https://github.com/asiviero/Clementine into asiviero-skip_track
Conflicts:
	src/playlist/playlist.cpp
	src/playlist/playlistitem.h
	src/ui/mainwindow.cpp
2014-02-08 13:19:23 +11:00
Krzysztof A. Sobiecki 22a00da717 Fix all+1 errors reported by cpplint.py 2014-02-07 22:35:28 +01:00
Krzysztof A. Sobiecki 171529c5b6 Fix all errors reported by cpplint.py 2014-02-07 22:35:28 +01:00
Alexander Bikadorov 2ab8ab8077 Use double click settings as default behaviour for new files added as command line arguments. 2014-02-07 20:28:37 +01:00
John Maguire 5469c0469e Merge pull request #4192 from pejakm/trfixes
[EditTag Dialog] Fix not displaying translated string
2014-02-07 17:21:55 +01:00
Mladen Pejaković 4c534e54ec [EdiTag Dialog] Fix not displaying translated string 2014-02-07 17:10:53 +01:00
Krzysztof A. Sobiecki 0ecf1e76a6 Reformat done with clang-3.5 svn200967 2014-02-07 17:08:31 +01:00
John Maguire bebd781fdf Reformat all non-3rd-party C/C++/Objective-C++.
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
 -style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
John Maguire acfc7e6d21 Add missing header for _exit()
Fixes #4188
2014-02-07 13:41:26 +01:00
Mattias Andersson eb622b7e00 Do not translate ip address. 2014-02-07 13:00:24 +01:00
David Sansome eaf182a59a Merge pull request #4161 from BrummbQ/master
don't rescan unchanged files if library has been unavailable.  Fixes #3032
2014-02-07 22:45:55 +11:00
John Maguire 90d838ba37 Merge pull request #4182 from sobkas/master
Fix auto download podcasts
2014-02-07 11:56:54 +01:00
John Maguire 7671108aa8 Add missing include for symlink() 2014-02-06 19:46:08 +01:00
Gregor Tätzner 0cab75b28f removed useless debug log 2014-02-06 19:27:36 +01:00
John Maguire 3df3a5b645 Add missing header for syscall().
This is cunningly not defined in syscall.h
2014-02-06 19:03:10 +01:00
John Maguire 8d1f4612db Hide use of boost multi-index behind pimpl. 2014-02-06 17:53:33 +01:00
Krzysztof A. Sobiecki 30fff5dfc4 Fix automatic podcast episodes downloads 2014-02-06 17:34:17 +01:00
John Maguire 71893e4847 Use nullptr instead of NULL everywhere. 2014-02-06 17:29:59 +01:00
John Maguire d309d4ab27 Use c++11 instead of boost where possible. 2014-02-06 16:51:39 +01:00
Mladen Pejaković e50ef0dd42 [Transcoder] Translate transcoder presets as well 2014-02-05 14:17:24 +01:00
asiviero 9a0b149877 Removed unnecessary clear and switched to clearContents on cdio not available 2014-02-05 10:25:47 -02:00
asiviero 62d919c1b5 Fixing segfaults, checking for cd change on the fly 2014-02-04 23:29:39 -02:00
Arnaud Bienner 7084697aa3 Prevent Clementine to loop forever when trying to play a song with repeat enabled in a playlist which contains only unavailable songs 2014-02-04 22:08:32 +01:00
Mattias Andersson 1b00e91fdf Add the ability to cancel a running CD rip. 2014-02-04 16:25:58 +01:00
Mladen Pejaković 657bbcf00f Fix for pull request #4170 2014-02-04 15:04:19 +01:00
John Maguire ddda13ceb7 u_int8_t is missing on mingw 2014-02-04 14:10:59 +01:00
asiviero d88c1fad04 Reset progress bar after cancel is pressed 2014-02-03 23:59:23 -02:00
asiviero 4251fd4331 Checks for CD before opening window (addresses #4165) 2014-02-03 22:40:56 -02:00
Mladen Pejaković 033d266fe9 Add contexts to some translation strings 2014-02-03 21:54:02 +01:00
Mattias Andersson 3bf44c78d4 Only remove the temporary directory if it has a non-empty name. 2014-02-03 15:14:08 +01:00
Mattias Andersson 4676e2839d Make the CD ripper clean up after itself. 2014-02-03 13:38:38 +01:00
Clementine Buildbot efd4e8666e Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2014-02-03 10:01:44 +01:00
Arnaud Bienner a349a96f5a Avoid having similar filenames when organising songs (number them instead) 2014-02-02 19:28:45 +01:00
David Sansome 96075faf88 Namespace clementine's 3rdparty implementation of sha2 to prevent its symbols
conflicting with the system's openssl symbols with the same names.

This was causing SSL connections to fail in weird ways on Debian.

Fixes #4130.
2014-02-02 20:25:11 +11:00
Gregor Tätzner 7317b6792e don't rescan unchanged files if library has been unavailable 2014-02-01 20:21:28 +01:00
Arnaud Bienner ee20103510 Set overwrite to false by default in organise dialog.
Too dangerous to be activated by default IMO.
2014-02-01 03:35:34 +01:00
Arnaud Bienner 06184cc5fb Avoid having empty filenames, or filenames with extension only.
In this case, keep the original filename.
2014-02-01 03:22:41 +01:00
Arnaud Bienner dac137cf11 Remove useless check.
No need to check isNull if you're checking isEmpty (see http://qt-project.org/doc/qt-4.8/qstring.html#distinction-between-null-and-empty-strings "A null string is always empty").
2014-01-31 20:17:26 +01:00
John Maguire 7ddf3aab45 Merge pull request #4145 from sobkas/master
Initial support for "Copy to device" in a podcast section
2014-01-31 04:31:43 -08:00
Krzysztof A. Sobiecki e244c9cfb2 My fault, was testing something and forgoten to replace song.basefilename() 2014-01-30 15:08:53 +01:00
John Maguire b96ec7555a Reformat all Objective-C++ files with clang-format.
clang-format -style=Google -i src/*/*.mm
2014-01-30 14:54:51 +01:00
John Maguire 0a778e2901 Do not log IP address from network remote settings. 2014-01-30 11:50:52 +01:00
Mattias Andersson c36e073921 Add trailing underscore to class member variable. 2014-01-29 20:35:03 +01:00
Krzysztof A. Sobiecki 361cca83cb Cpplint.py fixes 2014-01-29 17:30:58 +01:00
John Maguire 1fad6db52a Use std::unique_ptr instead of boost:scoped_ptr in one place. 2014-01-28 18:45:13 +01:00
Krzysztof A. Sobiecki 09d68bf415 Scrub the auto usage, use unique_ptr, use correct types instead of QList 2014-01-28 17:01:14 +01:00
John Maguire 59cb17c08d Change some API URLs to use https. 2014-01-28 12:57:27 +01:00
Krzysztof A. Sobiecki 3a72faba97 Fix errors reported by Cpplint.py 2014-01-28 04:50:00 +01:00
Krzysztof A. Sobiecki 295c5bc087 Make code more readable 2014-01-28 04:33:20 +01:00
Krzysztof A. Sobiecki 20befa439c Add a space 2014-01-28 04:31:06 +01:00
Krzysztof A. Sobiecki 7ea6c027d4 Fix podcasts metadata 2014-01-28 04:16:51 +01:00
Krzysztof A. Sobiecki 655d7e1989 CopyToDeviceSlot is a wrong name 2014-01-27 23:59:38 +01:00
Krzysztof A. Sobiecki b0a97de603 Use more auto in for statements 2014-01-27 23:59:38 +01:00
Krzysztof A. Sobiecki df992a4b4b Use auto in for statements, fix const in SetListened 2014-01-27 23:59:38 +01:00
Krzysztof A. Sobiecki 6ea793f446 Fixed some problems reported by cpplint.py, changed foreach to for in files touched by me mkII 2014-01-27 23:59:38 +01:00
Krzysztof A. Sobiecki f7be18b326 Fixed some problems reported by cpplint.py, changed foreach to for in files touched by me 2014-01-27 23:59:38 +01:00
Krzysztof A. Sobiecki c3e693a785 Whitespaces after if 2014-01-27 23:59:37 +01:00
Krzysztof A. Sobiecki 081f4f721a Introduce an intuitive behaviour in podcasts menu 2014-01-27 23:59:37 +01:00
Krzysztof A. Sobiecki 35060d6916 I accidently break this, nothing to see here 2014-01-27 23:59:37 +01:00
Krzysztof A. Sobiecki 4944e99d56 Fix copy functionality, break copy of a directory 2014-01-27 23:59:37 +01:00
Krzysztof A. Sobiecki 45ace04b29 More intuitive interface 2014-01-27 23:59:37 +01:00
Krzysztof A. Sobiecki b6c59bd4ca Fix whitespaces, Fix whitespaces, Fix whitespaces 2014-01-27 23:59:37 +01:00
Krzysztof A. Sobiecki 750354d8ca Clementine, don't lie to me 2014-01-27 23:59:37 +01:00
Krzysztof A. Sobiecki 3e27cdf749 Some minor fixes 2014-01-27 23:59:36 +01:00
Krzysztof A. Sobiecki 01635397d4 Fixed podcast copy to device 2014-01-27 23:59:36 +01:00
Krzysztof A. Sobiecki f60327b1d1 Initial 'Copy to device' support for podcasts 2014-01-27 23:59:36 +01:00
John Maguire 977a6769b2 Rename SkyDrive to OneDrive.
http://blog.onedrive.com/onedrive-for-everything-your-life/
2014-01-27 15:38:56 +01:00
Clementine Buildbot c90fc63822 Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2014-01-27 10:01:54 +01:00
asiviero c0132b2ed3 Renaming skip properties, strike out track when it is to be skipped 2014-01-27 00:26:51 -02:00
Mattias Andersson 333b1636fa Adjust column widths. 2014-01-27 00:13:33 +01:00
Mattias Andersson a31223e45c Group the input options in the rip cd dialog. Disable input and output groups when there is a ripping in progress. 2014-01-26 21:20:36 +01:00
Mattias Andersson 76a91ded88 Remove the 'Alongside the originals' destination in the CD rip dialog since it doesn't make sense in this context. Use the home directory as initial destination instead. 2014-01-26 21:20:19 +01:00
Mattias Andersson 27b1bf7014 Add buttons 'select all', 'select none' and 'invert selection' buttons to the rip cd dialog. 2014-01-26 21:20:19 +01:00
Mattias Andersson 96e6252fca Style the Rip cd dialog
Set a specific tab order in the dialog.
Add a Clementine window icon.
Add a header for the first column in the table widget.
Change the button box to a cancel and a close button and make these behave as in the transcoder dialog.
Move the rip button to the button box.
Hide the progress bar if no cd has been ripped.
2014-01-26 21:19:02 +01:00
David Sansome cc4cc472fb Delete tr_TR (removed on transifex) 2014-01-27 00:07:31 +11:00
David Sansome 5ac83bd463 Merge branch 'master' into gstreamer-1.2 2014-01-25 00:24:31 +11:00
David Sansome f816a47ad9 Make SongLoader add URLs as raw streams if there exists a URL handler
for that scheme.  This fixes a bug where sky:// URLs couldn't be added
with MPRIS.
2014-01-24 23:54:38 +11:00
John Maguire 556fb62cd2 Mark cd rip output filename format string as not for translation. 2014-01-24 11:47:19 +01:00
John Maguire 2010b7d500 Include sys/time.h required for time_t on FreeBSD. 2014-01-23 17:06:43 +01:00
John Maguire b594f44c64 Merge branch 'cdrip' of https://github.com/asiviero/Clementine
Fixes #3490
Closes #4113
2014-01-23 16:33:28 +01:00
Andre Siviero a827d71f4a Moving ifdef inside the function 2014-01-23 13:18:35 -02:00
Andre Siviero 8500dce6b3 Removing conditional from function definition 2014-01-23 13:17:48 -02:00
Andre Siviero 4f79898e2d Including the pointer rip_cd_ in a conditional 2014-01-23 11:47:51 -02:00
Andre Siviero fe45462034 Including the method definition in a conditional 2014-01-23 11:17:38 -02:00
Andre Siviero bbf7ff61af Included OpenRipCD in a conditional 2014-01-23 11:04:30 -02:00
asiviero d07174c1d4 Adding ifdefs to make cdio detection on compile time 2014-01-22 23:11:41 -02:00
asiviero 7cebf23bba Added ripcd to optional features, deleted ui_ripcd on destruction, added a warning in case cdio_open returns NULL 2014-01-22 01:45:55 -02:00
asiviero 2859d826ae Swapped non const reference for pointer, used qdata_stream writeRawData to write to file, removed unnecessary intializers 2014-01-20 23:38:36 -02:00
asiviero c817431593 Greying out song and added verification to next on album mode 2014-01-20 22:35:01 -02:00
asiviero 5c21768760 Minor fixes and label adjustments 2014-01-20 22:10:23 -02:00
asiviero 1c0a221563 Added skip track feature 2014-01-20 22:10:16 -02:00
asiviero 048c2d9b9c Modified queue to store tracks to skip 2014-01-20 22:10:08 -02:00
asiviero 94aa151f1a Added event handlers to Skip Track 2014-01-20 22:09:58 -02:00
David Sansome 7a9e5b553b Set a lower minimum column size in the playlist again. Fixes #201 2014-01-20 22:08:43 +11:00
David Sansome dc5670edfb Encode song URLs when inserting them into the database. This was broken by revision 98dd001a. Fixes issue #4127 2014-01-20 21:39:18 +11:00
David Sansome cfb8fc8fbc Merge pull request #4125 from Fitoschido/patch-1
Remove font customizations.  Fixes #4082
2014-01-20 02:22:43 -08:00
Clementine Buildbot e0e69d966c Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2014-01-20 10:01:47 +01:00
Andreas 7ad1d7abc3 Remote: Use sha1 instead of md5 for file hashing. 2014-01-18 18:33:49 +01:00
Andreas ed3365bc0d Lyrics: Fix "Apply exclude rules" 2014-01-18 18:22:00 +01:00
Arnaud Bienner a700bea095 Revert "Set padding-right correctly instead of moving the clear icon"
This reverts commit 5c05745985.
2014-01-18 00:23:07 +01:00
Arnaud Bienner b2f16b316e Revert "Oops"
This reverts commit b716f802f3.
2014-01-18 00:22:46 +01:00
Adolfo Jayme Barrientos 9642896af6 Remove font customizations
* Should respect whatever font the user has set.
  (“Respect the user’s settings by always using the system font, sizes, and colors.” http://msdn.microsoft.com/en-us/library/windows/desktop/aa511282.aspx)
* Courier looks odd and thin (a11y issue #4082).
2014-01-17 11:44:08 -06:00
ArnaudBienner bf35df140a Merge pull request #4094 from Tatsh/playback-counter-font
Revert "Update playback counter font."
2014-01-17 05:01:30 -08:00
Arnaud Bienner 08a4629565 '-' is considered as 'NOT' operator by FTS, leading to unexpected results. Not sure how to escape it, better to replace it for now 2014-01-16 16:35:09 +01:00
asiviero 97129ec3c0 Using QDataStream to write numbers to file, removed PutNum, turned pointers into objects, checking cdio_read_audio_sector return code 2014-01-16 03:05:24 -02:00
David Sansome f43d1576e3 Merge pull request #4118 from paperbagcorner/columncheck
Improve the handling of colons in library search.  Fixes #925.
2014-01-15 03:01:35 -08:00
asiviero 457d240854 Using QByteArray and QFile instead of FILE and int16_t, adapting to code style corrections? 2014-01-15 03:00:41 -02:00
David Sansome d3749eace9 Select the current item if the selection is empty when using Tab to move from
the playlist filter to the playlist view.  Fixes #4116
2014-01-14 20:07:03 +11:00
asiviero d2881aad4b Linting the code, using QDir::tempPath instead of "/tmp" 2014-01-13 23:41:41 -02:00
Mattias Andersson bd880dcafe Tweak the replacement of colons.
Make sure that there are no trailing whitspaces on tokens before appending "* ".
2014-01-14 01:09:24 +01:00
asiviero d014d1549d Minor fix in filename generated 2014-01-13 13:49:39 -02:00
asiviero a3f61bd612 Added format string to customize file names 2014-01-13 13:38:25 -02:00
Mattias Andersson 3f4e8e5b88 Check if token is a valid column name in the fts table before treating it as such. 2014-01-13 16:16:33 +01:00
Clementine Buildbot 827ed9425c Automatic merge of translations from Transifex (https://www.transifex.net/projects/p/clementine/resource/clementineplayer) 2014-01-13 11:50:09 +01:00
asiviero a5021e656b UI integration, needs beautification
Incorporates the 'Select Destiny' feature from 062889b, fetches values provided by user to populate file tags, UI adjustments
2014-01-13 03:32:25 -02:00
Arnaud Bienner c7b0c02800 Sanity check 2014-01-12 21:25:53 +01:00
Arnaud Bienner b716f802f3 Oops 2014-01-12 21:00:41 +01:00
Arnaud Bienner 5c05745985 Set padding-right correctly instead of moving the clear icon 2014-01-12 20:50:03 +01:00
Arnaud Bienner 3838bd7bd7 Change a bit the LTR logic (move the clear button also when editing/removing the text 2014-01-12 17:40:28 +01:00
asiviero 34c178af65 Merge branch 'master' into cdrip 2014-01-12 14:02:37 -02:00