Commit Graph

4806 Commits

Author SHA1 Message Date
kiselev-dv 864d4162d3 Add stop after each song repeat mode 2015-05-12 14:05:46 +05:00
Clementine Buildbot 2cbd13ebba Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-05-11 10:01:17 +02:00
John Maguire 5256a112fc Merge pull request #4840 from abika/chromaprinter
Simplification and cleanup fixes for chromaprint fingerprint creation.
2015-05-08 12:06:27 +01:00
Andreas 059aa7f832 Move `watcher->deleteLater();` at the end of the `BlockingSearchFinished()` function to ensure the `watcher` object is still available when emitting the signals. 2015-05-04 16:25:49 +02:00
Alexander Bikadorov 96f4d64449 Minor coding improvements for c71aa6 . 2015-05-04 15:43:23 +02:00
Alexander Bikadorov c71aa61f8f Simplification and cleanup fixes for chromaprint fingerprint creation.
Fixes among other things the "GLib-CRITICAL **: Source ID XXX was not found" error.
2015-05-04 15:11:31 +02:00
Clementine Buildbot a00761fecd Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-05-04 10:01:18 +02:00
Andreas d59e864947 Send search provider icon to the remote when sending the search results. 2015-05-03 18:30:58 +02:00
Andreas 4c9f7e6a5e Revert "Fix mono playback. This was broken with commit eaad4c32eeeb83302632aba887d51d2eccb55eed."
Spotify doesn't work with this fix anymore, gstreamer throws `gst_segment_to_stream_time: assertion 'segment->format == format' failed`. Using `audio/*` for caps doesn't work either, the channes property is ignored. An `if (url_.scheme == "spotify")` would work, but maybe there is a more elegant solution.

This reverts commit 8799222d64.
2015-05-02 17:12:55 +02:00
Andreas 8799222d64 Fix mono playback. This was broken with commit eaad4c32ee. 2015-05-02 16:14:44 +02:00
John Maguire e1ea116bfb Remove Grooveshark support.
Well that was nice while it lasted.
2015-05-01 11:57:59 +01:00
John Maguire c0cf5e1220 Check for both names of libcrypto++
Fixes #4835
2015-05-01 11:52:40 +01:00
Andreas a32f725c5f Register QList<int> as a media type. Under windows, the connect doesn't work without it. 2015-04-29 17:14:37 +02:00
John Maguire 319b8a5824 Use SHA512 signatures for the spotify blob.
SHA512 is unsupported by reasonable QCA versions so we must use
libcrypto++ instead.
2015-04-28 12:27:07 +01:00
John Maguire 4cbe098b83 Fix memory leak in Amazon Cloud Drive. 2015-04-27 14:02:07 +01:00
John Maguire 8d2e3373a8 Use a GTlsDatabase for gstreamer SSL on mac. 2015-04-27 11:21:22 +01:00
Clementine Buildbot 2da11e0d90 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-04-27 10:01:21 +02:00
Adam Porter bb5a952e25 Re-read FMPS_Rating from file when changed
When the FMPS_Rating changes in a file, Clementine will now re-read it
and change the rating in the library database.  This lets you modify
song ratings outside of Clementine and then load the new ratings into
Clementine.  Previously Clementine would ignore changed ratings in a
file's metadata after a song had been scanned into the library.
2015-04-25 18:32:34 +02:00
Arnaud Bienner 20583b8b0a Correct typo 2015-04-25 18:01:32 +02:00
ArnaudBienner c7416cbfb5 Merge pull request #4599 from cincodenada/spotify-improvements
Improve handling of Spotify Top Tracks and compilations
2015-04-25 17:59:27 +02:00
Arnaud Bienner 99521ac15f Add missing certificate for api.soundcloud.com
Fixes #4794.
2015-04-25 17:51:08 +02:00
Andreas a0f24dff86 Network remote: Only start transcoder when we actually have something to transcode. 2015-04-24 17:43:18 +02:00
Andreas c152bc26d9 Network remote: Don't send downloader the first data since it's not needed. 2015-04-24 17:30:21 +02:00
Andreas 136fca6dc2 Network remote: Send filesize on songoffer. 2015-04-24 17:24:14 +02:00
Andreas d93917ce9b Network remote: Send song url as well. 2015-04-24 15:35:18 +02:00
Andreas c9b39e7c83 Fix crash when trying to download a track, but there is no current one playing. 2015-04-24 15:31:09 +02:00
John Maguire 30346e7810 Fix missing gst_buffer_unref.
Fixes #4823
2015-04-23 11:25:34 +01:00
Clementine Buildbot d55628a1e8 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-04-20 10:01:18 +02:00
Joel Bradshaw 0cc7801d33 Add comments and declare `artist` in tighter scope 2015-04-19 21:05:55 -07:00
Joel Bradshaw ddd641b1ae Improve handling of Spotify Top Tracks and compilations
Two improvements to handling of Spotify albums:
 - Remove single-track results if they also show up in the album
results.  This eliminates duplicates showing up in albums.
 - For each album, choose the majority artist attribution to
specify as the Album Artist.  For users who group by Album Artist,
this prevents splitting albums into multiple entries when there
are contributing artists.

Squashes following commits:

    commit d8bf17e13f50c7642ba491228f31608f4861d3b6
    Author: Joel Bradshaw <cincodenada@gmail.com>
    Date:   Tue Oct 28 19:56:36 2014 -0700

        Improve handling of Spotify Top Tracks and compilations

        Two improvements to handling of Spotify albums:
         - Combine individual tracks into a "Top Tracks" album by just
        setting the album name to "Top Tracks"
         - For each album, choose the majority artist attribution to
        specify as the Album Artist.  For users who group by Album Artist,
        this prevents splitting albums into multiple entries when there
        is a contributing artist.

    commit 228650a1d7122e5d1947133ba793afaffaa69cb4
    Author: Joel Bradshaw <cincodenada@gmail.com>
    Date:   Wed Oct 29 10:00:21 2014 -0700

        Style cleanup, including run of make format

        Also wrapped Top Tracks with tr()

    commit a4f6c1ecd9bcc8338a956b1a45c2f184ee9d660d
    Author: Joel Bradshaw <cincodenada@gmail.com>
    Date:   Sun Feb 15 13:38:52 2015 -0800

        Simply remove duplicate entries from the "Top Tracks" section

        Don't create the fake "Top Tracks" album, but remove entries
        from it if they show up in the album results.  This will
        eliminate the main problem - duplicates showing up in albums -
        and avoid issues with actual single-track results showing up
        erroneously as "Top Tracks"

    commit 859abc93b3491cc526d89df19a85dc4cf9bce1c8
    Author: Joel Bradshaw <cincodenada@gmail.com>
    Date:   Sat Apr 18 09:17:50 2015 -0700

        Clean up stray f and make format

    commit 333de1c4aa947c7cbe785429565bf4f08f98d476
    Author: Joel Bradshjaw <cincodenada@gmail.com>
    Date:   Sat Apr 18 09:19:10 2015 -0700

        Update majority_count so it works

        Fixes issue with it just picking the last artist on the album
        as the album artist
2015-04-18 09:23:45 -07:00
John Maguire e142bcaa21 Remove extraneous logging. 2015-04-17 12:13:27 +01:00
John Maguire aa22a43f44 Add exponential back-off to Amazon requests. 2015-04-17 12:10:40 +01:00
John Maguire e59ab5fa27 Comply with Amazon Cloud Drive branding guidelines. 2015-04-16 15:57:54 +01:00
Clementine Buildbot 6ecd47011a Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-04-13 10:01:20 +02:00
Andreas ec35688c86 Fix crash when stopping a track while a fadeout to pause is occuring. Fixes #4800. 2015-04-11 11:30:28 +02:00
Andreas 11d2702841 Try fixing buildbot. 2015-04-10 22:59:35 +02:00
Andreas 25e73d5714 Merge pull request #4679 from TheUbuntuGuy/master
Do not remove currently playing track when repopulating a dynamic playlist
2015-04-10 22:41:44 +02:00
Martin Babutzka 258ae281d8 IDv3 tag lyrics support.
Squashed the following commits:

5c723ad commit: Fix: Includes alpha sort
15ac350 commit: Fix: Updated Database::kSchemaVersion to 49.
767a26a commit: Fixed small code style issue. Added schema-49 to data.qrc instead schema-48
bf6aa64 commit: fixup! Modified async handling of CollapsibleInfoPane as recommended by Andreas. Display of IDv2 tag lyrics works now.
c1f97e9 commit: fixup! Added support to read/display the ID tag lyrics in MP3 files:
c946b1d commit: Added support to read/display the ID tag lyrics in MP3 files:

-Added schema to the database to store it
-Added readers/writers for ID tags
-Added readers/writers for the database to the song class
-Added the taglyricsinfoprovider to show the lyrics in songinfo
2015-04-10 21:05:07 +02:00
Clementine Buildbot f533b2998c Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-04-06 10:01:21 +02:00
Arnaud Bienner ccf5bffd99 Oops, this should just be a comment (remove warning) 2015-03-30 18:34:45 +02:00
Clementine Buildbot 82df087a83 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-03-30 10:01:17 +02:00
Arnaud Bienner 9877ac49fa Use Alt+Tab to switch between playlist tabs on OS X, as Cmd+Tab is already used by default for switching applications 2015-03-28 17:18:22 +01:00
John Maguire 8d3fd00956 Amazon Cloud Drive support.
Squashed commit of the following:

commit 451a327fabb5f9aba077d93a33d75d8a6a288f5f
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:55:36 2015 +0100

    Revert debug console changes.

commit 52f643c3dc524a837f56268b6da4881187204165
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:49:28 2015 +0100

    Revert extra logging

commit 23645f9fea
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:47:55 2015 +0100

    How did you get there

commit 8153388f19
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:45:12 2015 +0100

    Update copyright headers.

commit fa9e279259
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:43:27 2015 +0100

    Remove logging

commit 47a405543c
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:42:05 2015 +0100

    Show login state correctly for Amazon.

commit 748d88d993
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:28:55 2015 +0100

    Ensure Amazon is connected before serving URLs.

commit 25ec9c65f4
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:22:28 2015 +0100

    Refresh Amazon authorisation & follow changes.

commit 27c1a37173
Author: John Maguire <john.maguire@gmail.com>
Date:   Thu Mar 26 18:27:27 2015 +0100

    Revert unneeded OAuthenticator change.

commit 3594af5be1
Author: John Maguire <john.maguire@gmail.com>
Date:   Thu Mar 26 16:52:19 2015 +0100

    Initial support for Amazon Cloud Drive.
2015-03-27 14:56:08 +01:00
Arnaud Bienner f3426c05c7 Don't call gst_deinit when exiting Clementine.
It sometimes cause a deadlock since we migrated to GStreamer 1.0.
And it seems we shouldn't need to call it as we are "a normal application":
http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/gstreamer-Gst.html#gst-deinit
2015-03-25 22:23:13 +01:00
Arnaud Bienner 7ae9e0dd9b Set starting_up_ to false in playlist container when manager is done adding playlists.
Otherwise, it was never set to false at startup if no "current_playlist" was saved in the settings, then there was no new value saved for "current_playlist".
Fixes #4011.
2015-03-25 22:13:39 +01:00
Ivan Leontiev aba0517b4c Fix memory leak in networkremote. 2015-03-24 09:22:02 +00:00
Clementine Buildbot 791aa482c2 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-03-23 10:01:17 +01:00
Clementine Buildbot b50c51200c Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-03-16 10:01:20 +01:00
Arnaud Bienner 5b2e4419ae Don't check AXAPIEnabled when initializing the shortcuts, fixes media keys not working on OS X.
Fixes issue #3958.
2015-03-15 13:40:27 +01:00
Arnaud Bienner 5e45f59e2c Fix crash in Grooveshark.
Not sure how I end up with this null pointer, but better to always to this sanity check.
2015-03-11 23:07:20 +01:00
Clementine Buildbot 3bad88d01e Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-03-09 10:01:15 +01:00
John Maguire 705cdf11fc Move ScopedNSAutoreleasePool to ext 2015-03-02 17:51:17 +01:00
John Maguire 7823d95a07 Merge pull request #4756 from paperbagcorner/fix-paths
Construct filenames with correct paths on all platforms
2015-03-02 12:18:20 +01:00
John Maguire 66333d2940 Merge pull request #4758 from Chocobozzz/seafile_info
Try to make Seafile implementation more robust
2015-03-02 12:17:48 +01:00
Clementine Buildbot b6fd781ace Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-03-02 10:01:13 +01:00
Arnaud Bienner 946c0381d1 Don't set thread priority in LibraryWatcher constructor, as this is executed in the main thread.
Do it when thread actually starts (create a new Thread class for this purpose).
Fixes #4523.
2015-02-28 16:44:32 +01:00
Krzysztof Sobiecki 24b6fbf36c Add ability to parse more of "innovative" datetime formats. close #4760 2015-02-27 02:11:53 +01:00
Chocobozzz 2804ab32ec Change the name of the task when updating the libraries in the Seafile
service and clean the code
2015-02-23 15:27:20 +01:00
Clementine Buildbot 0f2d7b9879 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-02-23 10:01:28 +01:00
Chocobozzz 4b1a6651b1 Stop adding new songs if we cancelled the seafile indexing 2015-02-21 16:28:13 +01:00
Arnaud Bienner 2986ca23e6 Fix Spotify drag n drop.
Was partially broken since commit ee7e2ec26c.
2015-02-21 13:42:01 +01:00
Mattias Andersson 8ad0e93381 Construct file paths correctly on all platforms 2015-02-20 19:19:45 +01:00
Chocobozzz ec60d1174c Fix disconnecting a closure, forgot it was single shot 2015-02-20 16:09:15 +01:00
Chocobozzz 716064a006 Try to make seafile implementation more robusts and more verbose 2015-02-20 15:15:55 +01:00
Mattias Andersson 7f4d467c27 Make the code clearer. 2015-02-19 16:49:42 +01:00
Mattias Andersson 666faa5b37 Simplify some things. Use iterators instead of non-const references in
two loops.
2015-02-19 13:31:53 +01:00
Mattias Andersson f7185101ce Update the target file name after transcoding
After a transcoding job is complete, we need to update the corresponding
filename since the transcoder, rather than overwriting an existing file,
changes the filename of the output file. This ensures that the right
file is tagged later on.
2015-02-19 11:07:06 +01:00
Mattias Andersson 7d0d7be568 Some ui changes to the ripcd dialog.
- Move the Rip audio CD menu item to the Tools menu.

- Hide the progress bar if the CD ripper isn't working when the CD ripping
dialog is shown.
2015-02-18 20:08:02 +01:00
Mattias Andersson eed0c0d45f Assorted edits to the ripper class.
- The constructor of the AlbumInformation struct now takes no arguments.

- Only add tracks to the rip list if their track numbers are valid.

- Only call cdio_get_media_changed if we have a valid cdio_ object.

- Add a description of the ripper class.
2015-02-18 20:08:02 +01:00
Mattias Andersson fc2e4db229 Split the CD ripper into two classes
Separate the cd ripper dialog from the ripper itself.
2015-02-18 20:08:02 +01:00
Mattias Andersson eb8a618197 Move the CD ripper into its own directory. 2015-02-18 20:08:02 +01:00
John Maguire fb2b91c874 Remove some more obsolete os x version checks. 2015-02-18 18:03:46 +01:00
John Maguire 484db9d92b Remove obsolete snow leopard check. 2015-02-18 17:29:07 +01:00
John Maguire e5508ed53c Remove check for NSUserNotification support. 2015-02-18 17:22:01 +01:00
Clementine Buildbot 5709f3c5b8 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-02-16 10:01:27 +01:00
David Sansome b268771c3a Merge pull request #4750 from DevynCJohnson/patch-1
Update equalizer.cpp
2015-02-16 07:35:50 +11:00
Arnaud Bienner ce50cbe09f Fix compile issue on Yosemite 2015-02-15 16:43:36 +01:00
Devyn Collier Johnson b63d1fb661 Update equalizer.cpp
I added more presets for additional generas
2015-02-15 09:32:30 -05:00
John Maguire f73d2f4d24 Merge pull request #4740 from sobkas/small_fixes
Small fixes for podcasts
2015-02-11 16:11:04 +01:00
Clementine Buildbot 1f15df9936 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-02-09 10:01:26 +01:00
Arnaud Bienner ee7e2ec26c Ability to add tracks to Spotify starred playlist by drag and drop 2015-02-07 14:40:34 +01:00
Krzysztof Sobiecki 9934efc76b Small fixes for podcasts 2015-02-06 23:38:36 +01:00
John Maguire fbf22ccf3b Merge pull request #4739 from Chocobozzz/subsonic_fix
Emit scanfinished when the library is empty
2015-02-06 11:33:34 +01:00
Chocobozzz 5df8471ad6 Emit scanfinished when the library is empty 2015-02-06 11:23:57 +01:00
John Maguire af8f4100cd Fix crash when trying to fingerprint but missing a plugin. 2015-02-03 18:13:23 +01:00
John Maguire f2e6d665f3 Remove references to libindicate-qt 2015-02-03 13:48:32 +01:00
John Maguire 33117a1b44 Fix name of pulse audio gstreamer sink. 2015-02-03 13:32:41 +01:00
John Maguire 1a01b825da Remove Discogs support.
Fixes #4735
Downloading album covers now requires per-user access tokens.
2015-02-03 13:10:13 +01:00
Clementine Buildbot 5b46923034 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-02-02 10:01:25 +01:00
Fletcher Dostie 5fc4be803b Add Now Playing widget option: No Song Details 2015-01-26 13:11:19 -05:00
Clementine Buildbot 9dbd58276b Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-01-26 10:01:29 +01:00
Arnaud Bienner 43768d4af8 Small modifications to previous pull request:
- remove reference to iPod, as this is not iPod specific IMO
- make comment clearer
2015-01-19 15:01:33 +01:00
ArnaudBienner 29bcd2e15c Merge pull request #4692 from asiviero/previous_restart
Added iPod-like behavior to previous button (closes #4638)
2015-01-19 14:56:40 +01:00
John Maguire 87fed5d0f4 Merge pull request #4715 from Chocobozzz/albumartist_flac
Fix album artist for FLAC/OGG files (with vorbis comments)
2015-01-19 10:57:31 +01:00
Clementine Buildbot 0712978866 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-01-19 10:01:26 +01:00
Chocobozzz b96c1f060f Add tests to check the tag edition of FLAC/OGG files and make format 2015-01-17 12:11:33 +01:00
Chocobozzz 2a7d4e6d5e Improve edit tag when set values 2015-01-17 11:31:02 +01:00
John Maguire c96502ef4b Merge pull request #4712 from Chocobozzz/skyfm
Change sky.fm to radiotunes.com
2015-01-15 22:29:13 +01:00
Chocobozzz 5e5738f642 Make format 2015-01-15 19:58:20 +01:00
Chocobozzz 7e9f8d75c6 Change sky.fm to radiotunes.com 2015-01-15 18:48:27 +01:00