Grace Dolphy
bdda50b28f
Continuation of "Seek instead of navigation with arrow keys" #5550 , now allows up arrow key. ( #5721 )
...
* Continuation of "Seek instead of navigation with arrow keys" #5550 , now allows up arrow key to not restart the song over when the library is in focus. Works as usuhal when playlist is in focus (song gets started over).
* Update playlistview.cpp
Added in the part that is responsible for seeking properly.
2017-05-30 18:19:08 +01:00
Rix
8ff7d5750c
SoundCloud service simple search limit is set. ( #5738 )
...
SoundCloud search limit it set to 100. Pagination may be added soon. (see SoundCloud HTTP api: https://developers.soundcloud.com/docs/api/guide#pagination )
2017-05-30 18:17:40 +01:00
Clementine Buildbot
322e49d20c
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2017-05-29 10:00:58 +00:00
Clementine Buildbot
f8f6feff34
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2017-05-15 10:01:16 +00:00
Elias Lattash
f854bc5deb
Simpler iconloader::Load() logic ( #5706 )
...
This fixes a bug when clementine uses an icon from the system, even though it exists in it the *data* folder.
For example: the icons at the top of *playlistlistview.ui*, and at the top of *fileview.ui*
2017-05-08 12:07:59 +01:00
Clementine Buildbot
61e6fc7815
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2017-05-08 10:01:07 +00:00
Clementine Buildbot
e8dbea8c93
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2017-05-01 10:00:55 +00:00
Clementine Buildbot
c1e7887857
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2017-04-24 10:00:59 +00:00
Grace Dolphy
52f1982353
Delete Undo Fix Attempt - Should Solve Issue #5701 Using Clementine to delete a song from disk should not be added to the undo stack ( #5702 )
...
* Fix delete functionality. Skips to next song if deleted song is also currently playing.
* Added in a bool to determine if the song being deleted is meant to be deleted from the disk or just from the playlist. Took advantage of the unused variable located in removeRows to distinguish between the two options. No longer adds delete from disk to the undo stack, and deleting from the playlist goes to undo stack as it should.
* Added in a bool to determine if the song being deleted is meant to be deleted from the disk or just from the playlist. Took advantage of the unused variable located in removeRows to distinguish between the two options. No longer adds delete from disk to the undo stack, and deleting from the playlist goes to undo stack as it should.
* Update mainwindow.cpp
* Formatting Changes
* Update playlist.cpp
Simplified condition statement.
* Added in a missed boolean for RemoveSelected
* Update playlistview.cpp
2017-04-18 14:29:25 +01:00
Clementine Buildbot
5acbcbb2ec
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2017-04-17 10:01:00 +00:00
Clementine Buildbot
edccd95916
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2017-04-10 10:00:55 +00:00
Clementine Buildbot
2c60481f74
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2017-04-03 10:00:57 +00:00
Grace Dolphy
9f00e021f6
This fixes "First track always the same in shuffle #793". Adding this call in the if statement allows a reshuffle to happen after the playlist ends so that when the playlist will restart, it will already have a new set location to go to. ( #5689 )
2017-03-31 11:49:41 +01:00
Mark Furneaux
fba9e8dd69
Fix psychedelic mode on analysers ( #5688 )
...
* Fix psychedelic mode
* Remove unnecessary checks
When the code isn't broken, these are just a waste
2017-03-31 11:48:28 +01:00
Grace Dolphy
672d00be05
Fixes the issue "Seek instead of navigation with arrow keys #5550". Now allows the leaf to be closed by arrow left at any point of the leaf, not only the parent, and if the library is focused and arrow keys are pressed and there is nothing to open or close, the request is ignored (no seek) ( #5684 )
2017-03-30 18:02:49 +01:00
MelissaManley97
a5d12d0d10
Request to merge a fix for a crash during searching under Internet Tab ( #5682 )
...
* Changing ClearSearchResults order.
If search_ is null, there is no point in clearing it.
* Update to fix 12 (Crash when searching under Internet tab with Spotify)
* Formatting Fixes
2017-03-28 17:38:55 +01:00
Santiago Gil
0b34586e52
Fix some warnings shown on start-up ( #5679 )
...
* Fix 'RGB parameters out of range' with psychedelic colors
* Fix 'edit-find' icon name
* BlockAnalyzer::drawBackground(): do not attempt to paint on a null background
* Use qBound()
2017-03-27 12:57:24 +01:00
santigl
18d2e35bc6
Register QAbstractSocket::SocketState meta type
2017-03-27 12:56:39 +01:00
Clementine Buildbot
0f4db74e0c
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2017-03-27 10:00:55 +00:00
santigl
e3ece3d4c4
SaveToTemporaryFile(): use QTemporaryFile directly
2017-03-21 10:50:12 +00:00
santigl
35e274c497
Refactor SongLoader::LoadRemotePlaylist()
2017-03-21 10:50:12 +00:00
santigl
f44414db81
Add Utilities::SaveToTemporaryFile()
2017-03-21 10:50:12 +00:00
santigl
f609bc793f
Fix remote-playlist load
2017-03-21 10:50:12 +00:00
Clementine Buildbot
33aa38bbdd
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2017-03-20 10:00:53 +00:00
santigl
a034c2d4d0
Remove non-allowed characters in playlist filename when saving. ( Fixes #5460 )
2017-03-16 15:18:02 +00:00
John Maguire
f7eea6c505
static_cast<:: apparently confuses older GCC.
2017-03-14 17:34:42 +00:00
Jacob Henner
2d1b425493
Fixes #5660 - compile error
2017-03-14 17:28:06 +00:00
santigl
6c9bc43bbb
Refactor analyzers for new FHT modifications. Use QVectors where possible. Make readability changes in the code.
2017-03-13 18:56:37 +00:00
santigl
6a19afde15
Refactor FHT class: use QVector and const values, remove unnecesary memory handling.
2017-03-13 18:56:37 +00:00
Clementine Buildbot
b7fb649b8f
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2017-03-13 10:00:55 +00:00
Jan Paul Erkelens
0215707810
Uses effective fields for album hashing and comparison ( #5653 )
2017-03-08 12:22:50 +00:00
Santiago Gil
62bc647cbc
Roll back to the cache naming conventions for covers ( #5651 )
2017-03-07 11:46:54 +00:00
santigl
99ad5dcd2d
Refactor EffectiveAlbumArtistName()
2017-03-06 18:47:34 +00:00
santigl
a8cbb3b18a
Unlock DB mutexes implicitly using scopes. Add error handling for query.
2017-03-06 18:21:27 +00:00
santigl
f5bd7ef5c0
ItemHasCover(): Replace pointer with reference
2017-03-06 18:21:27 +00:00
santigl
82f0d261fa
Use the 'effective_album' title when searching for a track's cover
2017-03-06 18:21:27 +00:00
santigl
e30e6da065
Add 'effective_album' property to Song
2017-03-06 18:21:27 +00:00
santigl
2c643513e2
Refactor icon handling. Make empty-cover filtering work again.
2017-03-06 18:21:27 +00:00
santigl
deb7c33c64
Add support for 'album artist' field in the LibraryBackendInterface
2017-03-06 18:21:27 +00:00
santigl
58b7c62f25
Make Cover Manager aware of 'album artist' field
2017-03-06 18:21:27 +00:00
santigl
62cec8cf28
Prioritize album artist in cover search and manager
2017-03-06 18:21:27 +00:00
John Maguire
5d0cf343d5
Use new clementine images API.
2017-03-06 18:15:59 +00:00
Clementine Buildbot
3d80f7e1e2
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2017-03-06 10:00:57 +00:00
Domenico Iezzi
3b51f80fa3
Small improvements to Cover Manager ( #5645 )
...
* nocover icon was previously loaded and used with the default size
(24x24), causing the list item without a cover in the QListWidget to be
shorter in height with respect to the others. Now the icon is
initialized to 120x120, which is the default size of the list elements.
* Added some padding between "Fetch Missing Cover" and "Export
Covers" buttons.
2017-03-03 11:49:47 +00:00
Santiago Gil
30e3fdb9cc
Fix overflow in MoodbarProxyStyle ( fixes #5638 ) ( #5643 )
2017-03-02 13:10:21 +00:00
John Maguire
27bf50d702
Do not log sensitive data in OAuthenticator.
2017-02-27 12:41:34 +00:00
Clementine Buildbot
973f32c061
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2017-02-27 10:00:52 +00:00
Andreas Muttscheller
652f38ac84
Fix C:\data cache directory for portable builds
...
Lastfm needs a NetworkAccessManager which is created during the
initialization of lastfm in main.cpp, it also sets a cache directory.
For the portable version, GetConfigPath uses
QCoreApplication::applicationDirPath() to get the current directory of
Clementine. If no QApplication (or QtSingleApplication in Clementines
case) was instantiated, it returns /data on Linux or C:\data on Windows
for the cache config path.
This commit changes the order so lastfm will be initialized after
QtSingleApplication was created and the correct cache config path will be
returned.
Fixes #5354
2017-02-26 11:20:10 +01:00
John Maguire
1aed6193e7
Fix intergalactic FM URLs.
2017-02-21 14:24:50 +00:00
Clementine Buildbot
3dd4375c77
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2017-02-20 10:00:57 +00:00
Morris Hafner
8a6cc8b506
Add missing <functional> includes ( #5630 )
2017-02-13 16:46:46 +00:00
Clementine Buildbot
4325be6944
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2017-02-13 10:00:46 +00:00
Clementine Buildbot
9967bd4194
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2017-02-06 10:00:57 +00:00
Clementine Buildbot
6483510bca
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2017-01-30 10:00:44 +00:00
Clementine Buildbot
df0e7ab203
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2017-01-23 10:00:46 +00:00
Ted Stein
69cddf70ef
macOS: Clear stale native notifications on 10.9+. ( #5601 )
2017-01-18 13:51:00 +00:00
Clementine Buildbot
b463e63dde
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2017-01-16 10:00:51 +00:00
Ilya Selyuminov
1a477201ed
Use CaseInsensitive file type checking #5499 ( #5592 )
...
* Fix Seafile setting page loading
Check access_token instead of QSetting parameters to make
sure that we're logged in.
* Use CaseInsensitive file type checking (#5499 )
CloudFileService and TagReader classes use
QString::endWith() method for checking file type.
This method is CaseSensitive by default.
2017-01-12 15:58:44 +00:00
Clementine Buildbot
7ce7fe185e
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2017-01-12 13:22:21 +00:00
John Maguire
becb0b3d7f
Remove some stray vkontakte code
2017-01-11 18:51:12 +00:00
John Maguire
c7b8aacad8
Remove support for VK
...
Fixes #5591
2017-01-11 18:08:43 +00:00
Marko Hauptvogel
57d00394ee
Bugfix for resume playback on start
...
This fixes issue #5365 .
Because of the asynchronous loading of playlists introduced by
09e83935
, the resume playback on startup logic finds the active
playlist as empty, because it is not restored yet. By attaching
the playback resume to the RestoreFinish signal, the playback
will be triggered as soon as the playlist is restored. It may be
possible (but unlikely) that the playlist will already be restored
before we wait for the signal, and playback won't be resumed.
Signed-off-by: Marko Hauptvogel <marko.hauptvogel@googlemail.com>
2017-01-05 17:09:57 +00:00
Santiago Gil
00c96f7334
Consider depth levels in path sorting ( #5445 ) ( #5573 )
2016-12-31 13:22:10 +00:00
Santiago Gil
d3898d2f47
Add dialog to display streams' audio details ( #5547 )
...
* Add Stream Details window
* Fix capitalization in StreamDiscoverer::Discover()
* StreamDiscoverer::Discover(): get URL by const reference
* Refactor StreamDiscoverer::Discover
* Rename StreamDiscoverer callbacks
* StreamDiscoverer::OnDiscovered: fix nullptr comparison
* StreamDiscoverer: rename DiscoverFinished signal
* StreamDiscoverer::DataReady: receive const reference
* StreamDiscoverer: Remove unsigned types
* StreamDetailsDialog: rename Close slot
* StreamDetailsDialog: rename ui pointer to ui_
* MainWindow::ShowStreamDetails: receive a const reference
* StreamDetailsDialog: use unique_ptr, remove unsigned types
2016-12-21 16:57:04 +00:00
Mark Furneaux
589d641955
Fix playlist save on dialogs which do not enforce extensions ( #5496 )
...
like GTK+
2016-12-21 14:41:48 +00:00
Santiago Gil
1c0891202d
Let the audio sink autonegotiate the bit depth. (Possible fix for #5533 ) ( #5541 )
2016-12-21 14:40:40 +00:00
John Maguire
bd2de93e3c
Add more override specifiers.
2016-12-20 14:16:42 +00:00
John Maguire
df5c53af84
Add "override" to SpotifyService.
2016-12-20 13:02:06 +00:00
Bigard Florian
6901c9b1b6
Fix podcast episodes forgotten ( #5560 )
2016-12-18 15:48:08 +00:00
John Maguire
da90d1ccf2
Fix cross compiling for mac
2016-12-15 18:45:51 +00:00
John Maguire
6f356592a5
Fixes for cross compiling for mac.
2016-12-15 11:36:05 +00:00
Chocobozzz
ded3126857
Add compatibility with chromaprint >= 1.4
2016-12-08 23:12:17 +01:00
John Maguire
5e7dd00024
Use a flickr group instead of a tag for kittens.
...
Fixes #5531
2016-11-14 12:55:24 +00:00
John Maguire
d19ee71443
Try disabling SPMediaKeyTap on Sierra+.
...
Update issue #5497
2016-11-09 13:58:39 +00:00
John Maguire
420601f10a
Add support for classicalradio.com
2016-11-07 18:22:06 +00:00
Nicolas Martinelli
650f06f7ad
Fix Subsonic endpoint
...
According to the documentation, the endpoint is `getAlbumList`, not
`GetAlbumList`. This typo makes the complete feature not working at
all.
Source: http://www.subsonic.org/pages/api.jsp#getAlbumList
2016-10-20 22:08:26 +02:00
Clementine Buildbot
1a2f6e2fe8
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2016-10-13 15:18:59 +00:00
Clementine Buildbot
ac90f0b091
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2016-09-26 10:00:52 +00:00
Clementine Buildbot
20ed72fe11
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2016-09-19 10:00:51 +00:00
Jan Suchomel
622a3e478a
Add support for displaying lyrics from a Vorbis comment ( #5495 )
...
* Added support for displaying lyrics from Vorbis Comments.
* Fixed style issues
2016-09-18 13:23:39 +01:00
Andreas Muttscheller
e5ab3e786f
Network Remote: Check bytesAvailable >= 4 before reading length integer
...
This caused Clementine Remote to stop working on Android N. writeInt()
splits the 4 bytes across multiple tcp frames. Clementine would read
a wrong length and thus fail to read any protocol buffer data.
2016-09-12 12:07:28 +02:00
Clementine Buildbot
363e88a6c4
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2016-09-12 10:00:50 +00:00
Matt
d96a04431a
added popular libraryfiltergroup filter: Album artist/Album ( #5476 )
2016-09-06 07:28:55 -05:00
Santiago Gil
8da53abcfa
Add option to show/hide sidebar ( #5459 )
2016-09-06 07:28:25 -05:00
John Maguire
afb7e1db36
Add attribution to wikipedia artist biographies
2016-09-05 15:17:14 +01:00
Clementine Buildbot
8ad56819b2
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2016-09-05 10:00:52 +00:00
Clementine Buildbot
d70778b99b
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2016-08-29 10:00:48 +00:00
Ilya Selyuminov
d9b3a9302a
Update playlist virtual order after sorting ( #5436 ) ( #5466 )
2016-08-26 08:59:26 -05:00
Ilya Selyuminov
09b0fab87c
Add new command line option for creating a new one playlist #5373 ( #5468 )
2016-08-26 08:59:11 -05:00
Mark Furneaux
0ce9e1696c
Don't cache missing covers ( #5471 )
...
They might change later
2016-08-23 09:26:15 -05:00
Clementine Buildbot
700361a9b7
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2016-08-22 10:00:43 +00:00
Clementine Buildbot
a99dc10cd6
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2016-08-08 10:00:44 +00:00
Clementine Buildbot
0b5fb0ccff
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2016-08-01 10:00:48 +00:00
ArnaudBienner
af8ba8946e
Merge pull request #5452 from santigl/path-sort-lowercase
...
Ignore case in path comparison (#5445 )
2016-07-26 16:17:16 +02:00
Santiago Gil
3d399cec8c
Restructure edittagdialog layout (corrects #5437 ) ( #5450 )
2016-07-25 11:45:57 +01:00
Clementine Buildbot
b702edb3ab
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2016-07-25 10:00:57 +00:00
santigl
9ddd630b3b
Ignore case in path comparison ( #5445 )
2016-07-24 16:15:59 -03:00
Clementine Buildbot
17beaa7a88
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2016-07-18 10:32:08 +00:00
Mattias Andersson
516391a599
Urlencode file names in smart playlists ( #5441 )
2016-07-13 17:56:01 +01:00
Josef Vitu
32ed8ebba4
Back/Forward mouse buttons support ( closes #4809 ) ( #5440 )
2016-07-12 21:47:42 +01:00