Funkwhale/Clementine-audio-player-Mac-Linux-Windows
1
0
Fork 0
mirror of https://github.com/clementine-player/Clementine synced 2024-12-25 17:12:35 +01:00
Code Issues Releases Wiki Activity
7,120 Commits 23 Branches 543 Tags 240 MiB
66fdc935ac
Commit Graph

7120 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jonas Kvinge
66fdc935ac Fix formatting 2019-07-21 14:38:15 +02:00
Jonas Kvinge
1a2274bd2b Merge branch 'master' into qt5-update 2019-07-21 14:20:59 +02:00
John Maguire
b910cd402e
Merge pull request #6373 from jonaski/taglib 
Add missing taglib configure checks
 2019-07-21 08:55:23 +01:00
Jonas Kvinge
21762dd402 Add missing taglib configure checks 2019-07-20 21:40:14 +02:00
Clementine Buildbot
a2dcb33d84 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-07-20 17:55:03 +00:00
Jonas Kvinge
5bb35bf08a Fix crash in messagereply (#6372) 
* Fix crash in messagereply

* Fix formatting
 2019-07-20 18:52:37 +01:00
lordlethis
c9800a4dc9 Fix blank window when restoring from systray (#6351) 
* Fix blank window when restoring from systray

This applies the fix qBittorrent used for this same issue:
https://github.com/qbittorrent/qBittorrent/issues/9240,
so credit goes to those guys

* Fix whitespace
 2019-07-13 12:57:27 +01:00
Clementine Buildbot
da0447142b Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-07-09 00:25:09 +00:00
Clementine Buildbot
a0e4785346 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-07-02 00:25:09 +00:00
John Maguire
9cdf0bb0f9
Merge pull request #6359 from hal7df/dbus-notification-fix 
Support per-app notification settings in KDE Plasma 5.16
 2019-06-17 10:14:08 +01:00
Paul Bonnen
b697e962b3 Make D-Bus 'desktop-entry' hint match system filename. 
"Clementine" (as returned by QCoreApplication::applicationName())
does not match the system .desktop file name (but it may match user
.desktop files, as was the case for me); Clementine won't be picked up
as an application in KDE Plasma notification settings unless it case
matches.
 2019-06-16 13:03:47 -04:00
Paul Bonnen
8483d24a04 Add `desktop-entry' hint to D-Bus notifications. 
The notification system in KDE Plasma 5.16+ requires a 'desktop-entry'
hint in the D-Bus message to enable per-application notification
settings.
 2019-06-16 12:37:53 -04:00
John Maguire
9af827b6ac
Merge pull request #6355 from Turpster/qt5 
Fixed Complete Tags Automatically
 2019-06-09 18:18:41 +01:00
Jonas Kvinge
9e85eb2c0f
Fix gst_buffer_unref assertion in chromaprinter 2019-06-09 10:29:41 +01:00
John Maguire
dd19df6ee4
Merge pull request #6354 from smithjd15/tagZeroValues 
Fix a number of zero-value tag issues (New PR)
 2019-06-05 10:16:10 +01:00
Clementine Buildbot
c1af92d24d Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-06-04 00:24:56 +00:00
James D. Smith
32e867a84b clang-formatter changes. 2019-05-31 11:25:38 -06:00
James D. Smith
96a7e18a8d Fix a number of potential zero-value field values. 2019-05-31 11:25:38 -06:00
Clementine Buildbot
4ed4eec817 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-05-21 00:25:05 +00:00
Clementine Buildbot
ebdaaaf714 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-05-14 00:25:05 +00:00
Clementine Buildbot
d3e79436af Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-05-07 00:25:10 +00:00
Clementine Buildbot
44ac3936ea Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-04-30 00:25:05 +00:00
Clementine Buildbot
013ee87177 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-04-27 16:41:30 +00:00
John Maguire
96c7374689
Merge pull request #6338 from jonaski/chromaprinter 
Fix gst_buffer_unref assertion with chromaprinter
 2019-04-27 17:39:21 +01:00
Jonas Kvinge
8094957e09 Fix gst_buffer_unref assertion in chromaprinter 2019-04-26 20:40:42 +02:00
Clementine Buildbot
d079f00cfe Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-04-23 00:25:03 +00:00
John Maguire
3b76fa6275
Merge pull request #6335 from aerusso/pulls/movable-section 
setFirstSectionMovable() in playlistview.cpp
 2019-04-23 00:46:19 +01:00
Antonio Russo
40326bb94b setFirstSectionMovable() in playlistview.cpp 
Qt 5.11 added a function allowing the first column in a list to be set
to be movable.  Contingent on its availability, make the first column
of the playlist viewer draggable.
 2019-04-22 17:31:16 -04:00
John Maguire
d52da64a73
Merge pull request #6334 from aerusso/pulls/revert-nvidia-blacklst 
Revert "Blacklist all NVidia drivers"
 2019-04-21 14:55:49 +01:00
Antonio Russo
783dada13e Revert "Blacklist all NVidia drivers" 
In 2011, there was a bug that caused NVIDIA drivers to hang
Clementine on shutdown. In 2012, only some drivers had the
fix for this issue. Now, in 2019, we do not need to work
around this bug. By reverting commit

c2723008a2

we work around known bad drivers, but do not penalize all
NVIDIA users for this ancient bug.
 2019-04-21 09:11:33 -04:00
Clementine Buildbot
b11316ff03 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-04-16 00:25:05 +00:00
James D. Smith
553c4013cf Merge remote-tracking branch 'upstream/master' 2019-04-15 18:07:05 -06:00
Clementine Buildbot
7c5a050ab8 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-04-13 18:32:41 +00:00
John Maguire
40400e850d
Merge pull request #6323 from jbroadus/async-load-errors 
Add error handling path for async song loading.
 2019-04-13 19:30:24 +01:00
Clementine Buildbot
4630032565 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-04-12 10:12:55 +00:00
Jim Broadus
babff78025 Add error handling path for async song loading. 
Async song loading can fail without user feedback. This change adds return codes
to these async load functions. It will now produce an error dialog in simple
scenarios (test case is user selecting a file that is not readable). Other cases,
such as directories and playlists, aren't yet covered.
 2019-04-10 11:49:09 -07:00
John Maguire
17d95b7833
Merge pull request #6286 from smithjd15/apeFiles 
More bits for APE files (Finish APE file support)
 2019-04-10 11:13:51 +01:00
John Maguire
e3609b27cd
Merge pull request #6296 from ShFil119/impr/simplify 
Simplify some statements
 2019-04-10 11:12:09 +01:00
John Maguire
878b366bfb
Merge pull request #6324 from jbroadus/set-min-fade-time 
Set non-zero minimum for fade times.
 2019-04-10 11:10:47 +01:00
Clementine Buildbot
641ab64ccc Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-04-09 00:25:03 +00:00
Jim Broadus
cc295a4c4c Set non-zero minimum for fade times. 
QTimeLine duration must be greater than 0. If set to 0, a default of 1000ms will
be used. To avoid this, enforce a minimum of 1ms for pause and cross fade values
if those fades are enabled.
 2019-04-07 21:31:30 -07:00
James D. Smith
bd89a1d2de Fixes for APE filetype. 2019-04-01 22:56:50 -06:00
James D. Smith
2752d61d2a clang-formatter changes. 2019-04-01 22:23:04 -06:00
James D. Smith
2adf9d068d Improved support for APEv2 tags. 2019-04-01 22:22:03 -06:00
Clementine Buildbot
f6ba37dbc5 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-04-02 00:25:06 +00:00
John Maguire
d8e0e7e67e
Merge pull request #6314 from jbroadus/fix-gobject-leak 
Fix several gstreamer object leaks.
 2019-03-26 09:51:06 +00:00
Jim Broadus
5c2ceb3490 Fix several gstreamer object leaks. 
There are a number of cases where gst_pipeline_get_bus,
gst_element_get_static_pad, and g_object_get are called without releasing
references. In addition to memory usage, some of these elements hold file
descriptors. In normal operation, two file descriptors are leaked for each
played track. The default fd ulimit for many linux distros is 1024. This
is likely the cause of the crash reported in issue 6309.

This change fixes the obvious and consistent leaks, but it's probably not a
complete solution. There are many error and corner conditions that need to be
examined.
 2019-03-25 23:22:09 -07:00
Clementine Buildbot
485f187e64 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-03-26 00:25:04 +00:00
John Maguire
a7f3e1bb65
Merge pull request #6311 from jbroadus/fix-potential-memory-leak 
Free decoder bin if error occurs during setup.
 2019-03-24 13:45:26 +00:00
Jim Broadus
ca8db288d5 Free decoder bin if error occurs during setup. 
In the case that an error occurs in ReplaceDecodeBin before the bin is added to
the pipeline, unreference the object to allow cleanup. This change also separates
CreateDecodeBinFromUrl from ReplaceDecodeBin, following the pattern of
CreateDecodeBinFromString.
 2019-03-23 22:33:17 -07:00