John Maguire
cb6cd7c485
Merge remote-tracking branch 'origin/master' into qt5
2019-10-04 16:51:43 +01:00
Clementine Buildbot
e2bc2eee90
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-09-24 00:24:59 +00:00
Clementine Buildbot
0c7b280b95
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-09-17 00:25:04 +00:00
Antonio Russo
c5c294ba14
fancytabwidget.cpp: reuse QSettings object
...
avoid excessive locking by reusing a common QSettings object in
loadSettings.
2019-09-10 18:41:18 -06:00
Antonio Russo
e2de5cd62e
fancytabwidget.cpp: prefer QString to std::string
...
Consistently use QString, rather than creating a std::string and
immediately casting to std::string
2019-09-10 18:41:18 -06:00
Antonio Russo
ccaa59cc66
Periodically save current playlist tab
...
Building on the previous commit, we save the current playlist (tab)
periodically as well.
Signed-off-by: Antonio Russo <antonio.e.russo@gmail.com>
2019-09-10 18:41:18 -06:00
Antonio Russo
e66fdd86da
Periodically save settings
...
Instead of immediately saving, which leads to poor performance,
and possible hardware damage (see #6057 ), limit saves to once
per second (similar to how KDE does it). It also guarantees
that only one save is required per second, by sharing a QSettings
object, and establishes a signaling framework to put other
setting save events into (but only uses this for the two major
offenders: playlist tab switching and window resizing).
This is in contrast to 6a312e7
, which simply deferred the save
until program exit, and caused problems for some people (see #6217
and #6209 ).
Signed-off-by: Antonio Russo <antonio.e.russo@gmail.com>
2019-09-10 18:41:18 -06:00
Clementine Buildbot
da6ff91241
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-09-10 00:25:00 +00:00
Clementine Buildbot
47f80d67c5
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-09-03 00:25:11 +00:00
Clementine Buildbot
b423808ddf
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-08-27 00:25:09 +00:00
Clementine Buildbot
3e7be7357e
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-08-22 11:13:28 +00:00
Clementine Buildbot
773f26a42d
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-08-22 10:30:35 +00:00
luz.paz
fb93ae4b02
Fix misc. source comment typos
...
Typos found via `codespell`
2019-08-21 23:43:16 -04:00
Jonas Kvinge
546078c317
Fix memory leaks ( #6376 )
2019-08-02 16:24:26 +01:00
Jonas Kvinge
8d921c15be
Fix memory leaks in database
2019-07-25 19:02:43 +02:00
John Maguire
75f18dab23
Merge pull request #6374 from jonaski/qt5-update
...
Qt5 update
2019-07-24 11:51:48 +01:00
John Maguire
3694bcfc82
Merge pull request #6371 from areading/limit_tagclient_procs
...
Introduce limit for number of tag client processes.
2019-07-22 10:56:03 +01:00
Andrew Reading
c76697b42c
Introduce limit for number of tag client processes.
...
Previously, the number of processes spawned was always
QThread::idealThreadCount() (returning the number of logical CPU
cores). On new systems with many cores, however, this can result
in 12, 16, 24, or ... processes being spawned, which is a bit
excessive.
This establishes a new config variable,
'max_numprocs_tagclients' within the Settings group, in order
to limit the maximum number of tag client processes that get
spawned. It also adds a means of setting this via the Behavior
page in Settings. It can be set to any integer in the interval
[1, QThread::idealThreadCount()]; it defaults to the maximal value
so as to emulate the old behavior.
2019-07-21 10:53:13 -07:00
Jonas Kvinge
66fdc935ac
Fix formatting
2019-07-21 14:38:15 +02:00
Jonas Kvinge
1a2274bd2b
Merge branch 'master' into qt5-update
2019-07-21 14:20:59 +02:00
Clementine Buildbot
a2dcb33d84
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-07-20 17:55:03 +00:00
lordlethis
c9800a4dc9
Fix blank window when restoring from systray ( #6351 )
...
* Fix blank window when restoring from systray
This applies the fix qBittorrent used for this same issue:
https://github.com/qbittorrent/qBittorrent/issues/9240 ,
so credit goes to those guys
* Fix whitespace
2019-07-13 12:57:27 +01:00
Clementine Buildbot
da0447142b
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-07-09 00:25:09 +00:00
Clementine Buildbot
a0e4785346
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-07-02 00:25:09 +00:00
Paul Bonnen
b697e962b3
Make D-Bus 'desktop-entry' hint match system filename.
...
"Clementine" (as returned by QCoreApplication::applicationName())
does not match the system .desktop file name (but it may match user
.desktop files, as was the case for me); Clementine won't be picked up
as an application in KDE Plasma notification settings unless it case
matches.
2019-06-16 13:03:47 -04:00
Paul Bonnen
8483d24a04
Add `desktop-entry' hint to D-Bus notifications.
...
The notification system in KDE Plasma 5.16+ requires a 'desktop-entry'
hint in the D-Bus message to enable per-application notification
settings.
2019-06-16 12:37:53 -04:00
Jonas Kvinge
9e85eb2c0f
Fix gst_buffer_unref assertion in chromaprinter
2019-06-09 10:29:41 +01:00
Clementine Buildbot
c1af92d24d
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-06-04 00:24:56 +00:00
Clementine Buildbot
4ed4eec817
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-05-21 00:25:05 +00:00
Clementine Buildbot
ebdaaaf714
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-05-14 00:25:05 +00:00
Clementine Buildbot
d3e79436af
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-05-07 00:25:10 +00:00
Clementine Buildbot
44ac3936ea
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-04-30 00:25:05 +00:00
Clementine Buildbot
013ee87177
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-04-27 16:41:30 +00:00
Jonas Kvinge
8094957e09
Fix gst_buffer_unref assertion in chromaprinter
2019-04-26 20:40:42 +02:00
Clementine Buildbot
d079f00cfe
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-04-23 00:25:03 +00:00
Antonio Russo
40326bb94b
setFirstSectionMovable() in playlistview.cpp
...
Qt 5.11 added a function allowing the first column in a list to be set
to be movable. Contingent on its availability, make the first column
of the playlist viewer draggable.
2019-04-22 17:31:16 -04:00
Antonio Russo
783dada13e
Revert "Blacklist all NVidia drivers"
...
In 2011, there was a bug that caused NVIDIA drivers to hang
Clementine on shutdown. In 2012, only some drivers had the
fix for this issue. Now, in 2019, we do not need to work
around this bug. By reverting commit
c2723008a2
we work around known bad drivers, but do not penalize all
NVIDIA users for this ancient bug.
2019-04-21 09:11:33 -04:00
Clementine Buildbot
b11316ff03
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-04-16 00:25:05 +00:00
Clementine Buildbot
7c5a050ab8
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-04-13 18:32:41 +00:00
John Maguire
40400e850d
Merge pull request #6323 from jbroadus/async-load-errors
...
Add error handling path for async song loading.
2019-04-13 19:30:24 +01:00
Clementine Buildbot
4630032565
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-04-12 10:12:55 +00:00
Jim Broadus
babff78025
Add error handling path for async song loading.
...
Async song loading can fail without user feedback. This change adds return codes
to these async load functions. It will now produce an error dialog in simple
scenarios (test case is user selecting a file that is not readable). Other cases,
such as directories and playlists, aren't yet covered.
2019-04-10 11:49:09 -07:00
John Maguire
17d95b7833
Merge pull request #6286 from smithjd15/apeFiles
...
More bits for APE files (Finish APE file support)
2019-04-10 11:13:51 +01:00
John Maguire
e3609b27cd
Merge pull request #6296 from ShFil119/impr/simplify
...
Simplify some statements
2019-04-10 11:12:09 +01:00
John Maguire
878b366bfb
Merge pull request #6324 from jbroadus/set-min-fade-time
...
Set non-zero minimum for fade times.
2019-04-10 11:10:47 +01:00
Clementine Buildbot
641ab64ccc
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-04-09 00:25:03 +00:00
Jim Broadus
cc295a4c4c
Set non-zero minimum for fade times.
...
QTimeLine duration must be greater than 0. If set to 0, a default of 1000ms will
be used. To avoid this, enforce a minimum of 1ms for pause and cross fade values
if those fades are enabled.
2019-04-07 21:31:30 -07:00
James D. Smith
bd89a1d2de
Fixes for APE filetype.
2019-04-01 22:56:50 -06:00
Clementine Buildbot
f6ba37dbc5
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-04-02 00:25:06 +00:00
John Maguire
d8e0e7e67e
Merge pull request #6314 from jbroadus/fix-gobject-leak
...
Fix several gstreamer object leaks.
2019-03-26 09:51:06 +00:00