94630bd58b
Merge pull request #6502 from jonaski/desktopwidget
...
Replace all uses of QDesktopWidget with QScreen
2020-01-05 00:29:33 +00:00
a240818b6c
Merge pull request #6501 from jonaski/compilations
...
Fix songs stuck in various artists
2020-01-05 00:28:15 +00:00
b10cc71c76
Merge pull request #6500 from jonaski/pixmapcache
...
Remove pixmap cache and pending art when removing parent nodes instead
2020-01-05 00:27:36 +00:00
52180a7484
Fix layouts with duplicate name in SmartPlaylistSearchTermWidget
2020-01-05 01:15:58 +01:00
5eb32b33c1
Replace QSet::toList() with QSet::values()
2020-01-05 00:58:33 +01:00
ddc8a5f010
Initialize QObject in constructor and add explicit
2020-01-05 00:21:04 +01:00
7f6e7f8b30
Fix formatting
2020-01-05 00:17:18 +01:00
f81a3aa8d8
Replace use of QString::sprintf with QString::asprintf
2020-01-05 00:12:32 +01:00
a70537b83f
Replace use of QStyleOptionFrameV3
2020-01-04 23:40:12 +01:00
39cdb7fc3f
Add fallthrough comment where fallthrough is intended
2020-01-04 23:29:19 +01:00
4c157a95dd
Replace use of QPalette::background with QPalette::window
2020-01-04 23:01:02 +01:00
28bbb74c26
Replace use of QColor::dark with QColor::darker
2020-01-04 23:00:40 +01:00
9e3461f818
Fix formatting
2020-01-04 21:24:31 +01:00
6a8f70285f
Replace all uses of QDesktopWidget with QScreen
2020-01-04 21:18:12 +01:00
39934dc302
Fix songs stuck in various artists
2020-01-04 18:27:42 +01:00
651965b905
Fix formatting
2020-01-04 18:12:44 +01:00
250b5ca0a6
Remove pixmap cache and pending art when removing parent nodes instead
2020-01-04 18:07:34 +01:00
a4a8726ddf
Fix formatting
2020-01-04 17:44:07 +01:00
30413767cb
Fix macOS filesystem listener (library watcher)
2020-01-04 17:38:55 +01:00
590d7f3823
Add an option to specify a gpodder server.
...
Add an "Advanced Settings" option to the gpodder sign in. If selected, a fully
qualified URL must be specified as the gpodder base. Upon successful login, the
URL is saved along with username and password. If advanced settings are not
selected, an empty URL is stored and the default will be used.
2020-01-03 22:46:15 -08:00
eec38a64d1
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2020-01-02 17:06:49 +00:00
e6e8090371
Merge pull request #6492 from jbroadus/fix-smartplaylist-crash
...
Fix smartplaylist crash
2020-01-02 17:04:11 +00:00
a164a5dffa
Fix smart playlist crash.
...
When QProxyStyle is given a base style, it take ownership of that object.
PlaylistView creates a proxy style based on its own style, but that is a shared
resource. When the PlayListView is destroyed, this object is destroyed.
Instead of passing style() to QStyle, pass nullptr. This will use the native
style.
2020-01-01 22:30:59 -08:00
963b272c4b
Don't crash if smartplaylist wizard plugin is not found.
2020-01-01 22:30:56 -08:00
e32ba7eac5
Gpodder login cleanup.
...
It's not necessary for the PodcastSettingsPage class to have knowledge of
GPodderSync's login implementation. Handling the network reply in a single
location sightly simplifies the code. It also makes the handling order
more deterministic.
2019-12-30 20:58:30 -08:00
a1da067002
Reset gpodder session cookies on logout.
...
A sessionid cookie is stored when logging in to gpodder. After logging out, a
subsequent login with the same user name but incorrect password will succeed,
ignoring the authorization header. The incorrect password will be stored for
future use.
To fix this, reset the cookie jar for GPodderSync's network access manager at
logout.
2019-12-30 14:19:08 -08:00
f9d4cd9f0d
Merge pull request #6485 from jbroadus/fix-gpodder-error-leak
...
Fix gpodder sync memory leaks in success cases.
2019-12-29 21:01:20 +00:00
36179a7197
Fix gpodder sync memory leaks in success cases.
...
A closure created by NewClosure that handles Qt signals is destroyed if the
signal object is destroyed, the slot object is destroyed, or the signal is
invoked. In the case where the sender is passed as a shared pointer, the
reference prevents the sender from being destroyed before the closure.
So for closures built to handle responses returned from ApiRequest in
GPodderSync, the closure object and the response object will only be destroyed
after the signal is invoked. In some cases, separate closures are built for
error signals as well. For these, only one closure will be destroyed. The other
closures and the response object will be leaked.
A simple fix for the success cases is to remove the unnecessary error case
closures and directly connect the signals to slots. This is low hanging fruit
and still leaves leaks in the error cases. Those cases will require a more
complete solution to properly manage the life cycle of the response object.
2019-12-29 10:11:29 -08:00
9e73aae821
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-12-29 16:40:32 +00:00
5e7e57df73
Set a 30 second timeout for gpodder requests.
2019-12-25 23:53:47 -08:00
77d5d8bdea
Add a timeout option to NetworkAccessManager.
...
In most cases, timeouts can be applied to a reply after a request has been made.
But some APIs, such as libmygpo-qt, don't always provide access to the reply or
provide abort methods. For these cases, add an optional timeout to
NetworkAccessManager. If set, create a NetworkTimeouts instance in createRequest
and add the reply. Use the reply as the parent so that it is destroyed when the
reply is destroyed.
2019-12-25 23:53:45 -08:00
82b185c087
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-12-24 00:25:44 +00:00
90a237716a
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-12-15 11:23:45 +00:00
715da8909f
Fix resuming playback position on startup
2019-12-14 17:22:16 +01:00
672b90659b
Merge pull request #6472 from cquike/xdg
...
Support for XDG_CONFIG_HOME and XDG_CACHE_HOME
2019-12-10 18:56:41 +00:00
a7ad66d028
Fix issues reported by clang-format
2019-12-10 18:45:06 +01:00
397145d21f
Remove obsolete forced setting of XDG_CONFIG_HOME.
...
Apparently this was introduced in 2011 as a workaround to solve a problem in
libimobiledevice. However already in 2013 the problem was solved
in libimobiledevice:
b811fbb05b
2019-12-10 18:05:55 +01:00
998f12699b
Merge pull request #6470 from lacc97/kglobalaccel
...
Add KGlobalAccel global shortcuts backend
2019-12-10 10:14:32 +00:00
ca2c6771fd
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-12-10 00:25:31 +00:00
7ef917008a
Fix formatting again
2019-12-09 17:02:42 +00:00
344989785b
Fix multiple triggers of shortcut actions
...
Also properly connect/disconnect from DBus signal upons register/unregister.
2019-12-09 16:58:32 +00:00
2307c15227
Fix style
2019-12-09 16:25:29 +00:00
f5ec88b529
Add support in GetConfigPath() for /pixmapcache directory
2019-12-07 23:30:14 +01:00
ab2f7c03ea
Use QStandardPaths to define Path_Root and Path_CacheRoot.
...
These two directories use QStandardPaths::ConfigLocation and
QStandardPaths::GenericCacheLocation respectively, with the
application name (Clementine) appended. The QStandardPaths class from QT
honors the XDG standards:
https://specifications.freedesktop.org/basedir-spec/basedir-spec-0.6.html
https://doc.qt.io/qt-5/qstandardpaths.html#writableLocation
2019-12-07 23:22:13 +01:00
a3531d749a
Actually fix formatting
2019-12-07 19:30:10 +00:00
0b6519bad4
Fix build with DBus disabled
2019-12-06 23:56:15 +00:00
8cab8fe180
Fix formatting
2019-12-06 23:53:40 +00:00
24a571769a
Initial KGlobalAccel support
2019-12-06 22:34:13 +00:00
440ac6dda2
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-12-03 00:25:13 +00:00
1e28f4e7dd
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-11-26 00:25:05 +00:00
23d0f3514d
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-11-18 16:20:16 +00:00
d8c020281e
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-11-15 17:28:36 +00:00
f71e99360b
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-11-15 12:34:01 +00:00
8b765a5257
Remove qtsparkle support
2019-11-14 20:53:46 +00:00
e0b04ec378
Merge pull request #6455 from jonaski/edittagdialog
...
Fix edit tag dialog
2019-11-13 23:24:19 +00:00
142f9f26c5
Merge pull request #6454 from jonaski/albumartist
...
Change remaining group by defaults to album artist
2019-11-13 23:11:16 +00:00
e985bd780a
Fix edit tag dialog
2019-11-13 20:47:14 +01:00
cdfc059cb1
Change remaining group by defaults to album artist
2019-11-13 20:20:44 +01:00
44c111941c
Fix updating song count
2019-11-13 19:20:17 +01:00
21848d62d8
Merge pull request #6450 from jonaski/compilations
...
Fix updating compilations
2019-11-13 18:01:29 +00:00
74d4f9e204
Merge pull request #6449 from paperbagcorner/removefile
...
Remove an unused file that had been left in the qt5 branch
2019-11-13 17:05:32 +00:00
6accd1e3db
Fix formatting
2019-11-13 17:39:29 +01:00
8d75f321de
Fix updating compilations
2019-11-13 17:25:54 +01:00
cd3d481eda
Remove an unused file that had been left in the qt5 branch
2019-11-13 09:48:34 +01:00
50663ddde0
Merge pull request #6448 from jonaski/librarywatcher
...
Remove watch for removed subdirectories
2019-11-12 19:57:16 +00:00
5898241190
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-11-12 19:25:52 +00:00
ca18a5584d
Fix formatting
2019-11-12 20:05:53 +01:00
fd35f20d26
Remove watch for removed subdirectories
2019-11-12 19:55:48 +01:00
1b35d3f6a3
Dont clear pixmap cache on model reset
2019-11-12 19:26:52 +01:00
796fa285f5
Fix formatting
2019-11-12 19:16:22 +01:00
04baa9ec0f
Remove album from pixmap cache when song is removed from library model
2019-11-12 19:08:42 +01:00
28f6bfd898
Merge pull request #6442 from jonaski/probequeue
...
Switch to queue2 for probe queue and set properties
2019-11-11 23:23:37 +00:00
2a2a71281a
Switch to queue2 for probe queue and set properties
2019-11-11 21:26:11 +01:00
b7c3173001
Merge pull request #6439 from jonaski/signalmapper
...
Replace all uses of QSignalMapper with C++11 lambda expressions
2019-11-10 19:13:31 +00:00
3f9b6b1192
Fix formatting
2019-11-10 15:21:08 +01:00
344023e6dd
Fix formatting
2019-11-10 15:16:39 +01:00
ba31c755ef
Replace all uses of QSignalMapper with C++11 lambda expressions
2019-11-10 15:07:12 +01:00
21da802630
Merge pull request #6438 from jonaski/remove-extra-semicolon
...
Remove extra ';'
2019-11-10 00:53:37 +00:00
9519829d1f
Fix formatting
2019-11-10 00:31:37 +01:00
d09c27f719
Remove extra ';'
2019-11-10 00:30:18 +01:00
0da490a5e1
Replace QString::null with QString()
2019-11-09 23:45:28 +01:00
f9627c2084
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-11-07 12:29:45 +00:00
04c85c2bb7
Merge pull request #6433 from clementine-player/qt5
...
Qt5
2019-11-07 12:27:25 +00:00
e72bccbf0d
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-11-05 00:25:15 +00:00
18c2b41615
Revert "Attempt to fix track change hang"
...
Queue2 tends to hang up on pause, unable to start playing
again. Pipeline actually stays PLAYING with ASYNC state
change, so it becomes impossible to unpause the player
without stop or forward/backward seeks.
This reverts commit 2b280de663
2019-11-02 10:16:42 +03:00
b3e2b4731b
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-10-29 00:25:20 +00:00
992311c185
Bunch of mac build fixes
2019-10-16 19:42:21 +01:00
cb6cd7c485
Merge remote-tracking branch 'origin/master' into qt5
2019-10-04 16:51:43 +01:00
e2bc2eee90
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-09-24 00:24:59 +00:00
0c7b280b95
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-09-17 00:25:04 +00:00
c5c294ba14
fancytabwidget.cpp: reuse QSettings object
...
avoid excessive locking by reusing a common QSettings object in
loadSettings.
2019-09-10 18:41:18 -06:00
e2de5cd62e
fancytabwidget.cpp: prefer QString to std::string
...
Consistently use QString, rather than creating a std::string and
immediately casting to std::string
2019-09-10 18:41:18 -06:00
ccaa59cc66
Periodically save current playlist tab
...
Building on the previous commit, we save the current playlist (tab)
periodically as well.
Signed-off-by: Antonio Russo <antonio.e.russo@gmail.com>
2019-09-10 18:41:18 -06:00
e66fdd86da
Periodically save settings
...
Instead of immediately saving, which leads to poor performance,
and possible hardware damage (see #6057 ), limit saves to once
per second (similar to how KDE does it). It also guarantees
that only one save is required per second, by sharing a QSettings
object, and establishes a signaling framework to put other
setting save events into (but only uses this for the two major
offenders: playlist tab switching and window resizing).
This is in contrast to 6a312e7#6217
and #6209 ).
Signed-off-by: Antonio Russo <antonio.e.russo@gmail.com>
2019-09-10 18:41:18 -06:00
da6ff91241
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-09-10 00:25:00 +00:00
47f80d67c5
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-09-03 00:25:11 +00:00
b423808ddf
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-08-27 00:25:09 +00:00
3e7be7357e
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-08-22 11:13:28 +00:00
773f26a42d
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2019-08-22 10:30:35 +00:00
fb93ae4b02
Fix misc. source comment typos
...
Typos found via `codespell`
2019-08-21 23:43:16 -04:00
John Maguire
Jonas Kvinge
Jim Broadus
Clementine Buildbot
Thor Merlin Lervik
Cesar Enrique Garcia Dabo
Luis Caceres
Mattias Andersson
Dmitry Valter
Antonio Russo
luz.paz