922afe506f
Automatic merge of translations from Transifex
2021-08-27 02:44:07 +00:00
8682d4de48
Fix sentinels in variadic function calls
...
Replace sentinel NULL with nullptr, guaranteed to be correctly expanded.
NULL may be defined as plain 0 in C++; which may lead to undefined upper
bits passed in variadic function arguments, causing crashes.
See: https://ewontfix.com/11/
2021-08-23 21:33:46 +01:00
03e13c69e7
Automatic merge of translations from Transifex
2021-08-17 02:42:46 +00:00
327d5fdac3
Automatic merge of translations from Transifex
2021-08-13 02:42:58 +00:00
b55e54388f
Automatic merge of translations from Transifex
2021-08-11 02:43:14 +00:00
cddc08e148
Automatic merge of translations from Transifex
2021-08-09 02:42:51 +00:00
bf424ce986
Automatic merge of translations from Transifex
2021-08-01 02:46:18 +00:00
e2d6759d55
Automatic merge of translations from Transifex
2021-07-27 02:45:37 +00:00
102317e5c8
internet/podcasts: Fix crash when updating podcasts.
...
When a podcast is updated and the number of visible items is set in the
podcast settings, child items that disappear from the view, and are
deleted, are still referenced by the database id map.
Move the removal code from SubscriptionRemoved to a common method and
use that for this case.
2021-07-26 12:36:24 +01:00
ac3a0d33f7
Automatic merge of translations from Transifex
2021-07-26 02:45:57 +00:00
224c475b50
Rename multiple files to match the application ID
...
The desktop entry file, appdata file and installed icons are renamed to
match the application ID for the benefit of Flatpak packaging.
2021-07-20 11:21:05 +01:00
dbe15e5e9f
Automatic merge of translations from Transifex
2021-07-20 02:45:18 +00:00
c0c9037677
Automatic merge of translations from Transifex
2021-07-19 02:44:08 +00:00
6982b47819
Search song from Spotify via web api
2021-07-18 10:45:10 +01:00
98dd3e48a6
Automatic merge of translations from Transifex
2021-07-17 02:45:02 +00:00
1e39ce29a4
Automatic merge of translations from Transifex
2021-07-15 02:43:57 +00:00
daa2f25e3c
Replace Q_ENUMS with Q_ENUM
...
Q_ENUMS is obsolete. See: https://doc.qt.io/qt-5/qobject-obsolete.html
The replacement is Q_ENUM which was introduced in Qt 5.5, and Clementine
requires Qt 5.6.
2021-07-14 10:19:28 +01:00
f379ad84d4
Fix use of emit
...
Adds missing emits.
QTreeView::collapse and QTreeView::expand are slots, not signals. So
remove emit.
2021-07-14 10:18:47 +01:00
1d1d3b157f
Add *.kdev4 to .gitignore
2021-07-14 10:18:25 +01:00
320a1b81c9
Fix incorrect use of QFutureWatcher
...
To avoid a race condition, it is important to call setFuture() after doing the connections.
See: https://doc.qt.io/qt-6/qfuturewatcher.html
2021-07-14 10:18:15 +01:00
0c1b6a2a44
Fix setting task blocking library scans
...
TaskManager::SetTaskBlocksLibraryScans() takes the ID of the task.
2021-07-14 10:18:01 +01:00
598e660aeb
Unref bus in SongLoader::LoadRemote()
...
See: https://developer.gnome.org/gstreamer/stable/GstPipeline.html#gst-pipeline-get-bus
2021-07-14 10:17:50 +01:00
4d34748401
Fix memory leak in global search context menu
2021-07-14 10:17:35 +01:00
b3b769f0e7
Automatic merge of translations from Transifex
2021-07-14 02:43:05 +00:00
2902a8786e
Automatic merge of translations from Transifex
2021-07-12 02:43:07 +00:00
4acfdae740
Automatic merge of translations from Transifex
2021-07-09 02:43:48 +00:00
6b2918ee92
Generate compile_commands.json
2021-07-08 21:33:19 +01:00
a5e84bbe98
internet: Add common InternetService::ConfigRequired() method.
...
This will allow some common handling of unconfigured services.
2021-07-07 10:47:01 +01:00
7cb5f5c804
Automatic merge of translations from Transifex
2021-07-06 02:43:44 +00:00
db8de64abb
Automatic merge of translations from Transifex
2021-07-03 02:40:42 +00:00
a5fd484a61
internet: Consolidate ShowConfig methods.
...
InternetService::ShowConfig() and ShowSettingsPage() were used to show
the settings page for a service.
2021-07-02 11:54:21 +01:00
25b537cf26
De-duplicate my translator credit
2021-07-02 10:29:17 +01:00
8c660e278c
Automatic merge of translations from Transifex
2021-07-01 02:44:35 +00:00
67aa154182
Explicitly tap liblastfm homebrew dependency
2021-06-30 22:30:38 +01:00
f35a640ce3
clang-format
2021-06-30 22:05:18 +01:00
cbe384d142
Add override
2021-06-30 22:05:18 +01:00
4a83f8c817
Automatic merge of translations from Transifex
2021-06-30 02:47:46 +00:00
67a947f116
Automatic merge of translations from Transifex
2021-06-29 02:46:23 +00:00
1db1e3231f
Automatic merge of translations from Transifex
2021-06-28 02:47:35 +00:00
f9854e564d
transcoder: Add options avenc_aac element.
...
Initially adding encoder and bitrate settings, but the gstreamer
element exposes a lot of ffmpeg options that can be added as needed.
Reference: https://gstreamer.freedesktop.org/documentation/libav/avenc_aac.html
2021-06-27 15:56:50 +01:00
5ab81fd8bc
Automatic merge of translations from Transifex
2021-06-25 02:47:39 +00:00
62cb889a3f
Automatic merge of translations from Transifex
2021-06-24 02:42:11 +00:00
e46503d0c3
Automatic merge of translations from Transifex
2021-06-23 02:46:40 +00:00
54be35f528
Automatic merge of translations from Transifex
2021-06-22 02:51:35 +00:00
6240fd3d0a
player: Fix crash on UrlHandler error.
...
In a case where a playlist is composed entirely of unresolvable
internet service URLs and the playlist is set to repeat, playing an
item will result in an infinite (until crash) recursive condition.
HandleLoadResult is called with a NoMoreTracks result. It then calls
NextItem, which calls PlayAt for the next item, which, again, calls
HandleLoadResult.
This can be reproduced by logging into a subsonic server, adding items
to an empty playlist, then signing out.
To solve this, separate the error condition from the NoMoreTracks
result. Handle URL resolution errors the same way that media playback
errors are handled, where an error count is incremented and the player
stops if a limit is reached. The common code also notifies the playlist
of the error and provides user feedback by graying out the item.
2021-06-21 12:52:25 +01:00
57b5911f13
Fixes from code review for PR #7037
2021-06-21 12:51:44 +01:00
6fa9cbcc65
Removing watch_for_disc_changes in CddaDevice constructor
2021-06-21 12:51:44 +01:00
83b6bf28f3
No exceptions for error handling! ConnectedDevice::Init now returns bool, indicating success or failure.
...
As decreed by @hatstand.
2021-06-21 12:51:44 +01:00
a4ad507704
Removed some unused includes.
2021-06-21 12:51:44 +01:00
d2240ec0ae
Device change watchdog timer no longer freezes main thread while CddaSongLoader is active.
2021-06-21 12:51:44 +01:00
Clementine Buildbot
Ismael Luceno
Jim Broadus
Robin Lee
kentsangkm
Jonas Kvinge
Adolfo Jayme Barrientos
John Maguire
Lukas Prediger