2dd566653f
Dealing with cdio_open failures in CddaDevice constructor
2021-06-21 12:51:44 +01:00
e35e4195c2
Not using std::make_unique
2021-06-21 12:51:44 +01:00
6ea20336c2
CddaSongLoader: Only run one song loading thread at once.
...
- CddaSongLoader destructor waits for thread to end.
- Added flag to interrupt LoadSongsFromCdda
- Only start song loading if not already running
- Removed (now obsolete) mutex
2021-06-21 12:51:44 +01:00
ae9824e26a
RipCDDialog no longer needs to LoadSongs on show.
2021-06-21 12:51:44 +01:00
63953e1045
RipCDDialog now allows selecting the CD drive
2021-06-21 12:51:44 +01:00
b68734c761
Fix: Missing include guard for cddadevice in mainwindow.cpp
2021-06-21 12:51:44 +01:00
95799a911d
Removing ConnectedDevice::Refresh altogether
2021-06-21 12:51:44 +01:00
639b918557
Removing CddaDevice::Refresh
2021-06-21 12:51:44 +01:00
3c06b92b24
Ripper now works with a cdio instance passed into constructor
...
which comes from a CddaDevice corresponding to the device
2021-06-21 12:51:44 +01:00
ae3037984c
RipCDDialog now uses CddaSongLoader from passed in CddaDevice
2021-06-21 12:51:44 +01:00
14d5c25d37
Integrated cddevice back into cddadevice
2021-06-21 12:51:44 +01:00
9ca75ae357
RipCDDialog now relies on CddaDevice to be notified about disc changes
2021-06-21 12:51:44 +01:00
d2c636ab46
Introducing CdDevice, simple wrapper for cdio that watches disc changes.
...
CddaDevice now relies on this to update song list. CddaDevice::Refresh is now a no-op.
2021-06-21 12:51:44 +01:00
11bd0db03b
Automatic merge of translations from Transifex
2021-06-21 02:54:22 +00:00
c3c77aef19
Automatic merge of translations from Transifex
2021-06-16 02:55:57 +00:00
ffdaeba09f
cueparser: Be more lenient when parsing indexes.
...
Most specs have mm:ss:ff as the index time format, but cue files have
been found with single digit minutes. e.g. 0:00:00 instead of 00:00:00
Reference: https://www.gnu.org/software/ccd2cue/manual/html_node/CUE-sheet-format.html
2021-06-15 14:14:00 +01:00
2bf8f1388b
Automatic merge of translations from Transifex
2021-06-15 02:57:02 +00:00
418a366931
Automatic merge of translations from Transifex
2021-06-14 02:55:24 +00:00
4aa4f4fce3
Automatic merge of translations from Transifex
2021-06-13 02:54:58 +00:00
3a00403ad0
build: Add patch for libgpod mac build.
...
Store patch file in repository rather than relying on strawberry's file
server.
Reference: 27955cc441
2021-06-12 15:14:44 +01:00
7fb387b967
Automatic merge of translations from Transifex
2021-06-12 02:54:18 +00:00
4e4fccc07a
playlistparser: Add error mechanism for parsers.
...
Add a new Error signal to parser implementations. Display an error when
user tries to use the unimplemented CueParser::Save.
2021-06-11 10:17:20 +01:00
f4108b5a0c
playlistparser: Display errors on failures.
...
Add an Error signal to PlayListParser and connect that to the
PlayListManager::Error signal. This is eventually connected to the
Application::AddError. Add error messages in some cases where
PlayListParser can fail silently.
2021-06-11 10:17:20 +01:00
612767c878
Automatic merge of translations from Transifex
2021-06-09 03:12:09 +00:00
b09ab3ff37
Automatic merge of translations from Transifex
2021-06-04 04:25:11 +00:00
0dbefa3064
Add a shortcut to go to next album
2021-06-03 17:06:48 +01:00
058fe6f4be
fall back to url if url_resolved is empty
2021-06-02 22:40:13 +01:00
38ac0d3ccb
Radiobrowser.info: use the url_resolved field for radio stations
2021-06-02 22:40:13 +01:00
72cfdf25a9
Remove FC32 build
2021-06-02 11:23:40 +01:00
f674753758
Automatic merge of translations from Transifex
2021-05-31 05:04:40 +00:00
f7369d2c42
Automatic merge of translations from Transifex
2021-05-28 04:26:27 +00:00
2132e99fbe
Automatic merge of translations from Transifex
2021-05-27 03:59:34 +00:00
684c9d232f
Automatic merge of translations from Transifex
2021-05-26 03:51:04 +00:00
d71eba97fb
Automatic merge of translations from Transifex
2021-05-25 03:20:50 +00:00
f071075e8c
build: Add Ubuntu Hirsute to workflows.
...
Reference: https://wiki.ubuntu.com/Releases
2021-05-24 23:05:56 +01:00
776bd3b022
settings: Add option to guess song metadata
...
Add "Try to guess missing metadata" option to the Song Metadata page
that controls the setting in SongPathParser.
2021-05-24 15:23:05 +01:00
cf88e47206
settings: Create a new Song Metadata settings page
...
Move tagreader process settings to the new page.
2021-05-24 15:23:05 +01:00
01be9f196a
settings: Organize page enums by category.
2021-05-24 15:23:05 +01:00
89831f8dca
MusicBrainzClient: Log message for malformed XML in reply
2021-05-18 12:13:10 +01:00
e756f2d686
CddaSongLoader: explicitly reading discid as UTF8
2021-05-18 12:12:01 +01:00
8d69da28f3
Fixing freeing of memory in cddasongloader
2021-05-18 12:12:01 +01:00
8668699977
CddaSongLoader: handle potential multiple tag messages correctly
2021-05-18 12:12:01 +01:00
e9945bcbc6
do NOT free toc entries in CddaSongLoader (reverting previous change)
2021-05-18 12:12:01 +01:00
86bbd2ace6
Formatting/linting fixes.
2021-05-18 12:12:01 +01:00
81c0661e8c
MusicBrainzClient stop result parsing after reading first medium with correct discid.
...
Tentative fix for #7020 .
2021-05-18 12:12:01 +01:00
54a497b302
RipCDDialog rejects metadata lists if number of tracks does not match disc.
...
First step for addressing #7020 .
2021-05-18 12:12:01 +01:00
436c53870a
Correctly freeing memory in CddaSongLoader::LoadSongsFromCdda
2021-05-18 12:12:01 +01:00
97800e613a
Fix for #7019 : CddaSongLoader obtaining metadata on first try.
2021-05-18 12:12:01 +01:00
1309c76bec
tagreader: Relocate artist/album/title guessing code
...
Move the code that attempts to fill missing song metadata out of the
tagreader worker. In the main process, it will be controllable using
settings and calling context.
The methods were moved into a new SongPathParser class that checks new
settings to determine if action should be taken.
2021-05-17 13:20:34 +01:00
75de59703c
Fix: Transcoding for CD rips not starting.
...
due to making Transcoder::Start a non-slot in 8d11e9ff
2021-05-15 10:14:18 +01:00
Lukas Prediger
Clementine Buildbot
Jim Broadus
Robin Ekman
Fabio Bas
John Maguire