Funkwhale/Clementine-audio-player-Mac-Linux-Windows
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
6,979 Commits 23 Branches 550 Tags
Commit Graph

6979 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Clementine Buildbot
da6ff91241 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-09-10 00:25:00 +00:00
Clementine Buildbot
47f80d67c5 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-09-03 00:25:11 +00:00
Clementine Buildbot
b423808ddf Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-08-27 00:25:09 +00:00
Clementine Buildbot
3e7be7357e Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-08-22 11:13:28 +00:00
Clementine Buildbot
773f26a42d Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-08-22 10:30:35 +00:00
John Maguire
19f2712ce7
Merge pull request #6393 from luzpaz/misc-typos 
Fix misc. source comment typos
 2019-08-22 10:22:48 +01:00
luz.paz
fb93ae4b02 Fix misc. source comment typos 
Typos found via `codespell`
 2019-08-21 23:43:16 -04:00
John Maguire
e1affba4ba
Merge pull request #6386 from ronjouch/fix-rating-not-written-to-file 
Fix ratings not saved to file tag (Fix #6385)
 2019-08-09 10:26:33 +01:00
Ronan Jouchet
483be6ef7c Fix ratings not saved to file tag (Fix #6385) 
Commit 96a7e18a8d2be8d9f3223a6a6c81fbaac1179869 by @smithjd15 from
2019-04-03 fixed a number of potential zero-value field values, but it
also flipped the early exit condition skipping saving a rating to file.

It seems out of place with the rest of the commit, so considering it a
mistake and reverting to the original condition.

Manually tested; works and saves again ratings to file.
 2019-08-09 03:09:17 +02:00
Jonas Kvinge
546078c317 Fix memory leaks (#6376) 2019-08-02 16:24:26 +01:00
John Maguire
ec2e8be4d6
Merge pull request #6375 from jonaski/database 
Fix memory leaks in database
 2019-07-25 18:38:35 +01:00
Jonas Kvinge
8d921c15be Fix memory leaks in database 2019-07-25 19:02:43 +02:00
John Maguire
b910cd402e
Merge pull request #6373 from jonaski/taglib 
Add missing taglib configure checks
 2019-07-21 08:55:23 +01:00
Jonas Kvinge
21762dd402 Add missing taglib configure checks 2019-07-20 21:40:14 +02:00
Clementine Buildbot
a2dcb33d84 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-07-20 17:55:03 +00:00
Jonas Kvinge
5bb35bf08a Fix crash in messagereply (#6372) 
* Fix crash in messagereply

* Fix formatting
 2019-07-20 18:52:37 +01:00
Clementine Buildbot
da0447142b Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-07-09 00:25:09 +00:00
Clementine Buildbot
a0e4785346 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-07-02 00:25:09 +00:00
John Maguire
9cdf0bb0f9
Merge pull request #6359 from hal7df/dbus-notification-fix 
Support per-app notification settings in KDE Plasma 5.16
 2019-06-17 10:14:08 +01:00
Paul Bonnen
b697e962b3 Make D-Bus 'desktop-entry' hint match system filename. 
"Clementine" (as returned by QCoreApplication::applicationName())
does not match the system .desktop file name (but it may match user
.desktop files, as was the case for me); Clementine won't be picked up
as an application in KDE Plasma notification settings unless it case
matches.
 2019-06-16 13:03:47 -04:00
Paul Bonnen
8483d24a04 Add `desktop-entry' hint to D-Bus notifications. 
The notification system in KDE Plasma 5.16+ requires a 'desktop-entry'
hint in the D-Bus message to enable per-application notification
settings.
 2019-06-16 12:37:53 -04:00
John Maguire
dd19df6ee4
Merge pull request #6354 from smithjd15/tagZeroValues 
Fix a number of zero-value tag issues (New PR)
 2019-06-05 10:16:10 +01:00
Clementine Buildbot
c1af92d24d Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-06-04 00:24:56 +00:00
James D. Smith
32e867a84b clang-formatter changes. 2019-05-31 11:25:38 -06:00
James D. Smith
96a7e18a8d Fix a number of potential zero-value field values. 2019-05-31 11:25:38 -06:00
Clementine Buildbot
4ed4eec817 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-05-21 00:25:05 +00:00
Clementine Buildbot
ebdaaaf714 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-05-14 00:25:05 +00:00
Clementine Buildbot
d3e79436af Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-05-07 00:25:10 +00:00
Clementine Buildbot
44ac3936ea Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-04-30 00:25:05 +00:00
Clementine Buildbot
013ee87177 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-04-27 16:41:30 +00:00
John Maguire
96c7374689
Merge pull request #6338 from jonaski/chromaprinter 
Fix gst_buffer_unref assertion with chromaprinter
 2019-04-27 17:39:21 +01:00
Jonas Kvinge
8094957e09 Fix gst_buffer_unref assertion in chromaprinter 2019-04-26 20:40:42 +02:00
Clementine Buildbot
d079f00cfe Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-04-23 00:25:03 +00:00
Clementine Buildbot
b11316ff03 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-04-16 00:25:05 +00:00
James D. Smith
553c4013cf Merge remote-tracking branch 'upstream/master' 2019-04-15 18:07:05 -06:00
Clementine Buildbot
7c5a050ab8 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-04-13 18:32:41 +00:00
John Maguire
40400e850d
Merge pull request #6323 from jbroadus/async-load-errors 
Add error handling path for async song loading.
 2019-04-13 19:30:24 +01:00
Clementine Buildbot
4630032565 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-04-12 10:12:55 +00:00
Jim Broadus
babff78025 Add error handling path for async song loading. 
Async song loading can fail without user feedback. This change adds return codes
to these async load functions. It will now produce an error dialog in simple
scenarios (test case is user selecting a file that is not readable). Other cases,
such as directories and playlists, aren't yet covered.
 2019-04-10 11:49:09 -07:00
John Maguire
17d95b7833
Merge pull request #6286 from smithjd15/apeFiles 
More bits for APE files (Finish APE file support)
 2019-04-10 11:13:51 +01:00
John Maguire
e3609b27cd
Merge pull request #6296 from ShFil119/impr/simplify 
Simplify some statements
 2019-04-10 11:12:09 +01:00
John Maguire
878b366bfb
Merge pull request #6324 from jbroadus/set-min-fade-time 
Set non-zero minimum for fade times.
 2019-04-10 11:10:47 +01:00
Clementine Buildbot
641ab64ccc Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-04-09 00:25:03 +00:00
Jim Broadus
cc295a4c4c Set non-zero minimum for fade times. 
QTimeLine duration must be greater than 0. If set to 0, a default of 1000ms will
be used. To avoid this, enforce a minimum of 1ms for pause and cross fade values
if those fades are enabled.
 2019-04-07 21:31:30 -07:00
James D. Smith
bd89a1d2de Fixes for APE filetype. 2019-04-01 22:56:50 -06:00
James D. Smith
2752d61d2a clang-formatter changes. 2019-04-01 22:23:04 -06:00
James D. Smith
2adf9d068d Improved support for APEv2 tags. 2019-04-01 22:22:03 -06:00
Clementine Buildbot
f6ba37dbc5 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-04-02 00:25:06 +00:00
John Maguire
d8e0e7e67e
Merge pull request #6314 from jbroadus/fix-gobject-leak 
Fix several gstreamer object leaks.
 2019-03-26 09:51:06 +00:00
Jim Broadus
5c2ceb3490 Fix several gstreamer object leaks. 
There are a number of cases where gst_pipeline_get_bus,
gst_element_get_static_pad, and g_object_get are called without releasing
references. In addition to memory usage, some of these elements hold file
descriptors. In normal operation, two file descriptors are leaked for each
played track. The default fd ulimit for many linux distros is 1024. This
is likely the cause of the crash reported in issue 6309.

This change fixes the obvious and consistent leaks, but it's probably not a
complete solution. There are many error and corner conditions that need to be
examined.
 2019-03-25 23:22:09 -07:00