1
0
mirror of https://github.com/clementine-player/Clementine synced 2025-01-31 03:27:40 +01:00

8051 Commits

Author SHA1 Message Date
Lukas Prediger
c8c110efaf Fix: RipCDDialog now correctly loads and stores chosen transcoder preset 1.4.0rc1-708-gc8c110efa 2021-08-31 10:19:32 +01:00
Lukas Prediger
a72e252ec6 RipCDDialog: Added file name preview 2021-08-31 10:19:32 +01:00
Lukas Prediger
b0704331d7 Integrate file name format options into RipCDDialog
for consistency with OrganiseDialog and reducing code duplication
2021-08-31 10:19:32 +01:00
Lukas Prediger
5c8ca3754f Added overwrite_existing argument to Transcoder::AddJob 2021-08-31 10:19:32 +01:00
Lukas Prediger
83d961f808 Transcoder: create output paths if they do not already exist 2021-08-31 10:19:32 +01:00
Lukas Prediger
a6fef97cac Separating out filename formatting options into separate widget.
First step towards unifying filename formatting over different dialogs.
2021-08-31 10:19:32 +01:00
Clementine Buildbot
922afe506f Automatic merge of translations from Transifex 1.4.0rc1-702-g922afe506 2021-08-27 02:44:07 +00:00
Ismael Luceno
8682d4de48 Fix sentinels in variadic function calls
Replace sentinel NULL with nullptr, guaranteed to be correctly expanded.

NULL may be defined as plain 0 in C++; which may lead to undefined upper
bits passed in variadic function arguments, causing crashes.

See: https://ewontfix.com/11/
1.4.0rc1-701-g8682d4de4
2021-08-23 21:33:46 +01:00
Clementine Buildbot
03e13c69e7 Automatic merge of translations from Transifex 1.4.0rc1-700-g03e13c69e 2021-08-17 02:42:46 +00:00
Clementine Buildbot
327d5fdac3 Automatic merge of translations from Transifex 1.4.0rc1-699-g327d5fdac 2021-08-13 02:42:58 +00:00
Clementine Buildbot
b55e54388f Automatic merge of translations from Transifex 1.4.0rc1-698-gb55e54388 2021-08-11 02:43:14 +00:00
Clementine Buildbot
cddc08e148 Automatic merge of translations from Transifex 1.4.0rc1-697-gcddc08e14 2021-08-09 02:42:51 +00:00
Clementine Buildbot
bf424ce986 Automatic merge of translations from Transifex 1.4.0rc1-696-gbf424ce98 2021-08-01 02:46:18 +00:00
Clementine Buildbot
e2d6759d55 Automatic merge of translations from Transifex 1.4.0rc1-695-ge2d6759d5 2021-07-27 02:45:37 +00:00
Jim Broadus
102317e5c8 internet/podcasts: Fix crash when updating podcasts.
When a podcast is updated and the number of visible items is set in the
podcast settings, child items that disappear from the view, and are
deleted, are still referenced by the database id map.

Move the removal code from SubscriptionRemoved to a common method and
use that for this case.
1.4.0rc1-694-g102317e5c
2021-07-26 12:36:24 +01:00
Clementine Buildbot
ac3a0d33f7 Automatic merge of translations from Transifex 1.4.0rc1-693-gac3a0d33f 2021-07-26 02:45:57 +00:00
Robin Lee
224c475b50 Rename multiple files to match the application ID
The desktop entry file, appdata file and installed icons are renamed to
match the application ID for the benefit of Flatpak packaging.
1.4.0rc1-692-g224c475b5
2021-07-20 11:21:05 +01:00
Clementine Buildbot
dbe15e5e9f Automatic merge of translations from Transifex 1.4.0rc1-691-gdbe15e5e9 2021-07-20 02:45:18 +00:00
Clementine Buildbot
c0c9037677 Automatic merge of translations from Transifex 1.4.0rc1-690-gc0c903767 2021-07-19 02:44:08 +00:00
kentsangkm
6982b47819 Search song from Spotify via web api 1.4.0rc1-689-g6982b4781 2021-07-18 10:45:10 +01:00
Clementine Buildbot
98dd3e48a6 Automatic merge of translations from Transifex 1.4.0rc1-688-g98dd3e48a 2021-07-17 02:45:02 +00:00
Clementine Buildbot
1e39ce29a4 Automatic merge of translations from Transifex 1.4.0rc1-687-g1e39ce29a 2021-07-15 02:43:57 +00:00
Jonas Kvinge
daa2f25e3c Replace Q_ENUMS with Q_ENUM
Q_ENUMS is obsolete. See: https://doc.qt.io/qt-5/qobject-obsolete.html
The replacement is Q_ENUM which was introduced in Qt 5.5, and Clementine
requires Qt 5.6.
1.4.0rc1-686-gdaa2f25e3
2021-07-14 10:19:28 +01:00
Jonas Kvinge
f379ad84d4 Fix use of emit
Adds missing emits.

QTreeView::collapse and QTreeView::expand are slots, not signals. So
remove emit.
1.4.0rc1-685-gf379ad84d
2021-07-14 10:18:47 +01:00
Jonas Kvinge
1d1d3b157f Add *.kdev4 to .gitignore 1.4.0rc1-684-g1d1d3b157 2021-07-14 10:18:25 +01:00
Jonas Kvinge
320a1b81c9 Fix incorrect use of QFutureWatcher
To avoid a race condition, it is important to call setFuture() after doing the connections.

See: https://doc.qt.io/qt-6/qfuturewatcher.html
1.4.0rc1-683-g320a1b81c
2021-07-14 10:18:15 +01:00
Jonas Kvinge
0c1b6a2a44 Fix setting task blocking library scans
TaskManager::SetTaskBlocksLibraryScans() takes the ID of the task.
1.4.0rc1-682-g0c1b6a2a4
2021-07-14 10:18:01 +01:00
Jonas Kvinge
598e660aeb Unref bus in SongLoader::LoadRemote()
See: https://developer.gnome.org/gstreamer/stable/GstPipeline.html#gst-pipeline-get-bus
1.4.0rc1-681-g598e660ae
2021-07-14 10:17:50 +01:00
Jonas Kvinge
4d34748401 Fix memory leak in global search context menu 1.4.0rc1-680-g4d3474840 2021-07-14 10:17:35 +01:00
Clementine Buildbot
b3b769f0e7 Automatic merge of translations from Transifex 1.4.0rc1-679-gb3b769f0e 2021-07-14 02:43:05 +00:00
Clementine Buildbot
2902a8786e Automatic merge of translations from Transifex 1.4.0rc1-678-g2902a8786 2021-07-12 02:43:07 +00:00
Clementine Buildbot
4acfdae740 Automatic merge of translations from Transifex 1.4.0rc1-677-g4acfdae74 2021-07-09 02:43:48 +00:00
kentsangkm
6b2918ee92 Generate compile_commands.json 1.4.0rc1-676-g6b2918ee9 2021-07-08 21:33:19 +01:00
Jim Broadus
a5e84bbe98 internet: Add common InternetService::ConfigRequired() method.
This will allow some common handling of unconfigured services.
1.4.0rc1-675-ga5e84bbe9
2021-07-07 10:47:01 +01:00
Clementine Buildbot
7cb5f5c804 Automatic merge of translations from Transifex 1.4.0rc1-674-g7cb5f5c80 2021-07-06 02:43:44 +00:00
Clementine Buildbot
db8de64abb Automatic merge of translations from Transifex 1.4.0rc1-673-gdb8de64ab 2021-07-03 02:40:42 +00:00
Jim Broadus
a5fd484a61 internet: Consolidate ShowConfig methods.
InternetService::ShowConfig() and ShowSettingsPage() were used to show
the settings page for a service.
1.4.0rc1-672-ga5fd484a6
2021-07-02 11:54:21 +01:00
Adolfo Jayme Barrientos
25b537cf26 De-duplicate my translator credit 1.4.0rc1-671-g25b537cf2 2021-07-02 10:29:17 +01:00
Clementine Buildbot
8c660e278c Automatic merge of translations from Transifex 1.4.0rc1-670-g8c660e278 2021-07-01 02:44:35 +00:00
John Maguire
67aa154182 Explicitly tap liblastfm homebrew dependency 1.4.0rc1-669-g67aa15418 2021-06-30 22:30:38 +01:00
kentsangkm
f35a640ce3 clang-format 1.4.0rc1-668-gf35a640ce 2021-06-30 22:05:18 +01:00
kentsangkm
cbe384d142 Add override 2021-06-30 22:05:18 +01:00
Clementine Buildbot
4a83f8c817 Automatic merge of translations from Transifex 1.4.0rc1-666-g4a83f8c81 2021-06-30 02:47:46 +00:00
Clementine Buildbot
67a947f116 Automatic merge of translations from Transifex 1.4.0rc1-665-g67a947f11 2021-06-29 02:46:23 +00:00
Clementine Buildbot
1db1e3231f Automatic merge of translations from Transifex 1.4.0rc1-664-g1db1e3231 2021-06-28 02:47:35 +00:00
Jim Broadus
f9854e564d transcoder: Add options avenc_aac element.
Initially adding encoder and bitrate settings, but the gstreamer
element exposes a lot of ffmpeg options that can be added as needed.

Reference: https://gstreamer.freedesktop.org/documentation/libav/avenc_aac.html
1.4.0rc1-663-gf9854e564
2021-06-27 15:56:50 +01:00
Clementine Buildbot
5ab81fd8bc Automatic merge of translations from Transifex 1.4.0rc1-662-g5ab81fd8b 2021-06-25 02:47:39 +00:00
Clementine Buildbot
62cb889a3f Automatic merge of translations from Transifex 1.4.0rc1-661-g62cb889a3 2021-06-24 02:42:11 +00:00
Clementine Buildbot
e46503d0c3 Automatic merge of translations from Transifex 1.4.0rc1-660-ge46503d0c 2021-06-23 02:46:40 +00:00
Clementine Buildbot
54be35f528 Automatic merge of translations from Transifex 1.4.0rc1-659-g54be35f52 2021-06-22 02:51:35 +00:00