Commit Graph

560 Commits

Author SHA1 Message Date
Paweł Bara bb79a68be0 some minor .cue related changes 2011-01-04 17:12:29 +00:00
John Maguire 3f923d2cb1 Add default parameters to MPRIS constructors. 2011-01-04 11:53:37 +00:00
John Maguire bde7902686 Refactor some initial setup out of MainWindow::MainWindow(). 2011-01-04 11:33:22 +00:00
Paweł Bara 59378166b4 finalized the support for loading .cue based media using 'files' tab or drag and drop from the system's file browser
use FILE's PERFORMER as albumartist
2011-01-03 23:36:10 +00:00
Paweł Bara bbe97b00a2 make engine 'multiple-section songs' aware -> you should now be able to play your .cue related music 2011-01-02 18:53:45 +00:00
David Sansome 5b1000834f Add some basic script loading support and add python bindings for the Player class 2010-12-31 18:13:28 +00:00
David Sansome b578c61b36 Fix loading songs with non-ascii characters in the filename on Windows. Fixes issue #1207. Fixes issue #531. Fixes issue #813. 2010-12-30 17:13:11 +00:00
David Sansome a9a8b849ca Add some safeguards to the merged proxy model against dereferencing child models that have been deleted 2010-12-28 23:21:56 +00:00
David Sansome d1d0236385 Make the "show full size" menu item in the now playing widget and edit tag dialog work with embedded covers 2010-12-28 22:20:54 +00:00
Paweł Bara da5f941333 consider .cues when scanning the library
persist the new 'beginning' marker of songs
fixed a bug where %allsongstables script would not update the attached databases
2010-12-28 15:36:01 +00:00
David Sansome 97d7fe764a Download higher resolution images from last.fm. Thanks markwatkinson. Fixes issue #1187 2010-12-26 20:19:12 +00:00
David Sansome 35242f740e Fix dbus 2010-12-26 17:24:44 +00:00
David Sansome dc31a0be7e Make it possible to disable all lyric providers. 2010-12-26 15:06:11 +00:00
David Sansome fd00924f26 Fix parsing non-ascii filenames passed on the commandline (or through a file browser). Fixes issue #773. Fixes issue #752. 2010-12-26 14:54:46 +00:00
David Sansome e3a9bd7b26 Make DBUS bits optional on Linux. Thanks Nickollai. Fixes issue #1177 2010-12-26 13:38:35 +00:00
David Sansome 6737b8a5c2 Always use the gstreamer engine, remove xine, vlc and phonon engines. 2010-12-26 13:01:35 +00:00
David Sansome b5942aa7d6 Fix network access on linux without a proxy 2010-12-26 12:03:10 +00:00
David Sansome ae9ada254c Maybe fix build error 2010-12-25 17:41:18 +00:00
David Sansome 9b22f2ce40 Proxy support. Fixes issue #38 2010-12-25 17:25:29 +00:00
David Sansome 843cd92615 Increment play counts even if the song is shorter than 30 seconds. Fixes issue #1172 2010-12-25 13:37:45 +00:00
Paweł Bara d7fe4600b8 an initial version of .cue sheets parser
initial support for multipart media files in Song ('beginning' and 'end' fields)
2010-12-23 21:13:43 +00:00
Arnaud Bienner ccd26b4002 Removing trackSkipped when stopping: even if Amarok wasn't acting like this, in my opinion, a 'stopped' track should not be considered as 'skipped' 2010-12-21 00:38:07 +00:00
David Sansome 2d8028d89a Use a smaller cover in the tray icon tooltip again. Fixes issue #1135 2010-12-19 15:04:22 +00:00
David Sansome a6445f2fe7 Don't strip off file extensions in the OSD. Fixes issue #1066 2010-12-18 20:40:35 +00:00
David Sansome c133a8db7c Don't scale album art when saving it to /tmp. Fixes issue #1096 2010-12-18 19:42:06 +00:00
David Sansome f1f0a384a5 Sort songs loaded from directories by filename if there are no other tags present. Fixes issue #1104 2010-12-18 18:47:44 +00:00
David Sansome 28fdb147d8 Make last.fm optional. Thanks volkov0aa. Fixes issue #49 2010-12-18 17:28:02 +00:00
David Sansome 623ab527ee Maybe fix a crash when loading tags from MP3 files with encrypted frames 2010-12-18 17:01:25 +00:00
David Sansome 6ec77eadf6 Fix a display bug in the Last played column for songs that haven't been played in the last week. Thanks gmail@robbertkrebbers.nl. Fixes issue #1081 2010-12-18 16:50:00 +00:00
Paweł Bara 5893c27d2b missing include failing on windows 2010-12-17 17:05:55 +00:00
Paweł Bara 32f9825794 global shortcuts for rating songs (Fixes issue #1089)
renaming *index* methods in Playlist to *row*
2010-12-17 00:21:20 +00:00
Paweł Bara 4563c2dbd9 you can now use "file path" attribute when creating dynamic playlists (Fixes issue #1073)
some more MPRIS 2 corrections (Updates issue #1058)
2010-12-15 15:50:22 +00:00
John Maguire f95d893945 Add support for building without Sparkle on mac. 2010-12-14 18:20:14 +00:00
John Maguire 21415ff230 Fix some mac ui and metadata bugs. 2010-12-14 15:00:46 +00:00
Paweł Bara 5082d81ba4 some corrections to MPRIS 2 (Updates issue #1058) 2010-12-12 23:20:41 +00:00
John Maguire f28d67966a Fix flickr url for kittens. 2010-12-11 14:31:03 +00:00
David Sansome 01cccc0468 Cache the last emitted state from the engine to fix some invalid values being emitted over DBUS while a last.fm stream is buffering. Fixes issue #374 2010-12-11 13:38:51 +00:00
David Sansome 67452baa4d Fix a crash when requesting an invalid playlist index over MPRIS. Fixes issue #1041 2010-12-11 10:58:15 +00:00
David Sansome 08b2bcc816 Always write URLs in XML based playlists, instead of URLs of relative paths. Also load playlist items from the library if possible. Fixes issue #1054 2010-12-11 10:35:07 +00:00
David Sansome 7650c1eddc Remove "-session" from the commandline to fix session management on KDE. Fixes issue #769 2010-12-11 10:04:17 +00:00
John Maguire 5f6dcbe4b7 Early Caturday! 2010-12-10 14:26:29 +00:00
Arnaud Bienner 6b35eea469 Moving emitTrackSkipped from Next to PlayAt, to handle cases where user doesn't use Next button to skip a track. Also emit TrackSkipped in Stop if track was not ended 2010-12-10 00:11:38 +00:00
John Maguire 81f43ac4f5 Unbreak the build. 2010-12-09 14:19:09 +00:00
John Maguire 4c66007e26 Code review comments from r2370. 2010-12-09 13:06:00 +00:00
John Maguire 3a19bb9d46 Fix config file location on Mac and automatically migrate. 2010-12-09 12:34:08 +00:00
Paweł Bara 04bbf73cff MPRIS' TracklistChanged event now contains the length of the playlist that has actually changed (Update issue #374)
the PlaylistChanged event now shows which playlist has changed
2010-12-08 00:09:17 +00:00
Paweł Bara 6bf3162449 some MPRIS 1 bugfixes (Updates issue #374)
also:
- PlaylistSequence: RepeatMode and ShuffleMode are changed before change event is emitted
- PlaylistManager: emits an event after it has been initialized (which, for example, indicates that it's PlaylistSequence is now in place)
2010-12-07 21:14:40 +00:00
David Sansome 44dc05a87a Don't stop the track when it's about to end if crossfading is enabled but fadeout is disabled. Fixes issue #1040 2010-12-07 20:29:13 +00:00
David Sansome bbf0cd48c2 Insert songs as library playlist items if they're in the library. Fixes issue #1039 2010-12-07 19:33:19 +00:00
David Sansome 8aa7973312 Always create the schema in external databases if it doesn't exist yet. Fixes issue #1034 2010-12-07 19:07:12 +00:00
David Sansome 6a27020ccd Make the volume down shortcut decrease the volume instead of increasing it... Fixes issue #1033 2010-12-07 18:52:21 +00:00
John Maguire d17703d39a Add function for getting the correct config directory on mac. 2010-12-06 17:06:02 +00:00
Paweł Bara 9f3e5773fb QT tooltip now includes cover art and is generally prettier (updates issue #125)
ArtLoader is now available to every object, even if MPRIS is off
2010-12-05 23:41:41 +00:00
David Sansome cef02b4f61 Fix database test 2010-12-05 12:53:12 +00:00
David Sansome fc15d66321 Remove a lot of the old MPRIS code from the Player class, and fix a couple of MPRIS2 bugs 2010-12-05 11:39:06 +00:00
David Sansome f9959a4fba Treat the Jamendo database schema the same as other databases. 2010-12-05 10:55:21 +00:00
David Sansome 987dd8c57a Refactor and fix most of the MPRIS code. Fixes issue #374 2010-12-04 22:27:58 +00:00
David Sansome f94f2cd03c Clean up the background streams settings page a bit, and use a different icon 2010-12-04 15:11:50 +00:00
John Maguire b67bc3939a Fix a couple of mpris bugs.
Update issue #374
I've fixed some of the GetStatus/GetMetadata issues.
2010-12-03 15:01:36 +00:00
John Maguire c625acfd87 Refactor background streams.
Add volume control for background streams and infrastructure for custom streams.
2010-12-03 13:53:43 +00:00
John Maguire 880909104e Fix album cover handling in Jamendo. 2010-11-29 13:34:30 +00:00
David Sansome b1bf95a668 Remember which library a dynamic playlist was using when you restart clementine 2010-11-27 19:11:36 +00:00
David Sansome b85ddbb380 Put the Jamendo songs in a separate database that gets attached to the main database. "Reload" it by deleting the file, which is much faster than DELETEing all the songs inside. Make reloading the Jamendo, Icecast and Magnatune databases always bypass the network cache. Store the Jamendo track IDs in a separate table - for some reason this makes inserts faster. Fix the Jamendo model after the inital database load. Make the Jamendo dymanic playlist use the entries that are already in the local database rather than fetching the song metadata again. 2010-11-27 16:14:09 +00:00
John Maguire eca1704384 Sort of working Jamendo dynamic playlist. 2010-11-26 15:16:48 +00:00
David Sansome 188c7a53ec Add a database table, backend, and model for Icecast radio stations. Added a filter widget as well, but it doesn't actually search or sort yet. 2010-11-23 22:36:00 +00:00
Paweł Bara eb41dea464 the title and artist of the currently playing song are now the title of Clementine's window (Fixes issue #779)
better unmute behavior if Clementine was muted before it was closed (Fixes issue #983)
2010-11-23 19:38:15 +00:00
John Maguire 5feabe09de Add Jamendo support.
Fixes issue #470
2010-11-23 17:38:39 +00:00
David Sansome 89e3fde23b Add missing copyright headers to the icecast source and objective-c 2010-11-23 11:42:19 +00:00
John Maguire c2c3c8145b Add basic icecast directory support.
Fixes issue #601
2010-11-22 16:57:26 +00:00
Paweł Bara 5ceb64c9e3 "mute" command in main menu and context menu of tray icon (Fixes issue #962)
"now playing" tray icon's tooltip in Qt environments
2010-11-21 21:36:27 +00:00
David Sansome 4356adb9e3 Fix the windows and mac builds 2010-11-21 15:46:43 +00:00
David Sansome 0a5d286798 Bound song scores properly. Thanks arnaud.bienner 2010-11-21 15:38:26 +00:00
David Sansome 626c75cd45 Add MPRIS2 and gnome sound menu support 2010-11-21 15:13:26 +00:00
David Sansome 5969e2b3d7 Remember whether a dynamic playlist was active between restarts 2010-11-20 20:30:21 +00:00
David Sansome 7d54549213 Add support for dynamic playlists. A dynamic playlist is just a smart playlist that chooses and adds a new track when you finish listening to a song. 2010-11-20 18:49:54 +00:00
David Sansome ed1a25693c Add missing licenses to debian/copyright, and add copyright information to each source file 2010-11-20 13:27:10 +00:00
David Sansome 9e20ef13bc Automatic scoring. Thanks Arnaud Bienner. Fixes issue #141 2010-11-01 21:15:52 +00:00
John Maguire 6c5ce58eda Better check for MS-WMSP. 2010-10-25 12:19:36 +00:00
John Maguire cc782430cf Fix MS-WMSP streams.
Fixes issue #912
2010-10-25 12:14:28 +00:00
David Sansome 5d9e43bc14 Add a new smart playlist wizard. Doesn't do anything yet except look pretty. 2010-10-24 23:46:05 +00:00
John Maguire 29d1e9e7cb Add bizarrely named "mtime" to MPRIS.
Fixes issue #893
2010-10-19 11:20:50 +00:00
David Sansome f55ffe15d6 Format the last played column more nicely 2010-10-17 20:53:15 +00:00
David Sansome a13e0ba3f3 Increment play and skip counts when playing or skipping songs from the library 2010-10-17 19:27:31 +00:00
David Sansome 42e4c4a8db Add a skipcount field to the database, and read the last played time into Song objects. (still not used in the GUI yet). 2010-10-17 17:50:20 +00:00
David Sansome f5750bc348 More comments 2010-10-17 16:30:22 +00:00
David Sansome eb9660edad Parse FMPS ratings and played counts from mp3 id3v2 tags 2010-10-17 16:03:49 +00:00
David Sansome 95556df6aa Move database schema into a subdirectory of data/ 2010-10-17 11:22:34 +00:00
David Sansome 47004d0ac3 Fix album cover manager test 2010-10-16 18:21:28 +00:00
David Sansome b5f366c40a Add a thread safe network disk cache, and remove the need to pass a NetworkAccessManager around everywhere. Fixes issue #852 2010-10-16 17:20:54 +00:00
David Sansome b97b2138fa Play last.fm tag radio or similar artists radio when clicking on a tag in the song/artist info pane. 2010-10-16 15:22:14 +00:00
David Sansome 14fb4ca202 Ignore playlists when loading local directories. Fixes issue #886 2010-10-16 12:37:33 +00:00
John Maguire 2d19c2899a Ignore engine metadata notifications if the song was previously loaded via taglib.
Fixes issue #880
Fixes issue #864
Fixes issue #574
2010-10-12 11:55:45 +00:00
David Sansome 2f3732e73e Move lyrics into the song info pane, refactor out a load of the common code between artist and song info. 2010-10-10 16:09:20 +00:00
David Sansome d09bae16ee Don't crash when the receiver of a network get is destroyed before the request finishes 2010-10-09 14:15:05 +00:00
John Maguire 4c186f15dc Add more fields to MPRIS GetMetadata 2010-09-29 17:03:32 +00:00
David Sansome 4f1a4fe39a Some initial lyrics support. Scrapes all the sites that are supported by Amarok's Ultimate Lyrics script. No GUI or configuration yet. 2010-09-26 14:21:23 +00:00
David Sansome bd59b7009b Don't crash when trying to load a wma file without a tag. 2010-09-25 15:46:35 +00:00
David Sansome 6971f81be4 Use QFile::decodeName when reading command-line arguments. Fixes isse #752 2010-09-25 15:15:05 +00:00
David Sansome 625e4dffdb Replace more invalid FAT32 characters in filenames. Fixes issue #799 2010-09-25 15:04:58 +00:00
David Sansome 24cb79285a Fix some weird behaviour when renaming a device and changing the sorting order in the devices view. 2010-09-18 12:33:23 +00:00
David Sansome d0699e0bb5 Fix a crash when loading a local directory that contains other directories or playlists. 2010-09-18 11:50:20 +00:00
David Sansome e95c4979f8 Replace ? characters when copying files to devices (since they're invalid on FAT32 filesystems), and check the return value of QDir::mkpath. Fixes issue #721. 2010-09-18 10:06:30 +00:00
David Sansome 0adc88a07d Ignore iTunNORM comment fields in ID3v2 tags 2010-09-15 19:24:31 +00:00
David Sansome 0a7fa788b3 On second thoughts, lose the gotos and handle the last.fm errors by throwing. 2010-09-13 23:52:05 +00:00
David Sansome 89c873f9ef There are no gotos in this code 2010-09-13 23:44:11 +00:00
John Maguire 4570d891f2 Change global shortcuts on Mac to be eaten.
Update issue #722
Fixed on Mac.
2010-09-13 10:14:46 +00:00
David Sansome c2ac3f8f32 Don't mount GIO devices automatically, instead put them in a "not mounted" state in the GUI and mount them when double-clicked on. Fixes issue #719. Probably fixes issue #723. 2010-09-11 12:29:44 +00:00
David Sansome 6fea62d68e Make the organise dialog and free space bar look better with a dark theme. Fixes issue #630 2010-09-05 12:49:56 +00:00
John Maguire 214d77bc0e Fix test and fix song loader infinite loop. 2010-08-31 21:24:57 +00:00
John Maguire ad16a8b1ba Load local files from the DB if we already have them. 2010-08-31 19:45:33 +00:00
John Maguire bf5245d499 Remove warning for sql queries on the GUI thread. 2010-08-31 18:46:00 +00:00
David Sansome 1dd6ac323e Get the drive letter for MSC WMDM devices on Windows 7 2010-08-30 19:58:01 +00:00
David Sansome e4f5e97b17 Allow GetSupportedFiletypes to return an error, and make it possible to request a list of supported filetypes at the same time as opening the device for copying - making things much faster on MTP devices. 2010-08-30 12:22:15 +00:00
David Sansome d7e71ad14a Fix some little progress calculation bugs 2010-08-30 12:00:11 +00:00
David Sansome 728925097d Show progress information when transcoding files to copy to a device 2010-08-30 11:36:40 +00:00
David Sansome ebe237cd40 Codereview comments from r1844 2010-08-29 19:50:06 +00:00
David Sansome 93b35a6379 Clean up transcoded files from /tmp 2010-08-29 19:26:20 +00:00
David Sansome 4b381e00fd Transcode files when copying them to devices 2010-08-29 19:22:21 +00:00
David Sansome 5873fe80a6 Pick a good default format to transcode to 2010-08-29 16:12:55 +00:00
David Sansome d8ea4660e7 Store the device's transcode preference in the database 2010-08-29 15:32:36 +00:00
David Sansome 04e7e26088 Allow devices to report progress information about individual songs back to the Organise object. Implement this for MTP 2010-08-28 21:55:30 +00:00
John Maguire c801ce1a2d Rollback analyzer changes. 2010-08-28 18:48:16 +00:00
David Sansome f5cbeabb9b Copy string metadata properly 2010-08-28 13:52:29 +00:00
David Sansome a066eb9968 Recognise music on devices where WMDM/FormatCode isn't provide, such as mass storage devices. 2010-08-28 13:23:33 +00:00
David Sansome c625ac229d Fix all the windows crashes 2010-08-28 12:30:53 +00:00
David Sansome d980fd5ff8 Remove the pointless CreateInThread method from BackgroundThread and instead move objects to the right thread after creation. 2010-08-27 18:36:57 +00:00
David Sansome a776758ad1 Clear the "stop after this track" marker after stopping after this track. Fixes issue #552 2010-08-26 19:29:55 +00:00
David Sansome dad73e7e7e Fix a mingw compile error in release mode 2010-08-25 22:13:58 +00:00
David Sansome 3a67124fd9 Support copying files to WMDM devices. Sometimes doesn't crash 100% of the time. 2010-08-23 19:13:27 +00:00
David Sansome bd4b6b2b50 Set a proper filename on songs that are copied over MTP 2010-08-22 17:54:49 +00:00
John Maguire 459a134201 Remove FHT and use gstreamer's FFT for all analyzers. 2010-08-18 18:21:30 +00:00
John Maguire f077e33091 Fix playlist loading. 2010-08-16 18:58:26 +00:00
David Sansome ff19d31403 Support removing files from MTP devices 2010-08-14 17:06:38 +00:00
David Sansome 9fda03aa60 Support copying files to MTP devices 2010-08-14 16:39:45 +00:00
David Sansome 3f5e188045 Initial support for MTP devices 2010-08-14 15:57:05 +00:00
David Sansome 39132c4dcd In the organise dialog, prompt before connecting a device that hasn't been connected before 2010-08-14 12:30:51 +00:00
David Sansome c0ea45a9c9 Show an error dialog when copying or deleting files failed. 2010-08-14 11:51:50 +00:00
David Sansome 1dbb1817e8 Codereview comments from r1685 2010-08-12 16:35:43 +00:00
David Sansome b27238a480 Test whether we can still talk to afc before freeing the lockdownd client (fixes usbmuxd errors once and for all), report afc copy errors, keep track of files that failed to copy to a device, don't attempt to write the itunesdb if there were errors during copying. 2010-08-10 19:42:43 +00:00
David Sansome 5e00eb11de Pass shared_ptrs to music storage things to the organiser thread so they won't get deleted if the device is disconnected 2010-08-09 21:50:46 +00:00
John Maguire b1a96fd54d Fix encoding of tags we get from gstreamer. 2010-08-09 13:12:54 +00:00
David Sansome 58506b0469 strdup to the rescue! 2010-08-08 17:45:57 +00:00
David Sansome a228e2b806 Copy files to afc devices. Doesn't quite work yet 2010-08-08 17:41:06 +00:00
David Sansome 49da0eee27 Put a mutex around all the taglib stuff 2010-08-08 12:35:23 +00:00
David Sansome aadd38708f Fix an overflow when calculating free space and capacity. Thanks YellowOnion. Fixes issue #584 2010-08-07 10:00:20 +00:00
John Maguire 67eb9770c4 Code review comments for r1631 2010-08-04 12:37:46 +00:00
John Maguire 35e87b2a77 Start gstreamer playing from a separate thread. 2010-08-04 12:13:43 +00:00
John Maguire 36264e0b2b Separate out UniversalEncodingHandler. 2010-08-03 19:29:49 +00:00
John Maguire e67f9a66c8 Load playlist in separate threads on startup. 2010-08-03 18:57:17 +00:00
John Maguire f5449b9f8d Move playlist loading off the GUI thread. 2010-08-03 14:59:18 +00:00
John Maguire 812a91214e Add a warning if Song::InitFrom{Query,File}() is called from the GUI thread. 2010-08-03 13:37:47 +00:00
David Sansome 6604e97493 Make it possible to change the language with --language, or an option in the settings dialog. Fixes issue #583 2010-08-02 19:02:21 +00:00
John Maguire 8166a50b2a Use persistent model index. 2010-08-02 14:07:34 +00:00
John Maguire 992e0fb95e Add support for saving songs in a separate thread.
Updates issue #542
2010-08-02 14:00:43 +00:00
David Sansome 7a6499abde Copy the iTunes database off a libimobiledevice device and load it from the local file 2010-08-01 14:13:27 +00:00
David Sansome 5517e2a503 Oops, don't need this hack any more 2010-08-01 11:05:14 +00:00
David Sansome 02783b1d5d Unmount devices from the main thread instead of the organiser thread - fixes a crash when unmounting after copying 2010-08-01 11:01:07 +00:00
David Sansome 1f2b69c6bc Add support for deleting files from the filesystem, devices, and ipods. 2010-07-31 16:12:16 +00:00
David Sansome a236861dfa Option to group the library by file type 2010-07-31 14:14:03 +00:00
David Sansome e54f0a18d9 Add an implementation of FileSystemCapacity and FileSystemFreeSpace for windows 2010-07-29 22:58:23 +00:00
David Sansome 6f259d4ecc Show a free space bar in the organise dialog, and also show how much space would be taken up after copying files. 2010-07-29 22:16:12 +00:00
John Maguire 124ceb2db9 Fix compiling with Clang. 2010-07-27 13:21:28 +00:00
John Maguire fe26c8bb8f Fix crash when expanding last.fm tree.
Fixes issue #463
2010-07-26 17:32:16 +00:00
John Maguire 7235194016 Hack font size down to 11pt on Mac.
Fixes issue #546
2010-07-26 12:55:33 +00:00
David Sansome b2aba2bac2 Add an option to eject a device after copying files to it. Now with bonus multiple virtual inheritance. 2010-07-25 09:52:29 +00:00
David Sansome 1d5cef0f0d Set the organise progress to 100% when all files have been copied, but before the device is finalised 2010-07-24 17:40:19 +00:00
David Sansome b624be9800 Add almost-working support for writing to ipods 2010-07-24 16:58:14 +00:00
David Sansome c35bd8779a Make sure -1 and "" get stored in the database instead of NULL for song metadata. Thanks YellowOnion. Fixes issue #396. Fixes issue #479. 2010-07-24 15:13:09 +00:00
John Maguire 3f78df5725 Fix the parsing of Finder command line options.
Fixes issue #537
2010-07-24 14:57:56 +00:00
David Sansome f3491add62 Load albumartist from flac and ogg metadata. Thanks YellowOnion 2010-07-24 14:49:49 +00:00
David Sansome 77b4ec54bd Look at the file extension as well as magic when loading a local playlist. Fixes issue #507 2010-07-24 14:09:27 +00:00
David Sansome 692e5715e3 Replace slashes with underscores when organising files. Fixes issue #503 2010-07-24 13:56:49 +00:00
David Sansome 60eb5a34f8 Add global shortcuts for show/hide and show osd.
Update issue #533
Status: Fixed
Thanks for the patch :)
2010-07-24 12:39:09 +00:00
David Sansome 62616304d8 Add a MusicStorage interface that can be used to abstract away the details of copying a file to a device. 2010-07-19 19:56:29 +00:00
David Sansome d108841e36 Fix a build failure with mingw 2010-07-19 19:33:13 +00:00
David Sansome f64cdb23e9 Make the AlbumCoverLoader read embedded album cover art when it's available. Fixes issue #516 2010-07-19 17:55:02 +00:00
David Sansome 2f11ee5d2b Load embedded album art from id3v2 tags 2010-07-19 11:40:30 +00:00
John Maguire 95bb4eccea Unpack artist/title from SomaFM streams correctly.
Fixes issue #497
2010-07-15 12:59:14 +00:00
John Maguire 579c7cc592 Fix some Latin1 encoding guessing. 2010-07-15 12:46:08 +00:00
John Maguire 41ab99e62e Generate Hypnotoad rather than streaming it. 2010-07-14 11:16:56 +00:00
David Sansome d612e8468d Make the mute shortcut toggle 2010-07-13 22:22:04 +00:00
John Maguire d03bdda5f7 Fixes issu...
,'``.._   ,'``.
              :,--._:)\,:,._,.:       All Glory to
              :`--,''   :`...';\      the HYPNO TOAD!
               `,'       `---'  `.
               /                 :
              /                   \
            ,'                     :\.___,-.
           `...,---'``````-..._    |:       \
             (                 )   ;:    )   \  _,-.
              `.              (   //          `'    \
               :               `.//  )      )     , ;
             ,-|`.            _,'/       )    ) ,' ,'
            (  :`.`-..____..=:.-':     .     _,' ,'
             `,'\ ``--....-)='    `._,  \  ,') _ '``._
          _.-/ _ `.       (_)      /     )' ; / \ \`-.'
         `--(   `-:`.     `' ___..'  _,-'   |/   `.)
             `-. `.`.``-----``--,  .'
               |/`.\`'        ,','); SSt
                   `         (/  (/
2010-07-12 19:51:23 +00:00
David Sansome 91f801639a Unpack "Artist - Title" from icycast metadata. Fixes issue #425 2010-07-10 19:51:34 +00:00
David Sansome d8cc037446 Don't grab global shortcuts while the global shortcut grabber is open. Fixes issue #462 2010-07-10 19:17:21 +00:00
David Sansome 384ff16f2b Add a parser for a weird playlist format that looks like a cross between ASX and PLS. I don't know what it's called... 2010-07-10 18:39:41 +00:00
David Sansome e9525e8ec3 Very basic support for reading iPods with libgpod. Uses a hardcoded ~/.gvfs path for now. 2010-07-04 20:52:45 +00:00
David Sansome 2b58a1e19a Pass dataChanged through MergedProxyModel 2010-07-04 11:43:17 +00:00
David Sansome 8c26c61b0b Sort the device libraries properly 2010-07-04 00:58:01 +00:00
David Sansome 71a1cf3c41 Disconnecting devices works 2010-07-04 00:33:34 +00:00
David Sansome db5409b66b Store devices in the main database 2010-07-03 23:00:07 +00:00
David Sansome 6654182032 Don't connect new devices automatically, put them in a list model. Add icons for ipods, android phones and USB memory sticks. 2010-07-03 21:05:55 +00:00
John Maguire b4fa694847 Fix crash in file organiser. 2010-07-01 19:10:48 +00:00
David Sansome a1fbd65f68 Test whether sqlite3 has the FTS3 at compile time, and use the static sqlite3 module if not 2010-06-30 19:55:46 +00:00
John Maguire 88be9986f1 Catch Enter key events & ignore events we don't understand.
Fixes issue #443
2010-06-29 18:44:36 +00:00
David Sansome 8d3ca44d14 moc doesn't know about config.h, so these slots need to always be declared. 2010-06-26 15:09:32 +00:00
David Sansome 0404ecec70 Fix compilation without gstreamer. Fixes issue #440 2010-06-26 13:20:08 +00:00
David Sansome 2deca7fd61 Add a DeviceManager which holds all the listers and connected devices. Make FilesystemDevices use their own LibraryWatcher. 2010-06-26 12:41:18 +00:00
David Sansome 2b17a8ee1f Revert r1344 (the timer tracing), it didn't help 2010-06-25 22:04:24 +00:00
David Sansome f0b984cbe9 Prepend a 0 to single-digit track numbers in the organiser. Fixes issue #438 2010-06-25 15:15:02 +00:00
David Sansome cc6413ab0e Add tracing to every timer event, might help track down CPU usage... 2010-06-25 08:46:03 +00:00
David Sansome 69924cd76a Add copy and move menu items to the playlist 2010-06-24 23:36:39 +00:00
David Sansome e1e8866424 Make pausing and resuming library scans come from the task manager, not the organiser. 2010-06-24 22:59:29 +00:00
David Sansome 05b6c8fe71 Allow organising of whole directories, and pause the library watcher while organising is in progress. 2010-06-24 21:46:18 +00:00
David Sansome f9e3d405cd Consts and grammar 2010-06-24 18:59:09 +00:00
David Sansome 5f9c1bb2aa Oops, don't need this any more 2010-06-24 18:37:13 +00:00
David Sansome 0848f62c3d Move OrganiseFormat to core/ and add an Organise class that actually does the work. 2010-06-24 18:33:38 +00:00
David Sansome 44d58482f0 Make the LibraryWatcher report on its progresss. Fixes issue #436 2010-06-23 14:00:18 +00:00
David Sansome eb830051c8 Show a percentage next to the loading indicator 2010-06-23 13:47:27 +00:00
David Sansome f808591ec7 Refactor the loading indicator widget into a seperate TaskManager class that can handle tasks with progress 2010-06-23 13:21:30 +00:00
David Sansome ed422c3743 Set a longer remote timeout on unit tests so they don't fail when they run on buildbit with high load. 2010-06-23 11:51:13 +00:00
David Sansome 9106abb1a0 Handle redirect messages from mmssrc properly. Fixes issue #385. 2010-06-23 11:47:54 +00:00
David Sansome c96e622897 Merge merge merge 2010-06-22 20:57:05 +00:00
John Maguire 15b8b90556 Implement native dock menu on Mac.
Fixes issue #349
2010-06-22 14:09:13 +00:00
David Sansome c357b2d548 Use the same last.fm API for automatic and manual fetching 2010-06-22 13:54:07 +00:00
David Sansome ad4229160e Pedantry 2010-06-21 12:42:22 +00:00
David Sansome 1339ee860d Don't need these symbols any more 2010-06-21 12:41:38 +00:00
David Sansome ea52bbf3e2 Register the FTS3 tokenizer with a QSqlQuery, so it works even if we couldn't resolve the sqlite symbols. 2010-06-21 12:38:24 +00:00
John Maguire b91a61c260 Tidy unicode length detection & add Cyrillic FTS test. 2010-06-21 12:07:56 +00:00
John Maguire f544e28051 Fix FTS on Mac & Win. 2010-06-21 09:32:57 +00:00
John Maguire 614e031c20 Hopefully fix static sqlite, ie. Mac & Win. 2010-06-20 21:05:18 +00:00
John Maguire 379681157a OCD 2010-06-20 20:59:54 +00:00
John Maguire 2f1a2fa9c7 More FTS tests. 2010-06-20 20:58:32 +00:00
John Maguire abf79ca447 Tests and refactoring for FTS. 2010-06-20 20:51:57 +00:00
John Maguire f989976d30 Some tests for the new FTS stuff. 2010-06-20 20:44:54 +00:00
John Maguire 59984c49ad Tidy up a bit. 2010-06-20 20:07:32 +00:00
John Maguire de4b889986 >.> 2010-06-20 20:05:01 +00:00
John Maguire 9f7803d964 The atrocity that is unicode-aware FTS.
Yes, this code is horrible. Maybe I'll fix it.
2010-06-20 19:46:51 +00:00
David Sansome c701c49004 Don't try to register empty global shortcuts (avoids loads of warnings being printed to stderr) 2010-06-20 18:43:20 +00:00
David Sansome 492d8fec87 Use sqlite's Full Text Search on the songs table 2010-06-20 16:30:10 +00:00
David Sansome 80837ce652 Oops - it helps if we actually remember to set the URL of the song we just loaded. Fixes issue #426 2010-06-20 12:50:08 +00:00
David Sansome e0d7b7021b Change the rain URL to one on clementine-player.org so we can redirect if the actual URL changes 2010-06-18 13:35:17 +00:00
John Maguire 82b728528e Better unicode search.
Fixes issue #419
2010-06-18 12:54:11 +00:00
David Sansome f82ff23d9b Don't miss out the first filename on the commandline 2010-06-18 12:19:19 +00:00
John Maguire 256b507cae Leopard compile fixes 2010-06-18 11:41:16 +00:00
David Sansome 28505857fc Fix commandline option parsing 2010-06-18 00:31:54 +00:00
David Sansome 398bd54203 Don't put NULL in these not nullable columns - fixes a crash when downloading the Magnatune db 2010-06-18 00:11:15 +00:00
John Maguire 67bc9351bd Only show mac universal access dialog if user clicks on button in global shortcuts dialog. 2010-06-17 23:11:51 +00:00
John Maguire 9f2db477f8 Remove useless function. 2010-06-17 23:00:07 +00:00
John Maguire 077dfd46b0 Support more shortcut keys on mac. 2010-06-17 22:55:34 +00:00
David Sansome 3fd807df31 Add an (unimplemented) label and button to the global shortcut dialog for mac 2010-06-17 22:15:07 +00:00
John Maguire a562190bbe Code review comments for r1198
Put back media keys for non-mac.

In this year:
The town of Riga is chartered as a city by Bishop Albert, who landed on the site of the town with 1,500 crusaders earlier that year.
2010-06-17 21:54:42 +00:00
John Maguire 25be0a1465 *Catch global shortcuts when clementine is focused.
*Automatically ask the user to enable assistive devices.
2010-06-17 21:33:16 +00:00
John Maguire f9e29fccf4 Global keyboard shortcuts for Cocoa.
Requires "Enable access for assistive devices" set in Universal Access control panel.
2010-06-17 20:31:34 +00:00
David Sansome 89ac81be10 Treat 0 the same as -1 and NULL for numeric columns such as "disc".
Update issue #411
Status: Fixed
Ah ha!  I knew it was the disc tag - one of them had a value of 0 set, and the other had no value at all which was taken by clementine to mean "-1", which was lower than 0 so screwed up the sorting.  Try now and it should be fixed (you'll have to get Clementine to rescan that directory - probably remove it from the library settings and add it again).
2010-06-17 15:52:06 +00:00
David Sansome 057a896967 Fix a few minor warnings 2010-06-17 14:05:21 +00:00
David Sansome c15afd8083 Fix a warning message 2010-06-16 22:12:08 +00:00
John Maguire 5307ca3db0 Return the correct type from GstBusFunc()s 2010-06-15 22:32:20 +00:00
John Maguire a8f7df9e28 Remove incorrect gst_message_unref. It should only be called from *sync* handlers that are returning GST_BUS_DROP. 2010-06-15 22:30:06 +00:00
John Maguire abdc2eee2e Put LoadUrl for mac back. 2010-06-15 21:56:33 +00:00
David Sansome 0f8ada10d3 Typo 2010-06-15 18:34:15 +00:00
David Sansome f162d9d620 Add a SongLoaderInserter that loads a list of URLs and inserts them into a playlist when it's done. Wire up everything in the GUI that loads URLs or filenames to use the new SongLoader. 2010-06-15 18:24:08 +00:00
David Sansome 25ff2bca59 Always treat text/uri-list as M3U 2010-06-15 14:52:42 +00:00
David Sansome 987a918d90 Timeout when fetching remote things 2010-06-15 14:44:28 +00:00
David Sansome 7afa3372f5 Fix the qWarning warning 2010-06-15 14:42:32 +00:00
David Sansome de630e0a9f Run LoadLocalDirectory in another thread so it doesn't block 2010-06-15 14:24:17 +00:00
David Sansome 2c3e9276aa Fix some of the comments on r1148 2010-06-15 13:56:41 +00:00
David Sansome a27b6d3561 Herp derp 2010-06-15 13:28:08 +00:00
David Sansome 08a01d6997 The start of some code to automagically determine whether a URL is a playlist or a song, and load the songs in the playlist if it's a playlist. Still to do: timeout, forcing M3U for text/uri-list. 2010-06-15 13:24:17 +00:00
John Maguire 73a381fe89 Rain! 2010-06-14 20:00:17 +00:00
John Maguire 5a97697702 Add support for opening files via Finder in OS X.
Update issue #405
Status: Started
Opening from Finder works but Clementine still isn't a "recommended" application.
2010-06-14 13:22:45 +00:00
David Sansome a8d79582c1 Add a status bar indicator to tell the user how many tracks are loaded. Fixes issue #155 2010-06-12 21:20:53 +00:00
David Sansome 083eb716a7 Crossfade magnatune streams properly 2010-06-12 20:22:58 +00:00
David Sansome 36abad486b Add a dialog for manual searching of Last.fm album covers. Fixes issue #402 2010-06-12 17:13:01 +00:00
David Sansome f69a82bc6e Force a re-download of the magnatune database so svn users will get the sku-codes required for downloading 2010-06-09 14:04:56 +00:00
David Sansome 40bb827fcd Make all the source files a single cmake target again. 2010-06-08 22:39:31 +00:00
John Maguire 2830ee1a62 Fix MPRIS pause behaviour.
Update issue 374
Pause/unpause should be fixed now.
2010-06-08 16:00:09 +00:00
David Sansome 7a449a545c Fix a compilation error when enabling other engines 2010-06-08 13:24:48 +00:00
John Maguire d34283a113 ProjectM on mac deployment fixes. 2010-06-07 11:38:43 +00:00
John Maguire a4386de578 Add some useful mac functions. 2010-06-07 09:49:20 +00:00
John Maguire 2e9dc6c570 Never override UTF-8 strings from TagLib. 2010-06-03 15:22:30 +00:00
David Sansome f33604580c Stop ASCII from voting, and add a failing test 2010-06-03 15:16:15 +00:00
David Sansome 3652ff30e0 Don't assert if one of the operands to our LIKE function is NULL 2010-06-03 14:56:49 +00:00
John Maguire 8a13f3e481 Qt is nice :-) 2010-06-03 14:11:53 +00:00
John Maguire 2ad15ffec6 Code review comments for r1023 2010-06-03 13:26:46 +00:00
John Maguire 407bc7a41e Fix segfault. 2010-06-03 13:02:24 +00:00
John Maguire b9df2a09d4 Add voting for codecs, eg. if 3/4 tags in a file are windows-1251 then they will all be decoded with windows-1251. 2010-06-03 12:36:43 +00:00
David Sansome c834a5f31f Do the compilation processing in the database thread, and make everything lock on the database to ensure two threads don't access it at once. 2010-06-02 16:22:20 +00:00
David Sansome 03d876a599 Put the Database object in its own thread, and create the Library and Playlist backends in that database thread. The database calls don't happen in the database thread yet, but this is the first step towards making sure sqlite access is thread safe. 2010-06-02 15:58:07 +00:00
David Sansome c7d351f68a Make it possible to wait for a background thread to start 2010-06-02 14:22:40 +00:00
David Sansome e891543f42 Fix the encoding of composers and albumartists as well 2010-06-02 13:22:54 +00:00
John Maguire f4385d4545 Detect cp866 & windows-1251 in "latin1" tags. 2010-06-02 12:31:40 +00:00
David Sansome 3dad151608 Undo part of r1004, thanks John 2010-05-31 21:24:54 +00:00
David Sansome d760721f61 Make this all a bit more sane 2010-05-31 20:59:13 +00:00
David Sansome 99cea19994 Create engine_ in the initialisation list. 2010-05-31 20:51:29 +00:00
David Sansome 5d272a89ee Codereview comment from r1000 2010-05-31 20:24:05 +00:00
David Sansome 3365c7c217 Fix a few memory leaks 2010-05-28 19:51:51 +00:00
David Sansome 2c9a29e226 Give this variable a default value so it doesn't get passed to QThread::start uninitialised 2010-05-28 18:42:11 +00:00
David Sansome 791534703c Allow names for custom saved streams. Fixes issue #242 2010-05-27 22:53:07 +00:00
John Maguire 734d505eb7 Fix media key global shortcuts on mac.
Dave: *again* :-P
2010-05-27 13:21:05 +00:00
John Maguire 722981e71d Stop streams on PlayPause. 2010-05-27 13:17:28 +00:00
David Sansome c9c44ca592 Move the playlist parsers to another directory, and add a PlaylistParser class that magically uses the right parser. 2010-05-22 20:06:19 +00:00
David Sansome 98235eea03 Remember the ordering of playlists 2010-05-21 10:37:24 +00:00
David Sansome 119c6fbd6e Refer to playlists by ID rather than index in the tabbar, so they can be moved around 2010-05-21 10:29:17 +00:00
David Sansome 1572124962 Seperate last played values for each playlist 2010-05-20 22:30:55 +00:00
David Sansome e515724bf7 Basic support for multiple playlists. Not everything works yet 2010-05-20 21:21:55 +00:00
David Sansome 33614533d8 Fix playlist wrapping into a last.fm stream, for real this time. 2010-05-19 13:08:52 +00:00
David Sansome a292677320 Refactor the way Player gets tracks to play from RadioPlaylistItems. They can now return synchronously with a URL, asynchronously via a signal, or with an error. This properly fixes the problem of preloading a last.fm stream when the track before is about to end. 2010-05-18 20:43:10 +00:00
John Maguire af3f8bcdfe Preload the next item in the playlist correctly when it's a radio station. 2010-05-18 14:30:55 +00:00
David Sansome bb015ca3aa Global shortcuts dialog should work now. 2010-05-17 11:06:50 +00:00
David Sansome 6806d78f96 Add a button to the global shortcuts dialog to open gnome's keybinding properties dialog. 2010-05-17 00:31:39 +00:00