*Catch global shortcuts when clementine is focused.

*Automatically ask the user to enable assistive devices.

src/core/macglobalshortcutbackend.h

@@ -40,11 +40,17 @@ protected:
 
 private:
   void KeyPressed(const QKeySequence& sequence);
+  bool CheckAccessibilityEnabled();
 
   QMap<QKeySequence, QAction*> shortcuts_;
 
-  friend class MacGlobalShortcutBackendPrivate;
+  enum AccessibilityStatus {
+    NOT_CHECKED,
+    ENABLED,
+    DISABLED
+  } accessibility_status_;
 
+  friend class MacGlobalShortcutBackendPrivate;
   MacGlobalShortcutBackendPrivate* p_;
 };
 

src/core/macglobalshortcutbackend.mm

@@ -23,26 +23,34 @@
 
 #include <QAction>
 #include <QList>
+#include <QMessageBox>
+#include <QPushButton>
 #include <QtDebug>
 
 #include <AppKit/NSEvent.h>
+#include <AppKit/NSWorkspace.h>
 #include <Foundation/NSString.h>
 #include <IOKit/hidsystem/ev_keymap.h>
 
 class MacGlobalShortcutBackendPrivate : boost::noncopyable {
  public:
   explicit MacGlobalShortcutBackendPrivate(MacGlobalShortcutBackend* backend)
-      : monitor_(nil),
+      : global_monitor_(nil),
+        local_monitor_(nil),
         backend_(backend) {
   }
 
   bool Register() {
   #ifdef NS_BLOCKS_AVAILABLE
-    monitor_ = [NSEvent addGlobalMonitorForEventsMatchingMask:NSKeyDownMask
+    global_monitor_ = [NSEvent addGlobalMonitorForEventsMatchingMask:NSKeyDownMask
         handler:^(NSEvent* event) {
-      qDebug() << __PRETTY_FUNCTION__;
       HandleKeyEvent(event);
     }];
+    local_monitor_ = [NSEvent addLocalMonitorForEventsMatchingMask:NSKeyDownMask
+        handler:^(NSEvent* event) {
+      HandleKeyEvent(event);
+      return event;
+    }];
     return true;
   #else
     return false;
@@ -50,7 +58,45 @@ class MacGlobalShortcutBackendPrivate : boost::noncopyable {
   }
 
   void Unregister() {
-    [NSEvent removeMonitor:monitor_];
+    [NSEvent removeMonitor:global_monitor_];
+    [NSEvent removeMonitor:local_monitor_];
+  }
+
+  // See UIElementInspector example.
+  bool CheckAccessibilityEnabled() {
+    if (AXAPIEnabled()) {
+      return true;
+    }
+
+    QMessageBox box(
+        QMessageBox::Question,
+        QObject::tr("Accessibility API required for global shortcuts"),
+        QObject::tr("Would you like to launch System Preferences so that you can turn on"
+                    " \"Enable access for assistive devices\"?\n"
+                    "This is required to use global shortcuts in Clementine."));
+    QPushButton* default_button =
+        box.addButton(QObject::tr("Open System Preferences"), QMessageBox::AcceptRole);
+    QPushButton* continue_button =
+        box.addButton(QObject::tr("Continue anyway"), QMessageBox::RejectRole);
+    box.setDefaultButton(default_button);
+
+    box.exec();
+    QPushButton* clicked_button = static_cast<QPushButton*>(box.clickedButton());
+    if (clicked_button == default_button) {
+      NSArray* paths = NSSearchPathForDirectoriesInDomains(
+          NSPreferencePanesDirectory, NSSystemDomainMask, YES);
+      if ([paths count] == 1) {
+        NSURL* prefpane_url = [NSURL fileURLWithPath:
+            [[paths objectAtIndex:0] stringByAppendingPathComponent:@"UniversalAccessPref.prefPane"]];
+        [[NSWorkspace sharedWorkspace] openURL:prefpane_url];
+      }
+      // We assume the user actually clicks the button in the preference pane here...
+      return true;
+    } else if (clicked_button == continue_button) {
+      return false;
+    }
+
+    return false;
   }
 
  private:
@@ -81,12 +127,14 @@ class MacGlobalShortcutBackendPrivate : boost::noncopyable {
     backend_->KeyPressed(sequence);
   }
 
-  id monitor_;
+  id global_monitor_;
+  id local_monitor_;
   MacGlobalShortcutBackend* backend_;
 };
 
 MacGlobalShortcutBackend::MacGlobalShortcutBackend(GlobalShortcuts* parent)
   : GlobalShortcutBackend(parent),
+    accessibility_status_(NOT_CHECKED),
     p_(new MacGlobalShortcutBackendPrivate(this)) {
 }
 
@@ -95,15 +143,28 @@ MacGlobalShortcutBackend::~MacGlobalShortcutBackend() {
 }
 
 bool MacGlobalShortcutBackend::DoRegister() {
+  // Always enable media keys.
   mac::SetShortcutHandler(this);
-  foreach (const GlobalShortcuts::Shortcut& shortcut, manager_->shortcuts().values()) {
-    shortcuts_[shortcut.action->shortcut()] = shortcut.action;
+
+  // Check whether universal access is enabled so that global shortcuts will work.
+  // This may pop up a modal dialog so only ask once per session.
+  if (accessibility_status_ == NOT_CHECKED) {
+    accessibility_status_ = CheckAccessibilityEnabled() ? ENABLED : DISABLED;
   }
-  return p_->Register();
+
+  if (accessibility_status_ == ENABLED && AXAPIEnabled()) {
+    foreach (const GlobalShortcuts::Shortcut& shortcut, manager_->shortcuts().values()) {
+      shortcuts_[shortcut.action->shortcut()] = shortcut.action;
+    }
+    return p_->Register();
+  }
+
+  return false;
 }
 
 void MacGlobalShortcutBackend::DoUnregister() {
   p_->Unregister();
+  shortcuts_.clear();
 }
 
 void MacGlobalShortcutBackend::MacMediaKeyPressed(int key) {
@@ -126,3 +187,7 @@ void MacGlobalShortcutBackend::KeyPressed(const QKeySequence& sequence) {
     action->trigger();
   }
 }
+
+bool MacGlobalShortcutBackend::CheckAccessibilityEnabled() {
+  return p_->CheckAccessibilityEnabled();
+}

src/translations/ar.po

@@ -873,6 +873,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr ""
 

src/translations/cs.po

@@ -875,6 +875,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr "Pokročilé řazení knihoven"
 

src/translations/da.po

@@ -878,6 +878,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr "Avanceret bibliotektsgruppering"
 

src/translations/de.po

@@ -877,6 +877,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr "Benutzerdefiniertes Gruppieren"
 

src/translations/el.po

@@ -880,6 +880,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr "Προχωρημένη ομαδοποίηση βιβλιοθήκης"
 

src/translations/en_CA.po

@@ -877,6 +877,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr "Library advanced grouping"
 

src/translations/en_GB.po

@@ -874,6 +874,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr "Library advanced grouping"
 

src/translations/es.po

@@ -880,6 +880,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr "Agrupamiento avanzado de la colección"
 

src/translations/fi.po

@@ -873,6 +873,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr ""
 

src/translations/fr.po

@@ -877,6 +877,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr "Groupement avancé de la bibliothèque"
 

src/translations/gl.po

@@ -875,6 +875,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr ""
 

src/translations/it.po

@@ -880,6 +880,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr "Raggruppamento avanzato della raccolta"
 

src/translations/kk.po

@@ -875,6 +875,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr ""
 

src/translations/nb.po

@@ -875,6 +875,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr "Avansert biblioteksgruppering"
 

src/translations/oc.po

@@ -873,6 +873,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr ""
 

src/translations/pl.po

@@ -875,6 +875,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr "Zaawansowanie grupowanie Biblioteki"
 

src/translations/pt.po

@@ -878,6 +878,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr "Agrupamento avançado da biblioteca"
 

src/translations/pt_BR.po

@@ -880,6 +880,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr "Organização avançada de biblioteca"
 

src/translations/ro.po

@@ -874,6 +874,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr ""
 

src/translations/ru.po

@@ -878,6 +878,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr "Расширенная сортировка коллекции"
 

src/translations/sk.po

@@ -878,6 +878,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr "Pokročilé zoraďovanie zbierky"
 

src/translations/sv.po

@@ -876,6 +876,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr "Bibliotek avancerad gruppering"
 

src/translations/tr.po

@@ -873,6 +873,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr ""
 

src/translations/zh_CN.po

@@ -873,6 +873,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr ""
 

src/translations/zh_TW.po

@@ -873,6 +873,21 @@ msgstr ""
 msgid "Select None"
 msgstr ""
 
+msgid "Accessibility API required for global shortcuts"
+msgstr ""
+
+msgid ""
+"Would you like to launch System Preferences so that you can turn on \"Enable "
+"access for assistive devices\"?\n"
+"This is required to use global shortcuts in Clementine."
+msgstr ""
+
+msgid "Open System Preferences"
+msgstr ""
+
+msgid "Continue anyway"
+msgstr ""
+
 msgid "Library advanced grouping"
 msgstr ""