Funkwhale/Clementine-audio-player-Mac-Linux-Windows
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
7,331 Commits 23 Branches 550 Tags
Commit Graph

7331 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
John Maguire
98e6061a3b
Merge pull request #6488 from clementine-player/release-on-tag 
Use proper git/ssh versions
 2019-12-30 18:18:09 +00:00
John Maguire
7d44268c0d Use proper git/ssh versions 2019-12-30 17:48:33 +00:00
John Maguire
240ba7b487
Merge pull request #6487 from clementine-player/release-on-tag 
Create github release on tag
 2019-12-30 00:55:21 +00:00
John Maguire
3a3113b784 Create github release on tag 2019-12-30 00:53:00 +00:00
John Maguire
d0ea1033a1
Build source tarball (#6486) 2019-12-29 23:50:53 +00:00
John Maguire
51c5939ba6 Set version 2019-12-29 21:16:57 +00:00
John Maguire
f9d4cd9f0d
Merge pull request #6485 from jbroadus/fix-gpodder-error-leak 
Fix gpodder sync memory leaks in success cases.
 2019-12-29 21:01:20 +00:00
John Maguire
5ee0a63a4f Try unlinking python2 first 2019-12-29 20:35:20 +00:00
Jim Broadus
36179a7197 Fix gpodder sync memory leaks in success cases. 
A closure created by NewClosure that handles Qt signals is destroyed if the
signal object is destroyed, the slot object is destroyed, or the signal is
invoked. In the case where the sender is passed as a shared pointer, the
reference prevents the sender from being destroyed before the closure.

So for closures built to handle responses returned from ApiRequest in
GPodderSync, the closure object and the response object will only be destroyed
after the signal is invoked. In some cases, separate closures are built for
error signals as well. For these, only one closure will be destroyed. The other
closures and the response object will be leaked.

A simple fix for the success cases is to remove the unnecessary error case
closures and directly connect the signals to slots. This is low hanging fruit
and still leaves leaks in the error cases. Those cases will require a more
complete solution to properly manage the life cycle of the response object.
 2019-12-29 10:11:29 -08:00
John Maguire
8f0f24f393 gettext & sqlite seem to already be installed 2019-12-29 17:10:51 +00:00
Clementine Buildbot
9e73aae821 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-12-29 16:40:32 +00:00
John Maguire
0d6279c983 Try running builds for tags 2019-12-29 16:37:23 +00:00
John Maguire
922e10bc48
Merge pull request #6480 from jbroadus/gpodder-timeout 
Add timeouts for gpodder requests.
 2019-12-26 21:42:23 +00:00
Jim Broadus
5e7e57df73 Set a 30 second timeout for gpodder requests. 2019-12-25 23:53:47 -08:00
Jim Broadus
77d5d8bdea Add a timeout option to NetworkAccessManager. 
In most cases, timeouts can be applied to a reply after a request has been made.
But some APIs, such as libmygpo-qt, don't always provide access to the reply or
provide abort methods. For these cases, add an optional timeout to
NetworkAccessManager. If set, create a NetworkTimeouts instance in createRequest
and add the reply. Use the reply as the parent so that it is destroyed when the
reply is destroyed.
 2019-12-25 23:53:45 -08:00
Clementine Buildbot
82b185c087 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-12-24 00:25:44 +00:00
John Maguire
fb51e7733c
Remove reference to buildbot 2019-12-16 13:55:11 +00:00
Clementine Buildbot
90a237716a Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-12-15 11:23:45 +00:00
John Maguire
9eeb6d3758
Merge pull request #6475 from rohtie/bugfix-position-not-resumed 
Fix resuming playback position on startup
 2019-12-15 11:21:00 +00:00
Thor Merlin Lervik
715da8909f Fix resuming playback position on startup 2019-12-14 17:22:16 +01:00
John Maguire
672b90659b
Merge pull request #6472 from cquike/xdg 
Support  for XDG_CONFIG_HOME and XDG_CACHE_HOME
 2019-12-10 18:56:41 +00:00
Cesar Enrique Garcia Dabo
a7ad66d028 Fix issues reported by clang-format 2019-12-10 18:45:06 +01:00
Cesar Enrique Garcia Dabo
397145d21f Remove obsolete forced setting of XDG_CONFIG_HOME. 
Apparently this was introduced in 2011 as a workaround to solve a problem in
libimobiledevice. However already in 2013 the problem was solved
in libimobiledevice:
b811fbb05b
 2019-12-10 18:05:55 +01:00
John Maguire
998f12699b
Merge pull request #6470 from lacc97/kglobalaccel 
Add KGlobalAccel global shortcuts backend
 2019-12-10 10:14:32 +00:00
Clementine Buildbot
ca2c6771fd Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-12-10 00:25:31 +00:00
Luis Caceres
7ef917008a Fix formatting again 2019-12-09 17:02:42 +00:00
Luis Caceres
344989785b Fix multiple triggers of shortcut actions 
Also properly connect/disconnect from DBus signal upons register/unregister.
 2019-12-09 16:58:32 +00:00
Luis Caceres
2307c15227 Fix style 2019-12-09 16:25:29 +00:00
Cesar Enrique Garcia Dabo
f5ec88b529 Add support in GetConfigPath() for /pixmapcache directory 2019-12-07 23:30:14 +01:00
Cesar Enrique Garcia Dabo
ab2f7c03ea Use QStandardPaths to define Path_Root and Path_CacheRoot. 
These two directories use QStandardPaths::ConfigLocation and
QStandardPaths::GenericCacheLocation respectively, with the
application name (Clementine) appended. The QStandardPaths class from QT
honors the XDG standards:

https://specifications.freedesktop.org/basedir-spec/basedir-spec-0.6.html
https://doc.qt.io/qt-5/qstandardpaths.html#writableLocation
 2019-12-07 23:22:13 +01:00
Luis Caceres
a3531d749a Actually fix formatting 2019-12-07 19:30:10 +00:00
Luis Caceres
0b6519bad4 Fix build with DBus disabled 2019-12-06 23:56:15 +00:00
Luis Caceres
8cab8fe180 Fix formatting 2019-12-06 23:53:40 +00:00
Luis Caceres
24a571769a Initial KGlobalAccel support 2019-12-06 22:34:13 +00:00
Clementine Buildbot
440ac6dda2 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-12-03 00:25:13 +00:00
Clementine Buildbot
1e28f4e7dd Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-11-26 00:25:05 +00:00
Clementine Buildbot
23d0f3514d Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-11-18 16:20:16 +00:00
John Maguire
00f3ae9e1b
Merge pull request #6462 from jonaski/snapcraft 
Fix and update snap
 2019-11-18 16:18:00 +00:00
Jonas Kvinge
7db052ca88 Fix and update snap 2019-11-16 22:50:56 +01:00
Clementine Buildbot
d8c020281e Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-11-15 17:28:36 +00:00
John Maguire
9bc73f21c1
Update README.md 2019-11-15 17:26:08 +00:00
Clementine Buildbot
f71e99360b Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2019-11-15 12:34:01 +00:00
John Maguire
62edd70188
Merge pull request #6459 from clementine-player/mingw 
Build windows release
 2019-11-15 12:31:55 +00:00
John Maguire
2090768058 Fix a few more gst plugins 2019-11-15 11:41:49 +00:00
John Maguire
019afdcc21 Add missing gstreamer plugin 2019-11-15 11:38:46 +00:00
John Maguire
0d6f01e7f4 Add missing gstreamer plugin 2019-11-15 11:00:42 +00:00
John Maguire
a359d0be05 Include Qt SVG dll 2019-11-15 10:14:35 +00:00
John Maguire
4ee4c192ec D'oh 2019-11-15 00:55:58 +00:00
John Maguire
dbd9a23e8e Update DLL list 2019-11-15 00:32:43 +00:00
John Maguire
ccf2fcec9b Don't use env as ~ isn't expanded 2019-11-14 23:32:03 +00:00