Commit Graph

8110 Commits

Author SHA1 Message Date
Jim Broadus 280a514ebc dbus: Fix annotation deprecation warnings
The com.trolltech was renamed to org.qtproject. The code generation tool
still handles the old name, but prints a deprecation error.

Reference: https://bugreports.qt.io/browse/QTBUG-23274
2021-04-20 22:49:21 +01:00
Jim Broadus f04657e7e7 Replace qrand usage with QRandomGenerator
QRandomGenerator was introduced in 5.10 and qrand has since been
deprecated. QRandomGenerator::global() returns a global instance that
has been securely seeded. QRandomGenerator provides methods that
generate values within ranges, so taking a modulus of the result isn't
necessary.
2021-04-20 10:31:07 +01:00
Jim Broadus 6b21079fd4 dbus: Fix xml format errors. 2021-04-20 10:30:06 +01:00
Jim Broadus 429d8ee0f9 core/logging: Fix QString::split deprecation
QString::SplitBehavior is deprecated in 5.14. Use Qt::SplitBehavior
after this version.
2021-04-19 10:25:31 +01:00
Jim Broadus 163ebe71d8 libclementine-tagreader: Discontinue use of deprecated taglib methods.
Direct use of MP4::itemListMap() was deprecated in favor of using item() and
setItem(). XiphComment::removeField was replaced by removeFields.
2021-04-18 13:48:13 +01:00
Jim Broadus 99ee1394a5 build: Remove CMP0012 NEW policy
This policy is already enabled by default. This may have originally
been a typo since it was added in the same commit where CMP0011 was set
to OLD in the top-level cmake file (b63d1cf9f1).
2021-04-18 13:47:10 +01:00
Jim Broadus 3690c41cb0 build: Remove CMP0011 OLD policy
This policy allowed included files and modules to affect policy in the
parent scope. Besides the top level, 3rdparty/libprojectm is the only
place where old policy is set.

Reference: https://cmake.org/cmake/help/latest/policy/CMP0011.html
2021-04-18 13:47:10 +01:00
Clementine Buildbot 7303f72ee8 Automatic merge of translations from Transifex 2021-04-18 02:57:04 +00:00
Jim Broadus e7364263b2 build: Move minimum cmake version to 3.0.0
Compatibility with versions prior to 2.8.12 is being deprecated,
resulting in build warning messages. The minimum for the official
supported distros is 3.7.2 (Stretch), so the version could be moved
forward when newer features are required.

Reference: https://cmake.org/cmake/help/v3.19/release/3.19.html#deprecated-and-removed-features
2021-04-17 16:24:46 +01:00
Clementine Buildbot 47f7b307f0 Automatic merge of translations from Transifex 2021-04-15 02:55:43 +00:00
Clementine Buildbot 009642d125 Automatic merge of translations from Transifex 2021-04-13 02:59:37 +00:00
Jim Broadus 3440f90a6b playbacksettings: Don't try to load empty icons
When populating output options, don't attempt to load an icon if that
field is empty. This cuts some log noise.
2021-04-12 10:58:46 +01:00
Clementine Buildbot 32944a15de Automatic merge of translations from Transifex 2021-04-12 02:58:52 +00:00
Clementine Buildbot 2d34588b84 Automatic merge of translations from Transifex 2021-04-11 02:57:39 +00:00
Jim Broadus a86558f9a6 playlist: Fix queued item painting
QueuedItemDelegate::DrawBox leaves the painter in a state that can cause
artifacts. Specifically, there are cases where the item text is not
visible. To fix this, push the painter state before making changes and
pop it after drawing.
2021-04-10 14:58:36 +01:00
Jim Broadus db55c541b2 Revert "↑↓ for "Up" and "Down" (#5841)"
This reverts commit 566708b778.

Escape sequences are not legal key sequences.

Reference: https://doc.qt.io/qt-5/qkeysequence.html#details
2021-04-10 14:57:55 +01:00
Clementine Buildbot 144bdc2495 Automatic merge of translations from Transifex 2021-04-09 02:55:40 +00:00
Clementine Buildbot 72c1f91c00 Automatic merge of translations from Transifex 2021-04-08 03:00:17 +00:00
Jim Broadus e8875faf83 visualisations: Properly scale projectM view
In version 5.6, Qt introduced an automatic scaling feature for high DPI
displays. Since projectM is not part of the Qt framework, it's necessary
to convert coordinates when specifying view size.

Reference: https://doc.qt.io/qt-5/highdpi.html
2021-04-07 21:49:18 +01:00
Fabio Bas 354f6a23e0 snake_case for variable names; reworked url resolution signals 2021-04-07 14:22:15 +01:00
Fabio Bas 91e1e5880d Fix compilation on older Qt, use Player::SongChangeRequestProcessed() signal to handle station play count 2021-04-07 14:22:15 +01:00
Fabio Bas cd561af516 radiobrowser url handler: emit metadata for radio stations 2021-04-07 14:22:15 +01:00
Clementine Buildbot 2d6bb4abd6 Automatic merge of translations from Transifex 2021-04-07 03:00:29 +00:00
Jim Broadus 3b8519fda3 internet: Move page creation to internet category class
This consolidates most of the knowledge of internet settings pages in
the internet subdirectory. The exception is the master page enumeration
in the settings dialog.
2021-04-06 14:05:00 +01:00
Jim Broadus 1de6a46e86 internet: Add InternetSettingsCategory class 2021-04-06 14:05:00 +01:00
Clementine Buildbot 8a7120e1e8 Automatic merge of translations from Transifex 2021-04-06 02:58:50 +00:00
Clementine Buildbot e077df22d3 Automatic merge of translations from Transifex 2021-04-05 02:58:16 +00:00
Clementine Buildbot 4f86e0b2b4 Automatic merge of translations from Transifex 2021-04-04 02:58:52 +00:00
Jim Broadus 2804a4d89f gstengine: Make output format configurable
Add an output format option in playback settings. The options are
Detect, S16LE, and F32LE. Selecting Detect will use the existing
behavior and detect the native format when the pipeline starts. The
other options will set the format when the pipeline is built.
2021-04-03 13:56:22 +01:00
Clementine Buildbot 15fdad3d51 Automatic merge of translations from Transifex 2021-04-03 02:57:07 +00:00
Jim Broadus ada6752eae gstengine: Don't modify caps when pipeline is running
When the decoder bin's src pad is added, only set caps to use the native
bit depth if the the pipeline is not already running.
2021-04-02 16:42:44 +01:00
Jim Broadus 4edf77082d settings: Remove unused page enum value
Remove unused Page_SoundCloud from SettingsDialog::Page.
2021-04-02 16:41:30 +01:00
Jim Broadus ae8a420690 settings: Move AddPage to SettingsCategory
This will allow future subclasses of SettingsCategory to populate their
own pages.
2021-04-02 16:41:30 +01:00
Clementine Buildbot d13410c91d Automatic merge of translations from Transifex 2021-04-02 03:02:29 +00:00
Jim Broadus f4e70face1 library: Fix rescan in case where library directory was recreated
If a root library directory is deleted and recreated, it is not
detected since inotify would need to watch the parent directory. On
rescan, if the subdirectory list for a directory is empty, re-add the
library's root directory.

This is an edge case on Linux systems. The issue may not exist on other
operating systems.
2021-04-01 14:53:49 +01:00
Jim Broadus fd3a2a2f12 library: Add accessors to directory structures
Add const accessors to the Directory and Subdirectory structures.
2021-04-01 14:53:49 +01:00
Jim Broadus 6412790723 smartplaylists: Escape pattern characters in search term
When using the LIKE function, use \ as an escape character and prepend
that to occurrences of the pattern characters _ and % in the search
term.
2021-04-01 14:52:48 +01:00
Jim Broadus b2e3f8ea6e smartplaylists: Cast filename to TEXT in queries
In some versions/builds of sqlite, the LIKE function won't match
blobs.

Reference: https://www.sqlite.org/compile.html#like_doesnt_match_blobs
2021-04-01 14:52:48 +01:00
Jim Broadus eb1b84b281 ratingwidget: Properly bind the ratings values
RatingPainter::RatingForPos should return a value in 0-1. But if the
passed position was outside of the widget's draw rectangle, a value
outside of that range could be returned.
2021-04-01 14:32:18 +01:00
Clementine Buildbot 86d782cb6a Automatic merge of translations from Transifex 2021-04-01 03:04:42 +00:00
Adolfo Jayme Barrientos 438e8ca61b Fix a typo in a translatable string 2021-03-31 18:10:50 +01:00
Clementine Buildbot 881898f845 Automatic merge of translations from Transifex 2021-03-31 02:57:36 +00:00
Jim Broadus c12294c5ec settings: Make the internet header selectable
Make the "Internet services" tab the internet providers category header instead of a tab under "User Interface".
2021-03-30 11:51:26 +01:00
Jim Broadus e77595fba6 widgets: Add option to draw selected GroupedIconView header 2021-03-30 11:51:26 +01:00
Jim Broadus 6b34d0435f settings: Add SettingsCategory class
Add a new category class for settings. This will eventually allow
category classes to maintain their own lists of subpages.
2021-03-30 11:51:26 +01:00
Clementine Buildbot fdb3f7ac37 Automatic merge of translations from Transifex 2021-03-26 04:03:26 +00:00
Clementine Buildbot b68b12010d Automatic merge of translations from Transifex 2021-03-25 02:47:45 +00:00
Jim Broadus c394d7d2dd settings: Don't connect service-specific signals to every page
Wii and notifications signals are currently connected for every settings
page. Move the signals from the base SettingsPage class into the derived
classes and connect the signals for only those objects.
2021-03-24 10:31:52 +00:00
Clementine Buildbot d1e9ee9f95 Automatic merge of translations from Transifex 2021-03-24 02:59:29 +00:00
Jim Broadus 3244cf0837 settings: Recategorize background stream settings
Move the background streams settings page to the general category.
2021-03-23 10:36:39 +00:00