Clementine Buildbot
4acfdae740
Automatic merge of translations from Transifex
2021-07-09 02:43:48 +00:00
kentsangkm
6b2918ee92
Generate compile_commands.json
2021-07-08 21:33:19 +01:00
Jim Broadus
a5e84bbe98
internet: Add common InternetService::ConfigRequired() method.
...
This will allow some common handling of unconfigured services.
2021-07-07 10:47:01 +01:00
Clementine Buildbot
7cb5f5c804
Automatic merge of translations from Transifex
2021-07-06 02:43:44 +00:00
Clementine Buildbot
db8de64abb
Automatic merge of translations from Transifex
2021-07-03 02:40:42 +00:00
Jim Broadus
a5fd484a61
internet: Consolidate ShowConfig methods.
...
InternetService::ShowConfig() and ShowSettingsPage() were used to show
the settings page for a service.
2021-07-02 11:54:21 +01:00
Adolfo Jayme Barrientos
25b537cf26
De-duplicate my translator credit
2021-07-02 10:29:17 +01:00
Clementine Buildbot
8c660e278c
Automatic merge of translations from Transifex
2021-07-01 02:44:35 +00:00
John Maguire
67aa154182
Explicitly tap liblastfm homebrew dependency
2021-06-30 22:30:38 +01:00
kentsangkm
f35a640ce3
clang-format
2021-06-30 22:05:18 +01:00
kentsangkm
cbe384d142
Add override
2021-06-30 22:05:18 +01:00
Clementine Buildbot
4a83f8c817
Automatic merge of translations from Transifex
2021-06-30 02:47:46 +00:00
Clementine Buildbot
67a947f116
Automatic merge of translations from Transifex
2021-06-29 02:46:23 +00:00
Clementine Buildbot
1db1e3231f
Automatic merge of translations from Transifex
2021-06-28 02:47:35 +00:00
Jim Broadus
f9854e564d
transcoder: Add options avenc_aac element.
...
Initially adding encoder and bitrate settings, but the gstreamer
element exposes a lot of ffmpeg options that can be added as needed.
Reference: https://gstreamer.freedesktop.org/documentation/libav/avenc_aac.html
2021-06-27 15:56:50 +01:00
Clementine Buildbot
5ab81fd8bc
Automatic merge of translations from Transifex
2021-06-25 02:47:39 +00:00
Clementine Buildbot
62cb889a3f
Automatic merge of translations from Transifex
2021-06-24 02:42:11 +00:00
Clementine Buildbot
e46503d0c3
Automatic merge of translations from Transifex
2021-06-23 02:46:40 +00:00
Clementine Buildbot
54be35f528
Automatic merge of translations from Transifex
2021-06-22 02:51:35 +00:00
Jim Broadus
6240fd3d0a
player: Fix crash on UrlHandler error.
...
In a case where a playlist is composed entirely of unresolvable
internet service URLs and the playlist is set to repeat, playing an
item will result in an infinite (until crash) recursive condition.
HandleLoadResult is called with a NoMoreTracks result. It then calls
NextItem, which calls PlayAt for the next item, which, again, calls
HandleLoadResult.
This can be reproduced by logging into a subsonic server, adding items
to an empty playlist, then signing out.
To solve this, separate the error condition from the NoMoreTracks
result. Handle URL resolution errors the same way that media playback
errors are handled, where an error count is incremented and the player
stops if a limit is reached. The common code also notifies the playlist
of the error and provides user feedback by graying out the item.
2021-06-21 12:52:25 +01:00
Lukas Prediger
57b5911f13
Fixes from code review for PR #7037
2021-06-21 12:51:44 +01:00
Lukas Prediger
6fa9cbcc65
Removing watch_for_disc_changes in CddaDevice constructor
2021-06-21 12:51:44 +01:00
Lukas Prediger
83b6bf28f3
No exceptions for error handling! ConnectedDevice::Init now returns bool, indicating success or failure.
...
As decreed by @hatstand.
2021-06-21 12:51:44 +01:00
Lukas Prediger
a4ad507704
Removed some unused includes.
2021-06-21 12:51:44 +01:00
Lukas Prediger
d2240ec0ae
Device change watchdog timer no longer freezes main thread while CddaSongLoader is active.
2021-06-21 12:51:44 +01:00
Lukas Prediger
2dd566653f
Dealing with cdio_open failures in CddaDevice constructor
2021-06-21 12:51:44 +01:00
Lukas Prediger
e35e4195c2
Not using std::make_unique
2021-06-21 12:51:44 +01:00
Lukas Prediger
6ea20336c2
CddaSongLoader: Only run one song loading thread at once.
...
- CddaSongLoader destructor waits for thread to end.
- Added flag to interrupt LoadSongsFromCdda
- Only start song loading if not already running
- Removed (now obsolete) mutex
2021-06-21 12:51:44 +01:00
Lukas Prediger
ae9824e26a
RipCDDialog no longer needs to LoadSongs on show.
2021-06-21 12:51:44 +01:00
Lukas Prediger
63953e1045
RipCDDialog now allows selecting the CD drive
2021-06-21 12:51:44 +01:00
Lukas Prediger
b68734c761
Fix: Missing include guard for cddadevice in mainwindow.cpp
2021-06-21 12:51:44 +01:00
Lukas Prediger
95799a911d
Removing ConnectedDevice::Refresh altogether
2021-06-21 12:51:44 +01:00
Lukas Prediger
639b918557
Removing CddaDevice::Refresh
2021-06-21 12:51:44 +01:00
Lukas Prediger
3c06b92b24
Ripper now works with a cdio instance passed into constructor
...
which comes from a CddaDevice corresponding to the device
2021-06-21 12:51:44 +01:00
Lukas Prediger
ae3037984c
RipCDDialog now uses CddaSongLoader from passed in CddaDevice
2021-06-21 12:51:44 +01:00
Lukas Prediger
14d5c25d37
Integrated cddevice back into cddadevice
2021-06-21 12:51:44 +01:00
Lukas Prediger
9ca75ae357
RipCDDialog now relies on CddaDevice to be notified about disc changes
2021-06-21 12:51:44 +01:00
Lukas Prediger
d2c636ab46
Introducing CdDevice, simple wrapper for cdio that watches disc changes.
...
CddaDevice now relies on this to update song list. CddaDevice::Refresh is now a no-op.
2021-06-21 12:51:44 +01:00
Clementine Buildbot
11bd0db03b
Automatic merge of translations from Transifex
2021-06-21 02:54:22 +00:00
Clementine Buildbot
c3c77aef19
Automatic merge of translations from Transifex
2021-06-16 02:55:57 +00:00
Jim Broadus
ffdaeba09f
cueparser: Be more lenient when parsing indexes.
...
Most specs have mm:ss:ff as the index time format, but cue files have
been found with single digit minutes. e.g. 0:00:00 instead of 00:00:00
Reference: https://www.gnu.org/software/ccd2cue/manual/html_node/CUE-sheet-format.html
2021-06-15 14:14:00 +01:00
Clementine Buildbot
2bf8f1388b
Automatic merge of translations from Transifex
2021-06-15 02:57:02 +00:00
Clementine Buildbot
418a366931
Automatic merge of translations from Transifex
2021-06-14 02:55:24 +00:00
Clementine Buildbot
4aa4f4fce3
Automatic merge of translations from Transifex
2021-06-13 02:54:58 +00:00
Jim Broadus
3a00403ad0
build: Add patch for libgpod mac build.
...
Store patch file in repository rather than relying on strawberry's file
server.
Reference: 27955cc441
2021-06-12 15:14:44 +01:00
Clementine Buildbot
7fb387b967
Automatic merge of translations from Transifex
2021-06-12 02:54:18 +00:00
Jim Broadus
4e4fccc07a
playlistparser: Add error mechanism for parsers.
...
Add a new Error signal to parser implementations. Display an error when
user tries to use the unimplemented CueParser::Save.
2021-06-11 10:17:20 +01:00
Jim Broadus
f4108b5a0c
playlistparser: Display errors on failures.
...
Add an Error signal to PlayListParser and connect that to the
PlayListManager::Error signal. This is eventually connected to the
Application::AddError. Add error messages in some cases where
PlayListParser can fail silently.
2021-06-11 10:17:20 +01:00
Clementine Buildbot
612767c878
Automatic merge of translations from Transifex
2021-06-09 03:12:09 +00:00
Clementine Buildbot
b09ab3ff37
Automatic merge of translations from Transifex
2021-06-04 04:25:11 +00:00
