Commit Graph

1818 Commits

Author SHA1 Message Date
John Maguire 718be22d0d Automatically bump the max file descriptors for clementine to the maximum on Mac. 2010-12-21 15:48:30 +00:00
John Maguire 596b5471b1 Nicer fix for mac crash. 2010-12-21 14:55:42 +00:00
John Maguire a139d46114 "Fix" for mac crash. Somehow adding an eventFilter prevents the stack overflow.
Fixes issue #1109
2010-12-21 14:41:02 +00:00
David Sansome 8453e9e768 Make the edit tag dialog save tags, also make it load them in a background thread. 2010-12-21 13:42:06 +00:00
Arnaud Bienner ccd26b4002 Removing trackSkipped when stopping: even if Amarok wasn't acting like this, in my opinion, a 'stopped' track should not be considered as 'skipped' 2010-12-21 00:38:07 +00:00
Arnaud Bienner 3218e08118 Displaying different text depending on the number of selected songs 2010-12-21 00:20:36 +00:00
David Sansome d531d01f60 Fix Windows \\ paths when preloading files as well as when playing them initially. 2010-12-20 19:00:48 +00:00
David Sansome 998f9e1af5 Add next and previous buttons to the edit tag dialog 2010-12-20 16:36:16 +00:00
David Sansome 2a63a746fe Allow changing the cover art from the edit tag dialog 2010-12-20 15:46:38 +00:00
John Maguire 4e2d82f3fb Fix mac build. 2010-12-20 14:49:47 +00:00
David Sansome b0d4d72b42 Add some information to the summary and statistics tabs in the edit tags dialog. 2010-12-20 14:12:40 +00:00
David Sansome c8520021d7 Start of a new edit tag dialog. Lots of things don't work and it doesn't actually save tags yet (so it's about as useful as before). 2010-12-19 23:40:36 +00:00
David Sansome a97c23d173 Fix liblastfm detection. Protip: variables can't be used before they're set. 2010-12-19 15:10:26 +00:00
David Sansome 2d8028d89a Use a smaller cover in the tray icon tooltip again. Fixes issue #1135 2010-12-19 15:04:22 +00:00
David Sansome 8bc23a4d66 Keep hold of the generator object while updating the smart playlist preview. Fixes issue #1139 2010-12-19 14:37:25 +00:00
David Sansome a21320e635 Make the sidebar larger by default 2010-12-19 14:29:25 +00:00
David Sansome afdf02e37b Hide the score and comment columns by default 2010-12-19 14:27:07 +00:00
David Sansome eb61b67dd1 Oops, remove debug output 2010-12-19 14:22:47 +00:00
David Sansome a348a4529d Make the pretty OSD snap to the center of the screen while dragging. Thanks brunciter. 2010-12-19 14:06:51 +00:00
David Sansome 7fd29f160d Add a configurable timeout to song and artist info network requests. Default to 2.5 seconds 2010-12-19 13:58:53 +00:00
David Sansome a6445f2fe7 Don't strip off file extensions in the OSD. Fixes issue #1066 2010-12-18 20:40:35 +00:00
David Sansome 05a1bf6e37 Make the clear button a part of the search textbox. Fixes issue #1071 2010-12-18 20:32:05 +00:00
David Sansome 75fad2ff60 Blur the sidepanel again if it was resized while blurred. Also make it opaque to mouse events while blurred. Fixes issue #1092 2010-12-18 19:56:05 +00:00
David Sansome c133a8db7c Don't scale album art when saving it to /tmp. Fixes issue #1096 2010-12-18 19:42:06 +00:00
David Sansome 85d1f16c5e Fix a crash when removing the active playlist when it is the first playlist. Fixes issue #1097 2010-12-18 19:37:29 +00:00
David Sansome f1f0a384a5 Sort songs loaded from directories by filename if there are no other tags present. Fixes issue #1104 2010-12-18 18:47:44 +00:00
David Sansome a8a035a13a Use the system libechonest if it's installed 2010-12-18 18:36:56 +00:00
Paweł Bara 5b2625f420 fixes a crash when trying to rate the current song if there's none (rate using global shortcut) 2010-12-18 17:41:03 +00:00
David Sansome 302333c36a Fix r2420 properly 2010-12-18 17:29:07 +00:00
David Sansome 28fdb147d8 Make last.fm optional. Thanks volkov0aa. Fixes issue #49 2010-12-18 17:28:02 +00:00
David Sansome 623ab527ee Maybe fix a crash when loading tags from MP3 files with encrypted frames 2010-12-18 17:01:25 +00:00
David Sansome 6ec77eadf6 Fix a display bug in the Last played column for songs that haven't been played in the last week. Thanks gmail@robbertkrebbers.nl. Fixes issue #1081 2010-12-18 16:50:00 +00:00
Paweł Bara 5893c27d2b missing include failing on windows 2010-12-17 17:05:55 +00:00
Paweł Bara 32f9825794 global shortcuts for rating songs (Fixes issue #1089)
renaming *index* methods in Playlist to *row*
2010-12-17 00:21:20 +00:00
Arnaud Bienner 6ecc69d18b Also filter on artist name on Cover manager (instead of only album name) 2010-12-16 23:38:27 +00:00
Paweł Bara 256d46624c in 'Files' tab, use Backspace or 'Back' key to go up one folder (Fixes issue #1105) 2010-12-15 20:41:31 +00:00
Paweł Bara 61d5641c35 try to start the 'load cover' dialog in album cover manager inside the chosen album's folder (Fixes issue #733) 2010-12-15 20:15:46 +00:00
Paweł Bara 80e8fc8d60 corrections to "make sure a playlist column will appear in the UI even if it's width was somehow set to 0" 2010-12-15 17:46:31 +00:00
Paweł Bara 0f3b8156f3 make sure a playlist column will appear in the UI even if it's width was somehow set to 0 2010-12-15 16:32:45 +00:00
Paweł Bara 4563c2dbd9 you can now use "file path" attribute when creating dynamic playlists (Fixes issue #1073)
some more MPRIS 2 corrections (Updates issue #1058)
2010-12-15 15:50:22 +00:00
John Maguire 7f6f1888cf Maybe fix crash in song info. 2010-12-14 19:00:05 +00:00
John Maguire 6cb9bd5619 Fix failed to build on ARM. 2010-12-14 18:54:25 +00:00
John Maguire d82262c0c9 Just one more close shortcut and settings dialog width fix on mac. 2010-12-14 18:28:14 +00:00
John Maguire cf160d6ebb Add one more close shortcut... 2010-12-14 18:23:14 +00:00
John Maguire f95d893945 Add support for building without Sparkle on mac. 2010-12-14 18:20:14 +00:00
John Maguire b9e642c864 Add more close shortcuts. 2010-12-14 17:55:08 +00:00
John Maguire 74b745366b Add keyboard shortcut to close queue manager. 2010-12-14 17:43:03 +00:00
John Maguire 6257b29629 Add keyboard shortcut for album cover manager close. 2010-12-14 17:31:39 +00:00
John Maguire 769a78c6a2 UI tweaks for mac album cover manager. 2010-12-14 17:09:41 +00:00
John Maguire 21415ff230 Fix some mac ui and metadata bugs. 2010-12-14 15:00:46 +00:00
Paweł Bara 5082d81ba4 some corrections to MPRIS 2 (Updates issue #1058) 2010-12-12 23:20:41 +00:00
David Sansome c6829feb82 Show just the artist and title in the system tray tooltip on Windows since it doesn't support HTML 2010-12-11 17:23:05 +00:00
David Sansome 8bd0319966 Merge translations from Launchpad 2010-12-11 15:31:44 +00:00
David Sansome 19ea38b0a1 Don't download the Magnatune catalogue every time. 2010-12-11 15:07:39 +00:00
David Sansome b8a78abe06 Don't wrap text in the loading indicator. Fixes issue #1028 2010-12-11 15:01:01 +00:00
David Sansome d98859eabb Support rating multiple songs at once. Fixes issue #1017 2010-12-11 14:53:43 +00:00
John Maguire f28d67966a Fix flickr url for kittens. 2010-12-11 14:31:03 +00:00
David Sansome 23f2530f59 Prevent the last playlist column from being hidden, and check that at least one is visible on startup. Fixes issue #991 2010-12-11 14:26:49 +00:00
David Sansome 5e17e93360 Smarter adding/removing from various artists. Fixes issue #717 2010-12-11 14:17:07 +00:00
David Sansome 01cccc0468 Cache the last emitted state from the engine to fix some invalid values being emitted over DBUS while a last.fm stream is buffering. Fixes issue #374 2010-12-11 13:38:51 +00:00
David Sansome 2b77c894db Err... fix the ASX parser 2010-12-11 12:12:36 +00:00
David Sansome bb186feda1 Show scroll buttons on the sidebar when it's bigger than the window. Fixes issue #1061 2010-12-11 12:01:19 +00:00
David Sansome 0aa3cb4308 Don't expand items on a double click now that we expand them on single clicks instead 2010-12-11 11:26:47 +00:00
David Sansome a739ff2714 Fix playlist parser tests 2010-12-11 11:07:00 +00:00
David Sansome 67452baa4d Fix a crash when requesting an invalid playlist index over MPRIS. Fixes issue #1041 2010-12-11 10:58:15 +00:00
David Sansome 9a7087d05f Add a "delete from disk" to the playlist menu. Fixes issue #218 2010-12-11 10:54:42 +00:00
David Sansome 2986d185e3 Make clicking items in tree views toggle expanded/collapsed, rather than always expanding 2010-12-11 10:40:54 +00:00
David Sansome 08b2bcc816 Always write URLs in XML based playlists, instead of URLs of relative paths. Also load playlist items from the library if possible. Fixes issue #1054 2010-12-11 10:35:07 +00:00
David Sansome d5f8d2f9af Translations 2010-12-11 10:33:35 +00:00
David Sansome 7650c1eddc Remove "-session" from the commandline to fix session management on KDE. Fixes issue #769 2010-12-11 10:04:17 +00:00
David Sansome 292fdd3e7f Fix writing of album art paths when saving XSPF files 2010-12-11 09:31:39 +00:00
John Maguire 5f6dcbe4b7 Early Caturday! 2010-12-10 14:26:29 +00:00
Arnaud Bienner 6b35eea469 Moving emitTrackSkipped from Next to PlayAt, to handle cases where user doesn't use Next button to skip a track. Also emit TrackSkipped in Stop if track was not ended 2010-12-10 00:11:38 +00:00
Paweł Bara 49f46bced8 playlists now emit PlaylistChanged also when their ordering changes (Updates issue #374) 2010-12-09 20:43:06 +00:00
David Sansome fca0ce1188 Use the current playlist, not the active playlist, when rating songs. Fixes issue #1047 2010-12-09 20:15:44 +00:00
David Sansome 47c13c4479 Listen for keyPressEvent instead of keyReleaseEvent in the library view. Thanks arnaud.bienner. Fixes issue #1042 2010-12-09 14:33:20 +00:00
John Maguire 81f43ac4f5 Unbreak the build. 2010-12-09 14:19:09 +00:00
John Maguire 4c66007e26 Code review comments from r2370. 2010-12-09 13:06:00 +00:00
John Maguire 3a19bb9d46 Fix config file location on Mac and automatically migrate. 2010-12-09 12:34:08 +00:00
Paweł Bara 04bbf73cff MPRIS' TracklistChanged event now contains the length of the playlist that has actually changed (Update issue #374)
the PlaylistChanged event now shows which playlist has changed
2010-12-08 00:09:17 +00:00
Paweł Bara 6bf3162449 some MPRIS 1 bugfixes (Updates issue #374)
also:
- PlaylistSequence: RepeatMode and ShuffleMode are changed before change event is emitted
- PlaylistManager: emits an event after it has been initialized (which, for example, indicates that it's PlaylistSequence is now in place)
2010-12-07 21:14:40 +00:00
David Sansome 579e24965a Make single clicking on an item in a library view expand it. Fixes issue #1027 2010-12-07 21:13:40 +00:00
David Sansome d761a5e91f Add a "plain sidebar" option. Fixes issue #1031 2010-12-07 21:04:52 +00:00
David Sansome 44dc05a87a Don't stop the track when it's about to end if crossfading is enabled but fadeout is disabled. Fixes issue #1040 2010-12-07 20:29:13 +00:00
David Sansome bbf0cd48c2 Insert songs as library playlist items if they're in the library. Fixes issue #1039 2010-12-07 19:33:19 +00:00
David Sansome 8aa7973312 Always create the schema in external databases if it doesn't exist yet. Fixes issue #1034 2010-12-07 19:07:12 +00:00
David Sansome 6a27020ccd Make the volume down shortcut decrease the volume instead of increasing it... Fixes issue #1033 2010-12-07 18:52:21 +00:00
David Sansome 2dce2e44fd Fix a regression where dragging songs into the playlist while a song was selected would abort the drop and start a new drag from the selected item. 2010-12-06 22:18:00 +00:00
David Sansome ef5494e08c Update Turkish translation. Thanks H. İbrahim Güngör 2010-12-06 21:20:06 +00:00
David Sansome 34532ed85f Allow editing tracks from the library pane. Thanks arnaud.bienner. Fixes issue #65 2010-12-06 21:16:04 +00:00
David Sansome ea725cb5f7 Add ari-tczew to the about box, and sort the list of people 2010-12-06 21:11:11 +00:00
John Maguire d17703d39a Add function for getting the correct config directory on mac. 2010-12-06 17:06:02 +00:00
Paweł Bara aafb3a3b73 include mpris_common in every environment 2010-12-06 00:36:31 +00:00
Paweł Bara 9f3e5773fb QT tooltip now includes cover art and is generally prettier (updates issue #125)
ArtLoader is now available to every object, even if MPRIS is off
2010-12-05 23:41:41 +00:00
David Sansome 4c72ef4177 Treat \r and \n in comment fields as newlines 2010-12-05 13:41:40 +00:00
David Sansome cef02b4f61 Fix database test 2010-12-05 12:53:12 +00:00
David Sansome 88831f4ebd Merge translations from Launchpad 2010-12-05 11:56:47 +00:00
David Sansome fc15d66321 Remove a lot of the old MPRIS code from the Player class, and fix a couple of MPRIS2 bugs 2010-12-05 11:39:06 +00:00
David Sansome f9959a4fba Treat the Jamendo database schema the same as other databases. 2010-12-05 10:55:21 +00:00
David Sansome 987dd8c57a Refactor and fix most of the MPRIS code. Fixes issue #374 2010-12-04 22:27:58 +00:00
David Sansome 3216f5b75e Remove ( and ) characters from FTS queries. Fixes issue #1010 2010-12-04 18:16:00 +00:00
David Sansome ba520b3793 Elide the text on the sidebar if it's too long. Fix tab animations when the tabs have non-ascii characters. Fixes issue #987 2010-12-04 18:03:53 +00:00
David Sansome 42f1bef53f Hide the first page in the smart playlist wizard 2010-12-04 17:36:10 +00:00
David Sansome 1dec3e9818 Add an option to stay running in the background when the window is closed, even if the tray icon is hidden. Fixes issue #914 2010-12-04 17:31:50 +00:00
David Sansome f818577907 Regression - remove the next track from the queue if it is the currently playing track. Fixes issue #1005 2010-12-04 16:47:28 +00:00
David Sansome a07a808e5f Show new lines properly in the comment tooltip, and simplify whitespace in the comment column. Fixes issue #1011 2010-12-04 16:43:09 +00:00
David Sansome 029f2e1f80 Re-enable the buffer duration spinner :S 2010-12-04 16:21:14 +00:00
David Sansome a18dafac9c Add a "Play from my Library" context menu item to similar artists in the song info view. Fixes issue #1014 2010-12-04 16:19:30 +00:00
David Sansome 5bb287c223 Add Load context menu item to all radio services. Fixes issue #1013 2010-12-04 15:49:43 +00:00
David Sansome f94f2cd03c Clean up the background streams settings page a bit, and use a different icon 2010-12-04 15:11:50 +00:00
John Maguire b67bc3939a Fix a couple of mpris bugs.
Update issue #374
I've fixed some of the GetStatus/GetMetadata issues.
2010-12-03 15:01:36 +00:00
John Maguire a33b4d4f49 Remove extraneous signal. 2010-12-03 13:59:35 +00:00
John Maguire c625acfd87 Refactor background streams.
Add volume control for background streams and infrastructure for custom streams.
2010-12-03 13:53:43 +00:00
John Maguire 880909104e Fix album cover handling in Jamendo. 2010-11-29 13:34:30 +00:00
John Maguire c679a19c91 Show behaviour preferences section on Mac but disable the irrelevant options. 2010-11-29 12:51:01 +00:00
David Sansome 31a6aa2de7 Add a Comment field to the playlist. Fixes issue #890 2010-11-28 15:22:48 +00:00
David Sansome 59875c9708 Make F2 edit the first playlist column again after the cursor has been moved. Fixes issue #939 2010-11-28 15:14:48 +00:00
David Sansome 96a45bb0ca Fix inline editing of multiple tracks from the playlist. Fixes issue #869 2010-11-28 14:47:35 +00:00
David Sansome e3760a5bc5 And fix the length parsing 2010-11-28 14:18:07 +00:00
David Sansome 68ae8aec0e Fix genre parsing from Jamendo 2010-11-28 14:13:46 +00:00
David Sansome dd937fb06d Make searching more responsive on large libraries (Jamendo) 2010-11-27 20:20:26 +00:00
David Sansome af234763f2 Do library searching and grouping in a background thread 2010-11-27 20:09:00 +00:00
David Sansome e63c101223 Don't show the various artists node for Jamendo (there aren't any various artists albums) - making search a bit faster 2010-11-27 19:37:34 +00:00
David Sansome bea4b39020 Make Jamendo search work again 2010-11-27 19:37:09 +00:00
David Sansome 858a8650b8 Create the correct type of playlist item from query generators 2010-11-27 19:23:52 +00:00
David Sansome f11c494c44 Add a random smart playlist to Jamendo 2010-11-27 19:18:56 +00:00
David Sansome b1bf95a668 Remember which library a dynamic playlist was using when you restart clementine 2010-11-27 19:11:36 +00:00
David Sansome 623b90e5e2 Make sure the smart playlists node really really gets put at the top 2010-11-27 18:43:49 +00:00
David Sansome 70df709fc2 Don't use Connection: Keep-Alive when doing requests to the Jamendo API 2010-11-27 18:37:53 +00:00
David Sansome 69d3d89b0f Have a different list of smart playlists for Jamendo and the normal Library. Only add default Jamendo smart playlists once. 2010-11-27 17:52:08 +00:00
David Sansome b85ddbb380 Put the Jamendo songs in a separate database that gets attached to the main database. "Reload" it by deleting the file, which is much faster than DELETEing all the songs inside. Make reloading the Jamendo, Icecast and Magnatune databases always bypass the network cache. Store the Jamendo track IDs in a separate table - for some reason this makes inserts faster. Fix the Jamendo model after the inital database load. Make the Jamendo dymanic playlist use the entries that are already in the local database rather than fetching the song metadata again. 2010-11-27 16:14:09 +00:00
David Sansome 421c04b6ec Do the limit clause in dynamic playlists properly 2010-11-27 12:24:47 +00:00
John Maguire d5d058fbaa Add debug header. 2010-11-26 16:03:13 +00:00
John Maguire eca1704384 Sort of working Jamendo dynamic playlist. 2010-11-26 15:16:48 +00:00
David Sansome 4e60558053 Use the Jamendo track id as the ROWID for tracks, and implement reloading the database. 2010-11-25 23:05:37 +00:00
David Sansome 17da224283 Record the Jamendo album ID with each song, and implement the context menu items to open album info and download album pages. 2010-11-25 22:16:29 +00:00
David Sansome 927937e236 Save and restore Jamendo playlist items properly. Add a Jamendo context menu. 2010-11-25 22:04:23 +00:00
David Sansome e36cbcb50c Get proper sized album art for Jamendo songs 2010-11-25 21:20:18 +00:00
David Sansome 9483f9b930 Typo 2010-11-25 21:20:06 +00:00
David Sansome f758004760 Stop the size of the radio header widget increasing when different services are selected. 2010-11-25 19:18:41 +00:00
John Maguire 8ede752ff9 Fix small leak. 2010-11-25 17:25:50 +00:00
John Maguire b2ffc58070 Only check subversion info if $BUILDBOT_REVISION not set.
Fix compile warning.
2010-11-25 17:14:11 +00:00
David Sansome 23d1ea81ea Add dividers to the list of icecast stations 2010-11-24 21:34:54 +00:00
David Sansome c021a639c5 Remember the icecast sort by mode 2010-11-24 21:16:33 +00:00
David Sansome ad191e0880 Show a context menu for icecast stations 2010-11-24 19:41:17 +00:00
David Sansome c43a06c04e Support drag&drop of icecast streams to the playlist 2010-11-24 19:25:41 +00:00
David Sansome 9a8d01e2bd Comment(s) from r2281 2010-11-23 23:10:53 +00:00
David Sansome 83948e4973 Fix the size of the icecast filter widget icons 2010-11-23 23:10:38 +00:00
David Sansome b9f7cf78a9 Make sorting and filtering the list of icecast stations work 2010-11-23 23:05:42 +00:00
David Sansome 8d23c8b3ee Comments from r2279 2010-11-23 22:37:00 +00:00