Two improvements to handling of Spotify albums:
- Remove single-track results if they also show up in the album
results. This eliminates duplicates showing up in albums.
- For each album, choose the majority artist attribution to
specify as the Album Artist. For users who group by Album Artist,
this prevents splitting albums into multiple entries when there
are contributing artists.
Squashes following commits:
commit d8bf17e13f50c7642ba491228f31608f4861d3b6
Author: Joel Bradshaw <cincodenada@gmail.com>
Date: Tue Oct 28 19:56:36 2014 -0700
Improve handling of Spotify Top Tracks and compilations
Two improvements to handling of Spotify albums:
- Combine individual tracks into a "Top Tracks" album by just
setting the album name to "Top Tracks"
- For each album, choose the majority artist attribution to
specify as the Album Artist. For users who group by Album Artist,
this prevents splitting albums into multiple entries when there
is a contributing artist.
commit 228650a1d7122e5d1947133ba793afaffaa69cb4
Author: Joel Bradshaw <cincodenada@gmail.com>
Date: Wed Oct 29 10:00:21 2014 -0700
Style cleanup, including run of make format
Also wrapped Top Tracks with tr()
commit a4f6c1ecd9bcc8338a956b1a45c2f184ee9d660d
Author: Joel Bradshaw <cincodenada@gmail.com>
Date: Sun Feb 15 13:38:52 2015 -0800
Simply remove duplicate entries from the "Top Tracks" section
Don't create the fake "Top Tracks" album, but remove entries
from it if they show up in the album results. This will
eliminate the main problem - duplicates showing up in albums -
and avoid issues with actual single-track results showing up
erroneously as "Top Tracks"
commit 859abc93b3491cc526d89df19a85dc4cf9bce1c8
Author: Joel Bradshaw <cincodenada@gmail.com>
Date: Sat Apr 18 09:17:50 2015 -0700
Clean up stray f and make format
commit 333de1c4aa947c7cbe785429565bf4f08f98d476
Author: Joel Bradshjaw <cincodenada@gmail.com>
Date: Sat Apr 18 09:19:10 2015 -0700
Update majority_count so it works
Fixes issue with it just picking the last artist on the album
as the album artist
Squashed the following commits:
5c723ad commit: Fix: Includes alpha sort
15ac350 commit: Fix: Updated Database::kSchemaVersion to 49.
767a26a commit: Fixed small code style issue. Added schema-49 to data.qrc instead schema-48
bf6aa64 commit: fixup! Modified async handling of CollapsibleInfoPane as recommended by Andreas. Display of IDv2 tag lyrics works now.
c1f97e9 commit: fixup! Added support to read/display the ID tag lyrics in MP3 files:
c946b1d commit: Added support to read/display the ID tag lyrics in MP3 files:
-Added schema to the database to store it
-Added readers/writers for ID tags
-Added readers/writers for the database to the song class
-Added the taglyricsinfoprovider to show the lyrics in songinfo
Otherwise, it was never set to false at startup if no "current_playlist" was saved in the settings, then there was no new value saved for "current_playlist".
Fixes#4011.
QList.removeAll calls the destructor for the elements in the list. This caused `req` to be initialized in `SpotifyClient::TryPlaybackAgain()`. Therefore, spotify method calls might crash because the pointers are invalid.
This commit moves the `pending_playback_requests_.removeAll` to the end of the method to ensure `req` is accessible all the time.
John Maguire
ArnaudBienner
Chocobozzz
Clementine Buildbot
Joel Bradshaw
Andreas
Andreas
Wuerstchen
Martin Babutzka
Ivan Leontiev
Andreas