1
0
mirror of https://github.com/clementine-player/Clementine synced 2025-01-31 11:35:24 +01:00

7890 Commits

Author SHA1 Message Date
Clementine Buildbot
8db8b1e788 Automatic merge of translations from Transifex 1.4.0rc1-447-g8db8b1e78 2021-01-30 02:55:19 +00:00
Jim Broadus
18eef830a5 transcoder: Add ability to dump pipeline graphs
Add a "Dump Graph" menu option to the pipeline view if CLEMENTINE_DEBUG
is enabled.
1.4.0rc1-446-g18eef830a
2021-01-29 22:30:03 +00:00
Jim Broadus
7d061afdc3 gstengine: Add PipelineView class
Add ListView derivative class for displaying GstPipelineModel data. A
GetSelectedIds method provides the list of selected pipelie IDs.
2021-01-29 22:30:03 +00:00
Jim Broadus
8d11e9ffab transcoder: Remove unused slots
Transcoder::Start() and Transcoder::Cancel() were defined as slots but
never used as such.
1.4.0rc1-444-g8d11e9ffa
2021-01-29 13:12:26 +00:00
Jim Broadus
d4c9628222 transcoder: Don't show progress when nothing is selected
Previously, pressing the "Start transcoding" button with zero files selected
would show the progress group with the progress bar in the busy state.
2021-01-29 13:12:26 +00:00
Clementine Buildbot
78d4c4f3f7 Automatic merge of translations from Transifex 1.4.0rc1-442-g78d4c4f3f 2021-01-29 02:56:20 +00:00
Clementine Buildbot
b9a8442632 Automatic merge of translations from Transifex 1.4.0rc1-441-gb9a844263 2021-01-28 02:54:59 +00:00
Jim Broadus
7ba322b10b debug: Generalize debug feature check
Move the debug console variable check to a static method in the
Application class and use environment variable CLEMENTINE_DEBUG instead
of CLEMENTINE_DEBUG_CONSOLE. This will allow debug features to be
enabled elsewhere in the code.

Example:
CLEMENTINE_DEBUG=1 clementine
1.4.0rc1-440-g7ba322b10
2021-01-27 15:14:40 +00:00
Clementine Buildbot
79ca9147e9 Automatic merge of translations from Transifex 1.4.0rc1-439-g79ca9147e 2021-01-27 02:54:57 +00:00
Maarten Jacobs
cb88954a3b Changed usage of boolean to enumeration
Changed the NextInternal() and NextItem() methods to use a enumerated value to track whether "next track" or "next album" is desired
1.4.0rc1-438-gcb88954a3
2021-01-26 23:35:10 +00:00
Maarten Jacobs
8fcdbd5114 Adding a "play next album" function, in addition to "play next
track".

Changed shortcut key for Next Album from "space" to F9

Fixed indentation in player.cpp

Fixed spacing in player.cpp.

Updated player.cpp to ensure while loop takes into consideration the last
song on the playlist.

Fixed lint formatting error in player.cpp

Additional changes to player.cpp to make sure next album search reacts properly to the given repeat mode.

Updated player.cpp to address cpplint issues.

Fixing formatting issues.

Fixing formatting errors.

Finished formatting updates.

Final formatting...

Final formatting

Really final formatting...

Addressed issues from code review.

Added functionality to disable Next Album option when repeat mode is "repeat track".

Added commentary to recent changes.

Disable Next Album action also when Repeat Mode is Repeat_Album

In addition to disabling this action for the Next_Track repeat mode, the same applies to the Next_Album repeat mode.
2021-01-26 23:35:10 +00:00
Jim Broadus
8c2ab8fa05 transcoder: Add pipeline list to details dialog
List current running transcode pipelines when the details dialog is displayed.
This will be allow the addition of cancel and debug options.
1.4.0rc1-436-g8c2ab8fa0
2021-01-26 10:31:25 +00:00
Jim Broadus
befaacebf9 gstengine: Add a model for pipelines
Provide GstPipelineModel for displaying lists of GstPipelineBase instances.
2021-01-26 10:31:25 +00:00
Clementine Buildbot
a7a32b08b6 Automatic merge of translations from Transifex 1.4.0rc1-434-ga7a32b08b 2021-01-22 03:38:11 +00:00
Clementine Buildbot
76c87146dd Automatic merge of translations from Transifex 1.4.0rc1-433-g76c87146d 2021-01-21 03:38:44 +00:00
Clementine Buildbot
447e91a68e Automatic merge of translations from Transifex 1.4.0rc1-432-g447e91a68 2021-01-20 03:37:48 +00:00
Clementine Buildbot
a9e193234e Automatic merge of translations from Transifex 1.4.0rc1-431-ga9e193234 2021-01-19 03:35:37 +00:00
Clementine Buildbot
7854aefdd6 Automatic merge of translations from Transifex 1.4.0rc1-430-g7854aefdd 2021-01-18 03:34:38 +00:00
Clementine Buildbot
f1678fd33c Automatic merge of translations from Transifex 1.4.0rc1-429-gf1678fd33 2021-01-17 03:35:38 +00:00
Clementine Buildbot
81a3c0f83c Automatic merge of translations from Transifex 1.4.0rc1-428-g81a3c0f83 2021-01-15 03:33:21 +00:00
Jim Broadus
cf842a8c5a gstengine: Use existing stream id to track background streams
New ids were being created for background stream mapping, but streams already
have unique IDs that can be used for this.
1.4.0rc1-427-gcf842a8c5
2021-01-14 11:29:43 +00:00
Clementine Buildbot
72e2e62eb1 Automatic merge of translations from Transifex 1.4.0rc1-426-g72e2e62eb 2021-01-14 03:36:26 +00:00
Jim Broadus
4f5bf1cc6f gstengine: Give pipelines unique names
Currently, most pipelines are named "pipeline". Use a type string in combination
with the stream id to give each pipeline a unique name.
1.4.0rc1-425-g4f5bf1cc6
2021-01-13 22:59:49 +00:00
Jim Broadus
5ffdb7d98c gstengine: Move pipeline id handling to base class
Move the id and the global counter from GstEnginePipeline to GstPipelineBase.
Make counter atomic.
2021-01-13 22:59:49 +00:00
Clementine Buildbot
2dd424a195 Automatic merge of translations from Transifex 1.4.0rc1-423-g2dd424a19 2021-01-13 03:27:02 +00:00
Jim Broadus
ace5234e62 transcoder: Fix flacenc "insane" level encoding
The gstreamer flacenc element defines a set of quality levels that is different
from the standard flac library. Its highest level, labeled "insane", uses
settings that are outside of the streamable subset. Set the streamable-subset
property to false for this level.

Reference: https://xiph.org/flac/format.html#subset
1.4.0rc1-422-gace5234e6
2021-01-12 11:47:12 +00:00
Clementine Buildbot
e1e559732b Automatic merge of translations from Transifex 1.4.0rc1-421-ge1e559732 2021-01-12 03:20:36 +00:00
Stephen
596cd9b0ab install dependencies after checkout 1.4.0rc1-420-g596cd9b0a 2021-01-11 10:27:12 +00:00
Stephen G
ea4772ba2a use Brewfile 2021-01-11 10:27:12 +00:00
Clementine Buildbot
b3aed042eb Automatic merge of translations from Transifex 1.4.0rc1-418-gb3aed042e 2021-01-11 03:16:59 +00:00
Jim Broadus
f779652aa2 Localize song count in playlist
Use %Lx to localize number formatting.

Reference: https://doc.qt.io/qt-5/qtquick-internationalization.html#5-use-lx-so-numbers-are-localized
1.4.0rc1-417-gf779652aa
2021-01-10 21:58:54 +00:00
Jim Broadus
7b94309827 transcoder: Use GstPipelineBase class for pipeline
This allows the use of the DumpGraph method in transcoding pipelines. The call
can be added to Transcoder::StartJob for debugging. In the future, a trigger
may be added to the debug console ui.
1.4.0rc1-416-g7b9430982
2021-01-10 18:14:57 +00:00
Jim Broadus
f9e9dae73d gstengine: Add a base class for pipelines
This allows debug functionality to be shared.
2021-01-10 18:14:57 +00:00
Clementine Buildbot
8c774e3880 Automatic merge of translations from Transifex 1.4.0rc1-414-g8c774e388 2021-01-10 03:17:22 +00:00
Jim Broadus
25d3fca079 gstengine: Fix output audio depth
When the decoder bin's src pad becomes available, check its caps
for a format. If the format is not S16LE, then apply F32LE caps
before the tee. This prevents the pipeline from negotiating
S16LE when the decoder produces other formats.
1.4.0rc1-413-g25d3fca07
2021-01-06 20:39:33 +00:00
Jim Broadus
06066dfba4 gstengine: Add a caps filter in pipeline before tee 2021-01-06 20:39:33 +00:00
Jim Broadus
2b17170bf8 gstengine: Move the probe capsfilter to the correct side of the converter
The pipeline currently constructs a caps filter between the tee and the
probe audio converter. This requires that S16LE data is fed to the tee.
2021-01-06 20:39:33 +00:00
Clementine Buildbot
479f1d4de9 Automatic merge of translations from Transifex 1.4.0rc1-410-g479f1d4de 2021-01-04 03:05:13 +00:00
Clementine Buildbot
8201c10355 Automatic merge of translations from Transifex 1.4.0rc1-409-g8201c1035 2021-01-03 03:03:01 +00:00
Clementine Buildbot
8f863bc969 Automatic merge of translations from Transifex 1.4.0rc1-408-g8f863bc96 2021-01-02 02:58:52 +00:00
Benjamin Valentin
3efa68f07d internet/soma.fm: use high quality AAC stream
Prefer the high quality 130 kbit/s AAC stream over the 'fast' 128 kbit/s
mp3 stream.
1.4.0rc1-407-g3efa68f07
2021-01-01 18:00:59 +00:00
Jim Broadus
409c6b89d1 gstengine: Add a gstreamer debug console page
New page initially provides a button that triggers a dump of a graph of the main
pipeline.
1.4.0rc1-406-g409c6b89d
2021-01-01 16:26:29 +00:00
Jim Broadus
c353deba0c gstengine: Add a DumpGraph method to GstEnginePipeline
This will write a .dot graph and can be integrated with the debug console.
2021-01-01 16:26:29 +00:00
Jim Broadus
0ee64a32f6 console: Add a mechanism to allow components to add pages
Add a MainWindow signal that is emitted when a debug console is created. Relay
that signal to the Application. Add an AddPage method to the Console class that
allows components to populate pages when they receive the signal.
2021-01-01 16:26:29 +00:00
Clementine Buildbot
2b99d32bee Automatic merge of translations from Transifex 1.4.0rc1-403-g2b99d32be 2021-01-01 03:01:46 +00:00
Jim Broadus
63a73a4a55 Fix debug console instance leak
Each time the debug console is launched, a new instance is created, but never
deleted. To fix, create one instance, if the option is enabled, and show that
one each time the menu option is selected.
1.4.0rc1-402-g63a73a4a5
2020-12-31 21:07:58 +00:00
Clementine Buildbot
dc2c1e1117 Automatic merge of translations from Transifex 1.4.0rc1-401-gdc2c1e111 2020-12-29 02:57:55 +00:00
Clementine Buildbot
87cd3d2aba Automatic merge of translations from Transifex 1.4.0rc1-400-g87cd3d2ab 2020-12-28 02:56:46 +00:00
Jim Broadus
a012e7e273 gstengine: Fix InitFromString return value
GstEnginePipeline::InitFromString was attempting to link the decoder and audio
bins twice and returning the result of the failed second attempt as it's own
status. The return value was also being ignored by the caller.
1.4.0rc1-399-ga012e7e27
2020-12-27 21:50:06 +00:00
Clementine Buildbot
0393d865ca Automatic merge of translations from Transifex 1.4.0rc1-398-g0393d865c 2020-12-27 02:55:57 +00:00