Funkwhale
/
Clementine-audio-player-Mac-Linux-Windows
mirror of https://github.com/clementine-player/Clementine
1
0
Fork 0
Code Issues Releases Wiki Activity

transcoder: Don't show progress when nothing is selected 

Previously, pressing the "Start transcoding" button with zero files selected
would show the progress group with the progress bar in the busy state.
This commit is contained in:
Jim Broadus 2021-01-27 22:32:58 -08:00 committed by John Maguire
parent 78d4c4f3f7
commit d4c9628222
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/transcoder/transcodedialog.cpp
View File

@ -135,14 +135,21 @@ void TranscodeDialog::SetWorking(bool working) {
}
void TranscodeDialog::Start() {
QAbstractItemModel* file_model = ui_->files->model();
const int count = file_model->rowCount();
if (count == 0) {
// Nothing to process.
return;
}
SetWorking(true);
QAbstractItemModel* file_model = ui_->files->model();
TranscoderPreset preset = ui_->format->itemData(ui_->format->currentIndex())
.value<TranscoderPreset>();
// Add jobs to the transcoder
for (int i = 0; i < file_model->rowCount(); ++i) {
for (int i = 0; i < count; ++i) {
QFileInfo input_fileinfo(
file_model->index(i, 0).data(Qt::UserRole).toString());
QString output_filename = GetOutputFileName(input_fileinfo, preset);
@ -151,10 +158,10 @@ void TranscodeDialog::Start() {
// Set up the progressbar
ui_->progress_bar->setValue(0);
ui_->progress_bar->setMaximum(file_model->rowCount() * 100);
ui_->progress_bar->setMaximum(count * 100);
// Reset the UI
queued_ = file_model->rowCount();
queued_ = count;
finished_success_ = 0;
finished_failed_ = 0;
UpdateStatusText();