Funkwhale/Clementine-audio-player-Mac-Linux-Windows
1
0
Fork 0
mirror of https://github.com/clementine-player/Clementine synced 2025-01-03 05:21:57 +01:00
Code Issues Releases Wiki Activity

Fix debug console instance leak

Browse Source 
Each time the debug console is launched, a new instance is created, but never
deleted. To fix, create one instance, if the option is enabled, and show that
one each time the menu option is selected.
This commit is contained in:
Jim Broadus 2020-12-29 01:05:10 -08:00 committed by John Maguire
parent dc2c1e1117
commit 63a73a4a55
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/ui/mainwindow.cpp
View File

@ -172,6 +172,7 @@ MainWindow::MainWindow(Application* app, SystemTrayIcon* tray_icon, OSD* osd,
edit_tag_dialog_(std::bind(&MainWindow::CreateEditTagDialog, this)),
love_dialog_(std::bind(&MainWindow::CreateLoveDialog, this)),
stream_discoverer_(std::bind(&MainWindow::CreateStreamDiscoverer, this)),
debug_console_(std::bind(&MainWindow::CreateDebugConsole, this)),
global_shortcuts_(new GlobalShortcuts(this)),
global_search_view_(new GlobalSearchView(app_, this)),
library_view_(new LibraryViewContainer(this)),
@ -2740,6 +2741,8 @@ StreamDiscoverer* MainWindow::CreateStreamDiscoverer() {
return discoverer;
}
Console* MainWindow::CreateDebugConsole() { return new Console(app_, this); }
void MainWindow::ShowAboutDialog() { about_dialog_->show(); }
void MainWindow::ShowTranscodeDialog() { transcode_dialog_->show(); }
@ -3075,10 +3078,7 @@ void MainWindow::DoGlobalSearch(const QString& query) {
global_search_view_->StartSearch(query);
}
void MainWindow::ShowConsole() {
Console* console = new Console(app_, this);
console->show();
}
void MainWindow::ShowConsole() { debug_console_->show(); }
void MainWindow::keyPressEvent(QKeyEvent* event) {
if (event->key() == Qt::Key_Space) {

3
src/ui/mainwindow.h
View File

@ -43,6 +43,7 @@ class Application;
class ArtistInfoView;
class BackgroundStreams;
class CommandlineOptions;
class Console;
class CoverProviders;
class Database;
class DeviceManager;
@ -268,6 +269,7 @@ class MainWindow : public QMainWindow, public PlatformInterface {
EditTagDialog* CreateEditTagDialog();
LoveDialog* CreateLoveDialog();
StreamDiscoverer* CreateStreamDiscoverer();
Console* CreateDebugConsole();
void OpenSettingsDialog();
void OpenSettingsDialogAtPage(SettingsDialog::Page page);
void ShowSongInfoConfig();
@ -318,6 +320,7 @@ class MainWindow : public QMainWindow, public PlatformInterface {
Lazy<LoveDialog> love_dialog_;
Lazy<About> about_dialog_;
Lazy<StreamDiscoverer> stream_discoverer_;
Lazy<Console> debug_console_;
GlobalShortcuts* global_shortcuts_;