David Sansome
020df2d360
Canadians can spell too
2010-06-16 23:09:31 +00:00
David Sansome
39907cda9a
Use visualizations with a 'z' in the UI, and save the proper spelling for en_GB
2010-06-16 23:05:11 +00:00
David Sansome
6d39996466
Make the indentation in the settings pages more consistent
2010-06-16 22:45:13 +00:00
David Sansome
5c6eefa5ac
Add another line left of the player controls
2010-06-16 22:43:20 +00:00
David Sansome
2c272a3341
Maybe fix the dodgy coloured tabs on mac
2010-06-16 22:38:19 +00:00
David Sansome
c15afd8083
Fix a warning message
2010-06-16 22:12:08 +00:00
David Sansome
afa4d0a4e2
Add a Now Playing widget
2010-06-16 22:00:39 +00:00
David Sansome
0d7eabcfb0
Show the "status bar" as part of the central widget
2010-06-16 19:21:15 +00:00
David Sansome
9b39b2db68
Move tabs to the top
2010-06-16 18:50:01 +00:00
David Sansome
ea87eddcd2
Fix some weirdness when saving and restoring the state of the playlist QHeaderView. Fixes issue #413
2010-06-16 17:15:13 +00:00
David Sansome
bc7c62c09e
Highlight the URL in the add stream dialog when it's opened
2010-06-16 16:21:38 +00:00
David Sansome
68edaff32f
Show the whole URL in the playlist for streams that don't have a title or basefilename set.
2010-06-16 16:18:28 +00:00
David Sansome
357f229e02
Make saved radio streams use the song loader when dragged to the playlist
2010-06-16 16:11:23 +00:00
David Sansome
7f3c0b853a
Sort by album artist properly.
...
Update issue #408
Status: Fixed
Looks good, thanks!
2010-06-16 14:52:01 +00:00
John Maguire
5307ca3db0
Return the correct type from GstBusFunc()s
2010-06-15 22:32:20 +00:00
John Maguire
a8f7df9e28
Remove incorrect gst_message_unref. It should only be called from *sync* handlers that are returning GST_BUS_DROP.
2010-06-15 22:30:06 +00:00
John Maguire
abdc2eee2e
Put LoadUrl for mac back.
2010-06-15 21:56:33 +00:00
David Sansome
0f8ada10d3
Typo
2010-06-15 18:34:15 +00:00
David Sansome
f162d9d620
Add a SongLoaderInserter that loads a list of URLs and inserts them into a playlist when it's done. Wire up everything in the GUI that loads URLs or filenames to use the new SongLoader.
2010-06-15 18:24:08 +00:00
David Sansome
02d01b1314
PLS playlists aren't really INI files - they don't follow the same rules with escaping characters, so parse them the old fashioned way.
2010-06-15 17:34:00 +00:00
David Sansome
8c7539f02e
ASF files aren't really XML - try to correct the mismatching case
2010-06-15 17:00:48 +00:00
David Sansome
25ff2bca59
Always treat text/uri-list as M3U
2010-06-15 14:52:42 +00:00
David Sansome
987a918d90
Timeout when fetching remote things
2010-06-15 14:44:28 +00:00
David Sansome
7afa3372f5
Fix the qWarning warning
2010-06-15 14:42:32 +00:00
David Sansome
de630e0a9f
Run LoadLocalDirectory in another thread so it doesn't block
2010-06-15 14:24:17 +00:00
David Sansome
2c3e9276aa
Fix some of the comments on r1148
2010-06-15 13:56:41 +00:00
David Sansome
a27b6d3561
Herp derp
2010-06-15 13:28:08 +00:00
David Sansome
08a01d6997
The start of some code to automagically determine whether a URL is a playlist or a song, and load the songs in the playlist if it's a playlist. Still to do: timeout, forcing M3U for text/uri-list.
2010-06-15 13:24:17 +00:00
John Maguire
73a381fe89
Rain!
2010-06-14 20:00:17 +00:00
John Maguire
92e95ecf80
Support for background streams.
2010-06-14 19:15:10 +00:00
David Sansome
b6a642ab15
Major graphical change: add a vertical line between the repeat/playlist buttons and the playlist length label
2010-06-14 16:18:15 +00:00
John Maguire
1e80ac8c5b
Use cmake rm.
2010-06-14 15:10:39 +00:00
John Maguire
fd037c0f9a
Fix buildsystem to build a new dmg every time.
...
Fixes issue #405
2010-06-14 14:50:04 +00:00
John Maguire
9415b2a3f4
Oops, this got left out from r1139.
2010-06-14 13:27:45 +00:00
John Maguire
5a97697702
Add support for opening files via Finder in OS X.
...
Update issue #405
Status: Started
Opening from Finder works but Clementine still isn't a "recommended" application.
2010-06-14 13:22:45 +00:00
David Sansome
e46d93b599
Move the track length indicator to the right, and add information about the selected tracks
2010-06-13 12:45:05 +00:00
David Sansome
a8d79582c1
Add a status bar indicator to tell the user how many tracks are loaded. Fixes issue #155
2010-06-12 21:20:53 +00:00
David Sansome
8340aa0a64
Warn before cancelling a Magnatune download, flash the taskbar and display a notification when it completes.
2010-06-12 20:43:07 +00:00
David Sansome
083eb716a7
Crossfade magnatune streams properly
2010-06-12 20:22:58 +00:00
David Sansome
dd36835b49
Make "" an acceptable option for LINGUAS meaning None
2010-06-12 19:36:22 +00:00
David Sansome
e419e27644
Replace the dock widgets with a tab widget to remove the (mostly) superfluous label at the top.
...
Update issue #389
Status: Fixed
It looked like it was going to be too difficult to make the tabs themselves draggable - the draggable dock widgets are actually a Qt thing and they're not very customisable. So instead I've just removed the top label all together.
2010-06-12 19:32:17 +00:00
David Sansome
a41a450218
Add an cmake option to leave translation out of the binary.
...
Update issue #400
Status: Fixed
Ok makes sense I suppose. I've cleaned up the patch a bit and committed it. I changed the cmake variable to LINGUAS (upper case), and valid values are "All", "None", or a space seperated list of languages.
2010-06-12 17:44:19 +00:00
David Sansome
c37933c370
Hack to prevent the user from dragging album covers around.
2010-06-12 17:32:27 +00:00
David Sansome
36abad486b
Add a dialog for manual searching of Last.fm album covers. Fixes issue #402
2010-06-12 17:13:01 +00:00
David Sansome
516f769a75
Enable dragging and double clicking from the album cover manager to add albums to the playlist
...
Update issue #169
Status: Fixed
I hadn't forgotten about this, honest... :)
2010-06-12 15:18:16 +00:00
David Sansome
efcd2c968a
Search library on composer and genre too
2010-06-12 13:19:55 +00:00
David Sansome
d40ab596bd
Fix a Windows bug where Clementine would get stuck hidden in the system tray forever
2010-06-12 00:30:35 +00:00
David Sansome
b16d072cd6
Add some progress information to the album cover fetcher
2010-06-11 23:07:53 +00:00
David Sansome
7e1b54a779
Fix the height of items in the album cover manager, don't show artists with no albums, and add a status bar (currently unused)
2010-06-11 22:35:41 +00:00
David Sansome
f739ae5e00
(Vertical) center align playlist items again.
...
Update issue #379
Fixed the alignment.
2010-06-11 16:41:29 +00:00
David Sansome
0a19a275a2
On Windows and Mac use a different gstreamer registry file
2010-06-11 12:22:21 +00:00
David Sansome
0e83490766
Search in albumartist too. Fixes issue #387
2010-06-11 12:01:41 +00:00
David Sansome
f04e4bb6ea
Add an icon to the visualisations window.
...
Update issue #394
Missed that one, thanks :)
2010-06-10 22:50:26 +00:00
David Sansome
cb2588b3a3
Juggling the translations
2010-06-10 22:49:47 +00:00
David Sansome
76f0803b81
Make visualisations optional.
...
Update issue #394
Status: Fixed
There's now an ENABLE_VISUALISATIONS option that you can set to cmake with cmake -DENABLE_VISUALISATIONS=OFF, or with ccmake or cmake-gui.
2010-06-10 22:48:23 +00:00
David Sansome
15df3b90a3
Set window icons on all the dialogs. Fixes issue #394
2010-06-10 22:09:35 +00:00
David Sansome
3fe941f5c1
Make the playlist header present a one-level menu for showing and hiding columns. Fixes issue #381
2010-06-10 17:40:14 +00:00
David Sansome
07ba35ff6d
Append a "Hz", "bpm", "kbps" etc. suffix to bit rate, sample rate and BPM columns in the playlist
2010-06-10 17:04:40 +00:00
David Sansome
6eea954fb1
Right-align numeric fields in the playlist
2010-06-10 17:04:05 +00:00
David Sansome
c41344524d
Display the BPM column in the playlist properly.
2010-06-10 16:54:07 +00:00
David Sansome
f4c7a50973
Convert the song's path to native seperators in the tag editor dialog. Fixes issue #370
2010-06-10 16:05:32 +00:00
David Sansome
ffa354e887
Use a proper Magnatune partner ID
2010-06-09 16:05:59 +00:00
David Sansome
9b713c2ed9
Add or load *all* selected library items, not just the one that you right clicked on. Fixes issue #366
2010-06-09 15:49:05 +00:00
David Sansome
5f92d652a9
Show a "Configure Magnatune" button on the magnatune header
2010-06-09 15:38:00 +00:00
David Sansome
782166db41
Invalidate the currently playing track cache when scrolling sideways. Fixes issue #377
2010-06-09 15:37:54 +00:00
David Sansome
f69a82bc6e
Force a re-download of the magnatune database so svn users will get the sku-codes required for downloading
2010-06-09 14:04:56 +00:00
David Sansome
903dbba87e
Dialog for downloading Magnatune albums
2010-06-09 14:02:26 +00:00
David Sansome
7a6df2860f
Play the mp3s without commercials for magnatune subscribers
2010-06-08 23:29:50 +00:00
David Sansome
38a92e802b
Save and load the magnatune settings properly
2010-06-08 23:18:20 +00:00
David Sansome
f1fb9ab6b9
Remove the library config dialog and make it show the page in the settings dialog instead
2010-06-08 23:06:29 +00:00
David Sansome
43ca921d65
Add a magnatune settings page (not functional yet), remove the last.fm config *dialog*, and instead make it bring up the settings dialog at the right page.
2010-06-08 22:56:31 +00:00
David Sansome
40bb827fcd
Make all the source files a single cmake target again.
2010-06-08 22:39:31 +00:00
John Maguire
2830ee1a62
Fix MPRIS pause behaviour.
...
Update issue 374
Pause/unpause should be fixed now.
2010-06-08 16:00:09 +00:00
David Sansome
f03449dd00
Fix compilation problems when compiling without gstreamer
2010-06-08 15:55:44 +00:00
David Sansome
7a449a545c
Fix a compilation error when enabling other engines
2010-06-08 13:24:48 +00:00
David Sansome
08dddac981
Fix a small memory leak
2010-06-08 12:12:47 +00:00
David Sansome
5099503b45
Make the small toolbar buttons stay small even on gtk styles that use bigger buttons
2010-06-08 11:43:34 +00:00
John Maguire
e8f1838d6d
Fucking mac.
2010-06-07 20:39:06 +00:00
John Maguire
7d18f60ca8
Ignore silly Info.plist from Sparkle.
2010-06-07 20:22:43 +00:00
John Maguire
ea95b847fc
Update dmg target to stop Qt copying silly plugins.
2010-06-07 19:43:07 +00:00
John Maguire
a821f5a505
Install resources into mac bundle.
2010-06-07 19:01:35 +00:00
John Maguire
2979b6ae84
Forgotten mac build fix.
2010-06-07 17:57:07 +00:00
David Sansome
ade492c56f
Make the visualisation duration configurable
2010-06-07 13:36:50 +00:00
David Sansome
0e19ca17e5
Make the visualisation chooser actually work
2010-06-07 13:29:57 +00:00
John Maguire
d34283a113
ProjectM on mac deployment fixes.
2010-06-07 11:38:43 +00:00
David Sansome
6d84c2f830
Don't use the system projectm config file. Search for presets in share/clementine/projectm-presets.
2010-06-07 10:23:11 +00:00
David Sansome
38e0c3a11f
Add projectm presets to svn
2010-06-07 10:09:30 +00:00
John Maguire
a4386de578
Add some useful mac functions.
2010-06-07 09:49:20 +00:00
David Sansome
2986b27fd7
Basic visualisation selector dialog.
2010-06-07 01:55:21 +00:00
David Sansome
c3149e40ed
Merge translations from Launchpad
2010-06-06 23:16:32 +00:00
David Sansome
87ecc89ca2
Add an option to change the quality (texture resolution) of visualisations
2010-06-06 23:05:11 +00:00
David Sansome
93cb686f08
Ctrl+W and Esc close the visualisation window
2010-06-06 22:39:01 +00:00
David Sansome
2a77a1070d
Hide the cursor on the visualisation window properly
2010-06-06 22:33:30 +00:00
David Sansome
6e81289ea2
Add a visualisation config menu
2010-06-06 22:28:24 +00:00
David Sansome
038c7b1bbf
Use the libprojectm from 3rdparty
2010-06-06 22:23:09 +00:00
John Maguire
920f7a0f3a
Make visualisations not crash :-)
2010-06-06 22:22:02 +00:00
David Sansome
0e155c1eaf
Fix liblastfm finding
2010-06-06 21:08:52 +00:00
David Sansome
42cd269538
Double click visualisation for fullscreen
2010-06-06 18:29:13 +00:00
David Sansome
793e0371fe
Oops, don't show the visualisation automatically
2010-06-06 18:28:58 +00:00
David Sansome
c541f242c5
Visualisation overlay
2010-06-06 18:18:06 +00:00
David Sansome
994d6d9c20
Set a better default size for the visualisation, and make resizing work
2010-06-06 18:17:41 +00:00
David Sansome
1895582eb9
Basic support for ProjectM visualisations
2010-06-06 14:06:23 +00:00
David Sansome
fe39d99923
Support playing \\host\share\file style URLs on Windows
2010-06-03 18:39:42 +00:00
John Maguire
2e9dc6c570
Never override UTF-8 strings from TagLib.
2010-06-03 15:22:30 +00:00
David Sansome
f33604580c
Stop ASCII from voting, and add a failing test
2010-06-03 15:16:15 +00:00
David Sansome
3652ff30e0
Don't assert if one of the operands to our LIKE function is NULL
2010-06-03 14:56:49 +00:00
John Maguire
8a13f3e481
Qt is nice :-)
2010-06-03 14:11:53 +00:00
John Maguire
2ad15ffec6
Code review comments for r1023
2010-06-03 13:26:46 +00:00
John Maguire
407bc7a41e
Fix segfault.
2010-06-03 13:02:24 +00:00
John Maguire
b9df2a09d4
Add voting for codecs, eg. if 3/4 tags in a file are windows-1251 then they will all be decoded with windows-1251.
2010-06-03 12:36:43 +00:00
David Sansome
c0103cc1e0
Bring 1020 back again for Windows systems that don't seem to have a system encoding set :/
2010-06-02 21:26:12 +00:00
David Sansome
7cbd8f7500
Revert r1020, it wasn't necessary - see issue #364
2010-06-02 21:08:37 +00:00
David Sansome
2381d2ba1a
Use UTF8 explicitly rather than the local 8-bit codec
2010-06-02 21:04:03 +00:00
David Sansome
6dd32da591
Make the M3U parser use the local 8-bit encoding instead of latin1. Yes I know the spec says m3us are always latin1 - you didn't expect anyone else to actually follow that did you? Fixes issue #364 .
2010-06-02 20:06:47 +00:00
David Sansome
e110febc86
Add a background to the pretty OSD
2010-06-02 19:19:30 +00:00
David Sansome
6e19e777d8
Don't create SettingsDialog until RadioModel is available
2010-06-02 16:27:52 +00:00
David Sansome
c834a5f31f
Do the compilation processing in the database thread, and make everything lock on the database to ensure two threads don't access it at once.
2010-06-02 16:22:20 +00:00
David Sansome
03d876a599
Put the Database object in its own thread, and create the Library and Playlist backends in that database thread. The database calls don't happen in the database thread yet, but this is the first step towards making sure sqlite access is thread safe.
2010-06-02 15:58:07 +00:00
David Sansome
c7d351f68a
Make it possible to wait for a background thread to start
2010-06-02 14:22:40 +00:00
David Sansome
24b22b1b17
Invalidate the cached current row pixmap when the column headers are moved/resized and when the song's metadata changes.
2010-06-02 13:51:16 +00:00
David Sansome
e891543f42
Fix the encoding of composers and albumartists as well
2010-06-02 13:22:54 +00:00
John Maguire
f4385d4545
Detect cp866 & windows-1251 in "latin1" tags.
2010-06-02 12:31:40 +00:00
David Sansome
3dad151608
Undo part of r1004, thanks John
2010-05-31 21:24:54 +00:00
David Sansome
d760721f61
Make this all a bit more sane
2010-05-31 20:59:13 +00:00
David Sansome
99cea19994
Create engine_ in the initialisation list.
2010-05-31 20:51:29 +00:00
David Sansome
bfebbc20c9
Show multiple errors in the same dialog
2010-05-31 20:49:44 +00:00
David Sansome
5d272a89ee
Codereview comment from r1000
2010-05-31 20:24:05 +00:00
David Sansome
3365c7c217
Fix a few memory leaks
2010-05-28 19:51:51 +00:00
David Sansome
2c9a29e226
Give this variable a default value so it doesn't get passed to QThread::start uninitialised
2010-05-28 18:42:11 +00:00
David Sansome
9a06fa0bfc
Don't start a new timer for *every* track we play.
2010-05-28 17:14:00 +00:00
David Sansome
48830f2acc
When doing a keyboard search in the library view, scroll so that the index is at the top of the viewport instead of at the bottom. Fixes issue #354
2010-05-28 12:52:22 +00:00
John Maguire
98c97d13d6
Template magic \o/
2010-05-27 23:34:05 +00:00
David Sansome
791534703c
Allow names for custom saved streams. Fixes issue #242
2010-05-27 22:53:07 +00:00
John Maguire
4836b8d420
Fix XML parsers to output file URLs.
2010-05-27 22:43:07 +00:00
John Maguire
7ad2c38333
Port XSPFParser to QXmlStreamWriter.
2010-05-27 21:16:17 +00:00
John Maguire
e8dab5c065
ASX support.
...
Fixes issue #325
2010-05-27 20:55:34 +00:00
David Sansome
ed03c4cd72
Lower the CPU usage of the currently playing track animation by about 50% by caching the row pixmap and lowering the framerate slightly.
2010-05-27 20:31:00 +00:00
David Sansome
4c13e78893
Fix a mingw warning
2010-05-27 20:30:15 +00:00
John Maguire
734d505eb7
Fix media key global shortcuts on mac.
...
Dave: *again* :-P
2010-05-27 13:21:05 +00:00
John Maguire
722981e71d
Stop streams on PlayPause.
2010-05-27 13:17:28 +00:00
David Sansome
3927d91cf1
We use decodebin2 on windows now
2010-05-25 22:25:04 +00:00
David Sansome
e6a13c76f1
Be sure to signal about changes to the library model so that the proxy model's cache gets updated.
2010-05-25 22:18:27 +00:00
David Sansome
8164066648
More Qt 4.5 fixes
2010-05-25 21:41:53 +00:00
David Sansome
9292bd3cb5
toFloat() was Qt 4.6
2010-05-25 21:33:16 +00:00
David Sansome
0021e5f7e4
Make library scanning on startup optional, and add a menu item to update the library. Fixes issue #341
2010-05-25 20:40:45 +00:00
David Sansome
7ecdb772a7
Always map model indexes from the UI to the source playlist model when using them in the playlist.
...
Update issue #340
Status: fixed
I think I've fixed all these bugs now, but please reopen if you find
another situation where the wrong track gets used in a filtered playlist.
2010-05-25 19:39:04 +00:00
John Maguire
bfa355cf82
Force menu items into correct place on mac.
...
Fixes issue #342
2010-05-25 13:19:28 +00:00
David Sansome
c6d1c69ad0
Make it possible to do an in-place build
2010-05-24 13:29:13 +00:00
David Sansome
46b3dc643f
"Stop after this song" on tray icon menu. Fixes issue #339
2010-05-23 21:51:31 +00:00
John Maguire
a0f19e5923
Remove unnecessary checks.
2010-05-23 17:04:55 +00:00