Funkwhale
/
Clementine-audio-player-Mac-Linux-Windows
mirror of https://github.com/clementine-player/Clementine
1
0
Fork 0
Code Issues Releases Wiki Activity

Lower the CPU usage of the currently playing track animation by about 50% by caching the row pixmap and lowering the framerate slightly.

This commit is contained in:
David Sansome 2010-05-27 20:31:00 +00:00
parent 4c13e78893
commit ed03c4cd72
2 changed files with 34 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/playlist/playlistview.cpp
View File

@ -32,7 +32,7 @@
#include <math.h>
const char* PlaylistView::kSettingsGroup = "Playlist";
const int PlaylistView::kGlowIntensitySteps = 32;
const int PlaylistView::kGlowIntensitySteps = 24;
const int PlaylistView::kAutoscrollGraceTimeout = 60; // seconds
const int PlaylistView::kDropIndicatorWidth = 2;
const int PlaylistView::kDropIndicatorGradientWidth = 5;
@ -49,6 +49,7 @@ PlaylistView::PlaylistView(QWidget *parent)
row_height_(-1),
currenttrack_play_(":currenttrack_play.png"),
currenttrack_pause_(":currenttrack_pause.png"),
cached_current_row_row_(-1),
drop_indicator_row_(-1)
{
setHeader(new PlaylistHeader(Qt::Horizontal, this));
@ -199,9 +200,33 @@ void PlaylistView::drawRow(QPainter* painter, const QStyleOptionViewItem& option
opt.palette.setColor(QPalette::AlternateBase, Qt::transparent);
opt.font.setItalic(true);
opt.decorationSize = QSize(20,20);
}
QTreeView::drawRow(painter, opt, index);
// Draw the actual row data on top. We cache this, because it's fairly
// expensive (1-2ms), and we do it many times per second.
if (cached_current_row_rect_ != opt.rect ||
cached_current_row_row_ != index.row() ||
cached_current_row_.isNull()) {
const_cast<PlaylistView*>(this)->UpdateCachedCurrentRowPixmap(opt, index);
}
painter->drawPixmap(opt.rect, cached_current_row_);
} else {
QTreeView::drawRow(painter, opt, index);
}
}
void PlaylistView::UpdateCachedCurrentRowPixmap(QStyleOptionViewItem option,
const QModelIndex& index) {
cached_current_row_rect_ = option.rect;
cached_current_row_row_ = index.row();
option.rect.moveTo(0, 0);
cached_current_row_ = QPixmap(option.rect.size());
cached_current_row_.fill(Qt::transparent);
QPainter p(&cached_current_row_);
QTreeView::drawRow(&p, option, index);
p.end();
}
void PlaylistView::timerEvent(QTimerEvent* event) {

6
src/playlist/playlistview.h
View File

@ -73,6 +73,8 @@ class PlaylistView : public QTreeView {
private:
void ReloadBarPixmaps();
QList<QPixmap> LoadBarPixmap(const QString& filename);
void UpdateCachedCurrentRowPixmap(QStyleOptionViewItem option,
const QModelIndex& index);
private:
static const char* kSettingsGroup;
@ -104,6 +106,10 @@ class PlaylistView : public QTreeView {
QPixmap currenttrack_play_;
QPixmap currenttrack_pause_;
QPixmap cached_current_row_;
QRect cached_current_row_rect_;
int cached_current_row_row_;
int drop_indicator_row_;
};