Commit Graph

6681 Commits

Author SHA1 Message Date
Grace Dolphy 52f1982353 Delete Undo Fix Attempt - Should Solve Issue #5701 Using Clementine to delete a song from disk should not be added to the undo stack (#5702)
* Fix delete functionality. Skips to next song if deleted song is also currently playing.

* Added in a bool to determine if the song being deleted is meant to be deleted from the disk or just from the playlist. Took advantage of the unused variable located in removeRows to distinguish between the two options. No longer adds delete from disk to the undo stack, and deleting from the playlist goes to undo stack as it should.

* Added in a bool to determine if the song being deleted is meant to be deleted from the disk or just from the playlist. Took advantage of the unused variable located in removeRows to distinguish between the two options. No longer adds delete from disk to the undo stack, and deleting from the playlist goes to undo stack as it should.

* Update mainwindow.cpp

* Formatting Changes

* Update playlist.cpp

Simplified condition statement.

* Added in a missed boolean for RemoveSelected

* Update playlistview.cpp
2017-04-18 14:29:25 +01:00
Clementine Buildbot 5acbcbb2ec Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-04-17 10:01:00 +00:00
Clementine Buildbot edccd95916 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-04-10 10:00:55 +00:00
Clementine Buildbot 2c60481f74 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-04-03 10:00:57 +00:00
Grace Dolphy 9f00e021f6 This fixes "First track always the same in shuffle #793". Adding this call in the if statement allows a reshuffle to happen after the playlist ends so that when the playlist will restart, it will already have a new set location to go to. (#5689) 2017-03-31 11:49:41 +01:00
Mark Furneaux fba9e8dd69 Fix psychedelic mode on analysers (#5688)
* Fix psychedelic mode

* Remove unnecessary checks

When the code isn't broken, these are just a waste
2017-03-31 11:48:28 +01:00
Grace Dolphy 672d00be05 Fixes the issue "Seek instead of navigation with arrow keys #5550". Now allows the leaf to be closed by arrow left at any point of the leaf, not only the parent, and if the library is focused and arrow keys are pressed and there is nothing to open or close, the request is ignored (no seek) (#5684) 2017-03-30 18:02:49 +01:00
MelissaManley97 a5d12d0d10 Request to merge a fix for a crash during searching under Internet Tab (#5682)
* Changing ClearSearchResults order.

If search_ is null, there is no point in clearing it.

* Update to fix 12 (Crash when searching under Internet tab with Spotify)

* Formatting Fixes
2017-03-28 17:38:55 +01:00
Santiago Gil 0b34586e52 Fix some warnings shown on start-up (#5679)
* Fix 'RGB parameters out of range' with psychedelic colors

* Fix 'edit-find' icon name

* BlockAnalyzer::drawBackground(): do not attempt to paint on a null background

* Use qBound()
2017-03-27 12:57:24 +01:00
santigl 18d2e35bc6 Register QAbstractSocket::SocketState meta type 2017-03-27 12:56:39 +01:00
Clementine Buildbot 0f4db74e0c Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-03-27 10:00:55 +00:00
santigl e3ece3d4c4 SaveToTemporaryFile(): use QTemporaryFile directly 2017-03-21 10:50:12 +00:00
santigl 35e274c497 Refactor SongLoader::LoadRemotePlaylist() 2017-03-21 10:50:12 +00:00
santigl f44414db81 Add Utilities::SaveToTemporaryFile() 2017-03-21 10:50:12 +00:00
santigl f609bc793f Fix remote-playlist load 2017-03-21 10:50:12 +00:00
Clementine Buildbot 33aa38bbdd Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-03-20 10:00:53 +00:00
santigl a034c2d4d0 Remove non-allowed characters in playlist filename when saving. (Fixes #5460) 2017-03-16 15:18:02 +00:00
John Maguire f7eea6c505 static_cast<:: apparently confuses older GCC. 2017-03-14 17:34:42 +00:00
Jacob Henner 2d1b425493 Fixes #5660 - compile error 2017-03-14 17:28:06 +00:00
Jacob Henner e7ec942256 Explicitly using python2 to prevent errors on py3-default systems 2017-03-13 18:58:15 +00:00
santigl 6c9bc43bbb Refactor analyzers for new FHT modifications. Use QVectors where possible. Make readability changes in the code. 2017-03-13 18:56:37 +00:00
santigl 6a19afde15 Refactor FHT class: use QVector and const values, remove unnecesary memory handling. 2017-03-13 18:56:37 +00:00
Clementine Buildbot b7fb649b8f Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-03-13 10:00:55 +00:00
Jan Paul Erkelens 0215707810 Uses effective fields for album hashing and comparison (#5653) 2017-03-08 12:22:50 +00:00
Santiago Gil 62bc647cbc Roll back to the cache naming conventions for covers (#5651) 2017-03-07 11:46:54 +00:00
santigl 99ad5dcd2d Refactor EffectiveAlbumArtistName() 2017-03-06 18:47:34 +00:00
John Maguire 426118a4dc Revert "include opus support in windows build (#5648)"
This reverts commit 81c905bcf5.

Breaks the windows build.
2017-03-06 18:23:17 +00:00
santigl a8cbb3b18a Unlock DB mutexes implicitly using scopes. Add error handling for query. 2017-03-06 18:21:27 +00:00
santigl f5bd7ef5c0 ItemHasCover(): Replace pointer with reference 2017-03-06 18:21:27 +00:00
santigl 82f0d261fa Use the 'effective_album' title when searching for a track's cover 2017-03-06 18:21:27 +00:00
santigl e30e6da065 Add 'effective_album' property to Song 2017-03-06 18:21:27 +00:00
santigl 2c643513e2 Refactor icon handling. Make empty-cover filtering work again. 2017-03-06 18:21:27 +00:00
santigl deb7c33c64 Add support for 'album artist' field in the LibraryBackendInterface 2017-03-06 18:21:27 +00:00
santigl 58b7c62f25 Make Cover Manager aware of 'album artist' field 2017-03-06 18:21:27 +00:00
santigl 62cec8cf28 Prioritize album artist in cover search and manager 2017-03-06 18:21:27 +00:00
John Maguire 5d0cf343d5 Use new clementine images API. 2017-03-06 18:15:59 +00:00
Nicolai J 81c905bcf5 include opus support in windows build (#5648) 2017-03-06 12:00:38 +00:00
Clementine Buildbot 3d80f7e1e2 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-03-06 10:00:57 +00:00
Domenico Iezzi 3b51f80fa3 Small improvements to Cover Manager (#5645)
* nocover icon was previously loaded and used with the default size
(24x24), causing the list item without a cover in the QListWidget to be
shorter in height with respect to the others. Now the icon is
initialized to 120x120, which is the default size of the list elements.
* Added some padding between "Fetch Missing Cover" and "Export
Covers" buttons.
2017-03-03 11:49:47 +00:00
Santiago Gil 30e3fdb9cc Fix overflow in MoodbarProxyStyle (fixes #5638) (#5643) 2017-03-02 13:10:21 +00:00
John Maguire 27bf50d702 Do not log sensitive data in OAuthenticator. 2017-02-27 12:41:34 +00:00
Clementine Buildbot 973f32c061 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-02-27 10:00:52 +00:00
Andreas Muttscheller 652f38ac84 Fix C:\data cache directory for portable builds
Lastfm needs a NetworkAccessManager which is created during the
initialization of lastfm in main.cpp, it also sets a cache directory.

For the portable version, GetConfigPath uses
QCoreApplication::applicationDirPath() to get the current directory of
Clementine. If no QApplication (or QtSingleApplication in Clementines
case) was instantiated, it returns /data on Linux or C:\data on Windows
for the cache config path.

This commit changes the order so lastfm will be initialized after
QtSingleApplication was created and the correct cache config path will be
returned.

Fixes #5354
2017-02-26 11:20:10 +01:00
John Maguire 1aed6193e7 Fix intergalactic FM URLs. 2017-02-21 14:24:50 +00:00
Clementine Buildbot 3dd4375c77 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-02-20 10:00:57 +00:00
Morris Hafner 8a6cc8b506 Add missing <functional> includes (#5630) 2017-02-13 16:46:46 +00:00
Clementine Buildbot 4325be6944 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-02-13 10:00:46 +00:00
Andreas 07f1ab6311 Change license for network remote protocol buffer meassages to Apache 2017-02-09 15:46:05 +01:00
Clementine Buildbot 9967bd4194 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-02-06 10:00:57 +00:00
Clementine Buildbot 6483510bca Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-01-30 10:00:44 +00:00