Commit Graph

5388 Commits

Author SHA1 Message Date
Jonas Kvinge da648fd08f Fix setting device on windows (#6081) 2018-06-12 09:27:10 +01:00
John Maguire 1b4955cc4a
Merge pull request #6076 from jonaski/taglib
Audio file detection by content supported by newer taglib
2018-06-10 00:04:07 +01:00
Jonas Kvinge 925e74f909 Fix crash when uridecodebin fails. (#6077)
Let's the user see the error message what failed instead of Clementine crashing.

Also don't do gst_object_unref unless bin is set.
This fixes GStreamer-CRITICAL gst_object_unref: assertion 'object != NULL' failed
2018-06-06 23:53:25 +01:00
Jonas Kvinge e0d2d9b424 Use taglib to check for valid audio file 2018-06-06 22:54:48 +02:00
ftiede c01b7bc430 Add option to verify subsonic server certificate. (#6060)
* Add option to verify subsonic server certificate.

Defaults to true, as it is safer to have a server certificate verified,
even more so, if the server is used over an insecure WAN link.
During subsonic configuration the checkbox can be deactivated, so that
no certificate verification will occur when talking to a subsonic
server, allowing for self-signed certificates.

With the proliferation of let's encrypt certificates there's probably
less need for this option but it has been requested and hard-coding
verify-off is IMHO bad security practice.
If a valid certificate has been installed, the configuration file can be
modified manually and after a restart Clementine will perform a proper
server certificate verification.

The patch might need some UI polishing and asks for string translations
but is operational so far.

* Satisfy CLang format checker.

* Use QSettings' default value support.

* Consistently use QSettings' default value method.
2018-05-23 14:23:53 +01:00
Chocobozzz 5bd2c77c58 Fix compilation with GCC 8 (#6053) 2018-05-13 18:02:33 +01:00
Jonas Kvinge 37912a87b8 Fix WavPack playback (#6048) 2018-05-01 18:29:47 +01:00
Mark Furneaux d28a318437 Clang format 2018-04-14 16:57:06 -04:00
Mark Furneaux 2793cfa7fb Add to loaderinserter 2018-04-14 16:31:48 -04:00
Mark Furneaux 3626d84964 Add play next from library 2018-03-18 22:44:00 -04:00
Mark Furneaux a789ce82ca Allow playing of tracks already in queue 2018-03-18 22:03:04 -04:00
Mark Furneaux 6e387c2578 Initial playlist implementation 2018-03-18 14:43:44 -04:00
Jonas Kvinge e52c7f6475 Fix formatting 2018-03-12 07:55:59 -04:00
Jonas Kvinge d33ac6ef81 Fix background not loading. 2018-03-12 07:55:59 -04:00
Jonas Kvinge c393926be6 Fix background not loading. 2018-03-12 07:55:59 -04:00
Jonas Kvinge de23c3181f Fix resume playback on start not working. 2018-03-12 07:55:59 -04:00
Jonas Kvinge c3a7920cb4 Don't use empty URL's from LastFM. 2018-03-12 07:55:59 -04:00
Pulfer ddfa5e63f1 Fix channels loading for DI.fm services after API domain changes (#6023) 2018-03-10 18:35:09 +00:00
Jonas Kvinge c9d954f8a3 Fix bug in covermanager not saving album cover to DB. (#6011)
* Fix bug in covermanager not saving album cover to DB.
2018-03-04 14:13:34 +00:00
Antonio Russo 1732e56fe6 Hide TrackSliderPopup on appropriate leaveEvent
The previous fix introduces a regression on some platforms
which did not generate a leaveEvent with the TrackSliderPopup
was displayed. Logic is introduced to identify bonafide mouse
motion out of the TrackSliderSlider.
2018-02-24 23:42:29 +00:00
John Maguire 9929450cc2 Revert "Hide TrackSliderPopup on exit from popup"
This reverts commit f629d37315.
2018-02-24 22:35:40 +00:00
Antonio Russo f629d37315 Hide TrackSliderPopup on exit from popup
The previous behavior exited on leaving TrackSliderSlider,
which causes the popup to flicker, as it is shown and
hidden rapidly.
2018-02-24 17:16:51 +00:00
kleinfreund 2555595ce0 Determine operator enum instead of comparing with magic numbers 2018-02-12 19:13:36 +00:00
kleinfreund 4ab6f359d5 Smart Playlists: Add empty/not empty operators 2018-02-12 17:59:43 +01:00
John Maguire eafc1713ab
Merge pull request #5960 from vikramambrose/feature-playlist-page-search-filter
Add search filter to playlist list page
2018-02-03 17:19:10 +00:00
Benjamin Sproule 595eec7878 Removed filter for audio/folder OneDrive items as OneDrive doesn't count many audio file types as audio (e.g. flac) (#5977) 2018-02-01 11:38:25 +00:00
Chocobozzz 38c1f8777c Fix compilation with crypto++ >= 6.0.0 (#5974) 2018-02-01 08:07:51 +00:00
Vikram Ambrose 5e065609b6 Ensure song items are shown on Favorited signal
There was an issue where the song items were only being shown
from a fresh start up but not when the playlist was created. This fixes
that issue and refactors the AddPlaylist code
2018-01-14 11:24:45 +02:00
Vikram Ambrose fefea9de61 Disable drag of track items until this is properly implemented
Stop bad things from happening until proper DnD support of track
items has been implemented
2018-01-11 13:49:18 +02:00
Vikram Ambrose ae71d24f6e Ensure all nodes are shown when filter is cleared 2018-01-11 13:31:23 +02:00
Vikram Ambrose 3da938eac2 Add search filter to playlist list page
This allows power users who keep 100s of playlists to easily
find a playlist either by directory name, playlist name or by
searching for a song artist/title a playlist might contain
2018-01-11 13:11:13 +02:00
Vikram Ambrose 790fc2ff28 Replace Nokia based FancyTabWidget with standard QTabWidget (#5956)
* Replace Nokia sidebar widget with QTabWidget

The old sidebar widget was written by Nokia 10 years ago
and was a hand made hardcoded mess of widgets trying to
emulate a QTabWidget.

This commit completely replaces it with a widget of the
same name (FancyTabWidget) but is a much simpler subclass
of the standard QTabWidget allowing for a 50% code reduction.

There is still some manual draw code copied over to get the
exact same look of the previous widget but this is not strictly
necessary and can be later refactored with simpler drawControl
code based on styling preferences.

Benefits:
 - 50% code reduction
 - Easier to understand standard QTabWidget mechanics
 - Built-in support for re-arranging and closing tabs

* Save and restore sidebar tab order

Allow the user to rearrange the tab order by dragging
tabs to a new location. Tab order is saved on exit and restored
on start

* Fix some code formatting issues
2018-01-10 09:22:05 +00:00
vikramambrose 2e4a67b8da Add appearance option to hide playlist filter toolbar (#5942)
Gives the user the option of a cleaner looking interface if the
filter toolbar isn't used.
2018-01-03 15:24:56 +00:00
Stephen Dawkins d9b12a5599 Added additional check when enclosure type is missing (#5934) 2017-12-23 12:48:38 +00:00
Mattias Andersson b724291ef9 Ensure that the correct playlist is played (#5929)
When the playlist doubleclick behavior is set to add songs to the queue,
the playback of the queue also starts if no song is currently
playing. To play the queue from the current playlist, we must set the
active playlist to the current one before starting the playback.

Fixes #5714.
2017-12-14 21:48:03 +00:00
Mattias Andersson 650eb0534a Always include the hours in the the time string if the duration if (#5925)
longer than one day.
2017-12-13 18:37:34 +00:00
benpicco 27bef68cf6 Attempt to reload stream on "Server does not support seeking." error (#5923)
When the network connection changes while playing an HTTP stream, I always get the "Server does not support seeking." error from GStreamer.
It seems like GStreamer tries to seek on reconnect, which fails, an propagates the error to Clementine which in turn ceases playback with
the error message handed through from GStreamer, even though there is now a perfectly fine network connection again.

As a workaround, try to reload the stream when this error occurs.

fixes #5116
2017-12-11 00:13:30 +00:00
Clementine Buildbot 3134e09aec Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-12-04 10:00:52 +00:00
Clementine Buildbot 944e5fb326 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-11-27 10:00:50 +00:00
Victor Parmar eab875c46d Add support for deleting the currently playing track via the commandline (#5899) 2017-11-21 10:02:36 +00:00
Adrian Garcia 27fc915921 Add settings option to stop playback if song fails to play (#5905) 2017-11-21 10:00:36 +00:00
Clementine Buildbot 7b1b43ffed Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-11-20 10:00:46 +00:00
Clementine Buildbot 83e860eabd Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-11-13 10:00:44 +00:00
Clementine Buildbot ce22905a01 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-11-06 10:00:44 +00:00
Clementine Buildbot 9a5bcb7a35 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-10-30 10:00:43 +00:00
Clementine Buildbot 221f6d7261 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-10-23 10:01:01 +00:00
Clementine Buildbot f1b767faa4 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-10-19 23:05:16 +00:00
Adrian Garcia dfa7042ff3 Subsonic: download cover art (#5880) 2017-10-06 14:08:00 +01:00
adwait a7ec5662e1 Updated qt bug report page 2017-10-04 16:47:35 +01:00
Clementine Buildbot c024b1340d Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2017-10-02 10:00:46 +00:00