Clementine Buildbot
51c600a537
Automatic merge of translations from Transifex
2020-12-19 02:51:12 +00:00
Clementine Buildbot
6a6ef729ef
Automatic merge of translations from Transifex
2020-12-18 02:52:23 +00:00
Jim Broadus
627ddc398c
build: Add Fedora 33
...
(cherry picked from commit e302811fae12e6bf8eb63039d3ea01b8b248604c)
2020-12-17 23:59:11 +00:00
Jim Broadus
bbb6a773fb
build: Use cmake build and install macros in rpm spec
...
Starting with fedora 33, the cmake macro macro uses the cmake -B flag for
out-of-source builds. Additional cmake_build and cmake_install macros
were created and backported to support this migration.
https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds
2020-12-17 23:04:58 +00:00
Jim Broadus
c9557237cf
build: RPM spec file updates
...
Remove BuildRoot:, Group:, and %clean in accordance with the Fedora packaging
guidelines.
Reference: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections
2020-12-17 23:04:58 +00:00
Matthieu Bruel
41513527cd
hatstand code review update 1
2020-12-17 12:23:30 +00:00
Matthieu Bruel
114802a0ca
Adding links to new remote in network remote settings
2020-12-17 12:23:30 +00:00
Matthieu Bruel
7d038c7354
Missing filechooserwidget files...
2020-12-17 12:23:30 +00:00
Matthieu Bruel
9714b0632d
All changes for ClemRemote v1.0 (in one go)
2020-12-17 12:23:30 +00:00
Jim Broadus
d7966c8285
Fix rpmbuild error in librojectm
...
When using rpmbuild on Fedora 33, the build fails with:
error: ‘__builtin_strncpy’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
This was fixed as part of projectm change d4d74f6d. This change takes the
relevant parts of that commit.
Note that the projectm commit contains several other warning fixes that might
affect Clementine builds in the future.
2020-12-17 11:29:49 +00:00
Robert-André Mauchin
cfcd0a956e
Drop -std=c++0x and -U__STRICT_ANSI__
...
This was causing compilation failures, static assertion failed, with GCC 11.
Fix #6865
Signed-off-by: Robert-André Mauchin <zebob.m@gmail.com>
2020-12-17 11:28:09 +00:00
Jim Broadus
a3a51ae11c
build: Remove dependency on obsolete gstreamer1-plugins-ugly
...
In fedora 31, the gstreamer1-plugins-ugly package was removed. A
gstreamer1-plugins-ugly-free package was added in fedora 27 and
gstreamer1-plugins-ugly had depended on that before removal.
Note that there is still a gstreamer1-plugins-ugly package available
in rpmfusion.
2020-12-16 11:13:25 +00:00
Jim Broadus
ccba649f62
Clear cached indexes in InternetModel when rows are removed
...
When opening a context menu on an internet item, the selected items are stored
in the InternetModel instance. In cases when the items are removed, certain menu
options can cause a crash. A specific case is downloading a podcast when the
user has chosen to limit the number of visible episodes. The subtree for the
podcast is rebuilt after the download completes, so if a context menu was opened
during the download time, selecting the append to playlist option will attempt
to operate on bad indexes.
This fix uses the rowsAboutToBeRemoved signal to remove these stored indexes.
There are likely another rare cases where the indexes can become invalid. For
example, sibling items within a subtree may be removed, causing the stored
indexes to become incorrect or out of range.
2020-12-15 22:36:30 +00:00
Jim Broadus
fe88d8f8b0
build: Remove eoan usage
...
Ubuntu Eoan (19.10) is EOL and the repositories are no longer accessible. Bump
the image used for the source tarball build to LTS ubuntu:focal.
2020-12-15 19:24:59 +00:00
Clementine Buildbot
c1c43e9a67
Automatic merge of translations from Transifex
2020-12-13 02:43:47 +00:00
Clementine Buildbot
91bad31f68
Automatic merge of translations from Transifex
2020-12-09 02:41:23 +00:00
Clementine Buildbot
ba8fc09a65
Automatic merge of translations from Transifex
2020-12-07 02:38:38 +00:00
Jim Broadus
01f0727649
giolister: Don't include invalid mountpoint url
...
If the gvfs mountpoint property for a volume is empty, we add an empty URL to
the devices URL list. This causes errors in duplicate entry detection.
2020-12-06 12:59:50 +00:00
Clementine Buildbot
df262c5c7e
Automatic merge of translations from Transifex
2020-12-06 02:37:13 +00:00
Jim Broadus
cca48b1ebf
giolister: Ignore mountpoints
...
Read the G_FILE_ATTRIBUTE_UNIX_IS_MOUNTPOINT attribute (unix::is-mountpoint) to
determine if a volume is a mount that udisks2 has detected. Ignoring these
prevents network mounts from showing up as devices.
2020-12-05 13:24:54 +00:00
Clementine Buildbot
f5c904b267
Automatic merge of translations from Transifex
2020-12-05 02:35:11 +00:00
Jim Broadus
1a0b288a8f
giolister: Remove extra g_object_unref
...
GioLister::UnmountDevice calls g_object_unref on the GVolume object held by a
DeviceInfo. This appears to be left over from a time before DeviceInfo held
onto the volume.
2020-12-04 22:07:01 +00:00
Jim Broadus
abc70554f3
giolister: Append _ to some DeviceInfo class members
...
Rename drive, mount, and volume to drive_, mount_, and volume_ to
avoid confusion with method arguments.
2020-12-04 22:07:01 +00:00
Clementine Buildbot
20f49c4454
Automatic merge of translations from Transifex
2020-12-03 02:34:21 +00:00
Clementine Buildbot
41b1ba8ffc
Automatic merge of translations from Transifex
2020-12-02 02:33:31 +00:00
Clementine Buildbot
c4d22d4414
Automatic merge of translations from Transifex
2020-12-01 02:33:42 +00:00
Clementine Buildbot
f60c422242
Automatic merge of translations from Transifex
2020-11-30 02:33:52 +00:00
NicolasToussaint
7b3e2dfd8c
PlayPlaylist: set current and not active playlist to selection
2020-11-30 01:50:58 +00:00
Clementine Buildbot
f17e29f41d
Automatic merge of translations from Transifex
2020-11-29 02:32:32 +00:00
NicolasToussaint
b2044a5be5
apply PR recomendations
2020-11-28 20:24:56 +00:00
NicolasToussaint
ee72b974bf
add CLI play-playlist option, to play given playlist name.
2020-11-28 20:24:56 +00:00
Clementine Buildbot
c536dc88e9
Automatic merge of translations from Transifex
2020-11-28 02:31:39 +00:00
Clementine Buildbot
eec7641ef7
Automatic merge of translations from Transifex
2020-11-27 02:31:50 +00:00
Clementine Buildbot
d417aed29f
Automatic merge of translations from Transifex
2020-11-26 02:31:54 +00:00
Clementine Buildbot
c856a66176
Automatic merge of translations from Transifex
2020-11-25 02:31:22 +00:00
Clementine Buildbot
d970b74003
Automatic merge of translations from Transifex
2020-11-24 02:31:19 +00:00
Clementine Buildbot
ae4948ce32
Automatic merge of translations from Transifex
2020-11-23 02:30:52 +00:00
John Maguire
aaee0b7018
Fix translations github action
2020-11-22 18:25:47 +00:00
Clementine Buildbot
1daf43f914
Automatic merge of translations from Transifex
2020-11-07 02:29:09 +00:00
Clementine Buildbot
eefb96bdce
Automatic merge of translations from Transifex
2020-11-03 02:27:29 +00:00
zan
16d09ace07
Fix visibility incongruences
2020-11-02 11:07:42 +00:00
Clementine Buildbot
cac606186a
Automatic merge of translations from Transifex
2020-10-31 02:27:33 +00:00
Jim Broadus
fc4cb6fc7a
Fix opml import crash
...
The opml parsing code handles cases where there are extra levels in the xml file
by copying the child to the main container. This corrupts the source instance
during the copy, which leads to corruption in the destination, and ultimately a
crash when it is later used.
To fix, do the copy in two steps, copying the child container to a temporary
location before copying to the destination.
2020-10-17 09:12:22 +01:00
Clementine Buildbot
4e3e9c8d14
Automatic merge of translations from Transifex
2020-10-12 02:34:09 +00:00
Clementine Buildbot
9e8d4434a0
Automatic merge of translations from Transifex
2020-10-04 02:31:34 +00:00
John Maguire
ad354276b0
Remove build for EoL Ubuntu Eoan
2020-09-30 17:06:51 +01:00
Clementine Buildbot
b49afcc5b7
Automatic merge of translations from Transifex
2020-09-24 02:30:41 +00:00
Zanny
2bac3626c5
Fix logout cancelling ( #6796 )
2020-09-23 10:39:59 +01:00
Clementine Buildbot
54f7637ad2
Automatic merge of translations from Transifex
2020-09-23 02:29:48 +00:00
John Maguire
2172732b1e
Include windows.h first as it's special
2020-09-22 14:56:06 +01:00
