Commit Graph

5919 Commits

Author SHA1 Message Date
Andreas dd2ba0fe33 Append id to spotify_bin gst_bin. 2015-04-21 11:47:32 +02:00
Andreas e916db9ae1 Simplify code. 2015-04-21 10:49:45 +02:00
Andreas a1855f84bc Almost. SpotifyClient streams new tracks to a new media pipeline.
Bugs:
- If the transition work, there is no audio output, but the pipeline is filled with data.
- Sometimes the transition doesn't work and a complete new gstpipeline is created. Not sure why yet.
2015-04-14 16:33:44 +02:00
Andreas c62cc10759 Merge branch 'spotify-gapless' of https://github.com/clementine-player/Clementine into spotify-gapless 2015-04-14 14:40:41 +02:00
Andreas 8ab13d2b23 Work on other approach. 2015-04-14 14:39:56 +02:00
Andreas 341d5d3722 Once track can be played gaplessly. But the gst pipeline position isn't reset to 0 and this causes further problems. 2015-04-14 14:39:56 +02:00
Andreas a759fdb2e0 Oops. 2015-04-14 14:39:56 +02:00
Andreas db14b75fe7 Use Spotify prefetch to load next song before the current one ends.
We still have the problem that each track a new GstPipeline is created and the SpotifyClient creates a new connection to this pipeline.
Therefore playback is not gapless yet.
2015-04-14 14:39:56 +02:00
Clementine Buildbot 6ecd47011a Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-04-13 10:01:20 +02:00
Andreas 10980280cc Merge pull request #4801 from Wuerstchen/patch-1
Update "Report a bug" in README.md
2015-04-11 15:03:29 +02:00
Wuerstchen c0b345a64f Update README.md
Fixed some typos/mistakes and improved readability
2015-04-11 14:49:57 +02:00
Andreas ec35688c86 Fix crash when stopping a track while a fadeout to pause is occuring. Fixes #4800. 2015-04-11 11:30:28 +02:00
Andreas 11d2702841 Try fixing buildbot. 2015-04-10 22:59:35 +02:00
Andreas 25e73d5714 Merge pull request #4679 from TheUbuntuGuy/master
Do not remove currently playing track when repopulating a dynamic playlist
2015-04-10 22:41:44 +02:00
Andreas cbbe7db5f2 Merge pull request #4784 from M-Bab/master
Added support to read/display the ID tag lyrics in MP3 files:
2015-04-10 22:29:30 +02:00
Martin Babutzka 258ae281d8 IDv3 tag lyrics support.
Squashed the following commits:

5c723ad commit: Fix: Includes alpha sort
15ac350 commit: Fix: Updated Database::kSchemaVersion to 49.
767a26a commit: Fixed small code style issue. Added schema-49 to data.qrc instead schema-48
bf6aa64 commit: fixup! Modified async handling of CollapsibleInfoPane as recommended by Andreas. Display of IDv2 tag lyrics works now.
c1f97e9 commit: fixup! Added support to read/display the ID tag lyrics in MP3 files:
c946b1d commit: Added support to read/display the ID tag lyrics in MP3 files:

-Added schema to the database to store it
-Added readers/writers for ID tags
-Added readers/writers for the database to the song class
-Added the taglyricsinfoprovider to show the lyrics in songinfo
2015-04-10 21:05:07 +02:00
Clementine Buildbot f533b2998c Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-04-06 10:01:21 +02:00
Andreas fbc25a0d87 Work on other approach. 2015-04-05 12:07:55 +02:00
Arnaud Bienner 34d3d7671d Oops: missed label 2015-04-01 14:07:58 +02:00
Arnaud Bienner 8bd97a1d38 Windows: check if there is already a previous install of Clementine and if so, ask the user if he wants to run the uninstaller. Running the installer will kill any running instance of Clementine, preventing installation issues because the files are used by this process and thus cannot be overwritten. 2015-04-01 11:41:05 +02:00
Arnaud Bienner ccf5bffd99 Oops, this should just be a comment (remove warning) 2015-03-30 18:34:45 +02:00
Clementine Buildbot 82df087a83 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-03-30 10:01:17 +02:00
Arnaud Bienner 9877ac49fa Use Alt+Tab to switch between playlist tabs on OS X, as Cmd+Tab is already used by default for switching applications 2015-03-28 17:18:22 +01:00
John Maguire 8d3fd00956 Amazon Cloud Drive support.
Squashed commit of the following:

commit 451a327fabb5f9aba077d93a33d75d8a6a288f5f
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:55:36 2015 +0100

    Revert debug console changes.

commit 52f643c3dc524a837f56268b6da4881187204165
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:49:28 2015 +0100

    Revert extra logging

commit 23645f9fea
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:47:55 2015 +0100

    How did you get there

commit 8153388f19
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:45:12 2015 +0100

    Update copyright headers.

commit fa9e279259
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:43:27 2015 +0100

    Remove logging

commit 47a405543c
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:42:05 2015 +0100

    Show login state correctly for Amazon.

commit 748d88d993
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:28:55 2015 +0100

    Ensure Amazon is connected before serving URLs.

commit 25ec9c65f4
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:22:28 2015 +0100

    Refresh Amazon authorisation & follow changes.

commit 27c1a37173
Author: John Maguire <john.maguire@gmail.com>
Date:   Thu Mar 26 18:27:27 2015 +0100

    Revert unneeded OAuthenticator change.

commit 3594af5be1
Author: John Maguire <john.maguire@gmail.com>
Date:   Thu Mar 26 16:52:19 2015 +0100

    Initial support for Amazon Cloud Drive.
2015-03-27 14:56:08 +01:00
Arnaud Bienner f3426c05c7 Don't call gst_deinit when exiting Clementine.
It sometimes cause a deadlock since we migrated to GStreamer 1.0.
And it seems we shouldn't need to call it as we are "a normal application":
http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/gstreamer-Gst.html#gst-deinit
2015-03-25 22:23:13 +01:00
Arnaud Bienner 7ae9e0dd9b Set starting_up_ to false in playlist container when manager is done adding playlists.
Otherwise, it was never set to false at startup if no "current_playlist" was saved in the settings, then there was no new value saved for "current_playlist".
Fixes #4011.
2015-03-25 22:13:39 +01:00
John Maguire d2ca9ac6ee Merge pull request #4785 from ivan-leontiev/fix-networkremote-memleak
Fix memory leak in networkremote.
2015-03-24 12:19:24 +01:00
Ivan Leontiev aba0517b4c Fix memory leak in networkremote. 2015-03-24 09:22:02 +00:00
Clementine Buildbot 791aa482c2 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-03-23 10:01:17 +01:00
John Maguire c553249684 Merge pull request #4779 from Chocobozzz/readme
Add "opening issue" to the README
2015-03-18 19:28:50 +01:00
Chocobozzz a2f86e02d2 Update readme with "opening an issue" informations 2015-03-18 19:03:37 +01:00
Andreas b5a6d42d32 Once track can be played gaplessly. But the gst pipeline position isn't reset to 0 and this causes further problems. 2015-03-17 20:44:01 +01:00
John Maguire 20005dd733 Merge pull request #4780 from Chocobozzz/changelog
Update changelog
2015-03-17 17:39:05 +01:00
Chocobozzz ec5de7809c Update changelog 2015-03-16 16:51:05 +01:00
Clementine Buildbot b50c51200c Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-03-16 10:01:20 +01:00
Arnaud Bienner 5b2e4419ae Don't check AXAPIEnabled when initializing the shortcuts, fixes media keys not working on OS X.
Fixes issue #3958.
2015-03-15 13:40:27 +01:00
Andreas 8e3fa5552a Oops. 2015-03-14 15:38:17 +01:00
Andreas f34734443b Remove pending playlist requests in SpotifyClient if sp_session_player_load failed as well. 2015-03-14 15:26:44 +01:00
Andreas 509b28aaeb Use Spotify prefetch to load next song before the current one ends.
We still have the problem that each track a new GstPipeline is created and the SpotifyClient creates a new connection to this pipeline.
Therefore playback is not gapless yet.
2015-03-14 15:22:39 +01:00
Arnaud Bienner fe7bc917de Check if Mac QSearchField has focus before handling the notification.
Otherwise, playlist's search field will always handle those shortcuts, and they won't work anywhere else on the same window.
Fixes #3320.
2015-03-14 01:55:46 +01:00
Arnaud Bienner fad0ccc8c6 Fix a crash that will sometime occur on exit on Mac, caused by my recent changes 2015-03-14 01:38:03 +01:00
Andreas 55e5eab157 Fix Race-Condition in SpotifyClient that caused playback to break.
QList.removeAll calls the destructor for the elements in the list. This caused `req` to be initialized in `SpotifyClient::TryPlaybackAgain()`. Therefore, spotify method calls might crash because the pointers are invalid.

This commit moves the `pending_playback_requests_.removeAll` to the end of the method to ensure `req` is accessible all the time.
2015-03-13 14:12:19 +01:00
Arnaud Bienner 5e45f59e2c Fix crash in Grooveshark.
Not sure how I end up with this null pointer, but better to always to this sanity check.
2015-03-11 23:07:20 +01:00
Clementine Buildbot 3bad88d01e Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-03-09 10:01:15 +01:00
John Maguire 705cdf11fc Move ScopedNSAutoreleasePool to ext 2015-03-02 17:51:17 +01:00
John Maguire 7823d95a07 Merge pull request #4756 from paperbagcorner/fix-paths
Construct filenames with correct paths on all platforms
2015-03-02 12:18:20 +01:00
John Maguire 66333d2940 Merge pull request #4758 from Chocobozzz/seafile_info
Try to make Seafile implementation more robust
2015-03-02 12:17:48 +01:00
Clementine Buildbot b6fd781ace Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-03-02 10:01:13 +01:00
Arnaud Bienner 946c0381d1 Don't set thread priority in LibraryWatcher constructor, as this is executed in the main thread.
Do it when thread actually starts (create a new Thread class for this purpose).
Fixes #4523.
2015-02-28 16:44:32 +01:00
David Sansome 489c9a1a67 Merge pull request #4762 from sobkas/fix_4760
Add ability to parse more of "innovative" datetime formats. close #4760
2015-02-27 13:46:43 +11:00