8d69da28f3
Fixing freeing of memory in cddasongloader
2021-05-18 12:12:01 +01:00
8668699977
CddaSongLoader: handle potential multiple tag messages correctly
2021-05-18 12:12:01 +01:00
e9945bcbc6
do NOT free toc entries in CddaSongLoader (reverting previous change)
2021-05-18 12:12:01 +01:00
86bbd2ace6
Formatting/linting fixes.
2021-05-18 12:12:01 +01:00
81c0661e8c
MusicBrainzClient stop result parsing after reading first medium with correct discid.
...
Tentative fix for #7020 .
2021-05-18 12:12:01 +01:00
54a497b302
RipCDDialog rejects metadata lists if number of tracks does not match disc.
...
First step for addressing #7020 .
2021-05-18 12:12:01 +01:00
436c53870a
Correctly freeing memory in CddaSongLoader::LoadSongsFromCdda
2021-05-18 12:12:01 +01:00
97800e613a
Fix for #7019 : CddaSongLoader obtaining metadata on first try.
2021-05-18 12:12:01 +01:00
1309c76bec
tagreader: Relocate artist/album/title guessing code
...
Move the code that attempts to fill missing song metadata out of the
tagreader worker. In the main process, it will be controllable using
settings and calling context.
The methods were moved into a new SongPathParser class that checks new
settings to determine if action should be taken.
2021-05-17 13:20:34 +01:00
75de59703c
Fix: Transcoding for CD rips not starting.
...
due to making Transcoder::Start a non-slot in 8d11e9ff
2021-05-15 10:14:18 +01:00
89155ace70
Automatic merge of translations from Transifex
2021-05-14 03:06:05 +00:00
a7468dcd41
Automatic merge of translations from Transifex
2021-05-13 03:03:53 +00:00
3f614464ee
Automatic merge of translations from Transifex
2021-05-12 03:01:45 +00:00
9bfd458b15
playlistparsers: Handle m3u UTF-16 playlists.
...
Rather than assume UTF-8, use QTextStream to read data. This checks the
byte order mark of the file to determine encoding.
As an optimization, since the playlist already needs to be searched for \r
characters, just create a string list and work from that.
2021-05-11 10:22:18 +01:00
d16d9ba282
Automatic merge of translations from Transifex
2021-05-11 02:59:45 +00:00
83157100c4
Automatic merge of translations from Transifex
2021-05-09 02:56:37 +00:00
590bcf1c7c
build: Add libgpod for mac
...
This change was taken from Strawberry. When and if a homebrew libgpod
package becomes available, this change can be replaced.
Reference: f2c7df3a3b
2021-05-08 15:53:20 +01:00
33aa8c8579
build: Add libgpod link directory.
2021-05-08 15:53:20 +01:00
f5d3079db8
Automatic merge of translations from Transifex
2021-05-08 02:56:24 +00:00
783213f9c1
Automatic merge of translations from Transifex
2021-05-07 02:58:09 +00:00
d798c76e06
devices: Remove obsolete DeviceKit.
...
DeviceKit-disks, renamed udisks, was superseded by udisks2 in 2012.
2021-05-06 20:52:33 +01:00
579d869042
build: Add libmtp to BrewFile.
2021-05-03 23:27:28 +01:00
079384c154
build: Add libmtp link directory.
...
If MTP is enabled, add library directory. This will allow it to be found
in brew installations.
2021-05-03 23:27:28 +01:00
f48888a430
networkremote: Fix some log noise.
...
In avahi, don't log empty errors.
2021-05-03 14:45:00 +01:00
9a337a9efc
logging: Fix {anonymous} class name.
...
If the __PRETTY_FUNCTION__ macro yields {anonymous} as the class name,
use the method name as the tag.
2021-05-03 14:44:19 +01:00
708385c71f
devices: Fix guessed icons in DeviceIcons
...
In the initial implementation, DeviceLister::DeviceIcons returned a
string list and some listers would concatenate other lists to form that
list. When DeviceIcons was changed to return a variant list, that
logic wasn't changed in many places, so instead of appending, string
list variants are being added icon list.
2021-05-01 20:37:01 +01:00
20647e8a98
Automatic merge of translations from Transifex
2021-04-29 02:54:42 +00:00
8c1bdc1a45
Changed to const reference
2021-04-28 21:51:12 +01:00
1646ab2221
Corrected comments + Added reference to Song& + use non-default
...
constructor for QFileInfo.
Forgot to apply clang-format so applied 2nd commit and squashed
both
2021-04-28 21:51:12 +01:00
66a34a906a
Removed unneeded empty arguments already provided by defaults
2021-04-28 21:51:12 +01:00
444f1e2e69
clang-format correction
2021-04-28 21:51:12 +01:00
b7a995d223
Re-added log message for URL and mime-type.
2021-04-28 21:51:12 +01:00
fb391a7fbe
Optimization to avoid save+delete of remote playlists to temporary file
2021-04-28 21:51:12 +01:00
8fddc816a0
Remove unsupported FC31 build
2021-04-27 18:08:18 +01:00
d59ed1e704
Add Fedora Core 34 workflow
2021-04-27 17:23:18 +01:00
fc83e41279
Automatic merge of translations from Transifex
2021-04-27 02:57:12 +00:00
7e48b78c15
Automatic merge of translations from Transifex
2021-04-26 03:01:00 +00:00
94f4f65a60
Automatic merge of translations from Transifex
2021-04-25 03:01:19 +00:00
b2ed9499f6
Automatic merge of translations from Transifex
2021-04-24 02:56:55 +00:00
8258c78c0b
dbus: Fix signal arg annotations
...
An earlier change attempted to fix qdbusxml2cpp parsing errors by adding
directions to arguments. However, signal arguments are always out and it
was the annotations that were incorrect.
Fixes: f17b79a10https://dbus.freedesktop.org/doc/dbus-specification.html
2021-04-22 11:24:12 +01:00
59f6d95b80
clementine-tagreader: Fix addDefaultCaCertificates deprecation
...
QSslSocket::addDefaultCaCertificates is deprecated in 5.15. Use
QSslConfiguration default configuration instead.
2021-04-22 11:23:50 +01:00
5f75bde396
libclementine-common: Use positive numbers for worker ids.
...
QRandomGenerator::generate() returns an unbounded int32, while the legacy
qrand method always returned a positive number. When generating a tag
reader ID with QRandomGenerator, cast the random value to an unsigned so
that it is formatted as a positive number in the name.
Note that most usages of QRandomGenrator in the codebase use bounded()
instead of generate(), and should work as expected.
2021-04-22 11:21:08 +01:00
73c0af1977
Remove expired Equifax CA root
...
The Equifax certificate expired in 2018, so any certificate that was
signed by that CA should also be expired.
2021-04-21 10:24:53 +01:00
f17b79a105
dbus: Fix qdbusxml2cpp unknown type warnings.
...
Add direction attributes to args where qdbusxml2cpp was looking for the
incorrect annotation.
2021-04-21 10:24:09 +01:00
c51d2f954e
Automatic merge of translations from Transifex
2021-04-21 02:57:30 +00:00
280a514ebc
dbus: Fix annotation deprecation warnings
...
The com.trolltech was renamed to org.qtproject. The code generation tool
still handles the old name, but prints a deprecation error.
Reference: https://bugreports.qt.io/browse/QTBUG-23274
2021-04-20 22:49:21 +01:00
f04657e7e7
Replace qrand usage with QRandomGenerator
...
QRandomGenerator was introduced in 5.10 and qrand has since been
deprecated. QRandomGenerator::global() returns a global instance that
has been securely seeded. QRandomGenerator provides methods that
generate values within ranges, so taking a modulus of the result isn't
necessary.
2021-04-20 10:31:07 +01:00
6b21079fd4
dbus: Fix xml format errors.
2021-04-20 10:30:06 +01:00
429d8ee0f9
core/logging: Fix QString::split deprecation
...
QString::SplitBehavior is deprecated in 5.14. Use Qt::SplitBehavior
after this version.
2021-04-19 10:25:31 +01:00
163ebe71d8
libclementine-tagreader: Discontinue use of deprecated taglib methods.
...
Direct use of MP4::itemListMap() was deprecated in favor of using item() and
setItem(). XiphComment::removeField was replaced by removeFields.
2021-04-18 13:48:13 +01:00
Lukas Prediger
Jim Broadus
Clementine Buildbot
diracsbracket
John Maguire