Funkwhale/Clementine-audio-player-Mac-Linux-Windows
1
0
Fork 0
mirror of https://github.com/clementine-player/Clementine synced 2025-02-02 12:26:48 +01:00
Code Issues Releases Wiki Activity
8,193 Commits 23 Branches 550 Tags 193 MiB
Commit Graph

8193 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Lukas Prediger
6ea20336c2 CddaSongLoader: Only run one song loading thread at once. 
- CddaSongLoader destructor waits for thread to end.
- Added flag to interrupt LoadSongsFromCdda
- Only start song loading if not already running
- Removed (now obsolete) mutex
 2021-06-21 12:51:44 +01:00
Lukas Prediger
ae9824e26a RipCDDialog no longer needs to LoadSongs on show. 2021-06-21 12:51:44 +01:00
Lukas Prediger
63953e1045 RipCDDialog now allows selecting the CD drive 2021-06-21 12:51:44 +01:00
Lukas Prediger
b68734c761 Fix: Missing include guard for cddadevice in mainwindow.cpp 2021-06-21 12:51:44 +01:00
Lukas Prediger
95799a911d Removing ConnectedDevice::Refresh altogether 2021-06-21 12:51:44 +01:00
Lukas Prediger
639b918557 Removing CddaDevice::Refresh 2021-06-21 12:51:44 +01:00
Lukas Prediger
3c06b92b24 Ripper now works with a cdio instance passed into constructor 
which comes from a CddaDevice corresponding to the device
 2021-06-21 12:51:44 +01:00
Lukas Prediger
ae3037984c RipCDDialog now uses CddaSongLoader from passed in CddaDevice 2021-06-21 12:51:44 +01:00
Lukas Prediger
14d5c25d37 Integrated cddevice back into cddadevice 2021-06-21 12:51:44 +01:00
Lukas Prediger
9ca75ae357 RipCDDialog now relies on CddaDevice to be notified about disc changes 2021-06-21 12:51:44 +01:00
Lukas Prediger
d2c636ab46 Introducing CdDevice, simple wrapper for cdio that watches disc changes. 
CddaDevice now relies on this to update song list. CddaDevice::Refresh is now a no-op.
 2021-06-21 12:51:44 +01:00
Clementine Buildbot
11bd0db03b Automatic merge of translations from Transifex 1.4.0rc1-639-g11bd0db03 2021-06-21 02:54:22 +00:00
Clementine Buildbot
c3c77aef19 Automatic merge of translations from Transifex 1.4.0rc1-638-gc3c77aef1 2021-06-16 02:55:57 +00:00
Jim Broadus
ffdaeba09f cueparser: Be more lenient when parsing indexes. 
Most specs have mm:ss:ff as the index time format, but cue files have
been found with single digit minutes. e.g. 0:00:00 instead of 00:00:00

Reference: https://www.gnu.org/software/ccd2cue/manual/html_node/CUE-sheet-format.html
1.4.0rc1-637-gffdaeba09 		2021-06-15 14:14:00 +01:00
Clementine Buildbot
2bf8f1388b Automatic merge of translations from Transifex 1.4.0rc1-636-g2bf8f1388 2021-06-15 02:57:02 +00:00
Clementine Buildbot
418a366931 Automatic merge of translations from Transifex 1.4.0rc1-635-g418a36693 2021-06-14 02:55:24 +00:00
Clementine Buildbot
4aa4f4fce3 Automatic merge of translations from Transifex 1.4.0rc1-634-g4aa4f4fce 2021-06-13 02:54:58 +00:00
Jim Broadus
3a00403ad0 build: Add patch for libgpod mac build. 
Store patch file in repository rather than relying on strawberry's file
server.

Reference: 27955cc441
1.4.0rc1-633-g3a00403ad 		2021-06-12 15:14:44 +01:00
Clementine Buildbot
7fb387b967 Automatic merge of translations from Transifex 2021-06-12 02:54:18 +00:00
Jim Broadus
4e4fccc07a playlistparser: Add error mechanism for parsers. 
Add a new Error signal to parser implementations. Display an error when
user tries to use the unimplemented CueParser::Save.
1.4.0rc1-631-g4e4fccc07 		2021-06-11 10:17:20 +01:00
Jim Broadus
f4108b5a0c playlistparser: Display errors on failures. 
Add an Error signal to PlayListParser and connect that to the
PlayListManager::Error signal. This is eventually connected to the
Application::AddError. Add error messages in some cases where
PlayListParser can fail silently.
 2021-06-11 10:17:20 +01:00
Clementine Buildbot
612767c878 Automatic merge of translations from Transifex 1.4.0rc1-629-g612767c87 2021-06-09 03:12:09 +00:00
Clementine Buildbot
b09ab3ff37 Automatic merge of translations from Transifex 1.4.0rc1-628-gb09ab3ff3 2021-06-04 04:25:11 +00:00
Robin Ekman
0dbefa3064 Add a shortcut to go to next album 1.4.0rc1-627-g0dbefa306 2021-06-03 17:06:48 +01:00
Fabio Bas
058fe6f4be fall back to url if url_resolved is empty 1.4.0rc1-626-g058fe6f4b 2021-06-02 22:40:13 +01:00
Fabio Bas
38ac0d3ccb Radiobrowser.info: use the url_resolved field for radio stations 2021-06-02 22:40:13 +01:00
John Maguire
72cfdf25a9 Remove FC32 build 1.4.0rc1-624-g72cfdf25a 2021-06-02 11:23:40 +01:00
Clementine Buildbot
f674753758 Automatic merge of translations from Transifex 1.4.0rc1-623-gf67475375 2021-05-31 05:04:40 +00:00
Clementine Buildbot
f7369d2c42 Automatic merge of translations from Transifex 1.4.0rc1-622-gf7369d2c4 2021-05-28 04:26:27 +00:00
Clementine Buildbot
2132e99fbe Automatic merge of translations from Transifex 1.4.0rc1-621-g2132e99fb 2021-05-27 03:59:34 +00:00
Clementine Buildbot
684c9d232f Automatic merge of translations from Transifex 1.4.0rc1-620-g684c9d232 2021-05-26 03:51:04 +00:00
Clementine Buildbot
d71eba97fb Automatic merge of translations from Transifex 1.4.0rc1-619-gd71eba97f 2021-05-25 03:20:50 +00:00
Jim Broadus
f071075e8c build: Add Ubuntu Hirsute to workflows. 
Reference: https://wiki.ubuntu.com/Releases
1.4.0rc1-618-gf071075e8 		2021-05-24 23:05:56 +01:00
Jim Broadus
776bd3b022 settings: Add option to guess song metadata 
Add "Try to guess missing metadata" option to the Song Metadata page
that controls the setting in SongPathParser.
1.4.0rc1-617-g776bd3b02 		2021-05-24 15:23:05 +01:00
Jim Broadus
cf88e47206 settings: Create a new Song Metadata settings page 
Move tagreader process settings to the new page.
 2021-05-24 15:23:05 +01:00
Jim Broadus
01be9f196a settings: Organize page enums by category. 2021-05-24 15:23:05 +01:00
Lukas Prediger
89831f8dca MusicBrainzClient: Log message for malformed XML in reply 1.4.0rc1-614-g89831f8dc 2021-05-18 12:13:10 +01:00
Lukas Prediger
e756f2d686 CddaSongLoader: explicitly reading discid as UTF8 1.4.0rc1-613-ge756f2d68 2021-05-18 12:12:01 +01:00
Lukas Prediger
8d69da28f3 Fixing freeing of memory in cddasongloader 2021-05-18 12:12:01 +01:00
Lukas Prediger
8668699977 CddaSongLoader: handle potential multiple tag messages correctly 2021-05-18 12:12:01 +01:00
Lukas Prediger
e9945bcbc6 do NOT free toc entries in CddaSongLoader (reverting previous change) 2021-05-18 12:12:01 +01:00
Lukas Prediger
86bbd2ace6 Formatting/linting fixes. 2021-05-18 12:12:01 +01:00
Lukas Prediger
81c0661e8c MusicBrainzClient stop result parsing after reading first medium with correct discid. 
Tentative fix for #7020.
 2021-05-18 12:12:01 +01:00
Lukas Prediger
54a497b302 RipCDDialog rejects metadata lists if number of tracks does not match disc. 
First step for addressing #7020.
 2021-05-18 12:12:01 +01:00
Lukas Prediger
436c53870a Correctly freeing memory in CddaSongLoader::LoadSongsFromCdda 2021-05-18 12:12:01 +01:00
Lukas Prediger
97800e613a Fix for #7019: CddaSongLoader obtaining metadata on first try. 2021-05-18 12:12:01 +01:00
Jim Broadus
1309c76bec tagreader: Relocate artist/album/title guessing code 
Move the code that attempts to fill missing song metadata out of the
tagreader worker. In the main process, it will be controllable using
settings and calling context.

The methods were moved into a new SongPathParser class that checks new
settings to determine if action should be taken.
1.4.0rc1-604-g1309c76be 		2021-05-17 13:20:34 +01:00
Lukas Prediger
75de59703c Fix: Transcoding for CD rips not starting. 
due to making Transcoder::Start a non-slot in 8d11e9ff
1.4.0rc1-603-g75de59703 		2021-05-15 10:14:18 +01:00
Clementine Buildbot
89155ace70 Automatic merge of translations from Transifex 1.4.0rc1-602-g89155ace7 2021-05-14 03:06:05 +00:00
Clementine Buildbot
a7468dcd41 Automatic merge of translations from Transifex 1.4.0rc1-601-ga7468dcd4 2021-05-13 03:03:53 +00:00