Commit Graph

608 Commits

Author SHA1 Message Date
David Sansome 13fc24f6c6 Refactor the last.fm, magnatune, spotify and di.fm settings pages - moving the login state display into a separate widget. 2011-08-27 22:01:28 +01:00
David Sansome 143bbb4019 Make the BusyIndicator contain a label too 2011-08-27 15:03:04 +01:00
John Maguire 72198db1ba Make the album cover search dialog window modal so that it acts like a sheet on Mac. 2011-08-27 14:50:11 +01:00
David Sansome 263f57b47b Only set the pretty OSD's message in the notifications settings page's constructor - don't show it as well. It would just get hidden again straight away, and for some reason this triggers a (Qt?) bug where the window gets painted in the top-left corner, but reacts to mouse clicks in its actual position.
Fixes issue 2110
2011-08-26 23:34:13 +01:00
David Sansome e194d89857 Fix a crash when choosing "Edit track information" from the library view 2011-08-18 00:38:49 +01:00
David Sansome 4ce5cf03d2 Enforce the correct minimum width on settings dialog pages so they don't appear clipped horizontally 2011-08-14 20:19:54 +01:00
David Sansome 4b1e2f08e9 Put each settings page in a scroll area, and resize the settings dialog to fit on the user's screen if it's too big. Fixes issue 953. 2011-08-14 15:41:47 +01:00
David Sansome dad76b78dd Move all the settings pages to their own widgets and classes 2011-08-14 00:07:10 +01:00
David Sansome c366f722fb Show the album cover dimensions on top of the images in the album cover search dialog.
Fixes issue 1704
2011-07-26 13:02:59 +01:00
David Sansome 5c90404915 Sort album covers by image size. Fixes issue 2048 2011-07-26 12:17:28 +01:00
David Sansome 38100f5e59 Make CoverProviders not a singleton 2011-07-23 19:34:41 +01:00
David Sansome dd3eee63e5 Remove python scripting support 2011-07-23 15:32:12 +01:00
David Sansome a0258a9e81 Add c++ implementations of the di.fm and sky.fm radio services 2011-07-23 15:32:11 +01:00
Tyler Rhodes ded8e5f6f0 Refactor "Radio" files into "Internet" files. 2011-07-15 13:27:50 +00:00
Tyler Rhodes 39858fcf9d Fix build error on mac. 2011-07-12 23:43:02 +00:00
John Maguire 3df5906250 Add script for searching for a song on youtube. 2011-07-08 15:11:48 +00:00
John Maguire b188241ec7 Support drag and drop of images to the cover in the edit tag dialog.
Fixes issue #1406
2011-07-07 14:20:34 +00:00
Tyler Rhodes 617ea33be9 Remove duplicate action key in wiimotedev preferences.
Fixes issue 2046.
2011-07-05 20:11:21 +00:00
Andrea Decorte 10af1e6627 Save last.fm options without login. Fixes issue #2023. Thanks to
samir.benmendil@gmail.com
2011-06-27 18:15:55 +00:00
David Sansome 7773e98ebf Keep track of some statistics while searching for album covers, and show a statistics dialog at the end. Fixes issue 1921 2011-06-26 15:07:48 +00:00
David Sansome f8045af720 Various album cover search changes:
- Download several covers and use some heuristics to decide which cover is the best, rather than just taking the first one.
 - Timeout album cover downloads after 2.5s
 - Show covers properly in the album cover manager if they were manually unset, and then Clementine was restarted.
2011-06-26 15:07:19 +00:00
David Sansome dd98f8abc8 Make the album cover search results list scroll by pixel instead of item, and re-layout the items when any data changes 2011-06-26 15:06:59 +00:00
David Sansome 2ef9ab6f6e Replace the KCategorizedView with a custom widget that works better. 2011-06-25 16:47:00 +00:00
Arnaud Bienner 47ad50dc41 Update mute button in tray icon 2011-06-22 21:50:25 +00:00
Arnaud Bienner 63300d79db Set tr function's codec to system encoding. Should (finally) resolve problems with already translated strings 2011-06-22 20:41:48 +00:00
David Sansome bac414a630 Allow the artist and album to be specified separately when searching for album covers 2011-06-22 19:07:15 +00:00
David Sansome 62bd3694ec Remove cover provider factories and refactor everything else to use cover providers directly instead. 2011-06-19 23:15:51 +00:00
David Sansome c6e2981860 Group album cover search results by category 2011-06-19 23:15:29 +00:00
David Sansome 36165ea9bf Keep the state of the rain and hypnotoad menu actions in sync with whether they're actually playing. Fixes issue 1986 2011-06-19 14:42:00 +00:00
David Sansome 7415d85dce When initialising a song from a library query, don't always assume the metadata originally came from a file (which means icycast tags are ignored when it is played). Fixes issue 1857 2011-06-17 20:00:10 +00:00
Arnaud Bienner 7fca5d37dc Minor modifications on load audio CD, including better cleaning of objects 2011-06-14 23:38:43 +00:00
Arnaud Bienner 272841ab73 Starting audio CD support. Starts issue 701 2011-06-09 23:08:43 +00:00
Tyler Rhodes 827d37e64b Add 'Enable playlist background image' to preferences.
Fixes issue #365
2011-06-08 14:48:43 +00:00
Andrea Decorte 0a5c8e3995 Fixed two little issue with OSD toggling and new lines 2011-06-05 13:34:12 +00:00
Andrea Decorte 527171fadb Toggle visibility for Pretty OSD by command line and global shortcut.
Fixes issue 1344
2011-06-05 08:21:17 +00:00
Andrea Decorte 44302a59b3 Added option to disable pretty OSD timeout 2011-05-29 12:44:38 +00:00
Andrea Decorte 61092899c9 Add font choice for pretty OSD and fixed bugs in the notification
preview
2011-05-28 08:50:29 +00:00
John Maguire 5f7b085f12 Disable popup delay settings when Growl is selected.
Fixes issue #1891
2011-05-26 13:13:38 +00:00
Andrea Decorte 2f7ea0acbe New lines are now allowed in OSD if the notification type support them 2011-05-23 19:49:03 +00:00
Andrea Decorte c2e9bee463 Add an option to customize OSD message on song change 2011-05-22 21:15:11 +00:00
Paweł Bara d1d177769a cover providers are now recreated every search (this will lead to simpler API of theirs in a moment)
initial migration from SIP -> PythonQt in cover providers
2011-05-17 17:53:36 +00:00
Andrea Decorte ddbe03b526 Added Login button to Last.Fm and others online services. Fixes issue
1772
2011-05-09 19:54:04 +00:00
David Sansome 70e6018b1e Add some spotify branding, display spotify login errors, add a button to the config dialog to download the blob, only make the config dialog try to login when it needs to, fix a bug where the Starred and Inbox items would sometimes not get created. 2011-04-30 12:31:20 +00:00
David Sansome b20d280156 Add a "Did you mean ...?" widget when searching on spotify 2011-04-28 20:48:53 +00:00
David Sansome 255682b057 Remove the special load behaviour from Playlist Items and instead add URL Handlers that do the same job but for all playlist item types. 2011-04-28 15:10:28 +00:00
David Sansome ccb9f8cf94 Use URLs everywhere instead of filenames. Move the URL parsing and song loading code out of individual playlist parsers and into the base class. Fix the playlist parser unit tests. 2011-04-28 12:27:53 +00:00
Andrea Decorte 9dd45dbe82 Improved Last.fm scrobbling when connection is down 2011-04-28 10:32:56 +00:00
Paweł Bara 10fbbca82f disable some more stuff in the cover manager's window if there are no active cover providers 2011-04-27 19:36:42 +00:00
Paweł Bara fdda938c53 now that we have more cover providers, we're bringing the cover manager and the cover searcher goodness to our last.fm-less users 2011-04-27 19:10:37 +00:00
David Sansome e152e3a3e3 Start of some spotify support - builds a binary blob linked against libspotify that Clementine starts as a separate process. 2011-04-25 19:16:26 +00:00
David Sansome 071f1f4f7e Add loads more debug logging on startup 2011-04-24 18:07:09 +00:00
David Sansome 3eedc916ad Add a new logging system 2011-04-22 16:50:29 +00:00
Arnaud Bienner be1ee059f2 Correct update lastfm's love/ban actions in tray icon 2011-04-21 22:19:28 +00:00
Arnaud Bienner 1cd1a4a641 Forgot to update translations. Also adding a key accelerator to 'Tools' menu text (while keeping already translated strings) 2011-04-19 20:31:41 +00:00
Arnaud Bienner 6653d740fc Adding shorcuts for navigating over the tabs. Fixes issue 1568 2011-04-19 20:11:24 +00:00
David Sansome 8f4c1dbbf6 When doing gapless playback, fix a bug where the TrackEnded signal would be emitted too early, before the track had actually ended. This caused the song after the current song to get scrobbled and its playcount increased. Fixes issue 1771 2011-04-17 14:11:37 +00:00
David Sansome 012eeee46a Only update a song's play count once if scrobbling is disabled. Fixes issue 1766 2011-04-16 23:17:48 +00:00
David Sansome 5ed1fcd5e1 Add a load of options to the transcoders. Fixes issue 415. 2011-04-16 23:04:15 +00:00
David Sansome 343b6d6c3a Re-enable the love button after going to a different song in a radio stream. Fixes issue 1086 2011-04-16 15:27:34 +00:00
David Sansome 23c744f41a Add a queue element to the pipeline to buffer even local sources, and increase the default buffer size to 4 seconds. 2011-04-16 14:04:12 +00:00
David Sansome b799543272 Stamp last.fm tracks before checking if they're valid scrobbles 2011-04-07 19:18:24 +00:00
Andrea Decorte 5d8f1fe872 Added scrobbling button in main window and a global shortcut for
toggling it. Fixes issue 1090
Improved last.fm error handling
2011-04-07 16:25:52 +00:00
Paweł Bara 2b22dfaaee download only large covers from google
add cover size tooltip (see issue #1704)
cover search window is now a grid and not a long list with vertical scrollbar
2011-04-06 15:24:56 +00:00
Paweł Bara f86b671272 fixing the minimal build 2011-04-02 14:43:50 +00:00
Paweł Bara 032b5f7e48 initial commit of "multiple covers providers" feature:
- simple API for cover providers (both C++ and SIP)
- a new "package" for cover related code
2011-04-02 13:34:06 +00:00
David Sansome e5bc2be85f Add some more debugging output for deciding when to scrobble a song 2011-03-29 21:12:49 +00:00
David Sansome 96b9321d3b Fix --seek-to and --seek-by. Fixes issue 1654 2011-03-29 19:05:09 +00:00
Arnaud Bienner 900cbcf001 Using trUf8 instead of classic tr. Now displays the already translated strings (utf8) correctly. Fixes issue 1620 2011-03-26 19:03:59 +00:00
Andrea Decorte ecda0ada4a Playlists get an automatic name, no more prompts. Fixes issue #423 2011-03-25 19:16:12 +00:00
Arnaud Bienner 4f83d59f59 Oups... :S 2011-03-23 00:51:19 +00:00
Arnaud Bienner 163e65d765 Translate equalizer settings' names at runtime. Fixes issue 1376 2011-03-23 00:42:35 +00:00
Paweł Bara f6c8c74302 mi scusi, missing translation 2011-03-22 14:53:48 +00:00
John Maguire eceb4164c1 Add more trayicon mouse wheel actions.
Update issue 1597
Status: Fixed
Thanks for the patch!
2011-03-21 15:15:17 +00:00
David Sansome 31ead96e91 Fix last.fm scrobbling. Fixes issue 1503 2011-03-20 22:19:38 +00:00
Paweł Bara bbd5b04244 visual revamp of "add to new playlist" option 2011-03-20 18:31:15 +00:00
Andrea Decorte a88e02c452 Added right-click menu option to copy track to specific playlist. Fixes issue 1289 2011-03-20 17:38:15 +00:00
Paweł Bara e619d7a280 fixing a bug where streams were removed from playlist during Clementine's startup 2011-03-20 16:07:24 +00:00
Paweł Bara bfb068a6d1 conditionally hide some context menu actions in library view and playlist view
Song.is_stream()
2011-03-20 12:43:10 +00:00
Paweł Bara 3db00fc339 plugin that lets you grey out deleted songs on demand ("main menu / playlist") - available by default
also: this action will "ungrey" songs that were deleted but got restored

SIPs
2011-03-19 10:22:55 +00:00
Paweł Bara 823f798451 new option for greying out deleted songs on startup 2011-03-19 09:41:00 +00:00
John Maguire 7705487f96 Default to large sidebar on all OS.
< r3000 >
 -------
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||
2011-03-18 15:09:30 +00:00
John Maguire 32193dbb9f Add validation for Magnatune accounts. 2011-03-18 14:39:29 +00:00
David Sansome 9086ab8ed4 Add a "Show in file browser..." to the library context menu as well. Fixes issue #1563 2011-03-17 19:52:21 +00:00
Andrea Decorte 4b6e2a8a62 Add global shortcuts for repeat and shuffle modes. Fixes issue #955 2011-03-17 08:21:05 +00:00
David Sansome cf826aeee0 Support dragging and dropping image files onto the now playing widget and edit tag dialog to set an album's cover art 2011-03-14 20:01:27 +00:00
Paweł Bara c8a0ab9625 don't hide the truth 2011-03-14 07:29:43 +00:00
David Sansome cb275f318f Add an option to disable automatic crossfading between tracks on the same album or from the same cuesheet. Fixes issue 1479 2011-03-13 18:37:46 +00:00
David Sansome 002ae13817 Use the canonical file path (resolve symlinks and '..') when adding directories to the library, and when adding files to the playlist. Fixes issue #1494 2011-03-13 14:43:03 +00:00
David Sansome 8690438ad4 Cancel network requests and outstanding fingerprint operations when cancelling musicbrainz lookups 2011-03-13 12:52:08 +00:00
David Sansome 1fb7dae446 Show a helpful error if the gstofa plugin isn't available 2011-03-12 22:29:13 +00:00
David Sansome b51566cdd9 Remove the dependencies on libtunepimp, libofa, libmusicbrainz. Use the gstreamer ofa plugin instead to fingerprint songs. 2011-03-12 21:19:41 +00:00
David Sansome 2c4102b060 Fix an error if you try to disable dbus, but enable wiimotedev. Fixes issue #1516 2011-03-12 21:19:32 +00:00
Paweł Bara 8722e00103 Clementine now skips songs that don't exist anymore (updates issue #250) 2011-03-10 18:01:35 +00:00
David Sansome 8e9c913605 Recreate the windows 7 thumbbar buttons if the window is hidden and then shown again. Fixes issue #1547 2011-03-09 00:13:50 +00:00
Arnaud Bienner 7fbd09954b Using new actions (that doesn't display unusuable shorcuts) for the tray icon menu. Fixes issue 679 2011-03-07 21:33:01 +00:00
David Sansome 7a60b52704 Fix the size of the now-playing widget to make it line up exactly with the top of the player controls 2011-03-07 20:21:34 +00:00
David Sansome 961a97659e Fix keyboard shortcuts on actions in the playlist menu that aren't added anywhere else. 2011-03-06 18:26:06 +00:00
David Sansome c4c7d8f82f Fix compilation without libtunepimp 2011-03-06 15:11:52 +00:00
David Sansome 0acfbda94d Don't crash when closing a playlist that has a pending SongLoaderInserter. Fixes issue #1471 2011-03-06 14:46:01 +00:00
David Sansome c2445edad5 Add a "complete tags automatically" shortcut to the playlist context menu. Fixes issue #1532 2011-03-06 14:07:41 +00:00
David Sansome 99101c8442 Add a "Show in file browser..." menu item to the playlist. Thanks dein.negativ. Fixes issue #465 2011-03-06 13:10:14 +00:00
David Sansome 4a020c0c04 Add support for fetching tags for multiple songs at once. Fixes issue #1399 2011-03-05 19:24:44 +00:00
David Sansome 90c35b3e3c Don't show the Script Manager entry in the Tools menu if scripting support is disabled. Fixes issue #1536 2011-03-05 13:01:03 +00:00
Paweł Bara aa6c3ab35b a way to mark DB schema versions as requiring a full library rescan
message dialog for a user when he's reached a full library rescan requiring schema version (like the final one of CUE sheet support)
2011-02-25 20:10:41 +00:00
Arnaud Bienner 57ac8c441a Play/Pause when pressing space (on playlistview). Fixes issue 244 2011-02-23 23:59:12 +00:00
Paweł Bara 17af8b935c fixing a regression where clicking on empty playlist space would crash Clementine 2011-02-23 18:34:42 +00:00
Paweł Bara e1d5abd83e first step of making CUEs read only (playlist view) 2011-02-21 18:18:16 +00:00
David Sansome 72096bf1c8 Move ArtLoader from mpris_common.h to its own file, add libxrme to 3rdparty, add a working XMPP remote. 2011-02-19 18:24:11 +00:00
Paweł Bara 20658989c3 full library rescan feature - should already work as expected 2011-02-17 19:57:14 +00:00
John Maguire 438e332ea5 Fix crash in settings dialog. 2011-02-17 19:42:36 +00:00
John Maguire 68de9c99d3 Fixing comments from code review for r2833 2011-02-17 14:34:45 +00:00
John Maguire 45cabc1b6b Add settings dialog for Google account with verification and stores password in secure keychain. 2011-02-17 13:47:54 +00:00
Arnaud Bienner 6d8c87418a Corrected an other regression introduced in r2826: exit when playing and fadeout is disable 2011-02-16 23:44:03 +00:00
Arnaud Bienner 0f1a1cc332 Corrected regression introduced in r2826: exit application when nothing is playing 2011-02-16 23:03:00 +00:00
Arnaud Bienner 375abfd04e Don't exit application to fast, to allow fadeout 2011-02-16 22:43:05 +00:00
Paweł Bara 7de912d3a1 moving the responsibility for naming playlists into mimeData() methods (into models)
this means that pretty names for new playlists now also work when double clicking (in certain mode) or dragging and dropping
fixes issue #1477
2011-02-16 18:29:35 +00:00
Arnaud Bienner b3839cf1d6 Adding accelerator key for just one simple string, while keeping old translations. Gonna check how Launchpad is able to handle this and how it will updated strings 2011-02-15 01:10:09 +00:00
Arnaud Bienner f893b34ae0 Adding myself to the about dialog. Feel proud to have my name here :) 2011-02-15 00:00:07 +00:00
David Sansome 8c691d2b3e Use constants instead of "1eN" literals for converting between time units. 2011-02-14 19:34:37 +00:00
Paweł Bara 0182829223 user-friendly name for 'Open in new playlist' playlists (fixes issue #1445) 2011-02-14 17:00:13 +00:00
David Sansome e18409ebf4 Factor out a PlayerInterface from Player, and use it in MPRIS1 and MPRIS2 2011-02-13 18:36:29 +00:00
David Sansome b38ce42ff8 Move the "Reset play counts" button in the edit tag dialog 2011-02-13 18:35:52 +00:00
David Sansome 507c5e2632 Change the fields in Song from seconds to nanoseconds 2011-02-13 18:34:30 +00:00
David Sansome 37618dae96 Use nanoseconds instead of seconds or milliseconds throughout the Player and Engine. 2011-02-13 18:29:27 +00:00
David Sansome 9aefae4e39 Remove a little space in the edit tag dialog 2011-02-13 18:29:13 +00:00
Paweł Bara 60ac6768b8 Fresh new 'open in new playlist' action (Updates issue #1431). 2011-02-09 17:51:59 +00:00
Arnaud Bienner fb36940d5e Add tooltip for cover manager's items, which displays artist and album name info. Fixes issue 451 2011-02-08 22:54:37 +00:00
Paweł Bara 4cd01a43b7 fixing names of all the 'add to playlist' items in context menus (Fixes issue #1421) 2011-02-08 22:42:09 +00:00
Paweł Bara 33276132ec when saving cover, start in the album's folder (just like with the similar 'load cover from disk' feature) 2011-02-07 23:53:32 +00:00
Paweł Bara 82e92bb3ac library view has now three modes: 'all songs', 'duplicates only' and new 'untagged songs only' (check out the http://code.google.com/p/clementine-player/wiki/LibraryViewModes) - fixes issue #305
+ hiding the 'complexity' of QueryOptions filter and query_mode mutual exclusion behind it's API
2011-02-06 13:18:18 +00:00
John Maguire 4fb6f92ad4 Fix compile warning on mac. 2011-02-04 15:25:05 +00:00
John Maguire 8a5455dc7e Fix UI file warnings. 2011-02-04 15:17:29 +00:00
John Maguire c680c55379 Fix a couple of warnings found by Clang. 2011-02-04 11:17:31 +00:00
Paweł Bara 77151d7ebd Hiding some of Song's cover art logic complexity in Song's API (namely: embedded and manually unset covers). 2011-02-02 21:01:08 +00:00
Paweł Bara 8aedda1795 moving the 'Save cover to file' action into AlbumCoverChoiceController; implementing the action in all related places (now playing widget, album cover manager, edit tag dialog)
now playing widget: disable all cover related context menu options (except for the 'save cover' one) when in 'Kittens' mode
2011-02-02 16:22:04 +00:00
Arnaud Bienner b52f3b6082 Improve track selection dialog: allow expanding, use linedit for filename and minor other modifications. Fixes issue 1392 2011-02-01 20:59:33 +00:00
John Maguire 9786570f35 Add support for saving album covers/kittens.
Fixes issue #1395
2011-01-31 20:53:38 +00:00
Paweł Bara 5b5d3f0c2e watch out for optional last.fm dependencies in AlbumCoverChoiceController -> fixes issue #1393
from the creators of "david is always right" movie -> maybe fix issue #1396
2011-01-31 15:21:32 +00:00
Paweł Bara 2959dbff85 'show duplicates only' view for library where you can see which songs in your library are duplicated and delete unnecessary duplicates (fixes issue #1328) 2011-01-30 21:00:49 +00:00
John Maguire 06c62f169f Set default mac sidebar to Large and allow building on mac without tunepimp & scripting. 2011-01-29 21:28:11 +00:00
Arnaud Bienner 9159e3c47e Oups... miss to also correct this 2011-01-29 16:11:20 +00:00
Arnaud Bienner 8b681a5dd2 Allow autotagging for non-library music files. Fixes issue 1389 2011-01-29 16:02:23 +00:00
Arnaud Bienner 05a4cae370 Add track seeking from playlistview 2011-01-26 23:20:56 +00:00
Paweł Bara 2fec795b89 fixed an error where entering the Cover Searcher dialog without query would make it show the busy indicator forever
further refactoring of album cover changes (QMenu in controller)
2011-01-25 23:33:27 +00:00
David Sansome 0beb12fc14 Add some options to control what happens when you double click or use the menu to add tracks to the playlist 2011-01-24 21:16:26 +00:00
John Maguire 2ad5acdd29 Move version information in to separate file to decrease churn on svn up.
Fix inverted error message for Avahi.
2011-01-24 20:45:15 +00:00
Paweł Bara 4a9d38bbdd final refactoring stage of cover changing code (common QAction*s)
reset URL in 'Cover from URL' dialog on reentrance
2011-01-24 18:32:09 +00:00
Paweł Bara ebfbdba8a9 further refactoring of cover changing code (saving covers in controller) 2011-01-24 17:53:31 +00:00
Arnaud Bienner 03df8195b0 Minors modification on TagFetcher. Fixes issue #1346 2011-01-24 17:03:36 +00:00
Paweł Bara 8bce92e69b refactoring the code that handles common UI album cover related actions into a common controller
fixes a bug where cancelling the 'cover from URL' dialog would set the cover to a previously chosen URL
2011-01-24 00:09:57 +00:00