3886f3d1e4
Fix socket leak in moodbarpipeline
...
Fixes #4663
When tearing down the pipeline, there was a leak of a GstBus which holds a socketpair open.
Eventually the OS runs out of file descriptors and terminates Clementine.
2014-12-22 16:13:44 -05:00
0a74c4cbff
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-12-22 10:01:26 +01:00
a6322da196
Fix header copyright tags in internet/
2014-12-19 00:47:55 +01:00
17c35e32e5
Fix header order in internet/
2014-12-19 00:40:30 +01:00
23ee9170b6
Fix header guards in internet/
2014-12-18 23:54:21 +01:00
fa9ea6ec5f
Fix compilation with moved files in internet/
2014-12-18 23:35:21 +01:00
93a286a272
Move files around and make subdirectories inside src/internet, move src/podcasts to src/internet
2014-12-18 00:39:20 +01:00
ff62032568
Various formating changes in src/internet
2014-12-17 22:36:27 +01:00
ad4bc3b88b
Cherry pick more make format changes src/podcasts
2014-12-16 14:59:17 +01:00
4fec417a93
Produce a proper url for date parse error
2014-12-16 13:14:56 +01:00
6851a15dc0
Merge pull request #4651 from sobkas/fix
...
Fix the parsing of some strange date formats in podcasts, and add a way to limit the number of podcast episodes shown, and hide listened podcasts. Fixes #3696 , fixes #3475
2014-12-16 12:33:50 +11:00
81537754e8
A better error url
2014-12-16 01:45:54 +01:00
943e79ebea
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-12-15 10:01:29 +01:00
ba1d73d1aa
Fix problems with code
2014-12-14 14:35:21 +01:00
bf55bc08fb
Cherry pick make format changes
2014-12-14 12:23:04 +01:00
6cc72e2f5d
Fix a date parser for one podcasts
2014-12-14 12:13:05 +01:00
958cb42e98
Allow to hide listened podcast episodes and show only n number of episodes.
...
Fixes #3696
Fixes #3475
2014-12-14 12:12:57 +01:00
946dc0ce3e
Merge pull request #4648 from sobkas/master
...
PodcastDownloader changes
2014-12-14 00:37:37 +01:00
a7e8c927f4
Now without sender
2014-12-13 20:06:39 +01:00
1922d51780
Fix header files order
2014-12-13 02:24:20 +01:00
418d65a1a7
Fix header files order
2014-12-13 02:05:08 +01:00
741bceab02
Ability to cancel downloads in progress
...
Fixes #3661
2014-12-12 19:38:29 +01:00
4b48be4a5b
Sort Grooveshark favorite songs according to "TSFavorited", as such songs have no "Sort" field.
...
BTW the compare was buggy (didn't compare against song2). This was OK though, as
we stable sort songs, and they are always ordered as far as I know (I remember
adding this sort just in case they will not be sent ordered on day).
2014-12-10 22:48:49 +01:00
a43a39b669
Fix errors, newline was here
2014-12-10 22:17:10 +01:00
3bdf765e3d
Fix errors, cherry picked make format fixes
2014-12-10 22:13:01 +01:00
8cbe742d9f
Fix errors, needed for a pull
2014-12-10 21:57:09 +01:00
2d2783ab04
Fix copyright notices
2014-12-10 01:25:52 +01:00
793ece163a
Fix copyright notices
2014-12-10 01:24:51 +01:00
a07f115088
Fix copyright notices
2014-12-10 01:23:43 +01:00
970e86aac5
Allows to download multiple podcasts at the same time
...
A new PodcastDeleter, it deletes podcast episodes
2014-12-10 00:47:52 +01:00
d1cad6cbc1
Remove podcast episode automatic deleter out of PodcastDownloader
2014-12-10 00:31:40 +01:00
fdd669360f
Merge pull request #4644 from sbird/fasterstartup
...
Patches to start clementine faster
2014-12-09 20:02:51 +01:00
3f9b5f4663
Do Podcast updates on song change off main thread
...
Each time the song is changed, the podcast backend checks whether the
new song is a podcast and, if so, mark it as listened to. This requires
1-2 db queries, so do it off the main thread.
Time to change song before: 300 ms
after: 50 ms usually, 80 ms sometimes
2014-12-09 12:49:24 -05:00
401f07c7cb
Avoid db commits during startup
...
When starting clementine, each playlist is loaded in turn.
When loading a playlist, the new tab order is committed to the db,
but we don't need to do that here because we know that once all the
playlists are loaded the tab order will be the same as it was initially.
This speeds startup substantially.
kstartperf:
Before: 3.5s
After: 1.5s
2014-12-09 12:48:53 -05:00
09e839353e
Speed up playlist restoring by moving sqlite query off main thread
...
The playlist fetching uses QtConcurrent to make the playlist on a
different thread (possibly concurrently for each item).
However, profiling reveals that the slow operation is fetching
the rows from the SQLite database, making this redundant.
Instead move the whole playlist loading, including the database access,
into a single function, and call that function in a different thread via
QtConcurrent::run.
This has the side effect of moving all the concurrent stuff from
PlaylistBackend into the callers.
kstartperf measures:
Before: 7.5s cold
3.6 s warm
After: ~4.0 s cold
3.5 s warm
2014-12-09 12:47:37 -05:00
8e0952e0b1
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-12-08 10:01:25 +01:00
0f1b29a523
Make sure SongSender is deleted when client disconnects.
2014-12-07 13:54:18 +01:00
16b2ac547c
Sort music brainz releases according to status
2014-12-06 17:54:13 +01:00
f34f868c0f
Add Spotify tracks to Spotify playlists by drag and drop
2014-12-03 23:58:09 +01:00
f7924905d2
Also add internet_service method for other search providers which have a internet services.
...
Shouldn't change anything in practice, but better to have items correctly inserted as Internet items FWIW. And will avoid other "custom context menu not working" issues if one day we implement one for
these services.
2014-12-03 22:33:29 +01:00
05d43e27a9
Add internet_service to SpotifySearchProvider so custom context menu is correctly shown on playlist items created from the global search
2014-12-03 22:27:43 +01:00
20e626a9ab
Merge pull request #4626 from ntrrgc/master
...
Fix #4420 : Previous track in dynamic random mix
2014-12-02 13:56:55 +00:00
f79b0c867c
Merge pull request #4628 from sobkas/master
...
Fixes for copyright notices, cpplint.py errors and misc.
2014-12-01 10:55:41 +00:00
dbe9f38dc8
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-12-01 10:01:25 +01:00
39e6d071f2
Merge pull request #4630 from Chocobozzz/xspfparser_fix
...
Fix accents issue in when save playlist in xspf format
2014-11-30 14:59:46 +00:00
4e32b36f59
Set ctime and mtime in Song returned by PodcastEpisode::ToSong
...
Fixes #4627,#4368
2014-11-30 15:49:13 +01:00
824526618c
Fix accents issue in when save playlist in xspf format
2014-11-30 10:36:36 +01:00
1cbe135a8d
Fix some errors in src/analyzers introduced while fixing cpplint.py errors
2014-11-29 21:05:59 +01:00
dc669eb603
Fix cpplint.py errors, fix copyright notices in src/analyzers, move src/core/fht* to src/analyzers
2014-11-29 20:07:01 +01:00
292fff7e3a
Fix #4420 : Previous track in dynamic random mix
2014-11-29 19:34:31 +01:00
64c34f58ae
Merge pull request #4608 from sobkas/src_core_fix
...
Fix the copyright info and formatting in src/podcast and src/core
2014-11-27 15:17:16 +01:00
154a1d3ebe
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-11-24 10:01:26 +01:00
ff91759b71
Fix Ubuntu PPA
...
Adds a missing check for libcdio.
Adds libcdio as a dependency for debian.
Fixes issue #4618
2014-11-19 15:45:05 +09:00
5e77aed01e
Cancel transcode when downloader disconnects.
2014-11-18 11:55:27 +01:00
8ac5d8e595
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-11-17 10:01:31 +01:00
880308c205
Remove async bus callback from transcoder. This caused the UI to get unresponsive after a song was converted.
...
A bit more information:
Normal transcoding worked fine, the transcoder object was in the main thread. In the network remote, a new transcoder object is created which runs in the network remote thread. When a song was transcoded there, the UI became unresponsive.
Removing the async bus callback solved the problem, exactly the g_source_remove() method caused it. Since the bus callback returned FALSE (GST_BUS_DROP), the watch was already removed. (See http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/GstBus.html#gst-bus-add-watch )
2014-11-14 23:50:59 +01:00
86a375f952
Send correct total file size if files were transcoded.
2014-11-14 17:53:25 +01:00
ff172f6ed4
Network remote can now transcode lossless files before sending them to the remote.
...
- It is configurable in the settings.
- Any format can be chosen that is supported by the transcoder.
- The status of the transcoder is send to the remote.
- Transcoder format settings have now a postfix so we can define mutliple transcoder formats and use them separatly. Here one for the normal transcoder and one for the network remote transcode. You can pass the postfix in the constructor.
- Fixed Transcoder crash (was introduced with the gstreamer1.0 merge, decodebin doesn't have a "new-decoded-pad").
- Transcoder emits the output filename as well on "JobComplete" signal
- Transcoder can now convert a file to a temporary file ("AddTemporaryJob")
2014-11-13 22:31:49 +01:00
8aa78af8f8
Save last used transcoder format with the mimetype instead of the extension.
...
ogg vorbis and ogg flac have the same extensions (*.ogg) and therefore the wrong item in the format combobox might be loaded.
2014-11-11 14:40:52 +01:00
9cdb31c2d8
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-11-10 10:01:29 +01:00
f150ad8971
Merge pull request #4600 from sobkas/master
...
Ability to automatically set podcast as listened
2014-11-06 12:21:07 +00:00
6efb5d05b7
Fix some problems
2014-11-05 17:48:04 +01:00
cabaaf3333
More copyright info fixes
2014-11-05 17:48:04 +01:00
130d3c72f0
More copyright info fixes
2014-11-05 17:48:04 +01:00
d775d72345
More copyright info fixes
2014-11-05 17:48:04 +01:00
39a3b46ead
More copyright info fixes
2014-11-05 17:48:04 +01:00
a85728dfb3
Fix some problems
2014-11-05 17:48:03 +01:00
011155a751
Fix copyright notices inside src/podcasts
2014-11-05 17:48:03 +01:00
c0614dbe09
Fix copyright notices inside src/core
2014-11-05 17:48:03 +01:00
0af1470cce
Clean up src/core
2014-11-05 17:48:03 +01:00
978a91442c
Connect signal to signal
2014-11-05 17:35:14 +01:00
8fba1c30f4
Make format
2014-11-05 13:05:58 +01:00
da99c55eed
Use constructor for QString
2014-11-05 12:25:55 +01:00
2e64b24290
Revert "Use constructor for QString and make format"
...
This reverts commit 5a2348fae6
2014-11-05 12:25:09 +01:00
5a2348fae6
Use constructor for QString and make format
2014-11-05 11:51:38 +01:00
5045f9b870
Don't use caller in OrganiseDialog
2014-11-05 02:37:44 +01:00
e4141dd862
Fix formating
2014-11-05 00:42:56 +01:00
b89c05048a
Move connect out of emitter
2014-11-05 00:42:56 +01:00
578c9ad598
Ability to automatically set podcast as listened after sucesfully sending it to a device
2014-11-05 00:42:55 +01:00
942fda88bf
Check if there is a current icon item in the device manager. Fixes #4604 #4555
2014-11-04 21:46:10 +01:00
797236fc60
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-11-03 10:01:27 +01:00
4f4c8f6894
Merge pull request #4580 from Chocobozzz/hide_internet_services
...
Hide internet services
2014-10-31 12:02:29 +01:00
a6514617cf
Merge pull request #4596 from Homulvas/master
...
Sorting by disc in advanced grouping
2014-10-29 18:00:51 +01:00
7c7e855e1a
correct formatting and some code cleanup
2014-10-29 16:45:52 +03:00
0a2a358d8b
"Green Day Problem" solved. Year-Album grouping also obeys grouping tag that allows to order albums released in the same year non-alphabetically
2014-10-29 15:29:45 +02:00
8406a47628
Merge branch 'master' of https://github.com/ivan-leontiev/Clementine
2014-10-29 01:40:01 +03:00
45a3f32c86
VkService: added albums support, added ability to fetch music from wall. Fixed
...
update bug.
2014-10-29 01:22:07 +03:00
3d124a2dea
encode "+" character in url in VkConnection::makeRequest
2014-10-28 20:12:01 +03:00
a2df43c830
Reverted changes amde to groupby_performer
2014-10-27 15:49:11 +02:00
7516438c8b
Added disc to the groupby interface. Replced groupby_performer to groupby_disc
2014-10-27 14:47:04 +02:00
5ec9dcdcb7
Merge pull request #4559 from TheUbuntuGuy/master
...
Fix missing buffers sent to analyzer
2014-10-27 22:17:14 +11:00
e222e1ad0d
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-10-27 10:01:31 +01:00
2208fa7d13
Add a source icon for CD tracks
2014-10-26 18:45:48 +01:00
baa0654b03
Try to fix minimal build
...
Maybe one day I will stop breaking it everytime I change something
2014-10-26 17:12:00 +01:00
7ac9e4c6d1
Fix a bug in InsertItems functions that makes Cdda tracks to not be saved/restored correctly when restarting Clementine
2014-10-26 17:08:12 +01:00
1779050fff
Add error message when MB disc id request fails
2014-10-26 17:07:29 +01:00
5a7c462fc3
Remove useless includes
2014-10-26 03:37:17 +01:00
dc0d3436c8
Finish CD integration update to Gstreamer 1.0
...
Move everything related to CDDA to a seperate class, so we can more easily reuse it in SongLoader
2014-10-26 03:32:37 +01:00
a8266173c5
Start to reactivate audio CD support
2014-10-26 00:28:03 +02:00
0b8e566544
Use utf8 for password instead of ascii
2014-10-24 13:12:50 +02:00
15a8af9bbb
Use hex in password auth for subsonic. Fixes #4589
2014-10-24 09:47:03 +02:00
33d38b94da
Use auto for iterator
2014-10-24 09:22:35 +02:00
1ad5884b39
Fix some minor C++ things in OutgoingDataCreator.
2014-10-23 18:07:39 +02:00
21551ca83c
Try to fix issue #4582
2014-10-21 21:54:46 +02:00
c43eb02efd
Android Remote: Add global search.
2014-10-21 18:07:02 +02:00
611d746855
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-10-20 10:02:20 +02:00
50b7b7d889
Make format after update to avoid conflicts
2014-10-15 21:57:57 +02:00
9770154b57
Merge remote-tracking branch 'upstream/master' into hide_internet_services
2014-10-15 21:55:09 +02:00
8279f21251
Revert "Make format"
...
This reverts commit 17b1e9fbe6
2014-10-15 21:55:03 +02:00
17b1e9fbe6
Make format
2014-10-15 20:55:24 +02:00
34a43635bd
Delete useless warning icon from internet show setting page
2014-10-15 20:51:09 +02:00
c54d1baf15
Allow user to hide internet services. Closes #2784
2014-10-15 20:44:09 +02:00
88a6300509
Completely revert the Spotify seeking stuff - it's hacky and I don't like
...
waiting 4 seconds to have my songs start. I'll reimplement it properly later.
Reverts commits 96387803cd160b151652
2014-10-14 19:33:03 +11:00
c428e536ab
When replacing a decodebin, offset the timestamps on the new element's buffers
...
so they match up with the buffers produced by the old element. Fixes #4542 .
2014-10-14 19:22:43 +11:00
bb439f61b9
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-10-13 10:01:36 +02:00
aa3671b54a
Merge pull request #4521 from Korvox/master
...
Add an option to pull all music files recursively into transcoding
2014-10-08 12:37:16 +02:00
78804b12c6
Use a save dialog option instead of quick change menu.
...
This is less confusing IMO. The dialog will shown up only if users decided to in the preferences, so that will not bother users who don't need this.
This reuses lot of things from Alan contribution from #4484
2014-10-07 00:29:46 +02:00
54d76506a7
Fix member not initialized in constructor.
...
Was init soon after anyway, but FWIW...
2014-10-07 00:29:46 +02:00
c69f2e5561
Reuse some work from Alan from pull request #4484
2014-10-07 00:29:46 +02:00
c35e573637
Missing things from previous commit
2014-10-07 00:29:46 +02:00
f6e6d3b937
Revert "Finished the changes to the quick change menu. Everything should work."
...
This reverts commit a468085c3a
2014-10-07 00:29:46 +02:00
f7d2dd94f9
Revert "Add a quick change menu to the playlist container."
...
This reverts commit 1cddc696ae
2014-10-07 00:29:46 +02:00
1ecee037c7
Fix moodbar segfault when playing broken mp3
...
When playing a broken mp3 (eg empty file) clementine crashed if moodbar
was enabled.
2014-10-06 15:40:10 +02:00
c0f4ab8591
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-10-06 10:01:33 +02:00
dba79a7e99
Revert "Add option to show year next to album name in library and global search."
...
This reverts commit e17fc06be1
2014-10-05 15:06:56 +02:00
e17fc06be1
Add option to show year next to album name in library and global search.
2014-10-05 14:14:24 +02:00
d32c3236ef
Fix little dropout when transition to next track. Updates #4542 .
...
SourceDrainedCallback() has a valid next url and calls TransitionToNext(). This sets a new decode bin for the pipeline. The pipeline then buffers the new track and sends GST_MESSAGE_BUFFERING. BufferingMessageReceived() then pauses the pipeline because it's buffering. But we are buffering the next track and not the current one, so the pipeline has still data and doesn't need to be paused.
2014-10-05 11:57:57 +02:00
37a6c125c0
Consider some more things as text (like numbers) when deciding if we should focus on the search bar
2014-10-04 18:08:53 +02:00
3be48f8f44
unref buffers going to analyser at the right time
...
This unrefs the buffer after the last chunk is pulled from it.
2014-10-04 10:39:33 -04:00
0b97a29aa1
Set log levels after commandline options are parsed. Fixes --verbose, --quiet and --log-levels
2014-10-04 21:22:29 +10:00
eec246718a
Fix track transitions with gstreamer-1.0. The segment-start event is now a stream-start bus message. Fixes #4542
2014-10-04 21:21:21 +10:00
e8c2b4b267
Fix missing buffers sent to analyzer
...
This is a regression in the upgrade to gstreamer1.0.
The gst_buffer_unref() is incorrect as it removes the buffer when it is still needed by the chunker.
Forcing the pointer to be null prevents it from segfaulting but causes it to skip all chunks in the buffer, dropping the framerate and causing a worse case of #4321 .
Removing these 2 lines restores original functionality.
2014-10-03 20:53:07 -04:00
51667c77ad
Update the database total size of Jamendo catalogue. Fixes #4554
2014-10-03 13:17:12 +02:00
66b2d996d3
Install qt framework Info.plists correctly.
2014-10-01 15:32:31 +02:00
b4784e82fd
Make Soup check SSL against our shipped root certs.
2014-10-01 15:06:22 +02:00
96387803cd
Disable this Spotify hack for now, as it is useless anyway.
...
Somewhat related to issue #4545 , but when plugin was installed by user wasn't logged in.
2014-09-30 21:35:27 +02:00
a667dceb29
Check if the blob is availabe in Spotify search provider.
2014-09-29 18:44:20 +02:00
40a5590108
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-09-29 10:01:34 +02:00
fdb88d4738
Fixed formatting for merge.
2014-09-28 19:34:28 -04:00
72cfa126ac
Fix a bug that makes Vk to be always displayed when trying to show any service's config.
...
Call stack: SettingsDialog::showEvent -> VkSettingsPage::Load -> VkService::ReloadSettings -> VkService::Logout -> VkService::UpdateRoot -> VkService::ShowConfig
Would probably be better to not call service in VkSettingsPage::Load and read QSettings only, but I don't think it's good either to call ShowConfig when user is being logged-out.
2014-09-28 02:13:56 +02:00
f81fa2d119
Add the ability to remove tracks from Spotify playlists
2014-09-28 02:00:32 +02:00
442d126b03
Hack to make the C++11 override keyword work with old compilers.
2014-09-26 20:33:02 +10:00
8b19b300b5
Stop using some C++11 features not supported by g++ 4.6.4 on Ubuntu 12.04
2014-09-26 11:43:54 +02:00
7b651136d8
Use the system's sha2 library if it's available. Fixes #4217
2014-09-25 23:51:46 +10:00
389d2972f5
Use decodebin in the transcoder (decodebin2 doesn't exist in gst-1.0).
2014-09-25 23:51:45 +10:00
3587e4197d
Renamed rootPath to just path, changed dialog message to reflect UI message.
2014-09-24 19:53:13 -04:00
e77c520ddd
Merge branch 'master' of github.com:clementine-player/Clementine
2014-09-22 22:43:15 +02:00
39db4dbefe
Add the ability to add a Spotify track to a Spotify playlist through context menu.
...
TODO: drag and drop (i.e. implement DropMimeData), update special playlist (Favorites), remove from playlist.
2014-09-22 22:40:21 +02:00
4bb3147006
Fix Spotify Blob installation promt. Fixes #4538 .
2014-09-22 21:20:48 +02:00
60d82e212d
Merge branch 'master' of github.com:clementine-player/Clementine
2014-09-22 19:32:18 +02:00
Mark Furneaux
Clementine Buildbot
Krzysztof Sobiecki
David Sansome
John Maguire
Arnaud Bienner
Simeon Bird
Andreas
Chocobozzz
Juan Luis Boya García
Ivan Leontiev
Ignas Kaziukenas
Alan Briolat
Pasi Saarinen
Mark Furneaux
Matthew Scheirer