Commit Graph

1882 Commits

Author SHA1 Message Date
Jonas Kvinge d936a080db Check for empty image 2021-03-24 22:30:37 +01:00
Jonas Kvinge 2a92af1e09 Change static_cast 2021-03-24 22:29:56 +01:00
Jonas Kvinge 9cde537066 Fix moodbar 2021-03-23 01:44:00 +01:00
Strawbs Bot ffc5446914 Update translations 2021-03-22 01:23:51 +01:00
Jonas Kvinge 5f70b32795 Remove unused using std::shared_ptr 2021-03-21 20:23:42 +01:00
Jonas Kvinge 6b6117653a Allow audio formats unsupported by taglib to be added
Fixes #669
2021-03-21 19:19:35 +01:00
Jonas Kvinge 59bffed47f Use static_cast 2021-03-21 18:53:02 +01:00
Jonas Kvinge f91a679cdf Add override 2021-03-21 18:40:33 +01:00
Jonas Kvinge 66b8d27d66 Change to QList 2021-03-21 06:26:48 +01:00
Jonas Kvinge 2436c87372 Use variable 2021-03-21 04:55:00 +01:00
Jonas Kvinge e90b5e63e5 Move variable 2021-03-21 04:49:22 +01:00
Jonas Kvinge 78588d8cdf Fix various clazy warnings 2021-03-21 04:47:11 +01:00
Jonas Kvinge 20c1c1d4be Remove unused variables 2021-03-21 04:43:55 +01:00
Jonas Kvinge 329dfb21b9 These don't need to be slots 2021-03-21 04:38:47 +01:00
Jonas Kvinge 20c5a79efa Fix playlist tabbar close and save 2021-03-21 04:28:22 +01:00
Jonas Kvinge b224aeb0d8 Use 4arg connects for networkreplies 2021-03-21 00:37:17 +01:00
Jonas Kvinge 73eebd6162 Set album cover filename by pattern as default when saving cover to album directory 2021-03-20 23:13:54 +01:00
Strawbs Bot 99a1851f4d Update translations 2021-03-20 23:02:12 +01:00
Jonas Kvinge 54f2aa5f77 Update copyrights 2021-03-20 21:14:47 +01:00
Jonas Kvinge d022e9dd00 Close the file 2021-03-20 19:23:33 +01:00
Jonas Kvinge 17cf8ec1c6 Move declaration 2021-03-20 19:11:05 +01:00
Jonas Kvinge c4a6d81cda Fix copying album covers to iPod
Cover file was deleted too soon.
File needs to be accessible until itdb_write is called.

Fixes #663
2021-03-20 19:00:42 +01:00
Jonas Kvinge 66ed485803 Check for existence of directory 2021-03-20 18:58:38 +01:00
Jonas Kvinge 6de585d1c8 Make sure process files isn't again called after finishing 2021-03-20 15:22:21 +01:00
Jonas Kvinge a7df2bc4fb Use original file when loading cover from file in album cover manager 2021-03-16 17:18:11 +01:00
Jonas Kvinge 5eda028af3 Minor code improvements to album cover loader 2021-03-16 17:17:22 +01:00
Jonas Kvinge f77475dbfe Specifically set get image 2021-03-16 17:16:40 +01:00
Jonas Kvinge 0ef26be03f Remove DEBUG define 2021-03-16 17:12:44 +01:00
Jonas Kvinge f5bb15f72e Fix QSearchField on macOS 2021-03-15 22:38:06 +01:00
Jonas Kvinge d84aebd8f4 Format code 2021-03-15 22:37:49 +01:00
Jonas Kvinge 7d8d9f4c4d Format code 2021-03-14 23:20:16 +01:00
Jonas Kvinge 61b201810d Fix marking songs available 2021-03-14 23:08:05 +01:00
Jonas Kvinge 88797424f1 Ignore empty lyrics from musixmatch 2021-03-13 15:58:34 +01:00
Jonas Kvinge 2695169514 Add type to metadata bundle to avoid updating previous song when it shouldn't 2021-03-13 03:14:30 +01:00
Jonas Kvinge efcdfdf612 Remove unused include for macOS 2021-03-13 02:00:38 +01:00
Jonas Kvinge f77e7334c5 Set album cover loader options in edit tag dialog 2021-03-13 01:52:37 +01:00
Jonas Kvinge 9079a7988c Turn off frame in edit tag dialog 2021-03-13 01:43:30 +01:00
Jonas Kvinge 5256d795b1 Fix tagreader process not starting on Windows in release build 2021-03-09 22:45:15 +01:00
Strawbs Bot 24a765814a Update translations 2021-03-08 01:12:33 +01:00
Jonas Kvinge ef18a00362 Use mouse event variable 2021-03-07 23:26:08 +01:00
Jonas Kvinge 1823786344 Show fullsize cover on doubleclick in edit tag dialog 2021-03-07 23:23:58 +01:00
Jonas Kvinge 548a1f30ca Support saving by filename in SaveAndSetCover 2021-03-07 23:03:02 +01:00
Jonas Kvinge e63859442a Ignore drop event in album cover manager
Fixes strange case where albums are duplicated by drag/drop.
2021-03-07 22:59:08 +01:00
Jonas Kvinge 69032db3c3 Remove unused function 2021-03-07 07:20:29 +01:00
Jonas Kvinge d3e5b1b4e0 Move comment 2021-03-07 07:05:02 +01:00
Jonas Kvinge e2cd68e3e8 Fix saving existing cover from file embedded for multiple albums 2021-03-07 07:01:22 +01:00
Jonas Kvinge 3e6029d33c Clear art automatic when embedded cover is deleted 2021-03-07 05:43:56 +01:00
Jonas Kvinge 89f1f8e6dc Check for empty art automatic 2021-03-07 05:41:49 +01:00
Jonas Kvinge cff25374b5 Fix collection update for art_manual 2021-03-07 05:37:07 +01:00
Jonas Kvinge 04bbff338d Fix deleting multiple covers in album cover manager 2021-03-07 03:43:49 +01:00
Jonas Kvinge bbcd6a3261 Fix saving empty cleared cover 2021-03-07 03:42:11 +01:00
Jonas Kvinge e587e8cfc8 Use original file when loading cover from file in tag editor 2021-03-07 02:36:50 +01:00
Jonas Kvinge 869f8cf380 Enable cover actions based on current cover 2021-03-07 02:34:17 +01:00
Jonas Kvinge 1ff6ba9480 Only enable album cover options for collection songs 2021-03-07 01:49:38 +01:00
Jonas Kvinge 5807bee23b Load album cover controller settings when album cover manager is opened 2021-03-07 00:54:20 +01:00
Jonas Kvinge b5bafbf23a Lowercase file extension 2021-03-07 00:53:33 +01:00
Strawbs Bot 24eb9d9e14 Update translations 2021-03-04 23:01:42 +01:00
Jonas Kvinge 7b2411eec5 Change to info log 2021-03-04 01:14:06 +01:00
Jonas Kvinge 32b94555c3 Remove 3rdparty taglib 2021-02-27 16:55:41 +01:00
Jonas Kvinge d5caff58c7 Fix cover delete in edit tag dialog 2021-02-27 02:12:26 +01:00
Jonas Kvinge ab4c725217 Fix embedded album cover default in edit tag dialog 2021-02-27 01:32:45 +01:00
Jonas Kvinge 901ba9cf13 Add QMap include 2021-02-27 01:02:37 +01:00
Jonas Kvinge 19b1bc6b3e Fix saving cover for multiple albums 2021-02-27 00:58:43 +01:00
Jonas Kvinge c623ea7c2a Use reference 2021-02-26 23:10:36 +01:00
Jonas Kvinge 72e61106a9 Remove unused include 2021-02-26 22:15:04 +01:00
Jonas Kvinge e15e7f0942 Fix compile with Qt 5
Forgot to test the changes from the last commit with Qt 5
2021-02-26 22:01:45 +01:00
Jonas Kvinge 133f094d72 Add support for saving embedded album covers
Fixes #286
2021-02-26 21:03:51 +01:00
Jonas Kvinge 193cf1c750 Rename protobuf namespace
Fixes #654
2021-02-20 17:06:55 +01:00
Jonas Kvinge 0ab214fd5d Add methods to tagreader for saving embedded art 2021-02-16 22:50:35 +01:00
Strawbsbot 3ff97e43e1 Update translations 2021-02-15 10:15:23 +01:00
Jonas Kvinge 29e8316527 Add missing static_cast 2021-02-11 22:33:54 +01:00
Jonas Kvinge 2b988b8ab1 Handle more gstreamer errors as non-fatal
Adds GST_RESOURCE_ERROR_OPEN_READ and GST_STREAM_ERROR_TYPE_NOT_FOUND

Fixes #648
2021-02-11 22:23:54 +01:00
Jonas Kvinge 7fc5b70553 Remove const reference from signals 2021-02-10 18:32:10 +01:00
Jonas Kvinge b3681002a7 Change int to qint64 2021-02-10 18:27:40 +01:00
Strawbsbot 1f9af7a1e4 Update translations 2021-02-06 03:54:07 +01:00
Jonas Kvinge 9ed184edbf Simplify code 2021-02-06 00:32:01 +01:00
Jonas Kvinge 89572b07fb Remove default argument 2021-02-06 00:30:40 +01:00
Gavin Howard 0f96daec9a
Fix playlist saving
The fix came from a suggestion by Jonas; I just tested it.
2021-02-03 16:38:24 -07:00
Strawbs Bot 59412c54de Update translations 2021-02-03 01:15:47 +01:00
Jonas Kvinge 03959a68d5 Formatting 2021-02-02 21:08:58 +01:00
Jonas Kvinge 59b48ceb4a Use std::make_shared 2021-02-02 21:08:12 +01:00
Strawbs Bot d499bfab8a Update translations 2021-02-02 01:02:36 +01:00
Strawbs Bot b7b2b5089f Update translations 2021-02-01 01:43:46 +01:00
Jonas Kvinge fcb417af17 Fix 'Except between tracks on the same album' backend fade option
Fixes #642
2021-01-30 23:16:19 +01:00
Jonas Kvinge 28c130a910 Add this as context to lambda connection 2021-01-30 22:42:21 +01:00
Jonas Kvinge 57a5eabd8f Use this and watcher instead of = 2021-01-30 22:41:57 +01:00
Jonas Kvinge 88874f0dcd Remove NewClosure 2021-01-30 21:53:53 +01:00
Jonas Kvinge 98d5e27a8c Remove use of NewClosure for playback resume 2021-01-30 21:52:17 +01:00
Jonas Kvinge 576956fa1d Use QTimer::singleShot directly for database backup 2021-01-30 21:51:32 +01:00
Jonas Kvinge be051a4bb1 Use timers for submitting scrobbles 2021-01-30 21:50:28 +01:00
Jonas Kvinge cc6c7430d4 Use a QTimer for writing scrobbler cache 2021-01-30 21:48:45 +01:00
Jonas Kvinge 2539b2333c Use new connect syntax in global shortcuts manager 2021-01-30 14:28:03 +01:00
Jonas Kvinge 60528525e0 Use QObject::connect() everywhere for consistency 2021-01-29 18:53:20 +01:00
Jonas Kvinge cb5a7f8c9d Replace NewClosure with lamdas 2021-01-29 18:47:50 +01:00
Jonas Kvinge fd9c6d460a Fix lamda connect for audio CD tracks load finished 2021-01-29 18:45:09 +01:00
Jonas Kvinge 9f5249e5b8 Make playlist moodbar column respect moodbar enabled setting 2021-01-28 21:43:06 +01:00
Jonas Kvinge 819800d3a4 Revert some lambda connects back to NewClosure 2021-01-28 21:22:50 +01:00
Jonas Kvinge daff2c1f84 Add option to append explicit to album titles for Tidal 2021-01-28 19:55:28 +01:00
Strawbs Bot a0e030a6ee Update translations 2021-01-28 01:02:00 +01:00
Strawbs Bot 690eb343ea Update translations 2021-01-27 01:22:31 +01:00
Jonas Kvinge ad5e476920 Fix compile without moodbar
Fixes #638
2021-01-26 22:34:31 +01:00
Jonas Kvinge 2a92ce867a Rename global shortcuts classes 2021-01-26 20:48:51 +01:00
Jonas Kvinge bf7c8df353
Connection syntax migration (#637) 2021-01-26 16:48:04 +01:00
Strawbs Bot d57f6303f4 Update translations 2021-01-26 01:02:23 +01:00
Jonas Kvinge 9c6c26f424 Delete TagCompletionModel 2021-01-26 00:40:06 +01:00
Jonas Kvinge 50d83dc070 Fix memory leak when moodbar is disabled
Only call MoodbarLoader::Load when moodbar is enabled.
2021-01-25 22:35:56 +01:00
Jonas Kvinge 010a0cc2a7 Fix playlist filter with Qt 6 2021-01-20 20:18:29 +01:00
Strawbs Bot fc1537fde8 Update translations 2021-01-17 01:02:48 +01:00
Jonas Kvinge 6e40f639b7 Turn off undo/redo stack for QTextDocument in playwidget details 2021-01-16 03:12:34 +01:00
Jonas Kvinge 21c5a97d15 Fix total album count 2021-01-15 21:17:32 +01:00
Strawbs Bot 001964f2f4 Update translations 2021-01-13 01:10:30 +01:00
Jonas Kvinge a6a29d5c5a Set limits for collection pixmap cache based on size unit 2021-01-12 20:36:10 +01:00
Jonas Kvinge 72b194cd7e Rename network to networkaccessmanager 2021-01-11 16:48:46 +01:00
Jonas Kvinge b85819ed9d Decode HTML entities in lyrics 2021-01-11 16:05:39 +01:00
Strawbs Bot c5cd648b5d Update translations 2021-01-11 01:02:20 +01:00
Strawbs Bot 3743408543 Update translations 2021-01-10 01:05:51 +01:00
Jonas Kvinge fd251c6e61 Use helper function for collection model container keys 2021-01-09 21:03:35 +01:00
Strawbs Bot b7ab6c5c3e Update translations 2021-01-09 01:02:46 +01:00
Jonas Kvinge 5659fd5839 Use mimetype instead of description from stream discoverer when available 2021-01-08 22:38:37 +01:00
Jonas Kvinge 4dcd3e95df Append album ID to collection model container nodes 2021-01-08 22:35:07 +01:00
Mikalai Daronin 57709413e1
Add SPMediaKeyTap back (#621) 2021-01-06 14:46:21 +01:00
Jonas Kvinge fb634bc2d4 Let watcher handle update of collection songs when organizing
Fixes bug duplicating songs in the db when moving songs across collection id's.

Fixes #623
2021-01-05 22:14:18 +01:00
Edgar Salgado 18a67e1f20
Last.fm last played date import: change date if it is newer than the … (#625)
* Last.fm last played date import: change date if it is newer than the one in database

* Last.fm lastplayed: make it more consistent with the code
2021-01-04 20:43:43 +01:00
Strawbs Bot b4c2ae251b Update translations 2020-12-30 01:07:43 +01:00
Jonas Kvinge bfaabafbfa Remove some unused utilities functions 2020-12-29 23:13:22 +01:00
Jonas Kvinge 8ea359ec8a Pass char16_t to QString::fromUtf16() 2020-12-28 20:33:09 +01:00
Strawbs Bot c983c8e447 Update translations 2020-12-27 01:02:06 +01:00
Strawbs Bot af96ce3e82 Update translations 2020-12-26 01:02:38 +01:00
Strawbs Bot 6a5928863c Update translations 2020-12-25 01:08:33 +01:00
Jonas Kvinge cb5222e4d6 Fix albumcover searcher dialog not showing up on macOS 2020-12-24 16:56:00 +01:00
Jonas Kvinge fa0fd6b7d0 Ignore deprecated QString::fromUtf16() 2020-12-24 15:23:35 +01:00
Jonas Kvinge 057ec49a3e Remove hack in MergedProxyModel and use QAbstractProxyModel::modelAboutToBeReset() 2020-12-24 12:33:05 +01:00
Jonas Kvinge 3ae9092226 Prefer native notifications instead of D-Bus on macOS 2020-12-23 20:25:23 +01:00
Jonas Kvinge 351999a01b Use setContentsMargins 2020-12-23 20:24:37 +01:00
Jonas Kvinge e407080057 Remove explicit for song 2020-12-23 20:24:15 +01:00
Strawbs Bot 9b5fdb1345 Update translations 2020-12-23 01:02:31 +01:00
Jonas Kvinge 47fd30c23f Ignore NSUserNotificationCenter deprecation 2020-12-22 20:37:39 +01:00
Strawbs Bot 0af767fff0 Update translations 2020-12-22 01:06:44 +01:00
Strawbs Bot a928aa61ca Update translations 2020-12-21 01:02:14 +01:00
Jonas Kvinge 30cb0b1cae QNetworkRequest::Http2AllowedAttribute require Qt 5.15 2020-12-20 07:42:14 +01:00
Jonas Kvinge 32ae3cd567 QNetworkRequest::Http2AllowedAttribute require Qt 5.14 2020-12-20 07:24:44 +01:00
Jonas Kvinge 91b9602e12 Dont use empty lyrics from API 2020-12-20 07:09:12 +01:00
Jonas Kvinge a5ab8ddf8b Disable http2 for musixmatch 2020-12-20 06:51:36 +01:00
Jonas Kvinge 1444a1578a Search all unicode letters in musixmatch cover search 2020-12-20 06:40:45 +01:00
Jonas Kvinge 5b8894b0ff Search all unicode letters in musixmatch lyrics search 2020-12-20 06:16:08 +01:00
Strawbs Bot a4329dd9a0 Update translations 2020-12-20 01:02:08 +01:00
Jonas Kvinge e78bb1b29c Use directsoundsink by default because of buggy wasapi plugin 2020-12-13 21:56:25 +01:00
Strawbs Bot db312a7380 Update translations 2020-12-13 01:02:57 +01:00
Jonas Kvinge 128935b55e Use LPCSTR in RegisterWindowMessageA 2020-12-12 12:51:01 +01:00
Jonas Kvinge d5a0d67c7b Use ScopedWCharArray 2020-12-12 12:50:33 +01:00