Commit Graph

6285 Commits

Author SHA1 Message Date
John Maguire 4cbe098b83 Fix memory leak in Amazon Cloud Drive. 2015-04-27 14:02:07 +01:00
John Maguire 8d2e3373a8 Use a GTlsDatabase for gstreamer SSL on mac. 2015-04-27 11:21:22 +01:00
John Maguire c3e88aced5 Update root certs file for mac 2015-04-27 11:21:22 +01:00
Clementine Buildbot 2da11e0d90 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-04-27 10:01:21 +02:00
Arnaud Bienner 44cd2f916c Merge branch 'alphapapa-read-new-ratings-from-files' 2015-04-25 18:33:29 +02:00
Adam Porter bb5a952e25 Re-read FMPS_Rating from file when changed
When the FMPS_Rating changes in a file, Clementine will now re-read it
and change the rating in the library database.  This lets you modify
song ratings outside of Clementine and then load the new ratings into
Clementine.  Previously Clementine would ignore changed ratings in a
file's metadata after a song had been scanned into the library.
2015-04-25 18:32:34 +02:00
Arnaud Bienner 20583b8b0a Correct typo 2015-04-25 18:01:32 +02:00
ArnaudBienner c7416cbfb5 Merge pull request #4599 from cincodenada/spotify-improvements
Improve handling of Spotify Top Tracks and compilations
2015-04-25 17:59:27 +02:00
Arnaud Bienner 99521ac15f Add missing certificate for api.soundcloud.com
Fixes #4794.
2015-04-25 17:51:08 +02:00
Andreas a0f24dff86 Network remote: Only start transcoder when we actually have something to transcode. 2015-04-24 17:43:18 +02:00
Andreas c152bc26d9 Network remote: Don't send downloader the first data since it's not needed. 2015-04-24 17:30:21 +02:00
Andreas 136fca6dc2 Network remote: Send filesize on songoffer. 2015-04-24 17:24:14 +02:00
Andreas d93917ce9b Network remote: Send song url as well. 2015-04-24 15:35:18 +02:00
Andreas c9b39e7c83 Fix crash when trying to download a track, but there is no current one playing. 2015-04-24 15:31:09 +02:00
John Maguire 30346e7810 Fix missing gst_buffer_unref.
Fixes #4823
2015-04-23 11:25:34 +01:00
ArnaudBienner 8a21078ae3 Merge pull request #4821 from Chocobozzz/master
Modify icon name of .protocol and .desktop too
2015-04-22 10:47:14 +02:00
Chocobozzz a07ff98456 Modify icon name of .protocol and .desktop too 2015-04-22 08:45:18 +02:00
John Maguire 766ba2ad89 Merge pull request #4816 from Chocobozzz/icons
Add 128x128 icon of Clementine and change the icons name
2015-04-20 17:18:42 +01:00
Chocobozzz 26718c777a Add 128x128 icon of Clementine and change the icons name 2015-04-20 18:06:34 +02:00
Clementine Buildbot d55628a1e8 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-04-20 10:01:18 +02:00
Joel Bradshaw 0cc7801d33 Add comments and declare `artist` in tighter scope 2015-04-19 21:05:55 -07:00
Joel Bradshaw ddd641b1ae Improve handling of Spotify Top Tracks and compilations
Two improvements to handling of Spotify albums:
 - Remove single-track results if they also show up in the album
results.  This eliminates duplicates showing up in albums.
 - For each album, choose the majority artist attribution to
specify as the Album Artist.  For users who group by Album Artist,
this prevents splitting albums into multiple entries when there
are contributing artists.

Squashes following commits:

    commit d8bf17e13f50c7642ba491228f31608f4861d3b6
    Author: Joel Bradshaw <cincodenada@gmail.com>
    Date:   Tue Oct 28 19:56:36 2014 -0700

        Improve handling of Spotify Top Tracks and compilations

        Two improvements to handling of Spotify albums:
         - Combine individual tracks into a "Top Tracks" album by just
        setting the album name to "Top Tracks"
         - For each album, choose the majority artist attribution to
        specify as the Album Artist.  For users who group by Album Artist,
        this prevents splitting albums into multiple entries when there
        is a contributing artist.

    commit 228650a1d7122e5d1947133ba793afaffaa69cb4
    Author: Joel Bradshaw <cincodenada@gmail.com>
    Date:   Wed Oct 29 10:00:21 2014 -0700

        Style cleanup, including run of make format

        Also wrapped Top Tracks with tr()

    commit a4f6c1ecd9bcc8338a956b1a45c2f184ee9d660d
    Author: Joel Bradshaw <cincodenada@gmail.com>
    Date:   Sun Feb 15 13:38:52 2015 -0800

        Simply remove duplicate entries from the "Top Tracks" section

        Don't create the fake "Top Tracks" album, but remove entries
        from it if they show up in the album results.  This will
        eliminate the main problem - duplicates showing up in albums -
        and avoid issues with actual single-track results showing up
        erroneously as "Top Tracks"

    commit 859abc93b3491cc526d89df19a85dc4cf9bce1c8
    Author: Joel Bradshaw <cincodenada@gmail.com>
    Date:   Sat Apr 18 09:17:50 2015 -0700

        Clean up stray f and make format

    commit 333de1c4aa947c7cbe785429565bf4f08f98d476
    Author: Joel Bradshjaw <cincodenada@gmail.com>
    Date:   Sat Apr 18 09:19:10 2015 -0700

        Update majority_count so it works

        Fixes issue with it just picking the last artist on the album
        as the album artist
2015-04-18 09:23:45 -07:00
Andreas d2bb07ead6 Fix writing install dir reg key. 2015-04-17 21:49:25 +02:00
Andreas 9deb331399 Remember last install dir on windows. Fixes #4806 2015-04-17 15:27:19 +02:00
Andreas d7a01c403e Add lyrics field to jamendo db. 2015-04-17 15:11:16 +02:00
John Maguire e142bcaa21 Remove extraneous logging. 2015-04-17 12:13:27 +01:00
John Maguire aa22a43f44 Add exponential back-off to Amazon requests. 2015-04-17 12:10:40 +01:00
John Maguire e59ab5fa27 Comply with Amazon Cloud Drive branding guidelines. 2015-04-16 15:57:54 +01:00
Clementine Buildbot 6ecd47011a Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-04-13 10:01:20 +02:00
Andreas 10980280cc Merge pull request #4801 from Wuerstchen/patch-1
Update "Report a bug" in README.md
2015-04-11 15:03:29 +02:00
Wuerstchen c0b345a64f Update README.md
Fixed some typos/mistakes and improved readability
2015-04-11 14:49:57 +02:00
Andreas ec35688c86 Fix crash when stopping a track while a fadeout to pause is occuring. Fixes #4800. 2015-04-11 11:30:28 +02:00
Andreas 11d2702841 Try fixing buildbot. 2015-04-10 22:59:35 +02:00
Andreas 25e73d5714 Merge pull request #4679 from TheUbuntuGuy/master
Do not remove currently playing track when repopulating a dynamic playlist
2015-04-10 22:41:44 +02:00
Andreas cbbe7db5f2 Merge pull request #4784 from M-Bab/master
Added support to read/display the ID tag lyrics in MP3 files:
2015-04-10 22:29:30 +02:00
Martin Babutzka 258ae281d8 IDv3 tag lyrics support.
Squashed the following commits:

5c723ad commit: Fix: Includes alpha sort
15ac350 commit: Fix: Updated Database::kSchemaVersion to 49.
767a26a commit: Fixed small code style issue. Added schema-49 to data.qrc instead schema-48
bf6aa64 commit: fixup! Modified async handling of CollapsibleInfoPane as recommended by Andreas. Display of IDv2 tag lyrics works now.
c1f97e9 commit: fixup! Added support to read/display the ID tag lyrics in MP3 files:
c946b1d commit: Added support to read/display the ID tag lyrics in MP3 files:

-Added schema to the database to store it
-Added readers/writers for ID tags
-Added readers/writers for the database to the song class
-Added the taglyricsinfoprovider to show the lyrics in songinfo
2015-04-10 21:05:07 +02:00
Clementine Buildbot f533b2998c Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-04-06 10:01:21 +02:00
Arnaud Bienner 34d3d7671d Oops: missed label 2015-04-01 14:07:58 +02:00
Arnaud Bienner 8bd97a1d38 Windows: check if there is already a previous install of Clementine and if so, ask the user if he wants to run the uninstaller. Running the installer will kill any running instance of Clementine, preventing installation issues because the files are used by this process and thus cannot be overwritten. 2015-04-01 11:41:05 +02:00
Arnaud Bienner ccf5bffd99 Oops, this should just be a comment (remove warning) 2015-03-30 18:34:45 +02:00
Clementine Buildbot 82df087a83 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-03-30 10:01:17 +02:00
Arnaud Bienner 9877ac49fa Use Alt+Tab to switch between playlist tabs on OS X, as Cmd+Tab is already used by default for switching applications 2015-03-28 17:18:22 +01:00
John Maguire 8d3fd00956 Amazon Cloud Drive support.
Squashed commit of the following:

commit 451a327fabb5f9aba077d93a33d75d8a6a288f5f
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:55:36 2015 +0100

    Revert debug console changes.

commit 52f643c3dc524a837f56268b6da4881187204165
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:49:28 2015 +0100

    Revert extra logging

commit 23645f9fea
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:47:55 2015 +0100

    How did you get there

commit 8153388f19
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:45:12 2015 +0100

    Update copyright headers.

commit fa9e279259
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:43:27 2015 +0100

    Remove logging

commit 47a405543c
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:42:05 2015 +0100

    Show login state correctly for Amazon.

commit 748d88d993
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:28:55 2015 +0100

    Ensure Amazon is connected before serving URLs.

commit 25ec9c65f4
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:22:28 2015 +0100

    Refresh Amazon authorisation & follow changes.

commit 27c1a37173
Author: John Maguire <john.maguire@gmail.com>
Date:   Thu Mar 26 18:27:27 2015 +0100

    Revert unneeded OAuthenticator change.

commit 3594af5be1
Author: John Maguire <john.maguire@gmail.com>
Date:   Thu Mar 26 16:52:19 2015 +0100

    Initial support for Amazon Cloud Drive.
2015-03-27 14:56:08 +01:00
Arnaud Bienner f3426c05c7 Don't call gst_deinit when exiting Clementine.
It sometimes cause a deadlock since we migrated to GStreamer 1.0.
And it seems we shouldn't need to call it as we are "a normal application":
http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/gstreamer-Gst.html#gst-deinit
2015-03-25 22:23:13 +01:00
Arnaud Bienner 7ae9e0dd9b Set starting_up_ to false in playlist container when manager is done adding playlists.
Otherwise, it was never set to false at startup if no "current_playlist" was saved in the settings, then there was no new value saved for "current_playlist".
Fixes #4011.
2015-03-25 22:13:39 +01:00
John Maguire d2ca9ac6ee Merge pull request #4785 from ivan-leontiev/fix-networkremote-memleak
Fix memory leak in networkremote.
2015-03-24 12:19:24 +01:00
Ivan Leontiev aba0517b4c Fix memory leak in networkremote. 2015-03-24 09:22:02 +00:00
Clementine Buildbot 791aa482c2 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2015-03-23 10:01:17 +01:00
John Maguire c553249684 Merge pull request #4779 from Chocobozzz/readme
Add "opening issue" to the README
2015-03-18 19:28:50 +01:00
Chocobozzz a2f86e02d2 Update readme with "opening an issue" informations 2015-03-18 19:03:37 +01:00