dmdmdm
d9fa56c179
Share the love: Minor corrections
2020-07-30 18:24:58 +01:00
dmdmdm
acb75a5099
Share the love
2020-07-30 18:24:58 +01:00
dmdmdm
75264f314d
Share the love
2020-07-30 18:24:58 +01:00
Keshav Kini
68d375c43c
Use effective album artist for Repeat Album logic
...
When there is album artist information available for a track, the user would
probably expect that "Repeat Album" should cycle through all songs with the same
album artist and album title, not only all songs with the same artist and album
title.
2020-07-20 10:45:49 +01:00
Clementine Buildbot
ee72793b5f
Automatic merge of translations from Transifex
2020-07-17 02:29:12 +00:00
Jim Broadus
987fe047c6
Fix access past end of vector in getPsychedelicColor
2020-07-13 15:07:02 +01:00
Jim Broadus
1f7607b1db
Get backend from application in PlaylistContainer::SetApplication
...
The manager's library backend may not be set when this is called.
2020-07-12 09:44:47 +01:00
Clementine Buildbot
dd9ed23345
Automatic merge of translations from Transifex
2020-07-11 02:27:49 +00:00
Jim Broadus
c75fa0077e
Fix playlist memory leak
...
When the current playlist is changed, PlaylistContainer::SetViewModel is called
to set the new list. This calls PlaylistView::SetItemDelegates, which allocates
several objects that are never freed. Instead, move the call to SetItemDelegates
to PlaylistContainer::SetApplication, which is only called once.
2020-07-10 10:28:19 +01:00
Clementine Buildbot
3bfaf3ff38
Automatic merge of translations from Transifex
2020-07-09 02:28:42 +00:00
dmdmdm
834b1d4514
Changed local variable names to be like_this
2020-07-08 18:01:59 +01:00
dmdmdm
0ff11ee2e0
Autoformated code
2020-07-08 18:01:59 +01:00
dmdmdm
d3a28a40ed
Shortened a line
2020-07-08 18:01:59 +01:00
dmdmdm
2c5c30de15
Guess album name from folder name
2020-07-08 18:01:59 +01:00
Mattias Andersson
ebf9ebf080
Show only a basic tooltip in the system tray
...
For environments that implements the D-Bus
http://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/StatusNotifierItem
specification HTML is not supported in the tool tip title. (It is
supported in the tool tip subtitle but this field is not set by
QSystemTrayIcon.)
See the discussion in #6733 for more info.
2020-07-08 17:24:42 +01:00
Jim Broadus
7d28e8700b
Call SettingsPage::showEvent from child class implementations
2020-07-07 10:35:02 +01:00
Clementine Buildbot
0fcb1df200
Automatic merge of translations from Transifex
2020-06-28 02:29:27 +00:00
Jim Broadus
ad882cc999
Add static IsTypeSupported methods to playlist item classes
2020-06-23 11:06:06 +01:00
Jim Broadus
9455a3ef79
Use IsLocalLibraryItem instead of comparing type string
2020-06-23 11:06:06 +01:00
Clementine Buildbot
cf279e6f48
Automatic merge of translations from Transifex
2020-06-21 02:27:27 +00:00
Jim Broadus
76a24a0a28
Use DbPlaylistItem base class for Jamendo and Magnatune
...
Moving these from LibraryPlaylistItem removes local file specific
implementations of IsLocalLibraryItem and Reload. Returning true for
IsLocalLibraryItem caused ratings to be set on unrelated library songs.
2020-06-19 11:18:32 +01:00
Jim Broadus
f563b7da40
Add DbPlaylistItem base class to LibraryPlaylistItem
...
This will be used to move items from non-library databases away from the
LibraryPlaylistItem class.
2020-06-19 11:18:32 +01:00
Jim Broadus
247cc8f715
Add missing playlistitem.h to CMakeLists.txt
2020-06-19 11:18:32 +01:00
Clementine Buildbot
8c25c443cd
Automatic merge of translations from Transifex
2020-06-19 02:28:31 +00:00
Jim Broadus
0d25a1b39c
Properly delete ignored DeviceInfo object
...
Since the SimpleTreeItem constructor variant used from LoadAllDevices adds the
object to the parent's children list, use the parent's Delete method to destroy
it.
2020-06-19 00:10:54 +01:00
Clementine Buildbot
1ef5ec2590
Automatic merge of translations from Transifex
2020-06-18 02:27:25 +00:00
Clementine Buildbot
06544054a6
Automatic merge of translations from Transifex
2020-06-15 02:27:43 +00:00
John Maguire
edb8c3b4ed
Update link to latest builds
2020-06-13 19:49:36 +01:00
Clementine Buildbot
56ed6d4f7e
Automatic merge of translations from Transifex
2020-06-12 02:27:47 +00:00
Clementine Buildbot
6900197a8c
Automatic merge of translations from Transifex
2020-06-10 02:28:25 +00:00
Jim Broadus
cf8d2004bd
Use deleteLater to destroy device backends
2020-06-07 14:46:13 +01:00
Jim Broadus
c299c198de
organise: Update the song preview when the selected destination's data changes
...
This will cause the file exensions to change when transcode options are changed.
2020-06-07 14:45:50 +01:00
Jim Broadus
4dd3233976
organise: Set extension override in OrganiseDialog
...
If the destination device has a transcode option set, then compute filenames
with updated extensions. This does not cover the case where Organise needs to
transcode due to format support.
2020-06-07 14:45:50 +01:00
Jim Broadus
2e921c6584
organise: Add a tag override mechanism to OrganiseFormat
...
Add a method to set override tag values when formatting a song name.
The use case for this is transcoding where the extension will change.
2020-06-07 14:45:50 +01:00
Jim Broadus
22cfade4a4
organise: Refresh filename after transcode
2020-06-07 05:34:08 +01:00
Clementine Buildbot
22537a4501
Automatic merge of translations from Transifex
2020-06-07 02:28:28 +00:00
Clementine Buildbot
4c9241db1a
Automatic merge of translations from Transifex
2020-06-06 02:27:32 +00:00
Jim Broadus
536f345268
database: Add ftsyear to jamendo.songs_fts
...
A previous change added ftsyear to all songs_fts tables, but the base jamendo
schema, which is used when recreating the database, was not updated. This
resulted in thousands of sql errors when reloading the catalog.
2020-06-05 10:26:26 +01:00
Jonas Kvinge
48ae27b4ad
Update .github/workflows/all.yml
2020-06-05 00:11:57 +01:00
Jonas Kvinge
d374e50fed
Add Qt5Svg.dll and qsvg.dll
2020-06-05 00:11:57 +01:00
Jonas Kvinge
789dcfa0eb
Update windows nsi
2020-06-05 00:11:57 +01:00
Jonas Kvinge
84fc00d553
Use builtin taglib on Windows and set -DTAGLIB_STATIC
2020-06-04 22:00:52 +01:00
Jim Broadus
236cfa7adf
Don't include cdda code if HAVE_AUDIOCD isn't defined
2020-06-01 22:09:46 +01:00
Jim Broadus
3616a50d83
Don't modify the original request URLs when doing cdda fixup
...
The current URL is compared againt the unmodified next in some cases.
2020-06-01 22:09:46 +01:00
Jim Broadus
7e3cd84b5d
Fix cdda playback
...
QUrl interprets a single number as an ip address, so the track URL cdda://1
would become cdda://0.0.0.1. A previous fix addresses this issue by adding an
extra character "a" to the affected URLs then removing the last instance of the
character upon usage. However, this didn't apply when a path was present
(cdda:///dev/sr0/1), but would still attempt to reverse the change later
(cdd:///dev/sr0/1).
This change applies the fix-up to all cdda urls and moves the conversion
utilities to a single location.
See: 335bc89c9 ("Workaround for broken CD playback in Qt5 (#6021 )")
2020-06-01 22:09:46 +01:00
Clementine Buildbot
bf3d3db234
Automatic merge of translations from Transifex
2020-06-01 02:27:31 +00:00
Clementine Buildbot
00f9597d37
Automatic merge of translations from Transifex
2020-05-31 02:27:35 +00:00
Clementine Buildbot
c8d56776a8
Automatic merge of translations from Transifex
2020-05-30 02:28:35 +00:00
Clementine Buildbot
6f5fe724bb
Automatic merge of translations from Transifex
2020-05-29 02:27:41 +00:00
dmdmdm
a63a37a7ab
Changed to translator comment
2020-05-28 19:40:57 +01:00
