Commit Graph

5191 Commits

Author SHA1 Message Date
Clementine Buildbot 003b258aab Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-04-04 10:00:54 +00:00
John Maguire 1489191794 Revert "Require Qt4.8.1 and CMake deprecate warnings ..."
This reverts commit e1124403fd.

qdbusxml2cpp did not support new annotation names until 4.8.2
2016-03-31 15:06:14 +01:00
John Maguire ed13d02231 Remove support for mpris1 2016-03-30 17:14:58 +01:00
John Maguire 807e4552e1 Merge pull request #5314 from ivan-leontiev/fix-globalsearch-sources
Move global search settings loading later in "MainWindow" initialisation
2016-03-30 16:44:34 +01:00
John Maguire 1d07be584e Fix annotations on mpris1 args. 2016-03-30 15:50:08 +01:00
John Maguire 9c33369fcc Merge pull request #5292 from printesoi/fix-mpris-signals
Fix mpris dbus notifications
2016-03-30 15:36:04 +01:00
Victor Dodon 3dd55e1c86 mpris2: fix format
Minor code refactoring:
- Use ternary operator in Mpri2::CanSeek
- Run make format
2016-03-29 21:29:47 -07:00
Ivan Leontiev 75d4731534 Move global search settings loading later in "MainWindow" initialisation
Fixes #5312.
2016-03-30 04:58:47 +03:00
David Sansome 2257dcd278 Merge pull request #5318 from goggle/master
Fixed compile error for the subsonic module.
2016-03-30 10:01:07 +11:00
John Maguire b20d0d87fd Revert "Adding support for subsonic cover art download" 2016-03-29 21:12:54 +01:00
Alex Seiler 6cc60d0cf8 Fixed compile error for the subsonic module. 2016-03-29 21:23:53 +02:00
John Maguire ca487a5166 Merge pull request #5270 from davidgfnet/master
Adding support for subsonic cover art download
2016-03-29 16:44:21 +01:00
John Maguire c22911815a Merge pull request #5285 from santigl/dummyBands
Add dummy bands to avoid #695
2016-03-29 15:35:43 +01:00
Clementine Buildbot 2e66eeb61f Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-03-28 10:00:51 +00:00
Ivan Leontiev 9afd71c651 Fix pressing "Backspace" key on a playlist results in appending "^H" character to the filter 2016-03-25 03:45:33 +03:00
Clementine Buildbot 23c0fe9f12 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-03-23 16:52:38 +00:00
René Tronsgaard Rasmussen 8e70046e4b Add -q,--stop-after-current commandline flag 2016-03-18 20:21:34 +01:00
David Guillen Fandos 10bac1cd2d Fixing issues in the pull request. 2016-03-12 19:44:32 +00:00
Pavel Vatagin b2db55e772 fix "undefined reference to" for clementine when build in MXE 2016-03-12 18:14:40 +03:00
Victor Dodon 91c144478b mpris2: emit CanSeek notification in EngineStateChanged
When the engine status is Playing must emit the notification CanSeek
2016-03-10 21:29:09 +00:00
Victor Dodon 5b066991ab playlist: call InformOfCurrentSongChange only after updating the virtual index
Calling InformOfCurrentSongChange before updating the virtual index results in
sending the CanGoNext and CanGoPrevious notifications with the wrong values.
2016-03-10 21:20:53 +00:00
Victor Dodon 5f14e887a7 mpris2: more notifications in RepeatModeChanged
Emit CanGoNext, CanGoPrevious notifications in RepeatModeChanged
2016-03-10 21:20:17 +00:00
Victor Dodon 3cf6cdb925 mpris2: more notifications in CurrentSongChanged
Emit CanGoNext, CanGoPrevious, CanSeek notifications in CurrentSongChanged
2016-03-10 21:14:31 +00:00
Victor Dodon c973c446e3 mpris2: add support for CanGoNext, CanGoPrevious, CanSeek 2016-03-10 21:11:05 +00:00
JulianVolodia e1124403fd Require Qt4.8.1 and CMake deprecate warnings ...
... "com.trolltech.*" changed to "org.qtproject"
2016-03-09 18:26:43 +01:00
Santi ed7375d7da Add dummy bands to equalizer (Fixes #695) 2016-03-08 15:26:45 -03:00
Clementine Buildbot e2fbb8e966 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-03-07 10:00:42 +00:00
Clementine Buildbot 357af2263b Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-02-29 10:00:41 +00:00
David Guillen Fandos e4efde900a Adding support for subsonic cover art download 2016-02-26 23:29:13 +00:00
Pander 1496d581cd Changed HTTPS to HTTP for Intergalactic FM 2016-02-25 17:37:45 +01:00
Clementine Buildbot 9252925a56 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-02-22 10:00:42 +00:00
John Maguire 51c1c36934 Merge pull request #5263 from simark/fix-moodbar-crash
moodbar: check QSlider max/min before using them in division
2016-02-18 14:17:58 +00:00
Simon Marchi 725e1d8f0d moodbar: check QSlider max/min before using them in division
When switching playback from an item for which the moodbar is not
displayed (e.g. an internet stream), to an item for which it is
displayed (e.g. a local mp3 file), Clementine sometimes crashes.

This happens because the slider_opt->maximum and slider_opt->minimum
have the value 0 (their default value), and the difference is used as a
divisor.  This gives a division by 0, and a SIGFPE.

This problem has been fixed in commit af42cce.  However, when a9f9b0e
reverted 3f79fa5, a little to much was reverted and we lost what af42cce
did.  This patch re-introduces the fix.

Fixes #5261

moodbar: Add comment
2016-02-18 09:15:44 -05:00
John Maguire 4cd20ffdaa Cope with receiving no images from spotify 2016-02-17 18:06:30 +00:00
John Maguire 52c72f95ba Too clever for old GCC versions. 2016-02-17 16:42:03 +00:00
John Maguire 1304f8898e Fetch artist images from spotify. 2016-02-17 15:55:37 +00:00
John Maguire 5b4c0c920c Blacklist artist images from echonest using dead last.fm server. 2016-02-17 15:55:37 +00:00
John Maguire a80e241bbe Make image requests follow redirects 2016-02-17 15:55:32 +00:00
John Maguire b0322e7e7d Cleanup ApplicationImpl 2016-02-15 17:41:39 +00:00
John Maguire 20bfade965 Hide Application classes behind pimpl.
This should also fix the build on windows where gcc gets confused as
libmygpo declares DELETE as part of an enum and mingw #defines DELETE in
winnt.h
2016-02-15 17:39:50 +00:00
Clementine Buildbot b3d5cabdc1 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-02-15 10:00:41 +00:00
John Maguire affb215a52 Move cover providers initialisation later in startup. 2016-02-12 16:25:01 +00:00
John Maguire dcdd81d69f Moar Lazy migrations 2016-02-12 16:10:56 +00:00
John Maguire b99b090adc Refactor simple dialogs to use Lazy 2016-02-12 16:01:35 +00:00
John Maguire 74e6a1744f Convert edit tag & settings dialog to Lazy. 2016-02-12 15:56:08 +00:00
John Maguire 589f2ff62e Lazy initialise organise dialog 2016-02-12 12:25:35 +00:00
John Maguire 0cf83b19ee Eagerly initialise TagReaderClient 2016-02-12 12:07:26 +00:00
John Maguire 86a6345995 Merge pull request #5251 from santigl/gainLabel
EqualizerSlider: move include from .h to .cpp
2016-02-11 18:03:18 +00:00
Santi 1fa4201926 EqualizerSlider move include from .h to .cpp 2016-02-11 14:59:39 -03:00
John Maguire 7d1abbda55 Don't connect action signals multiple times.
Fixes #5249
2016-02-11 17:07:00 +00:00
John Maguire ce3ba02749 Fix songkick concert fetching 2016-02-11 16:59:40 +00:00
John Maguire d06f337ade Remove special deletion of objects in threads.
Fixes #5250
2016-02-11 16:31:08 +00:00
John Maguire 729dc8e281 Merge pull request #5182 from abika/fix-fetch_edit_dialog
Fix bug in edit tag dialog when fetching (2)
2016-02-11 15:30:51 +00:00
John Maguire f2daa772c1 Lazy initialise everything in Application. 2016-02-11 15:15:38 +00:00
Alexander Bikadorov 56e95839f0 Revert to iterator usage in edit tag dialog 2016-02-11 16:09:38 +01:00
John Maguire 6844dcc140 Remove unused variable 2016-02-11 14:19:01 +00:00
John Maguire 4c8b1d8143 Add lazy initialisation helper. 2016-02-11 13:46:23 +00:00
John Maguire ea12cfacac Merge pull request #5209 from narunlifescience/patch-1
move duplicated code to annonymous namespace static function
2016-02-11 11:58:06 +00:00
Arun Narayanankutty b4fe7ac7e2 move duplicated code to annonymous namespace static function
update
2016-02-11 05:45:08 -06:00
John Maguire 0ea84e129e Merge pull request #5210 from narunlifescience/patch-2
Use icon loader for remaining icons
2016-02-11 11:24:09 +00:00
narunlifescience b6bf54be6c remove magic numbers 2016-02-11 04:41:37 -06:00
John Maguire 100222477c Merge pull request #5218 from santigl/gainLabel
Add gain label to EqualizerSlider
2016-02-10 15:46:47 +00:00
Santi ec89bd3ea2 Add gain label to equalizerSlider 2016-02-10 12:44:33 -03:00
Alexander Bikadorov 9d413ad01d Edit tag dialog: merged duplicate code 2016-02-09 21:56:22 +01:00
John Maguire 1cc889fbfc Only set lastfm to https for liblastfm1 2016-02-09 15:17:20 +00:00
John Maguire be471e1792 Merge pull request #5181 from Korvox/master
OPML imports should prefer title to text attributes for podcast names
2016-02-09 14:05:10 +00:00
John Maguire 80bf644f8a Merge pull request #5214 from narunlifescience/patch-4
Remove unwanted lines from playlistcontainer
2016-02-09 13:59:15 +00:00
John Maguire 05c0d647f8 Merge pull request #5219 from narunlifescience/patch-5
use normal text color for volume
2016-02-09 13:56:15 +00:00
John Maguire 8dd933b265 Merge pull request #5233 from naokiiwakami/5151
Fix issue in checking existence of media files pointed by CUE files
2016-02-09 13:55:40 +00:00
John Maguire be651acbca Merge branch 'master' of https://github.com/PanderMusubi/Clementine into PanderMusubi-master 2016-02-09 13:40:54 +00:00
John Maguire 3ef46f016f Revert "Don't use https since it's not supported on windows and ubuntu 12.04"
This reverts commit ab5e86fec9.
2016-02-09 11:52:04 +00:00
Clementine Buildbot 9ba41411d3 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-02-08 10:00:52 +00:00
Pander e361af3eed Support also highest quality playlist 2016-02-07 20:06:03 +01:00
Pander 646983d6a9 Added space in name 2016-02-07 18:47:04 +01:00
ArnaudBienner 50c1fcb112 Merge pull request #5213 from ivan-leontiev/fix-tree-view
Resolve some issues related to "AutoExpandingTreeView"
2016-02-07 00:32:24 +01:00
Pander 2d3af58873 Added header files for Intergalactic FM 2016-02-06 14:21:51 +01:00
Pander dc534bbcef Added support for Intergalactic FM 2016-02-05 19:29:43 +01:00
John Maguire 20de7a1a81 Don't leak AudioScrobbler. 2016-02-04 17:13:42 +00:00
John Maguire ccedb0fdc6 At least try to authenticate with last.fm over https 2016-02-04 17:12:42 +00:00
Andreas ab5e86fec9 Don't use https since it's not supported on windows and ubuntu 12.04 2016-02-03 16:33:43 +01:00
Andreas 6c726e3e38 Use desktopauth instead of mobileauth for last.fm
It now uses an oauth like authentication process so the user isn't required to enter the last.fm password in Clementine but rather authenticate through the last.fm website.

Updates #5028
2016-02-03 15:33:46 +01:00
Clementine Buildbot ac0aff5e81 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-02-01 10:00:50 +00:00
Naoki Iwakami 4cb57c0543 Fix issue in checking existence of media files pointed by CUE files 2016-01-30 16:31:10 -08:00
John Maguire 8ef1d4cae2 Bump spotify lib & blob version. 2016-01-28 14:33:04 +00:00
Clementine Buildbot e269cdc8ee Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-01-25 10:00:52 +00:00
John Maguire 9467babee4 Download spotify blob over ssl 2016-01-21 14:54:42 +00:00
Arun Narayanankutty dd1dcb0b6b use normal text color for volume 2016-01-20 19:51:34 -06:00
Matt Scheirer 8193f6c2ec OPML imports should prefer title attributes to text attributes for podcast names 2016-01-20 18:05:22 -05:00
Clementine Buildbot 8eec78671f Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-01-18 10:00:51 +00:00
Arun Narayanankutty 9a7732577d Remove unwanted lines from playlistcontainer 2016-01-16 07:06:27 -06:00
Ivan Leontiev e5be225a39 Collapse current "AutoExpandingTreeView" branch if you press "Left" key under its root 2016-01-15 07:55:56 +03:00
Ivan Leontiev 780a34c0bc Make "AutoExpandingTreeView" animated by default
This adds dropdown animation to views which are derived
from "AutoExpandingTreeView" (internet, library, global search etc.)
2016-01-15 07:55:46 +03:00
Ivan Leontiev b85d09cd9c Fix misbehavior when you double click after a single click on a tree item
This issue appeared as a side effect since the commit
bcaa9e4a37, which adds dropdown
animation to the library/internet view.

Reproduce:
Single/double click on a song item in library/internet view
then all double clicks on this item will be ignored, until you
single click on it once again.

The reason of this behavior in that the "setExpanded" method call from the
"ItemClicked" slot makes the invocation of the "mouseDoubleClickEvent"
method in the context where the view is in the "QAbstractTreeView::AnimatingState"
which makes impossible to emit "doubleClicked" signal, because it just
returns immediatelly (see http://code.qt.io/cgit/qt/qt.git/tree/src/gui/itemviews/qtreeview.cpp#n1849).

To get rid of this behavior we emit "doubleClicked" signal ourselves.
2016-01-15 07:55:19 +03:00
Ivan Leontiev 93aa5031c7 Fix autoscroll fail to follow the selection in "InternetView"
The cause of this issue was the missing call of the parent class
method in "InternetView::currentChanged".

Removed "InternetView::CurrentIndexChanged" signal along with
the "InternetView::currentChanged" method since it looks redundant,
the "InternetView::selectionModel" and its "currentChanged" signal
can be used instead, also it isn't used anywhere in the code.

Resolves: #4485
2016-01-15 07:51:15 +03:00
Arun Narayanankutty 29b8d308b3 Use icon loader for remaining icons 2016-01-14 06:10:54 -06:00
Arnaud Bienner 8579cce85c SoundCloud: add configure action to context menu 2016-01-14 00:04:36 +01:00
David Sansome 48ff15d29c Merge pull request #5200 from Chocobozzz/difm2
show settings dialog for difm when populate streams without a premium account
2016-01-14 07:10:13 +11:00
Chocobozzz ef58ce27e5 show settings dialog for difm when populate streams without a premium account 2016-01-13 19:29:36 +01:00
Clementine Buildbot 3463b720c9 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-01-13 12:28:57 +00:00
Mattias Andersson d9c4e0844d Use mp4mux instead of ffmux_mp4 when transcoding to aac 2016-01-12 15:59:23 +01:00