Commit Graph

5306 Commits

Author SHA1 Message Date
Mark Furneaux 6c653e5ba2 Synchronize buffer chunks with audio stream
The chunks are now determined by the density of data in the buffer
to the length of audio in the buffer. The chunk length can change
size so that the audio that is analysed is exactly what is being played
at the instant the frame is requested.
2014-04-30 14:18:39 -04:00
Mark Furneaux ee7fed36bc Fix pointer arithmetic when seeking buffers
It's possible the sample type will change, so best to not use
a fixed value.
2014-04-30 10:00:58 -04:00
Mark Furneaux 53f21584e4 Fix inconsistent buffer sizes sent to analyzer
The analyzers are sent new buffers of audio data to process each time
they pass through the gst pipeline. Different file formats and bit depths/
sample rates can change the size of these buffers, in some cases making them
large and therefore infrequent. This causes choppiness in the analyzer
as it is not getting new data with every frame. This patch chunks the buffers
coming off the pipeline to correspond with the framerate of the analyzer.
2014-04-29 21:38:21 -04:00
John Maguire 41e9c15248 Add arraysize macro from Chromium 2014-04-29 14:11:52 +02:00
Clementine Buildbot 0392420cd8 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-04-28 10:01:51 +02:00
David Sansome ec0565d07d Merge pull request #4313 from TheUbuntuGuy/master
Fix analyzer framerate when mouseover play scrubber.  Fixes ##2504
2014-04-27 16:51:36 +10:00
Mark Furneaux 16f12a3da8 Formatting 2014-04-27 02:49:26 -04:00
Mark Furneaux 7d3d0f04cf Fix analyzer framerate when mouseover play scrubber
This patch prevents the framerate of all analyzers from
increasing beyond the framerate set in the interface at all times.
It however will allow the analyser to redraw as often as required
to prevent artifacting when the play scrubber is drawn in front.
2014-04-27 01:54:42 -04:00
David Sansome 3e57a85711 Merge pull request #4308 from TheUbuntuGuy/master
Fix play bleeding into next track after auto stop
2014-04-26 18:46:26 +10:00
Mark Furneaux f793d09d8e Fix play bleeding into next track after auto stop
If "fade out on stop" is enabled, the "stop after this track" feature
would stop not stop the on current track, but instead start playing
the next track and fade out on that immediately. This patch disables
fadeout when the engine is stopped by HandleStopAfter().
2014-04-26 00:58:08 -04:00
David Sansome 231443f6d1 Merge pull request #4305 from TheUbuntuGuy/master
Fix stop after track.  Fixes #3572
2014-04-26 13:10:23 +10:00
Mark Furneaux d0ca2cef6c Comment remove 2014-04-25 23:02:42 -04:00
Mark Furneaux ce8b7303c0 Formatting 2014-04-25 22:50:52 -04:00
Mark Furneaux c890af6306 More elegant solution to last commit
set_current_row now takes optional parameter "is_stopping" for when auto stop
is enabled.
2014-04-25 22:45:25 -04:00
David Sansome a9abe4a4f0 Merge pull request #4303 from vkrishtal/issue_858
BugFix: clementine cannot delete directories in file tab.  Fixes #858
2014-04-26 12:26:41 +10:00
Mark Furneaux 416d06bb06 Fix stop after track
Stop after track would cause now playing widget, OSD, and last.fm
scrobbler to change to next track after stopping. This patch prevents
set_current_row() from firing an event which triggers the track change.
2014-04-25 14:30:31 -04:00
vkrishtal 42f62be5b6 Fix after review 2014-04-25 08:57:31 +04:00
vkrishtal 69b4f9113a BugFix: clementine cannot delete directories in file tab #858 2014-04-25 00:28:22 +04:00
John Maguire b3ef8b0fe0 Try out actually using lambdas for something useful. 2014-04-23 18:05:59 +02:00
David Sansome c7459b1b28 Load songs in a background thread while initialising the Organise dialog 2014-04-23 21:46:05 +10:00
David Sansome 98a328cf97 Switch from foreach to for 2014-04-23 21:13:58 +10:00
David Sansome 25ee987ec7 Recursively add songs in subdirectories to the organise dialog. Broken in revision 35060d6. 2014-04-23 21:06:23 +10:00
David Sansome e8a0c1cd9f Add more things to the 1.2.3 changelog 2014-04-23 20:16:20 +10:00
Arnaud Bienner d49d818b37 Very minor style change 2014-04-23 00:40:06 +02:00
Arnaud Bienner 3f79fa5c65 Try to make the slider more accurate when moodbar is activated.
Previously, the slide wasn't displayed at the exact position where the user clicked, and the moodbar's width was equal to the slider's width, while it should have been as long as long the groove.
2014-04-23 00:03:30 +02:00
John Maguire 2e61ef9b17 Bump changelog for 1.2.3 2014-04-22 13:43:27 +02:00
John Maguire c94a94ece2 Merge pull request #4285 from paperbagcorner/sqlite-3.8
Fix slow library search on sqlite 3.8.
2014-04-22 18:47:45 +08:00
Mattias Andersson 5fffbbc689 Add explanatory comment to last commit. 2014-04-22 12:25:59 +02:00
Clementine Buildbot e09298b9a3 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-04-21 10:01:49 +02:00
Mattias Andersson 56dade2598 Fix slow library search on sqlite 3.8. 2014-04-19 14:23:50 +02:00
Arnaud Bienner 3dad47e7ca Reorder SoundCloud menu 2014-04-16 23:17:23 +02:00
Arnaud Bienner 67951f64a5 SoundCloud: retrieve user's playlists 2014-04-16 23:09:48 +02:00
Arnaud Bienner ef01353a0f SoundCloud: retrieve stream playlists 2014-04-16 22:37:40 +02:00
David Sansome 8c164e2a8f Merge pull request #4278 from paperbagcorner/fix-filename
Remove unnecessary string conversion
2014-04-15 15:32:43 +02:00
Mattias Andersson 773c3475ba Remove unnecessary string conversion. 2014-04-15 14:47:26 +02:00
Clementine Buildbot 2c82826d26 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-04-14 10:01:28 +02:00
David Sansome baeff2e897 Merge pull request #4277 from Fitoschido/patch-1
[Trivial] Remove space in provider’s name
2014-04-14 07:45:20 +02:00
Adolfo Jayme Barrientos 15e4f7fe9c Remove space in provider’s name 2014-04-14 00:32:58 -05:00
David Sansome b9279ca128 Merge pull request #4263 from abika/master
Load all songs that require disc-read non-blocking.
2014-04-12 16:03:55 +02:00
John Maguire f75c2a9bf6 Merge pull request #4270 from fumiyas/master
Update Transifex URL
2014-04-11 12:16:21 +02:00
SATOH Fumiyasu 9add1ad708 Update Transifex URL 2014-04-11 16:30:57 +09:00
John Maguire 8429e92b52 Remove obsolete configure #defines 2014-04-10 18:03:15 +02:00
Arnaud Bienner 2f5e03e921 Use a more appropriate log level 2014-04-10 00:49:31 +02:00
Arnaud Bienner 532720ea79 Merge branch 'master' of https://github.com/clementine-player/Clementine 2014-04-09 23:08:14 +02:00
Arnaud Bienner e557c56d96 We ask for 'non-expiring' tokens, so it seems normal that we don't have refresh_tokens actually 2014-04-09 23:07:58 +02:00
Arnaud Bienner beb5f9fa30 Handle error in SoundCloud replies 2014-04-09 23:03:09 +02:00
Alexander Bikadorov 66fcaefed9 Documentation update for async song load. 2014-04-07 15:38:26 +02:00
Alexander Bikadorov a056a87c8e Coding style fixes for async song load. 2014-04-07 15:27:47 +02:00
John Maguire 712d8ecd8a Remove Growl support. 2014-04-07 14:54:10 +02:00
Clementine Buildbot 57e4217ccc Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-04-07 10:01:42 +02:00