Commit Graph

172 Commits

Author SHA1 Message Date
David Sansome 98b6b6f906 Don't use italic text anywhere - Arabic text doesn't have italics. Fixes #4329 2014-05-11 20:42:49 +10:00
Joseph Freeman fe4a80b2d5 Removed commented-out code and ran make format. 2014-04-25 19:41:04 -04:00
Joseph Freeman 156728390d Increase performance of mass rating changes. 2014-04-25 19:37:46 -04:00
Alexander Bikadorov 3adaf5d598 fixed indentation / coding style 2014-02-11 13:18:08 +01:00
Alexander Bikadorov c7ac2012b4 correct selection after removing rows in playlist 2014-02-10 16:51:43 +01:00
John Maguire 3323c2d094 Convert all instances of foreach() to a C++11 for
find ext src -name '*.cpp' -exec \
    sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
John Maguire bebd781fdf Reformat all non-3rd-party C/C++/Objective-C++.
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
 -style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
John Maguire 71893e4847 Use nullptr instead of NULL everywhere. 2014-02-06 17:29:59 +01:00
David Sansome d3749eace9 Select the current item if the selection is empty when using Tab to move from
the playlist filter to the playlist view.  Fixes #4116
2014-01-14 20:07:03 +11:00
Andreas 1e4819f2df Add stop after current track feature to network remote. 2013-07-20 19:38:37 +02:00
Mateusz Kowalczyk 2cb58ab937 Blur the colour channels instead of just the alpha channel of playlist
background images.  Fixes issue 3498
2013-03-10 18:19:40 +11:00
David Sansome d89954ae31 Fix style, hide the new columns by default, and move the new columns to the end of the enum 2013-03-10 18:16:14 +11:00
Uwe Klotz a6d3b48231 Extend tag support: performer, grouping
The transaction handling while upgrading the database schema had to be revised.
Furthermore some QSqlQuery statements needed to be finished properly.

Fixes issue 2556
2013-03-10 18:16:03 +11:00
Arnaud Bienner fa5a16e057 Inhibit autoscroll only for 30 seconds instead of 1 minute 2013-03-05 23:51:27 +01:00
David Sansome cec965edf9 Don't try to manipulate null playlist background images. 2013-02-17 14:07:46 +11:00
David Sansome 122d5ad139 Clean up the appearance settings page and add sensible defaults 2013-02-17 14:03:39 +11:00
Mateusz Kowalczyk f40b8ab892 Add adjustable transparency to album art background.
Fixes issue #3431
2013-02-15 14:39:14 +01:00
Perttu Ahola 40081a97e7 Start following the cursor again when Ctrl+J is pressed. Fixes issue 697. 2012-11-24 21:21:49 +11:00
David Sansome a6eea2b941 Fix an off-by-one error when choosing which row to select after removing items in the playlist 2012-11-24 17:10:20 +11:00
David Sansome 65aa0ebae0 Hide the moodbar column by default. 2012-11-24 15:59:36 +11:00
David Sansome 577d131c6a Use qt_blurImage instead of the handwritten function 2012-11-10 18:04:55 +11:00
Arnaud Bienner 65f1dca716 Minor style changes 2012-11-09 20:30:32 +01:00
Mateusz Kowalczyk c4796564ea Add an option to blur background image.
Fixes issue 3266.
2012-11-09 20:17:26 +01:00
David Sansome b9bb449651 Use the first visible column when dragging+dropping within the playlist, instead of column 0 which may be hidden
Fixes issue 2879
2012-06-15 10:18:38 +01:00
David Sansome 836a2b0c89 Update the moodbar column on the correct model 2012-05-30 11:06:41 +01:00
David Sansome b03563f317 Make it possible to compile out moodbar support 2012-05-27 21:33:05 +01:00
David Sansome 19c3e1d5ec Add a Mood column to the playlist 2012-05-27 16:46:16 +01:00
Arnaud Bienner 14cba7e704 Use application's palette when setting text color of the current playing song's row 2012-05-15 00:49:14 +02:00
Arnaud Bienner 58c217c1fa Always save previous background image, and start fading only is visible 2012-03-28 00:45:14 +02:00
Arnaud Bienner b9d449f3b0 Fadeout when player stop.
+ Also clear all background images when changing background image type to something different from AlbumCover or Custom
+ Remove useless code
2012-03-18 19:22:08 +01:00
Arnaud Bienner 9dff2dd0b1 Give background_type a default value, as some compilers sometimes wrongly assume that it might be used uninitialized 2012-03-17 13:34:29 +01:00
Arnaud Bienner ab0a050855 Add a fading animation when background image change 2012-03-16 22:39:39 +01:00
Arnaud Bienner 4e54634504 Reset current_covert_art when player is stopped 2012-03-13 23:15:53 +01:00
Arnaud Bienner 2a4ab30a69 Connect player->playlistview signals directly in playlistview, now that we have an Application object which holds player. 2012-03-13 22:59:18 +01:00
Arnaud Bienner b676676b9a Precompute the (CPU expensive) opacity filter in a new set_background_image function.
Also, convert the image and modify only alpha channel
2012-03-10 18:55:22 +01:00
Arnaud Bienner 45c172f3fb If the new playing song has no covers, display nothing as playlist background, instead of default cover.png, which isn't very nice as a background IMHO 2012-03-08 23:42:34 +01:00
Arnaud Bienner 0b9d7f2a1a Move all the logic about background precomputation in a new method, to make paintEvent cleaner 2012-03-08 22:39:27 +01:00
Arnaud Bienner b00bdcf04e Scale background image before applying (CPU expensive) opacity filter on it, if the scaled image will be smaller than the original one 2012-03-08 22:25:29 +01:00
John Maguire d09f96d6eb Use qBound instead of ಠ__ಠ 2012-03-06 14:46:35 +01:00
John Maguire 8e6dd551ef Fix background image rendering on Mac by pre-computing the opacity change.
Fixes issue #2745
2012-03-06 13:40:19 +01:00
Arnaud Bienner 3b19d730b6 Add the ability to have the current playing song cover as playlist's background.
I think it can be nice. But some users' feedback about this might be nice...
Also, few things may be improved (like adding fading when cover changes)
2012-03-03 01:20:37 +01:00
Arnaud Bienner 906d6f5995 Force background redraw when changing background preferences. 2012-02-19 22:40:58 +01:00
Arnaud Bienner 639fcf6a3b Change background opacity 2012-02-19 22:26:11 +01:00
Arnaud Bienner 7912caa115 Do not use QPainter::setOpacity because, as explained in http://techbase.kde.org/Development/Tutorials/Graphics/Performance#QPainter::setOpacity.28.29 this deactivate hardware acceleration and make Clementine use 100% CPU when using a custom image as background. 2012-02-19 21:43:55 +01:00
Arnaud Bienner 2f710a9395 Add the ability to modify the playlistview's background image.
Updates issue 365
It is now possible to also modify background image, instead of just hide the default one
2012-02-18 19:57:36 +01:00
David Sansome 845fe2122e Use the highlighted text colour as the text colour of the currently playing song in the playlist view 2012-02-02 20:33:40 +00:00
David Sansome 7166f0d922 When pressing Ctrl+C on a playlist item, copy the text of all visible columns, rather than just the text of the "current" one. Fixes issue 2558 2012-01-29 19:24:13 +00:00
David Sansome 74c4720054 Don't crash when the playlist view in the smart playlist preview doesn't get a Player*. 2012-01-06 11:22:17 +00:00
David Sansome bfd725f2ed Don't crash when adding new columns to a stretch header view.
Fixes issue 2562
2012-01-04 18:45:08 +00:00
John Maguire 11619c9484 Bump the playlist view state version. 2012-01-04 15:43:28 +00:00
John Maguire bcf9475f2b Add a source column to the playlist view with appropriate icons. 2012-01-04 11:56:09 +00:00
David Sansome efce2498ca Indicate which column alignment action is currently set on each column in the menu. 2011-11-12 16:23:41 +00:00
David Sansome 63fdf11cd8 Keep the playlist column alignment setting in PlaylistView instead of in each individual Playlist, ensuring all playlists share the same column alignments and there's only one place to save/restore them.
Fixes issue 1795
2011-11-12 16:12:51 +00:00
HyperQuantum 94a7ceb898 Add an "Expand" button to add more tracks to a dynamic playlist. Fixes issue 1268 2011-11-10 11:21:41 +00:00
David Sansome d62d11df8d When songs are added to the end of the playlist, scroll the playlist to ensure the top one is visible. 2011-09-27 22:28:12 +01:00
David Sansome 3eb9aee989 Save the state of the playlist column sort marker
Fixes issue 2098
2011-07-25 16:55:45 +01:00
David Sansome f599c0fca7 Remember the playlist column stretch setting when changing it, and update the menu action's checked state properly when opening clementine. 2011-07-25 16:54:42 +01:00
David Sansome 30f68d6981 Store the floating point proportional playlist column widths directly instead of storing the integer pixel widths then recalculating the floating point values on startup, which would lead to floating point errors over time. Fixes a bug where columns would slowly change size the more times you opened and closed clementine. 2011-07-24 12:47:48 +01:00
Tyler Rhodes 5c6f9e625b Allow shorter playlist column names if header size is too small.
Fixes issue 201.
2011-07-06 13:22:42 +00:00
Tyler Rhodes 4daae2249e Add selection-size check before removing items from playlist.
Fixes issue 2038.
2011-07-05 20:24:59 +00:00
Tyler Rhodes 827d37e64b Add 'Enable playlist background image' to preferences.
Fixes issue #365
2011-06-08 14:48:43 +00:00
John Maguire 8880b06833 Make backspace delete in playlist view on Mac.
Fixes issue #1710
2011-05-26 14:34:22 +00:00
David Sansome 06852aaeb7 Show spotify search results in a separate playlist tab rather than in a tree in the sidebar. 2011-04-28 17:50:45 +00:00
Arnaud Bienner 93eb4dea3f Revert r3155, as it seems this doesn't correct issue 1710 2011-04-21 22:23:44 +00:00
Arnaud Bienner 096c563a9c On Mac OS X, we shouldn't transmit the event to search box when backspace is pressed, but accept it (this should result in deleting the track from the view). Updates issue 1710 2011-04-19 23:56:18 +00:00
Andrea Decorte 9a31eb7fd4 When deleting items in playlist, select the next one. Fixes issue 1279 2011-04-17 13:48:02 +00:00
David Sansome 246723a5a2 Don't crash when dragging a file in the playlist by grabbing its rating. Fixes issue 1458 2011-03-20 12:39:49 +00:00
Paweł Bara 823f798451 new option for greying out deleted songs on startup 2011-03-19 09:41:00 +00:00
Andrea Decorte a356c5c425 Ctrl + Space to select/deselect in playlist. Fixes issue #1190 2011-03-09 13:03:52 +00:00
Arnaud Bienner 80c1b9417e Pressing ESC (from playlist view) also focus on filter, and clear it. Fixes issue 606 (definitely) 2011-02-24 18:05:38 +00:00
Arnaud Bienner 57ac8c441a Play/Pause when pressing space (on playlistview). Fixes issue 244 2011-02-23 23:59:12 +00:00
Arnaud Bienner 9c0094b9a6 Improve playlist view: focus on playlistview or search filter, depending on keyboard event. Fixes issue 606 2011-02-23 22:21:17 +00:00
Arnaud Bienner e6b59de56b Corrected center on last played track 2011-02-11 20:16:42 +00:00
Arnaud Bienner 79159700fc Center on last played song when restoring playlist. Fixes issue 410. 2011-02-10 20:55:19 +00:00
Arnaud Bienner 05a4cae370 Add track seeking from playlistview 2011-01-26 23:20:56 +00:00
David Sansome 9b82ecbb72 Add tag completers for albumartist, composer and genre, and load completion models in background threads 2010-12-25 13:11:09 +00:00
David Sansome 95ef57cf1e Add column text alignment options to the playlist header menu. Thanks brunciter! 2010-12-22 10:45:14 +00:00
David Sansome afdf02e37b Hide the score and comment columns by default 2010-12-19 14:27:07 +00:00
Paweł Bara 32f9825794 global shortcuts for rating songs (Fixes issue #1089)
renaming *index* methods in Playlist to *row*
2010-12-17 00:21:20 +00:00
David Sansome d98859eabb Support rating multiple songs at once. Fixes issue #1017 2010-12-11 14:53:43 +00:00
David Sansome 23f2530f59 Prevent the last playlist column from being hidden, and check that at least one is visible on startup. Fixes issue #991 2010-12-11 14:26:49 +00:00
David Sansome 2dce2e44fd Fix a regression where dragging songs into the playlist while a song was selected would abort the drop and start a new drag from the selected item. 2010-12-06 22:18:00 +00:00
David Sansome 31a6aa2de7 Add a Comment field to the playlist. Fixes issue #890 2010-11-28 15:22:48 +00:00
David Sansome 3e7108e9cf Stop hovering over the rating column if the mouse moves from the rating column into a scrollbar. 2010-11-20 23:20:27 +00:00
David Sansome 3dd0e56c1b Show controls at the bottom of the playlist when a dynamic playlist is active 2010-11-20 20:00:40 +00:00
David Sansome ed1a25693c Add missing licenses to debian/copyright, and add copyright information to each source file 2010-11-20 13:27:10 +00:00
David Sansome 3819a039c8 Hide the score column by default 2010-11-01 21:20:12 +00:00
David Sansome 9e09995fff Some UI polish 2010-10-29 19:26:37 +00:00
David Sansome f9bf6def04 Use an actual playlist widget in the preview 2010-10-29 18:58:43 +00:00
David Sansome fb224608ae Add a rating widget, use it in the smart playlist dialog, refactor the playlist delegate to use it. 2010-10-26 19:59:55 +00:00
David Sansome b35732a585 Drop the mouse hover effect on the ratings column when the mouse enters the header 2010-10-23 23:30:38 +00:00
David Sansome f18f935b67 Draw the background on the ratings column properly when using QGtkStyle 2010-10-23 23:27:15 +00:00
David Sansome 3a32c41c7e Update the rating stars in the currently playing item properly, and the fix the bug that would cause the currently playing item pixmap cache to not be updated with the whole row. 2010-10-23 20:58:20 +00:00
David Sansome acd9b2e136 Only react to *left* mouse clicks on the ratings column 2010-10-17 22:35:52 +00:00
David Sansome bcddb2317a Allow song ratings to be set by clicking on the stars in the playlist 2010-10-17 21:56:19 +00:00
David Sansome f55ffe15d6 Format the last played column more nicely 2010-10-17 20:53:15 +00:00
David Sansome bbe1250c31 Add skip count and last played columns to the playlist, draw the background behind the rating column properly, hide rating and statistic columns when upgrading from an old version. 2010-10-17 18:21:30 +00:00
David Sansome dd4afe9b06 Add rating and play count columns to the playlist 2010-10-17 17:10:19 +00:00
John Maguire 71bfbd9aaa Use per pixel scrolling on mac.
Fixes issue #738
2010-09-13 18:33:18 +00:00
David Sansome c83394b6b4 Work around a bug introduced in Qt 4.7's QGtkStyle that broke our custom QTreeView::drawRow to draw the current track indicator in the playlist. Fixes issue #706 2010-09-06 22:49:15 +00:00