Commit Graph

58 Commits

Author SHA1 Message Date
Amish Naidu 107e945872 Convert uses of QtAlgorithms to std:: algorithms 2018-10-09 19:17:54 +01:00
David Roeca 49876536a5 Resolve #3693 (#5790)
* bring in playlist updates for potential fix

* define signal to handle organise playlist bugs

* work in progress

* fix wrong signal/slot

* next push forward on handling new song creation

* Reorganize signals/slots; still need to figure out why not all signals are being handled

* Get playlists to work when they're in memory

* more changes to playlist updates

* revert unnecessary changes and finalize fix
2017-07-22 18:57:33 +01:00
John Maguire f300946c81 Remove most usages of QFutureWatcher 2015-11-27 14:28:12 +00:00
narunlifescience dd953fd86c check custom icon location, then system theme & then fallback theme
icons added & replaced
2015-10-13 22:35:49 -05:00
Eduardo Sánchez Muñoz e0816800b1 Add support for original year tags. 2015-06-30 18:34:34 +02:00
Martin Babutzka 258ae281d8 IDv3 tag lyrics support.
Squashed the following commits:

5c723ad commit: Fix: Includes alpha sort
15ac350 commit: Fix: Updated Database::kSchemaVersion to 49.
767a26a commit: Fixed small code style issue. Added schema-49 to data.qrc instead schema-48
bf6aa64 commit: fixup! Modified async handling of CollapsibleInfoPane as recommended by Andreas. Display of IDv2 tag lyrics works now.
c1f97e9 commit: fixup! Added support to read/display the ID tag lyrics in MP3 files:
c946b1d commit: Added support to read/display the ID tag lyrics in MP3 files:

-Added schema to the database to store it
-Added readers/writers for ID tags
-Added readers/writers for the database to the song class
-Added the taglyricsinfoprovider to show the lyrics in songinfo
2015-04-10 21:05:07 +02:00
Krzysztof Sobiecki 978a91442c Connect signal to signal 2014-11-05 17:35:14 +01:00
Krzysztof Sobiecki 5045f9b870 Don't use caller in OrganiseDialog 2014-11-05 02:37:44 +01:00
Krzysztof Sobiecki b89c05048a Move connect out of emitter 2014-11-05 00:42:56 +01:00
Krzysztof Sobiecki 578c9ad598 Ability to automatically set podcast as listened after sucesfully sending it to a device 2014-11-05 00:42:55 +01:00
David Sansome 18f72f3ada Capture this lambda argument by value, since it's a local variable and won't be valid when the outer function exits. 2014-05-11 19:24:22 +10:00
John Maguire b3ef8b0fe0 Try out actually using lambdas for something useful. 2014-04-23 18:05:59 +02:00
David Sansome c7459b1b28 Load songs in a background thread while initialising the Organise dialog 2014-04-23 21:46:05 +10:00
David Sansome 98a328cf97 Switch from foreach to for 2014-04-23 21:13:58 +10:00
David Sansome 25ee987ec7 Recursively add songs in subdirectories to the organise dialog. Broken in revision 35060d6. 2014-04-23 21:06:23 +10:00
John Maguire bebd781fdf Reformat all non-3rd-party C/C++/Objective-C++.
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
 -style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
John Maguire d309d4ab27 Use c++11 instead of boost where possible. 2014-02-06 16:51:39 +01:00
Mladen Pejaković 033d266fe9 Add contexts to some translation strings 2014-02-03 21:54:02 +01:00
Arnaud Bienner a349a96f5a Avoid having similar filenames when organising songs (number them instead) 2014-02-02 19:28:45 +01:00
Arnaud Bienner ee20103510 Set overwrite to false by default in organise dialog.
Too dangerous to be activated by default IMO.
2014-02-01 03:35:34 +01:00
Krzysztof A. Sobiecki e244c9cfb2 My fault, was testing something and forgoten to replace song.basefilename() 2014-01-30 15:08:53 +01:00
Krzysztof A. Sobiecki 09d68bf415 Scrub the auto usage, use unique_ptr, use correct types instead of QList 2014-01-28 17:01:14 +01:00
Krzysztof A. Sobiecki b0a97de603 Use more auto in for statements 2014-01-27 23:59:38 +01:00
Krzysztof A. Sobiecki f7be18b326 Fixed some problems reported by cpplint.py, changed foreach to for in files touched by me 2014-01-27 23:59:38 +01:00
Krzysztof A. Sobiecki 4944e99d56 Fix copy functionality, break copy of a directory 2014-01-27 23:59:37 +01:00
Krzysztof A. Sobiecki 750354d8ca Clementine, don't lie to me 2014-01-27 23:59:37 +01:00
Uwe Klotz a6d3b48231 Extend tag support: performer, grouping
The transaction handling while upgrading the database schema had to be revised.
Furthermore some QSqlQuery statements needed to be finished properly.

Fixes issue 2556
2013-03-10 18:16:03 +11:00
David Sansome 9be641ee87 The external tagreader mostly works now:
* Make TagReaderClient a singleton until it's easier to pass dependencies around
 * Add a WaitForSignal() that uses a local event loop to wait for a signal to be emitted
 * Add a WaitForFinished() to _MessageReplyBase that blocks using a semaphore
 * Add blocking versions of all TagReaderClient methods
 * Use the TagReaderClient everywhere that Song::InitFromFile and friends were used before
2012-01-07 00:26:07 +00:00
David Sansome 527135abb1 Stop the organise files dialog from resizing only after a manual resize has been done by the user - otherwise the dialog doesn't grow/shrink automatically when you select a new destination. 2012-01-04 22:29:26 +00:00
David Sansome 76e6281af5 Revert "Stop the 'Organise files' window constantly resizing. Fixes issue 968."
This reverts commit 9cfe834ef4.
2012-01-04 22:21:39 +00:00
Jonathan Horvath 9cfe834ef4 Stop the 'Organise files' window constantly resizing. Fixes issue 968. 2011-12-27 15:07:09 +00:00
David Sansome ccb9f8cf94 Use URLs everywhere instead of filenames. Move the URL parsing and song loading code out of individual playlist parsers and into the base class. Fix the playlist parser unit tests. 2011-04-28 12:27:53 +00:00
David Sansome ed1a25693c Add missing licenses to debian/copyright, and add copyright information to each source file 2010-11-20 13:27:10 +00:00
David Sansome 7419c52bec Fix a path handling problem that caused the OK button to be greyed out when copying files to a device on Windows. Also show an error message when trying to copy songs that can't be copied (like streams). Fixes issue #750 2010-09-15 20:00:17 +00:00
John Maguire be6e887375 Fix quirks table and add my device manually :-)
Also fixes error dialog for organise files.
2010-09-04 20:11:14 +00:00
David Sansome c5af7d54f0 Don't disable the OK button on the organise dialog if the format string is invalid, but the format string is going to be ignored anyway 2010-09-04 13:28:57 +00:00
David Sansome 2a160bee5f Pass the list of songs into the organiser from the library 2010-08-30 15:28:55 +00:00
David Sansome 39132c4dcd In the organise dialog, prompt before connecting a device that hasn't been connected before 2010-08-14 12:30:51 +00:00
David Sansome c0ea45a9c9 Show an error dialog when copying or deleting files failed. 2010-08-14 11:51:50 +00:00
David Sansome 5e00eb11de Pass shared_ptrs to music storage things to the organiser thread so they won't get deleted if the device is disconnected 2010-08-09 21:50:46 +00:00
David Sansome 68d7156071 Add Copy to device... to the playlist context menu 2010-08-08 13:06:52 +00:00
David Sansome cb2ae56949 Disable the OK button on the organise dialog when the destination device doesn't have enough free space. Fixes issue #539 2010-07-30 22:25:32 +00:00
David Sansome 06ce5e5253 Fix a crash when a device can't be connected, and remove some debug noise 2010-07-30 22:19:28 +00:00
David Sansome 6f259d4ecc Show a free space bar in the organise dialog, and also show how much space would be taken up after copying files. 2010-07-29 22:16:12 +00:00
David Sansome b2aba2bac2 Add an option to eject a device after copying files to it. Now with bonus multiple virtual inheritance. 2010-07-25 09:52:29 +00:00
David Sansome 4ffc118468 Give the organise dialog a more sensible size 2010-07-25 09:32:44 +00:00
David Sansome eeafce66bc Show devices in the organise dialog that are connected but not open 2010-07-25 09:27:41 +00:00
David Sansome 21ee5ba01f Make the Organise dialog look better when copying to an iPod 2010-07-24 18:12:47 +00:00
David Sansome 9f2d610e9d Add a menu item for copying songs to devices. Only filesystem devices supported so far 2010-07-19 21:16:22 +00:00
David Sansome 62616304d8 Add a MusicStorage interface that can be used to abstract away the details of copying a file to a device. 2010-07-19 19:56:29 +00:00